| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-01-25 | |||
| 10:09:17 | sean-k-mooney | stephenfin: the exra docs for sriov that adrianc was working on? | |
| 10:09:29 | sean-k-mooney | or live migration | |
| 10:09:33 | stephenfin | Live migration | |
| 10:09:37 | stephenfin | Also the docs though, I guess? | |
| 10:09:38 | sean-k-mooney | ah | |
| 10:10:15 | sean-k-mooney | stephenfin: https://review.openstack.org/#/c/627312/ | |
| 10:11:43 | sean-k-mooney | stephenfin: hopefully they will help you set up the new card when it arrives | |
| 10:13:21 | stephenfin | sean-k-mooney++ Very useful indeed | |
| 10:33:02 | ioni | hello guys | |
| 10:34:05 | ioni | i have a lot of warnings regarding resources not beeing updated after migraton(i think the migration had an error regarding neutron port allocation) but the instance ended up on a new compute node | |
| 10:34:14 | ioni | https://paste.xinu.at/ecVs8/ | |
| 10:34:30 | ioni | is there a way to sync the used resources ? | |
| 10:35:10 | ioni | i'm running queens at this time | |
| 10:38:14 | openstackgerrit | Kevin Rasmussen proposed openstack/nova master: created AggregateSubnetAvailabilityFilter https://review.openstack.org/633178 | |
| 11:04:54 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add functional test for libvirt vgpu reshape https://review.openstack.org/631559 | |
| 11:24:53 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Handle libvirt reporting incorrect 4k page quantities https://review.openstack.org/631038 | |
| 11:24:54 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Make overcommit check for pinned instance pagesize aware https://review.openstack.org/631053 | |
| 11:24:54 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Split '_get_host_numa_topology' function https://review.openstack.org/631237 | |
| 11:49:51 | kashyap | sean-k-mooney: Hi, something seems to be off in your line-break formatting in the LP bug comments (https://bugs.launchpad.net/nova/+bug/1811870) | |
| 11:49:52 | openstack | Launchpad bug 1811870 in OpenStack Compute (nova) "libvirt reporting incorrect value of 4k (small) pages" [High,In progress] - Assigned to Stephen Finucane (stephenfinucane) | |
| 11:50:58 | kashyap | In comment#1, the line breaks in a paragraph seem to come in randomly, which slightly impairs readability. :-) | |
| 11:53:30 | sean-k-mooney | that because for longer comment i type them up somewhere else then copy past and the web form messes up the original formating i had | |
| 11:54:44 | ioni | i found that allocation refresh is not requred on compute nodes greater than pike: https://git.openstack.org/cgit/openstack/nova/commit/?id=c3eb6ea3f6f31ae9473d0d2a4fa3f7c3a590d5f2 | |
| 11:54:58 | sean-k-mooney | things like text formating is very unimportant to me so i rarely if ever check if it messed it up before i leave teh comment | |
| 11:55:12 | ioni | is it safe to run refresh allocation on queens if already have resouces that aren't deallocated after a migration? | |
| 11:55:55 | sean-k-mooney | ioni: you mean the placement refresh | |
| 11:56:17 | ioni | sean-k-mooney, i'm not sure: https://paste.xinu.at/ecVs8/ | |
| 11:56:21 | ioni | i have this warnings | |
| 11:58:06 | sean-k-mooney | non of the placement folks seam to be about at the momment. i would ping cdent or efried later when they come online | |
| 11:58:24 | ioni | i guess is about allocations | |
| 12:00:27 | ioni | sean-k-mooney, ok, i'll wait | |
| 12:01:19 | sean-k-mooney | jaypipes: you might know the answer as to how to correct https://paste.xinu.at/ecVs8/ | |
| 12:01:46 | sean-k-mooney | ioni: jaypipes is logged in to irc but its still early for him | |
| 12:03:10 | ioni | it's fine, i can wait | |
| 12:03:28 | ioni | good thing that you guys changed from debug to warning | |
| 12:03:47 | ioni | i had problems in the past scheduling instances on some hypervisors | |
| 12:03:54 | ioni | but now i know why | |
| 12:10:26 | sean-k-mooney | ioni: if you are sure the instance is not running on the host you might be able to manually clean up old allocation safely via the osc placemnet cli | |
| 12:10:50 | sean-k-mooney | i dont know if there is a way to get nova do do it however | |
| 12:11:51 | ioni | sean-k-mooney, pretty sure is not on that hypervisor. openstack server show it's showing the new one and i can see the libvirt file on the node | |
| 12:12:07 | ioni | the only thing is that the resources weren't deallocated from the old one | |
| 12:12:12 | ioni | that warning | |
| 12:12:24 | ioni | i cannot find where in databases i need to update | |
| 12:12:37 | ioni | i tried to find it in the tables without success | |
| 12:12:48 | sean-k-mooney | ya in which case its probaly safe to manually remove the allocation via the placemnt api | |
| 12:13:10 | sean-k-mooney | i would avoid direct db updates unless it cant be fixed via the api | |
| 12:13:43 | sean-k-mooney | ioni: if you ask in #openstack-placement there maybe someone about who can suggest hot to heal the allocations correctly | |
| 12:13:54 | ioni | ok, thanks | |
| 12:14:31 | sean-k-mooney | ioni: looks like edleafe: is logged on but its seams pretty quite | |
| 12:18:13 | ioni | sean-k-mooney, alright, i have asked in the channel | |
| 12:31:31 | openstackgerrit | Martin Midolesov proposed openstack/nova master: Implementing graceful shutdown. https://review.openstack.org/608704 | |
| 12:32:51 | openstackgerrit | Merged openstack/nova master: Move interface enabling to privsep. https://review.openstack.org/621528 | |
| 12:33:08 | kashyap | sean-k-mooney: Yeah, FWIW, I do that too, just write the comment in `vim`, and wrap the lines to 72 (or your choice) & then copy / paste. | |
| 12:33:33 | sean-k-mooney | kashyap: my choise would be ~150 | |
| 12:33:40 | kashyap | Hehe | |
| 12:34:27 | sean-k-mooney | i hate the 80 colum limit and i hate passionetly that we test for 79 is pep8 for some reason even when we say it should be 80 | |
| 12:37:51 | stephenfin | sean-k-mooney: That's easily fixed, if you were so inclined | |
| 12:39:27 | sean-k-mooney | ya it should be | |
| 12:39:43 | sean-k-mooney | i think its testing <80 instead of <=80 | |
| 12:39:56 | sean-k-mooney | we dont explcitly set it | |
| 12:41:49 | jangutter | sean-k-mooney: 79 is clearly better because it's a prime number. 80 just has too many factors and it's not a pure power of two either. | |
| 12:43:33 | sean-k-mooney | true but in that case i vote for rounding up not down :) | |
| 12:44:53 | jangutter | sean-k-mooney: 80's possibly a holdover from 4:3 aspect ratio, but it still makes sense for people holding their phone in portrait mode. | |
| 12:45:21 | jangutter | sean-k-mooney: that's actually an argument to go for a 60 column limit. | |
| 12:45:44 | sean-k-mooney | there is also an argument to got to 160 or 190 the fortran uses | |
| 12:47:18 | sean-k-mooney | pep8 package doc example seam to encurate 160 indretly https://pep8.readthedocs.io/en/release-1.7.x/intro.html#configuration | |
| 12:48:49 | jangutter | sean-k-mooney: I just had a fringe idea - what if 79 characters is because there's a secret conspiracy to allow CRLF line endings? | |
| 12:49:22 | sean-k-mooney | they are both non pritable chariters so it does not matter | |
| 12:49:49 | sean-k-mooney | anyway i need to go rebase some things and fix some typos :) | |
| 12:50:29 | jangutter | sean-k-mooney: without nits like these to pick on Fridays, the world would be a lot more boring. Good luck! | |
| 12:51:24 | cdent | the world is unable to avoid this conversation isn't it | |
| 12:51:41 | cdent | I get unhappy when code lines are longer than 50 characters or so. | |
| 12:52:51 | cdent | My standards have completely collapsed since joining the openstack scene | |
| 12:55:49 | jangutter | cdent: I notice you didn't specifically say _coding_ standards. | |
| 12:56:02 | cdent | jangutter: that's correct | |
| 12:56:32 | sean-k-mooney | cdent: i hate wasting vertical space it almost -2 able in my book | |
| 12:56:51 | cdent | sean-k-mooney I WILL FIGHT YOU OVER THIS :) | |
| 12:56:52 | sean-k-mooney | its not but it severly hurts at leas my readablity of the code | |
| 12:57:23 | sean-k-mooney | cdent: :) | |
| 12:57:26 | cdent | I tend to associated wide code with not extracting methods enough | |
| 12:57:50 | jangutter | cdent: one more level of indirection can't hurt, right? | |
| 12:58:10 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Fix typo https://review.openstack.org/633196 | |
| 12:58:11 | openstackgerrit | Stephen Finucane proposed openstack/nova stable/rocky: Fix overcommit for NUMA-based instances https://review.openstack.org/633197 | |
| 12:58:20 | sean-k-mooney | cdent: that can be true but when we have function like post_live_migration_at_destination(...) | |
| 12:58:20 | cdent | but interestingly it also has a lot to do with readability for me too: if I have to go to the right I get confused. sean-k-mooney if we combined our brains we'd either be able to read nothing or everything, not sure | |
| 12:58:42 | sean-k-mooney | i can sometimes be hard to call them with out it requreing multiple lines | |
| 12:59:02 | stephenfin | lyarwood: Any chance you could you take a look at those two backports today? | |
| 12:59:06 | jangutter | cdent: I tend to notice something's wrong when the member I'm looking up gets to about 50 characters. | |
| 13:00:18 | sean-k-mooney | cdent: it only becomes annoying to me or hard to read when a function has multiple argumetns and i can nolonger clearly see everything returns and accpes at once | |
| 13:00:46 | sean-k-mooney | if the lines are too short or too long it become an issue but its also an issue if we have lost of indetation | |
| 13:01:35 | sean-k-mooney | for example in conditional within a fucntion within a fuction within a class. | |
| 13:02:07 | sean-k-mooney | in which case the satment may be only 30 letters wide but its wrapped because of the nested ness of the code | |
| 13:03:28 | sean-k-mooney | i think the best evolutionin in modern programming was clang-format | |
| 13:03:53 | jangutter | I've seen code (and yonks ago, written) with indents being 2 spaces. Doing it once makes you forever want 4 or more. | |
| 13:03:54 | sean-k-mooney | it inspired go to creat go formate and decide its a tools proplem to make the code consitent and readable | |
| 13:04:21 | sean-k-mooney | jangutter: i think the kernel still has an intend of 8 to discurabe deep nesting | |
| 13:04:53 | jangutter | sean-k-mooney: yep, indents shall be 1 tab and tabs are 8 characters wide like $deity intended. | |
| 13:05:13 | sean-k-mooney | yaml uses indentaion of 2 spaces i think by convention | |
| 13:17:26 | mdbooth | your monitor is. | |
| 13:17:26 | mdbooth | sean-k-mooney: I think 80 is arbitrary these days, but having a width limit around there does make sense even with very wide monitors, as it allows you to put multiple files next to each other. Most lines are not that long, so if you allow the occasional one to be that long you end up with truncation when viewing multiple files. Basically: imposing a (arbitrary) limit makes the code denser on screen, which is good no matter how big | |