| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-01-17 | |||
| 03:40:02 | openstackgerrit | Jack Ding proposed openstack/nova master: Flavor extra spec and image properties validation https://review.openstack.org/620706 | |
| 03:55:31 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689 | |
| 03:55:47 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709 | |
| 03:56:13 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712 | |
| 04:05:51 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Body verification for the lock action https://review.openstack.org/622835 | |
| 04:06:01 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add descriptions for vol-backed snapshots https://review.openstack.org/615084 | |
| 04:06:10 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.openstack.org/566153 | |
| 04:06:23 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add descriptions of numbered resource classes and traits https://review.openstack.org/621494 | |
| 06:34:36 | openstackgerrit | Eric Fried proposed openstack/nova master: Use a static resource tracker in compute manager https://review.openstack.org/620711 | |
| 07:11:39 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Per-instance serial number https://review.openstack.org/619953 | |
| 07:48:01 | kashyap` | Is there a place where we get nightly docs? (Besides from the renderings of the merged patches found on logs.openstack.org) | |
| 07:55:19 | openstackgerrit | WEN-SHENG,LI proposed openstack/nova stable/rocky: Add "apt install nova-consoleauth" command in the document to install module https://review.openstack.org/631446 | |
| 08:18:25 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Fix incompatible version handling in BuildRequest https://review.openstack.org/631179 | |
| 08:25:57 | yan0s | Is there a way to associate a quota class with a user? | |
| 09:32:21 | openstackgerrit | Yikun Jiang proposed openstack/nova master: Per aggregate scheduling weight https://review.openstack.org/628163 | |
| 10:07:32 | jangutter | melwitt: yes, thank you very much! the dominoes started falling! | |
| 10:18:12 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add functional test for bug 1550919 https://review.openstack.org/631294 | |
| 10:18:16 | openstack | bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9) | |
| 10:21:55 | mdbooth | gibi: If you have time, ^^^ is the evacuate functional test which was reverted after timeouts in the gate last month. I've made a couple of minor changes to decrease the chance of future timeouts, added an LVM test to address review comments from mriedem in the follow-on patch, and moved it out of regressions. | |
| 11:26:31 | gibi | mdbooth: thanks. I've put it on my list | |
| 11:32:06 | mdbooth | gibi: many thanks. | |
| 12:45:22 | openstackgerrit | Adrian Chiris proposed openstack/nova master: SR-IOV Live migration indirect port support https://review.openstack.org/620115 | |
| 13:26:05 | openstackgerrit | Adrian Chiris proposed openstack/nova master: SR-IOV Live migration indirect port support https://review.openstack.org/620115 | |
| 13:32:46 | Miouge- | Can I get some eyes on those backports patches: https://review.openstack.org/#/q/36f310f469b91c7de72a8366c7d493e1e7a4fd0f ? Thanks! | |
| 13:59:53 | openstackgerrit | Merged openstack/nova master: Send context.global_id on neutron calls https://review.openstack.org/627034 | |
| 14:31:32 | openstackgerrit | Eric Fried proposed openstack/nova master: Turn off rp association refresh in nova-next https://review.openstack.org/616033 | |
| 15:09:39 | openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Add fill_virtual_interface_list online_data_migration script https://review.openstack.org/614167 | |
| 15:09:40 | openstackgerrit | Maciej Jozefczyk proposed openstack/nova master: Force refresh instance info_cache during heal https://review.openstack.org/591607 | |
| 15:11:33 | maciejjozefczyk | mriedem: ^ updated, should be better now, thanks :) | |
| 15:18:55 | gibi | mriedem: hi!, I've started playing with the libvirt based functional test for reshape. The cons are what you described, the pros is that we can test not just the reshape in general but also the vgpu specific reshape implementation | |
| 15:19:20 | gibi | mriedem: I will push it as soon as it works so we can argue about the amount of mocking needed | |
| 15:22:19 | mriedem | maciejjozefczyk: i replied to your comment on the bottom patch | |
| 15:22:39 | mriedem | maciejjozefczyk: tl;dr making the online data migration multi-cell aware might not be worth the complexity | |
| 15:22:42 | mriedem | but i'm not asking you to change it | |
| 15:23:07 | mriedem | gibi: cool - i'm happy to do either as long as something gets done :) | |
| 15:23:11 | mriedem | so thanks for taking that on | |
| 15:25:19 | gibi | :) | |
| 15:25:19 | gibi | mriedem: cool ) | |
| 15:26:54 | mriedem | maciejjozefczyk: we should have a test for the max_limit adjust logic | |
| 15:26:57 | mriedem | i left a comment | |
| 15:27:55 | maciejjozefczyk | mriedem: this will work in loop to the end even for 9 cells, the case is if operator is aware of that or not | |
| 15:28:30 | maciejjozefczyk | the marker is used across cells, but first only instances from cell1,2,3 will be migrated | |
| 15:28:59 | mriedem | maciejjozefczyk: is there a marker per cell to know when we've completed processing a given cell? | |
| 15:29:43 | maciejjozefczyk | this marker is upper cells, but we migrate instance one-by-one starting from first cell, so there is no need to make marker per cell | |
| 15:29:55 | mriedem | although let's say we completed cell1, set a marker, and then a new instance was created in cell1, we would check that one again | |
| 15:30:49 | maciejjozefczyk | you're right above, but we basically fill vif list for instances, that are created in releases older than newton, so for this use-case we shouldn't care | |
| 15:31:02 | mriedem | ok, but you understand my concern for cern right? they have 70+ cells, and if they run online data migrations per cell (which i'm assuming they have to do given some migrations are per-cell), then this would churn a lot of data needlessly on the other cells | |
| 15:31:12 | mriedem | belmoreira: can you confirm how you run online_data_migrations? ^ | |
| 15:31:17 | sean-k-mooney | mriedem: at the point at wich the online data migration is running have you upgraded to the new code or are teh cells still running the old code | |
| 15:31:47 | maciejjozefczyk | mriedem: I understand your point, and yeah, I can do it because its easy :) | |
| 15:31:47 | sean-k-mooney | mriedem: if they are using the new code the the new instance would not need the data migration right? | |
| 15:31:48 | mriedem | sean-k-mooney: either | |
| 15:32:07 | mriedem | maciejjozefczyk: sorry, do what exactly? | |
| 15:32:12 | maciejjozefczyk | but I don't think its needed anyway | |
| 15:32:24 | maciejjozefczyk | mriedem: do a marker per cell, to track new instances in cell after migrate | |
| 15:33:50 | maciejjozefczyk | cern shouldn't have anything to migrate by this script, due they don't have instances older than newton I think | |
| 15:34:18 | maciejjozefczyk | only OVH has cattle-like instances :) | |
| 15:34:37 | mriedem | you mean pet-like | |
| 15:34:42 | mriedem | i know huawei public cloud has a lot of pets | |
| 15:34:45 | maciejjozefczyk | yup | |
| 15:34:46 | mriedem | and old instances | |
| 15:35:36 | maciejjozefczyk | so this will 'scan' all the instances in all cells sequentially and after it one new code nothing will be migrated | |
| 15:37:52 | openstackgerrit | Merged openstack/nova master: api-ref: Body verification for the lock action https://review.openstack.org/622835 | |
| 15:38:57 | openstackgerrit | Merged openstack/os-vif master: Apply workaround to host_info serialization test https://review.openstack.org/631173 | |
| 15:47:15 | mriedem | maciejjozefczyk: ok i certainly don't want to hold this up. i think we need a test for the marker adjustment across cells (i can help with that if needed) and add more context to the release note (i left a suggestion), and it would be great to get some buy-in from belmoreira but again i don't want to hold it up | |
| 15:47:35 | mriedem | i appreciate you working on this | |
| 15:48:14 | mriedem | i sent an email to one of our operators internally just to get him to take a look also and make sure it's ok with him | |
| 15:48:20 | mriedem | (i might not get a response...) | |
| 15:48:25 | maciejjozefczyk | mriedem: Thanks for your time :) I'll do like you suggest. | |
| 15:50:05 | maciejjozefczyk | btw I did migration on one of my db with 40k instances, I did about 7k migrations, so a lot of pets | |
| 15:53:22 | mriedem | maciejjozefczyk: cool. ovh has multiple regions but not multiple cells yet right? | |
| 15:53:35 | mriedem | and you're working on collapsing some regions into multiple cells? | |
| 15:54:09 | belmoreira | mriedem maciejjozefczyk what's the patch that you are discussing? | |
| 15:54:37 | belmoreira | mriedem yes, data migrations are per cell | |
| 15:54:48 | maciejjozefczyk | mriedem: we don't use cells because neutron is not cell-aware :( | |
| 15:54:52 | gryf | belmoreira, https://review.openstack.org/#/c/614167 | |
| 15:55:12 | maciejjozefczyk | mriedem: so wi'll have more issues because of neutron | |
| 15:55:29 | mriedem | neutron has routed networks if that helps | |
| 15:55:43 | mriedem | but nova isn't really aware of routed networks for scheduling... | |
| 15:56:09 | maciejjozefczyk | oh, so as you see :D | |
| 15:57:28 | maciejjozefczyk | but its mostly related to our network architecture, we created own neutron ml2 plugin along with network_types that are different… and more complicated | |
| 16:02:28 | mriedem | maciejjozefczyk: heh vif get by instance uuid will never return deleted instances regardless of the context :) https://github.com/openstack/nova/blob/4f5cb30a2f88965772bcbff0a19a1dcfcd3836c6/nova/db/sqlalchemy/api.py#L1542 | |
| 16:02:31 | mriedem | jaypipes: ^ | |
| 16:02:39 | mriedem | b/c the db api hard-codes it | |
| 16:02:43 | mriedem | \o/ | |
| 16:05:04 | maciejjozefczyk | ^^ | |
| 16:05:40 | maciejjozefczyk | ;D | |
| 16:06:44 | efried | jaypipes, cdent, mriedem: Pretty sure I've got the CERN stack down to only spurious timeout failures at this point. Will y'all be able to take a look today? | |
| 16:07:10 | cdent | efried: aye | |
| 16:07:39 | efried | thx | |
| 16:08:45 | jaypipes | mriedem: lol | |
| 16:08:50 | mriedem | idk, got some other stuff i need to deal with first | |
| 16:09:00 | mriedem | including the tasks i signed up for yesterday | |
| 16:09:08 | jaypipes | efried: sorry, the CERN stack? | |
| 16:09:16 | mriedem | the pile seems to grow faster than i can dig out of it | |
| 16:09:29 | mriedem | jaypipes: the reduce placement api calls series | |
| 16:09:43 | mriedem | provider tree hullabaloo 2019 | |
| 16:09:51 | jaypipes | oh, that's the CERN stack? :) yes, efried I will be reviewing it all again today | |
| 16:14:28 | maciejjozefczyk | bb guys, grabbing a beer | |
| 16:46:11 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Add functional test for libvirt vgpu reshape https://review.openstack.org/631559 | |