| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-01-10 | |||
| 18:21:01 | sean-k-mooney | perhaps someone else can answer the netboot question but not that i am aware of | |
| 18:26:21 | openstackgerrit | sean mooney proposed openstack/nova-specs master: Add spec for sriov live migration https://review.openstack.org/605116 | |
| 18:26:54 | sean-k-mooney | jaypipes: artom stephenfin bauzas ^ nits addressed | |
| 18:36:35 | openstackgerrit | sean mooney proposed openstack/nova-specs master: Add spec for sriov live migration https://review.openstack.org/605116 | |
| 18:37:58 | openstackgerrit | sean mooney proposed openstack/nova-specs master: Add spec for sriov live migration https://review.openstack.org/605116 | |
| 18:39:00 | sean-k-mooney | ok i had a tab and a repated "as" which i also just fixed that really should be done now | |
| 18:40:05 | sean-k-mooney | https://review.openstack.org/#/c/605116/10..13/specs/stein/approved/libvirt-neutron-sriov-livemigration.rst will show you the delta from the previous version ye reviewed | |
| 18:59:47 | jaypipes | sean-k-mooney: +2 from me. stephenfin can send it on its merry way in a bit. | |
| 19:00:29 | sean-k-mooney | jaypipes: well he could if he was a specs core but he is not | |
| 19:00:39 | sean-k-mooney | jaypipes: thank you however for your +2 | |
| 19:00:39 | jaypipes | ah, then melwitt can :) | |
| 19:00:46 | sean-k-mooney | nope neither is she | |
| 19:00:52 | jaypipes | wha?! | |
| 19:01:00 | sean-k-mooney | jaypipes: dansmith: and bauzas can | |
| 19:01:14 | jaypipes | ok, bauzas it is then, since he's reviewed that already :) | |
| 19:01:40 | melwitt | yeah, I think you could +W it yourself though with a note that bauzas was previously +2 before nit fixing | |
| 19:01:52 | sean-k-mooney | jaypipes: nova-specs-core is a very select group https://review.openstack.org/#/admin/groups/302,members :) | |
| 19:02:07 | melwitt | in case bauzas is gone for the day | |
| 19:04:09 | jaypipes | melwitt: k, I will give bauzas a little while and will +W it along after waiting a bit. | |
| 19:04:45 | melwitt | k, sounds good | |
| 21:41:39 | artom | Booting an instance with cpu_policy=dedicated (and no other NUMA-y stuff) and 1GB of RAM in the flavor results in a rather bizarre libvirt message | |
| 21:41:55 | artom | total memory for NUMA nodes (0x100000) should equal RAM size (0x200000) | |
| 21:42:37 | artom | Even if <memory unit='KiB'>1024</memory> and <numa> <cell id='0' cpus='0' memory='1024' unit='KiB'/> </numa> | |
| 21:42:46 | artom | Same thing but with 2GB is fine. | |
| 21:43:06 | artom | Either I'm missing something way obvious, or there's a bug :/ | |
| 21:47:27 | artom | sean-k-mooney ^^ if your weird sleep schedule makes you still be here. You always know about these things ^_^ | |
| 22:05:53 | sean-k-mooney | artom i wasnt but i am now | |
| 22:06:52 | sean-k-mooney | artom: adding hw:cpu_policy=dedicated create an implict numa toplogy as if you also set hw:numa_nodes=1 | |
| 22:08:19 | sean-k-mooney | that message however is strange | |
| 22:10:35 | openstackgerrit | Inbar Stolberg proposed openstack/nova master: Fixes server rebuild if NumaTopologyFilter is used with CPU pinning https://review.openstack.org/629646 | |
| 22:13:09 | artom | sean-k-mooney, right, I knew about the implicit NUMA topology | |
| 22:13:25 | artom | But... Nova's XML is correct, as far as I can tell, units and everything | |
| 22:13:28 | sean-k-mooney | so i cant find that error upstream | |
| 22:13:33 | sean-k-mooney | what raised it | |
| 22:13:41 | artom | sean-k-mooney, it's from libvirt itsel | |
| 22:13:50 | artom | For all I know it's a bug in qemu/kvm | |
| 23:12:32 | sean-k-mooney | jaypipes: im just about to log off for the night. looks like bauzas didnt come back online. are you still ok to +w https://review.openstack.org/#/c/605116/? | |
| 23:13:13 | jaypipes | sean-k-mooney: yup | |
| 23:13:21 | sean-k-mooney | thanks :) | |
| 23:14:08 | jaypipes | sean-k-mooney: done | |
| 23:15:03 | sean-k-mooney | night all o/ | |
| 23:19:53 | openstackgerrit | Merged openstack/nova-specs master: Add spec for sriov live migration https://review.openstack.org/605116 | |
| #openstack-nova - 2019-01-11 | |||
| 00:42:05 | openstackgerrit | sean mooney proposed openstack/nova master: [WIP] libvirt: auto detach/attach sriov ports on migration https://review.openstack.org/629589 | |
| 02:48:35 | openstackgerrit | Jack Ding proposed openstack/nova master: Correct instance port binding for rebuilds https://review.openstack.org/603844 | |
| 02:50:00 | openstackgerrit | Yikun Jiang proposed openstack/nova master: Per aggregate scheduling weight https://review.openstack.org/628163 | |
| 03:45:28 | openstackgerrit | Rui Zang proposed openstack/nova-specs master: support virtual persistent memory https://review.openstack.org/601596 | |
| 03:51:12 | openstackgerrit | Jack Ding proposed openstack/nova master: Correct instance port binding for rebuilds https://review.openstack.org/603844 | |
| 03:52:59 | openstackgerrit | Hesam Chobanlou proposed openstack/nova master: nova.exception._clean_dict should use oslo_utils.strutils https://review.openstack.org/629769 | |
| 06:25:20 | openstackgerrit | Yikun Jiang proposed openstack/nova master: Per aggregate scheduling weight https://review.openstack.org/628163 | |
| 06:52:49 | openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Create specs directory for Train https://review.openstack.org/630037 | |
| 09:15:49 | kashyap | Can I get a second reviewer who can +W this doc patch? -- https://review.openstack.org/#/c/629627/ ("docs: Secure live migration with QEMU-native TLS") | |
| 09:15:55 | kashyap | Happy to trade a few reviews in exchange :-) | |
| 09:17:40 | kashyap | IMHO, the last couple of -1 nits from Takashi are just too trivial to deserve a respin. | |
| 09:20:56 | kashyap | sean-k-mooney: Thanks for the review, and the 'recheck' while I was asleep :-) | |
| 09:29:49 | openstackgerrit | 98k proposed openstack/gantt master: Updatae home-page https://review.openstack.org/630096 | |
| 10:20:46 | stephenfin | What the heck if gantt and why is the openstackgerrit bot logging it here? | |
| 10:21:13 | stephenfin | ah, dead project | |
| 10:44:10 | openstackgerrit | Stephen Finucane proposed openstack/gantt master: Retire gantt https://review.openstack.org/630138 | |
| 11:19:09 | openstackgerrit | Stephen Finucane proposed openstack/python-ganttclient master: Retire python-ganttclient https://review.openstack.org/630154 | |
| 11:32:07 | stephenfin | melwitt: When you're about, are you OK with me sending out a retirement email for these two projects? http://github.com/openstack/gantt http://github.com/openstack/python-ganttclient | |
| 11:34:26 | stephenfin | melwitt: Alternatively, if you've more context, feel free to do it yourself. I have the patches already proposed against the various repos https://review.openstack.org/630162 | |
| 11:42:57 | openstackgerrit | Merged openstack/nova master: libvirt: Support native TLS for migration and disks over NBD https://review.openstack.org/625216 | |
| 11:53:43 | kashyap | stephenfin: gibi: Since the above is merged, can anyone give +W for the accompanying: https://review.openstack.org/#/c/629627/ | |
| 11:54:13 | stephenfin | kashyap: Needs another +2 before I can do that, I'm afraid | |
| 11:54:23 | kashyap | Yeah, that's why I was asking Gibi :-) | |
| 11:54:26 | kashyap | Thanks for your review, already! | |
| 11:54:26 | stephenfin | ack | |
| 11:56:40 | gibi | kashyap: it is on my list :) | |
| 11:56:50 | kashyap | Most excellent; thanks for your time. | |
| 12:09:10 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: docs: Secure live migration with QEMU-native TLS https://review.openstack.org/629627 | |
| 12:09:11 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: docs: Address minor comments for the QEMU-native TLS document https://review.openstack.org/630183 | |
| 12:10:40 | kashyap | stephenfin: When you can, does the last patch look OK to you? | |
| 12:10:56 | kashyap | Which addresses the Takashi's remark | |
| 12:11:06 | stephenfin | kashyap: are the TripleO docs versioned? | |
| 12:11:20 | kashyap | Oh, I don't know | |
| 12:11:26 | kashyap | You said "this comment is invalid" | |
| 12:11:31 | stephenfin | yeah, I left comments | |
| 12:11:40 | kashyap | Who's comment is that? Takashi's or my response to him? | |
| 12:11:47 | stephenfin | Takashi's | |
| 12:11:47 | kashyap | Just read your comment | |
| 12:11:51 | stephenfin | Build it locally and see if the docs link through | |
| 12:11:56 | stephenfin | I suspect they won't. | |
| 12:12:02 | stephenfin | If they do, it's all good | |
| 12:12:22 | kashyap | I built it locally; and it works | |
| 12:12:41 | kashyap | As in, it renders the linked TLS TripleO doc correctly | |
| 12:12:52 | stephenfin | ah yeah, that's because it links to latest | |
| 12:12:59 | stephenfin | but there's no e.g. rocky docs, I think | |
| 12:13:00 | stephenfin | https://docs.openstack.org/tripleo-docs/latest/ | |
| 12:13:08 | kashyap | Ah-ha | |
| 12:13:13 | stephenfin | https://docs.openstack.org/nova/rocky/ is valid | |
| 12:13:23 | stephenfin | https://docs.openstack.org/tripleo-docs/rocky/ is not | |
| 12:13:52 | stephenfin | So maybe drop that bit and add a NOTE in place of the conf.py change noting that TripleO docs aren't versioned? | |
| 12:13:54 | kashyap | Okay, then I'll remove that bit of change, good that I did a follow-up, instead of messing with the current one | |
| 12:14:00 | stephenfin | Just to prevent confusion in the future | |
| 12:14:21 | kashyap | Yeah, I'll drop that bit | |
| 12:14:31 | kashyap | stephenfin: Where would you want me to add the note? In the conf.py? | |
| 12:14:38 | stephenfin | ideally, yes | |
| 12:14:46 | stephenfin | just above that openstack_projects option | |
| 12:15:08 | kashyap | Yep, doing that | |
| 12:22:43 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: docs: Address minor comments for the QEMU-native TLS document https://review.openstack.org/630183 | |