| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2019-01-10 | |||
| 14:25:40 | kashyap | stephenfin: One last English nit-pick: you suggest "commas" in the place of em-dash, e.g. look at point 2 in the "Prerequisites" section: http://logs.openstack.org/27/629627/2/check/openstack-tox-docs/dc52e37/html/admin/secure-live-migration-with-qemu-native-tls.html | |
| 14:26:00 | stephenfin | yup? | |
| 14:26:02 | kashyap | It makes sense to retain that there. | |
| 14:26:21 | kashyap | Because the content between the em-dashes can also be used in brackets, _or_ two commas. | |
| 14:27:17 | stephenfin | kashyap: True, em dash ~= comma | |
| 14:27:26 | stephenfin | but I tend to see them used more for asides | |
| 14:27:28 | kashyap | Sure. | |
| 14:27:45 | stephenfin | something not directly related to the main sentence | |
| 14:27:53 | stephenfin | i.e. | |
| 14:27:54 | kashyap | In this case I've used it in place of two commas (which is also used for bracketed content) | |
| 14:28:23 | stephenfin | I was on the way home, driving on the motorway, when I saw a cat | |
| 14:28:25 | stephenfin | vs. | |
| 14:28:45 | stephenfin | I was on the way home -- a needless endeavour, it turned out -- when I saw a cat | |
| 14:29:04 | stephenfin | I don't know if that's correct, but that's how _I've_ done it :) | |
| 14:29:11 | kashyap | Hehe, I see your point there | |
| 14:29:14 | kashyap | But, in this case: | |
| 14:29:16 | kashyap | "A pre-configured TLS environment—i.e. CA, server, and client certificates, their file permissions, et al—must be “correctly” configured (typically by an installer tool) on all relevant compute nodes." | |
| 14:29:19 | jaypipes | kashyap: em-dash ftw. | |
| 14:29:24 | stephenfin | fair :) | |
| 14:29:27 | kashyap | Replacing those em-dashes with more commas is fugly | |
| 14:29:29 | jaypipes | stephenfin: :P | |
| 14:29:31 | kashyap | I can use brackets, though. | |
| 14:29:54 | stephenfin | Just space them out either side and I'm happy (not sure if that's correct but it's tough to read otherwise) | |
| 14:30:02 | stephenfin | jaypipes: I blame asettle | |
| 14:30:22 | jaypipes | heh :) | |
| 14:30:24 | kashyap | stephenfin: Haha, you know ... I have read the literature on the _spacing_ too | |
| 14:30:40 | kashyap | stephenfin: When the doc is rendered, a space between two em-dashes attract too much attention to the em-dash iself. | |
| 14:30:43 | kashyap | s/iself/itself/ | |
| 14:30:48 | kashyap | See the fine point? :D | |
| 14:31:06 | kashyap | That was also a conscious (and consistent) choice throughout the doc | |
| 14:31:37 | stephenfin | :D | |
| 14:31:37 | kashyap | But if you insist, you know, in the name of civility I will happily add the spaces (consistently through out) :-) | |
| 14:31:53 | kashyap | stephenfin: I don't joke when I say I take my English seriously :D | |
| 14:32:09 | stephenfin | Noted :D | |
| 14:32:24 | kashyap | Sorry, if I'm taxing your brain. I like these pedantics, I know you do, too. | |
| 14:32:27 | jangutter | kasyap: obligatory https://imgs.xkcd.com/comics/third_way.png | |
| 14:33:06 | kashyap | stephenfin: I dislike the past tense :-( | |
| 14:33:30 | kashyap | The team no longer exists now? And all docs are taken care of by relavant components? | |
| 14:34:42 | stephenfin | Still there but only for things like the contributor guide that don't have a home elsewhere | |
| 14:34:43 | kashyap | jangutter: Two spaces after a period is, of course, the correct thing. It gives the brain a "breathing room" between the sentences, dammit. | |
| 14:35:04 | kashyap | stephenfin: I see. But I can still enjoy working on the Nova docs to my heart's content | |
| 14:35:10 | kashyap | stephenfin: LOL, I know your view on that | |
| 14:35:28 | jangutter | kashyap: Them's fighting words. | |
| 14:42:45 | edleafe | kashyap: I like how the iPhone settled it. You type two spaces, and it inserts a period and a single space. :) | |
| 14:44:39 | jangutter | One day, someone's going to add a small piece of code to lint the spaces after a period in doc8 and it will trigger World War III. | |
| 14:46:43 | adrianc | jaypipes: Hi, ive been working with sean-k-mooney on enabling live-migration with SR-IOV, it would be great if you could add this to your review queue. | |
| 14:47:13 | jaypipes | adrianc: it's the next one in my list. | |
| 14:47:32 | gibi | melwitt: FYI On the today's meeting stephenfin and I agreed that the bp https://blueprints.launchpad.net/nova/+spec/fix-reschedule-up-calls is good to go for Stein but as no other cores was present I haven't approved the bp yet. | |
| 14:47:33 | kashyap | edleafe: Heh | |
| 14:47:54 | kashyap | edleafe: Didn't know that; /me doesn' want to put more cash in Apple's bank :D | |
| 14:47:55 | adrianc | jaypipes, thanks :) | |
| 14:59:56 | stephenfin | adrianc: finished reviewing the stack of changes and spec. Ping me if there's anything else to do | |
| 15:00:05 | sean-k-mooney | i see stephenfin has corrected my grammer hehe | |
| 15:00:22 | stephenfin | sean-k-mooney: I had to leave _some_ comments ;) | |
| 15:00:39 | stephenfin | emphasis on "none of which matter that much unless you have to rework" though | |
| 15:01:02 | sean-k-mooney | stephenfin: ill wait for jaypipes to finish and i can quickly resping or i can submig a follow up pacth with the cleanup which ever suits | |
| 15:01:46 | adrianc | stephenfin: ack thank you, will review. | |
| 15:02:40 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: docs: Secure live migration with QEMU-native TLS https://review.openstack.org/629627 | |
| 15:12:52 | kashyap | Darn, one last thing to fix, the ".. note::" indentation | |
| 15:16:35 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: docs: Secure live migration with QEMU-native TLS https://review.openstack.org/629627 | |
| 15:41:13 | kashyap | dansmith: When you have a spare minute, as promised (with even a nice +2 on it), the doc patch: http://logs.openstack.org/27/629627/4/check/openstack-tox-docs/5bc0591/html/admin/secure-live-migration-with-qemu-native-tls.html | |
| 15:42:02 | kashyap | dansmith: It is also revised and corrected as thoroughly as I could (and the back-and-forth on the review shows it, I hope) :-) | |
| 15:42:15 | kashyap | (For convenience, here's the review: https://review.openstack.org/#/c/629627/4) | |
| 15:42:31 | dansmith | kashyap: yeah I know, I've gotten the notifications, just have stuff to do this morning before I get to it | |
| 15:42:42 | kashyap | stephenfin: Thanks for the quick turn around | |
| 15:43:13 | kashyap | dansmith: Ah, didn't know you follow those notifications. On IRC, I follow the "explicit is better than implicit" principle :-) | |
| 15:44:40 | kashyap | It can wait until your morning tasks are done, so long as it doesn't miss the BP-Approvals deadline. | |
| 15:51:46 | mnaser | kashyap: that's a pretty sweet doc patch. | |
| 15:51:58 | kashyap | mnaser: Thanks :-) | |
| 15:52:14 | mnaser | i'm going to try and work up some openstack ansible patches which allow setting tls config | |
| 15:52:30 | kashyap | mnaser: Cool; do post a URL here when you get around to it | |
| 15:52:35 | mnaser | we have a full pki so switching this on and replacing it should be straightforward, will do | |
| 15:52:48 | kashyap | mnaser: When I dev-tested it, I painfully configured it by hand! Look at the scrollbar: https://kashyapc.fedorapeople.org/Native-TLS/Setup-for-NBD-and-migration-streams-over-TLS.rst.txt | |
| 15:53:04 | mnaser | OSA doesn't have the PKI, our deployments do, but i'm sure we can figure out a way to make it easily available inside it, somehow | |
| 15:53:10 | kashyap | It's from-scratch, though, set up in virtual environments | |
| 15:53:14 | dansmith | kashyap: I'm fine with approving the blueprint at this point | |
| 15:53:28 | kashyap | mnaser: Do you know about the freeipa.org project? | |
| 15:53:37 | mnaser | kashyap: freeipa is exactly what we run :) | |
| 15:53:48 | kashyap | mnaser: It does all the Cert Lifecycle handling. (In the distant past, /me used to work on one of its PKI components :-)) | |
| 15:53:55 | mnaser | so i was thinking of getting certs and using certmonger to keep em up to date too | |
| 15:53:56 | jaypipes | sean-k-mooney: done. | |
| 15:53:56 | kashyap | dansmith: Nice, thank you | |
| 15:54:00 | jaypipes | adrianc: ^ | |
| 15:54:14 | kashyap | mnaser: Yep; 'certmonger' handles the much-needed renewal aspect | |
| 15:54:37 | sean-k-mooney | jaypipes: cool ill assume i have rework to do so ill respin | |
| 15:54:49 | jaypipes | sean-k-mooney: just typos/grammar nits. | |
| 15:54:51 | mnaser | yep, so i'd probably wire it up to that, somehow | |
| 15:54:55 | jaypipes | sean-k-mooney: fix those up and I'm +2. | |
| 15:55:29 | sean-k-mooney | cool ill do dose now so thanks for reviewing | |
| 15:55:51 | kashyap | mnaser: Sometimes, I just write a no-frills PKI setup with GnuTLS -- that's hacky, but I like the minimalism of it | |
| 15:56:15 | mnaser | kashyap: freeipa has simplified pki so much | |
| 15:56:18 | kashyap | (That's only for dev environments, though. Normally, you'd want an "enterprise PKI" :D) | |
| 15:57:05 | mnaser | and it has a ton of neat things like we're using SSHFP + DNSSEC so for clients that aren't enrolled, they can use SSHFP to verify validity of server when logging in | |
| 15:57:08 | kashyap | mnaser: Yep, recall. Components of FreeIPA were part of my first project at Red Hat 10 years ago :-) | |
| 15:57:11 | mnaser | aka never hitting "yes" blindly anymore | |
| 15:57:15 | kashyap | s/recal/I recall/ | |
| 15:59:06 | kashyap | mnaser: Didn't follow it lately; good to know it also handles DNNSEC | |
| 15:59:42 | mnaser | kashyap: yeah so you can have signed zones, and then freeipa will create SSHFP records on enrollment, ssh clients lookup these records when connecting and make sure the server is who it claims to be :) pretty neat | |
| 16:00:04 | kashyap | Very nifty | |
| 16:17:51 | melwitt | dansmith, gibi, jaypipes: looks like we are a go for approving https://blueprints.launchpad.net/nova/+spec/support-qemu-native-tls-for-live-migration now? | |