| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-12-07 | |||
| 21:14:42 | dansmith | radez: can you show more of the log so we can see both? | |
| 21:15:07 | radez | yea, that was just a quick grep, lemme grab more of the scheduler log and check my version | |
| 21:16:54 | dansmith | melwitt: that would only affect nodes in cleaning right? | |
| 21:18:11 | melwitt | dansmith: I don't know, tbh | |
| 21:19:14 | melwitt | I remember there were some ironic driver bugs we fixed near the end of rocky and was curious if those can be ruled out based on what version of rocky they're running | |
| 21:19:43 | dansmith | the only way this should be happening, AFAIK, is if we're not exposing one inventory per node, or somehow not claiming in placement | |
| 21:20:15 | melwitt | yeah, this bug was related to the claiming of a node via setting reserved == total | |
| 21:20:36 | melwitt | and one spot where the newer placement api microversion needed to be set was missed | |
| 21:21:00 | melwitt | so I was thinking that might possible cause a node to not be claimed when it was supposed to. but as for if it only comes up during cleaning, that I didn't know | |
| 21:21:20 | melwitt | *possibly | |
| 21:21:57 | mriedem | radez: what are the values for cpu/ram/disk for the flavors being used for these baremetal nodes? | |
| 21:21:58 | melwitt | I had thought the reserved == total thing was claiming in general and not only for cleaning, but could easily be wrong as I don't know _that_ much about the ironic driver | |
| 21:22:11 | radez | openstack-nova-scheduler-18.0.3 | |
| 21:22:20 | radez | ok, got hte version, sry fighting with docker :/ | |
| 21:22:42 | melwitt | thanks radez. so yeah, the thing I wondered can be ruled out | |
| 21:22:44 | dansmith | melwitt: reserved=total is only for making the node look unschedulable while being cleaned right? | |
| 21:22:55 | dansmith | melwitt: reserved=total does't make any sense when the node is actually allocated | |
| 21:23:30 | openstack | Launchpad bug 1796920 in OpenStack Compute (nova) queens "Baremetal nodes should not be exposing non-custom-resource-class (vcpu, ram, disk)" [High,In progress] - Assigned to Matt Riedemann (mriedem) | |
| 21:23:30 | mriedem | i'm wondering if you're hitting https://bugs.launchpad.net/nova/+bug/1796920 | |
| 21:23:31 | radez | | properties | {u'memory_mb': u'4096', u'cpu_arch': u'x86_64', u'local_gb': u'40', u'cpus': u'4', u'capabilities': u'boot_option:local' | |
| 21:23:35 | radez | both look liek that | |
| 21:23:40 | mriedem | yeah so check that bug | |
| 21:23:44 | mriedem | or https://review.openstack.org/#/c/609043/ | |
| 21:23:45 | radez | getting the logs... | |
| 21:23:59 | dansmith | mriedem: yeah, that's the kind of thing I was thinking of | |
| 21:24:05 | melwitt | dansmith: I didn't know that. but what you say makes sense, you're probably right | |
| 21:24:06 | dansmith | mriedem: we consume one CUSTOM_FOO, and then schedule the next one based on there looking like there's ram or something | |
| 21:24:22 | mriedem | i'm very much half assing my involvement here, | |
| 21:24:25 | mriedem | but that's something i'd check out | |
| 21:25:45 | dansmith | I have to leave soon | |
| 21:28:24 | radez | here's more of the scheduler log http://paste.openstack.org/show/736846/ | |
| 21:31:23 | dansmith | radez: okay but that's still just one instance, right? | |
| 21:31:40 | dansmith | however, it looks like whatever host it chose got successfully claimed in placement, | |
| 21:31:50 | dansmith | which can't happen if each host is exposing only one inventory item | |
| 21:32:32 | dansmith | radez: can you correlate the "Attempting to claim.." line with the relevant context in the placement log? | |
| 21:32:52 | radez | placement log is the scheduler log? | |
| 21:32:57 | mriedem | no | |
| 21:33:00 | dansmith | nope, a different service | |
| 21:33:01 | mriedem | placement-api log | |
| 21:33:12 | radez | oh, sec lemme find that log | |
| 21:33:16 | dansmith | that should (I think) show you what is being claimed for the instance | |
| 21:33:28 | dansmith | which really should be only one resource, something like CUSTOM_IRONIC_FOO=1 | |
| 21:34:56 | radez | would that coorelate on the insance uuid? | |
| 21:35:24 | dansmith | I'm not sure what the string looks like, so not sure if it dumps the consumer (instance) uuid or not | |
| 21:35:26 | mriedem | if the flavor has vcpu/ram/disk, and the compute node is reporting vcpu/ram/disk inventory - which it will be still before stein, the claim will be on vcpu/ram/disk as well | |
| 21:35:28 | dansmith | so I would go by date | |
| 21:35:51 | dansmith | mriedem: wait, what? | |
| 21:36:04 | dansmith | I thought it only reported the old resources in some compat situation? | |
| 21:36:06 | radez | kk | |
| 21:37:09 | mriedem | dansmith: no, | |
| 21:37:22 | mriedem | we didn't neuter the ironic driver until stein, right around the ptg | |
| 21:37:26 | dansmith | I think I recoiled in horror the last time we talked about this | |
| 21:37:36 | mriedem | that's why we needed https://review.openstack.org/#/c/609043/ | |
| 21:37:49 | dansmith | so maybe he just doesn't have the resource class in his flavor? | |
| 21:39:31 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Drop pre-cellsv2 compat in compute API.get() https://review.openstack.org/615347 | |
| 21:39:32 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Drop old service version check compat from _delete_while_booting https://review.openstack.org/623589 | |
| 21:39:32 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove "API Service Version" upgrade check https://review.openstack.org/615348 | |
| 21:39:46 | mriedem | | properties | {u'memory_mb': u'4096', u'cpu_arch': u'x86_64', u'local_gb': u'40', u'cpus': u'4', u'capabilities': u'boot_option:local' | |
| 21:39:54 | mriedem | those are extra specs? | |
| 21:40:03 | dansmith | no, | |
| 21:40:08 | mriedem | then correct the baremetal flavor doesn't have the custom resource class | |
| 21:40:10 | dansmith | node detaisl Ithink | |
| 21:40:52 | mriedem | radez: have you gone through this? https://docs.openstack.org/ironic/rocky/install/configure-nova-flavors.html | |
| 21:41:02 | mriedem | especially: openstack flavor set --property resources:CUSTOM_BAREMETAL_SMALL=1 my-baremetal-flavor | |
| 21:41:15 | dansmith | and/or.. who created your flavor? | |
| 21:41:16 | radez | http://paste.openstack.org/show/736847/ | |
| 21:41:48 | dansmith | o.O | |
| 21:42:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Drop old service version check compat from _delete_while_booting https://review.openstack.org/623589 | |
| 21:42:48 | radez | jlibosvar created the flavor, it looks like that custom baremetal small is not on it | |
| 21:43:13 | mriedem | CUSTOM_BAREMETAL_SMALL is an example | |
| 21:43:14 | dansmith | radez: it needs to be equal to whatever is set on the node | |
| 21:43:18 | dansmith | right | |
| 21:43:25 | radez | http://paste.openstack.org/show/736848/ | |
| 21:43:27 | mriedem | the node has a resource_class field | |
| 21:43:34 | radez | yea lemme see what's on the node | |
| 21:43:43 | mriedem | yeah that flavor isn't going to cut it | |
| 21:43:59 | dansmith | yeah | |
| 21:44:03 | mriedem | https://docs.openstack.org/ironic/rocky/install/configure-nova-flavors.html ftw | |
| 21:44:35 | radez | I don't think there is a resources property on the bm node either | |
| 21:44:55 | mriedem | resource_class | |
| 21:45:10 | mriedem | https://developer.openstack.org/api-ref/baremetal/?expanded=show-node-details-detail#show-node-details | |
| 21:45:13 | dansmith | radez: that "how to configure flavors" doc above is probably your ticket out of here, right? | |
| 21:45:21 | radez | | resource_class | None | |
| 21:45:25 | mriedem | heh "This will be used by the openstack Placement Engine in a future release." | |
| 21:45:43 | mriedem | jroll: maybe we should update the resource_class api-ref parameter description in ironic now... | |
| 21:46:17 | radez | yea maybe he's just missed some of the setup steps. Lemme regroup and try and go back through the steps that have been taken in this env and I'll circle back back next week if we're still haveing trouble | |
| 21:46:47 | dansmith | cool | |
| 21:47:01 | radez | ok, thanks for your time! | |
| 21:52:34 | dansmith | I need to remember to remember that we only closed that silly loop in stein | |
| 21:52:42 | dansmith | all that discussion at the first denver ptg ... | |
| 22:05:52 | mriedem | melwitt: thanks for hitting the stable branch reviews | |
| 22:06:31 | melwitt | np | |
| 22:29:36 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove allocations before setting vm_status to SHELVED_OFFLOADED https://review.openstack.org/623596 | |
| 22:29:39 | mriedem | gibi: efried_cya_jan: finally got that alternative fix up for that shelve gate race bug ^ | |
| 22:35:59 | cfriesen | in compute/api.py in the @check_instance_state() decorator, if we don't specify a task_state does that mean that we don't care what the state is? | |
| 22:36:24 | mriedem | no | |
| 22:36:34 | mriedem | not specifying a task_state means task_state must be None | |
| 22:37:36 | cfriesen | what if we have @check_instance_state(task_state=None) ? | |
| 22:38:05 | openstackgerrit | Ben Nemec proposed openstack/nova master: Migrate upgrade checks to oslo.upgradecheck https://review.openstack.org/603499 | |
| 22:38:56 | mriedem | cfriesen: if only the source code were freely available... | |