| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-12-05 | |||
| 15:56:06 | dansmith | come on, even for atcs? | |
| 15:56:13 | mriedem | no idea about atcs | |
| 15:56:41 | stephenfin | mriedem: Oh, I wonder if we should include this too, if we're doing a release? https://review.openstack.org/#/c/505731/ | |
| 15:56:54 | stephenfin | I'll prepare an ocata release too. Nothing else on the backlog | |
| 15:58:01 | cdent | efried: is https://review.openstack.org/#/c/613613/ still alive (kill safe connect) | |
| 15:58:50 | efried | cdent: I think so. Just needs core reviews. | |
| 16:00:40 | cdent | roger, just doing a to do list review, and it came round | |
| 16:04:05 | mriedem | stephenfin: question in https://review.openstack.org/#/c/505731/4 | |
| 16:04:28 | stephenfin | looking | |
| 16:06:02 | melwitt | o/ | |
| 16:08:55 | mriedem | stephenfin: i guess it's always been there? https://kernel.googlesource.com/pub/scm/linux/kernel/git/shemminger/bridge-utils/+/38837a8e19540690c80f5a3b0971e0e1495a4a3e/brctl/brctl_cmd.c#124 | |
| 16:09:29 | stephenfin | mriedem: :D I was looking at the exact same thing | |
| 16:09:55 | lbragstad | yan0s i think it depends on how the service init's the oslo.policy enforcer object | |
| 16:10:01 | openstackgerrit | Chris Dent proposed openstack/nova master: Correct lower-constraints.txt and the related tox job https://review.openstack.org/622972 | |
| 16:10:09 | lbragstad | yan0s there is a configuration option to reload policy rules when they change on disk, i believe | |
| 16:10:29 | lbragstad | s/configuration option/option parameter to the enforcer/ | |
| 16:10:36 | mriedem | lbragstad: that would be here https://github.com/openstack/nova/blob/master/nova/policy.py#L68 | |
| 16:11:15 | stephenfin | mriedem: It's in Ubuntu 16.04 http://manpages.ubuntu.com/manpages/xenial/man8/brctl.8.html and there's no changelog section, so I assume it's always been there too | |
| 16:11:56 | lbragstad | mriedem yeah - some documentation on it here https://docs.openstack.org/oslo.policy/latest/reference/api/oslo_policy.policy.html#oslo_policy.policy.Enforcer | |
| 16:13:09 | mriedem | hmm, so nova-api isn't dynamically reloading rules? | |
| 16:13:30 | mriedem | i only see ENFORCER.load_rules() called when we initialize it | |
| 16:14:24 | mriedem | yan0s: did you restart nova-api when you changed nova.conf to set the policy_file option? | |
| 16:14:40 | sean-k-mooney | o/ | |
| 16:15:52 | gibi | mdbooth: I run ~30 consecutive full nova functional tests with random test case order to reproduce the test failure but I failed | |
| 16:16:47 | gibi | mdbooth: so I think it is more likely a timing issue as the gate runs the test slower than I | |
| 16:16:51 | sean-k-mooney | stephenfin: brctl? | |
| 16:16:56 | stephenfin | yes | |
| 16:17:54 | sean-k-mooney | i was wondering whtat the context was | |
| 16:19:35 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Add workaround to remove instance dir during cleanup with rbd https://review.openstack.org/618478 | |
| 16:20:19 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Remove port allocation during detach https://review.openstack.org/622421 | |
| 16:27:03 | openstackgerrit | Merged openstack/os-vif stable/pike: ovs-hybrid: should permanently keep MAC entries https://review.openstack.org/505731 | |
| 16:28:12 | stephenfin | gibi: I know no one wants to see that patch, but the notification samples would be so much easier to grok if they were a consistently sorted 😅 (especially the common payloads) | |
| 16:29:15 | yan0s | yes I did restart it | |
| 16:29:22 | yan0s | nova-api-os-compute | |
| 16:29:28 | yan0s | nova-api-os-compute.service | |
| 16:31:04 | mriedem | yan0s: ok so it might have just been that you restarted the service that reloaded the policy file rather than needing to configure nova.conf | |
| 16:31:18 | mriedem | i thought we always dynamically read the policy file on each auth check | |
| 16:31:20 | mriedem | but i guess not | |
| 16:31:29 | mdbooth | gibi: Yeah, I *suspect* that it's just a canary. I think that create is taking close to the 5 second timeout, and when the gate is clogged its the first thing to get pushed over. | |
| 16:32:25 | cfriesen | sean-k-mooney: regarding https://review.openstack.org/#/c/620959/, I believe the traits are already defined as part of https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/report-cpu-features-as-traits.html | |
| 16:32:47 | mdbooth | gibi: Problem is I can't prove it. I spent time this morning looking at a profiler and I can see a couple of opportunities for making that test slightly faster, but if I guessed wrong it's just going to be merge ping-pong. | |
| 16:33:50 | mdbooth | gibi: The other thing, of course, would be to increase the timeout. | |
| 16:36:32 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add compute_node ratio online data migration script https://review.openstack.org/609995 | |
| 16:36:32 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add ratio online data migration when load compute node https://review.openstack.org/613499 | |
| 16:36:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add docs for (initial) allocation ratio configuration https://review.openstack.org/622588 | |
| 16:36:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Note the aggregate allocation ratio restriction in scheduler docs https://review.openstack.org/620713 | |
| 16:36:48 | mriedem | dansmith: done ^ | |
| 16:39:06 | dansmith | mriedem: got 'em | |
| 16:39:15 | mriedem | thanks | |
| 16:39:25 | mriedem | approving the non-docs changes | |
| 16:40:02 | mdbooth | mriedem: What do you think would be acceptable criteria for re-proposing that patch, btw? | |
| 16:40:17 | mriedem | the racy test? | |
| 16:40:29 | dansmith | mriedem: I'll look at the following ones in a bit | |
| 16:40:37 | mriedem | dansmith: thanks | |
| 16:40:42 | mdbooth | mriedem: Yeah. | |
| 16:40:47 | mriedem | mdbooth: idk, maybe not using mocks/stubs on the libvirt driver in functional tests? | |
| 16:41:00 | mriedem | like i said, might be better to subclass the libvirt driver and override what you need | |
| 16:41:04 | mdbooth | mriedem: I suspect the *race* is against a slow test worker. | |
| 16:41:19 | mdbooth | I can't see any evidence of an ordering thing. | |
| 16:41:24 | mriedem | could also add the REQUIRES_LOCKING = True variable, but i don't know if that will help anything | |
| 16:41:42 | mdbooth | Which isn't to say that it's not an ordering thing, but without being able to reproduce it we're really just trying stuff. | |
| 16:41:52 | mdbooth | So... when have we tried enough stuff? | |
| 16:41:58 | mriedem | just, doing file i/o and mocks and such in a functional test like that with a real driver - i'm not really surprised there were side effects | |
| 16:42:07 | mriedem | mdbooth: i can't answer that | |
| 16:42:16 | mdbooth | mriedem: Me neither :/ | |
| 16:42:57 | mdbooth | However, like I say I don't see any evidence of side effects, or globals, or anything like that. | |
| 16:43:23 | mdbooth | The failures look like it was just too slow to me. | |
| 16:43:30 | mdbooth | I can post performance improvements. | |
| 16:45:26 | efried | My boss just made me look at my remaining vacation time for the year. Turns out... I'm gone until January, starting this afternoon. melwitt mriedem Sundar edmondsw FYI. | |
| 16:45:43 | aspiers | efried: whoa nice, enjoy ;-) | |
| 16:45:43 | mdbooth | efried: \o/ | |
| 16:45:54 | efried | :) thanks | |
| 16:46:02 | lbragstad | mriedem yan0s fwiw - i keystone doesn't either, but i can't really think of a reason not to? | |
| 16:46:20 | mriedem | lbragstad: perf? | |
| 16:46:20 | lbragstad | s/i// | |
| 16:46:32 | melwitt | efried: thanks for the heads up. enjoy your time off :) | |
| 16:46:52 | mriedem | efried: ack | |
| 16:46:57 | lbragstad | mriedem possibly - i could time it | |
| 16:47:09 | mriedem | efried: i'll just rebase and abuse any changes of yours that i need | |
| 16:47:24 | efried | mriedem: It would be easier just to merge them right now. | |
| 16:47:43 | mriedem | bah | |
| 16:47:55 | mriedem | my queue is already deep and i haven't started on either of the 2 things i said i'd do today | |
| 16:49:25 | Sundar | efried: Have fun and Happy Holidays! | |
| 16:49:31 | efried | Thanks | |
| 16:51:25 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Cyborg PCI handling https://review.openstack.org/623027 | |
| 16:51:25 | openstackgerrit | Eric Fried proposed openstack/nova master: Add cyborg client to requirements https://review.openstack.org/623026 | |
| 16:56:36 | yan0s | No I definitely needed to change the nova.conf | |
| 16:56:50 | yan0s | I was restarting the service in every try | |
| 16:57:11 | yan0s | @lbragstad | |
| 16:57:20 | yan0s | @mriedem | |
| 16:58:19 | mriedem | hmm, well i'm stumped then | |
| 16:58:20 | lbragstad | yeah - by default, oslo.policy isn't going to reload policy files on disk | |
| 16:58:44 | mriedem | lbragstad: but they shouldn't have had to explicitly configure nova.conf with [oslo_policy]/policy_file = policy.json | |
| 16:58:49 | mriedem | since that's the default in code | |
| 16:59:12 | mriedem | anyway, probably just something i'd need to mess with in devstack to see if i can recreate it | |
| 16:59:23 | lbragstad | this sounds like two different issues | |
| 17:03:19 | lbragstad | yan0s if you're in #openstack-oslo this might be more relevant to talk about there | |
| 17:07:57 | openstackgerrit | Eric Fried proposed openstack/nova master: Add cyborg client to requirements https://review.openstack.org/623026 | |
| 17:07:58 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Cyborg PCI handling https://review.openstack.org/623027 | |
| 17:25:12 | mriedem | gibi: not sure if you saw my comment in that notifications patch, but if we planned on switching the default format to unversioned, marking it as deprecated would be weird | |