| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-12-05 | |||
| 14:42:34 | aspiers | *patchset 15 | |
| 14:42:44 | mriedem | right, so, | |
| 14:43:06 | mriedem | at this point, i will likely just +2 out of exhaustion on the spec and we'll push it through and doc the hell out of this in the admin guide | |
| 14:43:11 | mriedem | b/c it's a snowflake feature | |
| 14:43:31 | mriedem | being brutally honest | |
| 14:43:43 | mriedem | not because i'm against it, | |
| 14:43:46 | mriedem | i'm just too dumb to understand it | |
| 14:43:53 | aspiers | haha, I highly doubt that :) | |
| 14:44:01 | mriedem | no really i'm not very smart | |
| 14:44:03 | aspiers | but totally understand that you have limited time for it | |
| 14:44:33 | aspiers | rest assured I will be doc'ing the hell out of it | |
| 14:44:42 | aspiers | that intention is also captured in the spec | |
| 14:45:01 | aspiers | http://logs.openstack.org/79/609779/15/check/openstack-tox-docs/eaf9d54/html/specs/stein/approved/amd-sev-libvirt-support.html#documentation-impact | |
| 14:45:15 | lbragstad | stephenfin cdent hitting issues with I7cd27fe8c39ddfc6ec20f4cfe4d62912d4cebaa4 ? | |
| 14:46:37 | cdent | lbragstad: causes issues in https://review.openstack.org/#/c/622972/ (see commit message) | |
| 14:48:01 | lbragstad | yeah - i don't have a strong attachment to that test... | |
| 14:48:17 | lbragstad | i changed something though so i wanted to test it | |
| 14:48:47 | mriedem | still looking for another core on the allocation ratio data migration patch https://review.openstack.org/#/c/613499/ it's pretty easy | |
| 14:48:53 | mriedem | and we can flush this runway bp today | |
| 14:49:39 | dansmith | yeah, I've had that open since middle of yesterday | |
| 14:51:22 | dansmith | I'll get some protein to go with my caffeine and see if I can make myself do it | |
| 14:53:34 | mriedem | power through | |
| 14:53:44 | mriedem | bauzas: i'm removing reshaper from the runway queue again | |
| 14:53:48 | mriedem | dec 4 came and went | |
| 14:55:04 | stephenfin | mriedem, dansmith, cdent, gibi, anyone else around: are you happy with me doing this? https://review.openstack.org/622987 | |
| 14:55:20 | stephenfin | I'm removing osc-placement notifications from this channel | |
| 14:55:29 | cdent | wfm | |
| 14:55:30 | stephenfin | *gerritbot notifications | |
| 14:56:07 | mriedem | sure | |
| 14:56:18 | mriedem | reminds me that osc-placement is falling behind on parity | |
| 14:56:35 | gibi | stephenfin: I think the original reason to keep that was to know when we need to keep placement changes in sync in placement code in nova and in the separated placement | |
| 14:57:07 | mriedem | osc-placement | |
| 14:57:08 | mriedem | not placement | |
| 14:59:37 | bauzas | mriedem: ack, ok | |
| 15:01:03 | bauzas | mriedem: I'll tho ping people later about reviewing it ;) | |
| 15:04:07 | yan0s | hi guys, I'm having a trouble with policy.json file in /etc/nova/ | |
| 15:04:20 | mriedem | bauzas: you also have some review comments to address it looks like | |
| 15:04:22 | yan0s | how can I debug if it actually being parsed? | |
| 15:04:44 | bauzas | mriedem: just the ones from artom but yeah :) | |
| 15:04:54 | bauzas | I was waiting for other comments | |
| 15:06:06 | mriedem | yan0s: interesting question which someone was having trouble with last week, i don't have a great answer... | |
| 15:06:40 | mriedem | i'm not sure if enabling debug logging will dump anything from oslo.policy when the check is performed? | |
| 15:06:43 | yan0s | I have set "compute:create": "is_admin:True" and "compute:create": "is_admin:True" | |
| 15:07:00 | yan0s | but users of any role can still create instances | |
| 15:07:00 | mriedem | those are the same | |
| 15:07:06 | yan0s | that's wrong right? | |
| 15:07:12 | yan0s | "os_compute_api:servers:create": "is_admin:True" | |
| 15:07:22 | yan0s | that was the second rule | |
| 15:07:32 | mriedem | what is your is_admin definition? | |
| 15:07:36 | mriedem | and which release is this? | |
| 15:07:41 | yan0s | rocky | |
| 15:07:45 | yan0s | but with juju | |
| 15:08:36 | mriedem | and [oslo_policy]/policy_file in nova.conf is not changed from the default policy.json? | |
| 15:08:43 | mriedem | and policy.json is in /etc/nova/policy.json or somewhere else? | |
| 15:09:27 | mriedem | we do have this CLI https://github.com/openstack/nova/blob/master/nova/cmd/policy.py#L73 but it's not really what you're looking for probably | |
| 15:09:41 | yan0s | policy.json is in /etc/nova/ | |
| 15:10:55 | yan0s | is there a field in nova.conf that defines the policy.json directory? | |
| 15:11:39 | mriedem | the options are in this group https://docs.openstack.org/nova/latest/configuration/config.html#oslo-policy | |
| 15:16:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add docs for (initial) allocation ratio configuration https://review.openstack.org/622588 | |
| 15:16:57 | yan0s | [oslo_policy] was missing from the nova.conf | |
| 15:16:59 | yan0s | thanks mriedem! | |
| 15:17:23 | mriedem | yan0s: well, it doesn't need to be in nova.conf if you're not changing defaults | |
| 15:17:30 | mriedem | if the defaults are what you need anyway, it should just work | |
| 15:17:33 | yan0s | adding policy_file = policy.json under it fixed it | |
| 15:17:47 | mriedem | hmm, that shouldn't matter, that's already the default in code... | |
| 15:17:52 | mriedem | lbragstad: ^ | |
| 15:17:53 | yan0s | no I need a specific configuration | |
| 15:18:01 | mriedem | yan0s: why? | |
| 15:18:57 | yan0s | I need user roles with different access rights | |
| 15:19:14 | mriedem | sure, that's in policy.json though, | |
| 15:19:22 | mriedem | nova.conf is already pointing at policy_file=policy.json by default | |
| 15:19:27 | mriedem | because of defaults in the code | |
| 15:19:27 | yan0s | is there a better way of doing this? | |
| 15:19:41 | mriedem | https://docs.openstack.org/nova/latest/configuration/config.html#oslo_policy.policy_file Default:policy.json | |
| 15:20:08 | mriedem | overriding policy rules is fine and expected, i just wonder why the config defaults weren't working | |
| 15:20:16 | mriedem | because someone was having a similar issue last week | |
| 15:20:25 | yan0s | could it be a juju charm specific issue? | |
| 15:20:37 | mriedem | i think the person last week was using kolla but it's hard to remember | |
| 15:21:18 | mriedem | lbragstad: apparently [oslo_policy]/policy_file default not being read for some reason in some deployments | |
| 15:21:37 | mriedem | explicitly putting policy_file=policy.json in nova.conf fixed it, but that shouldn't be necessary given it's already the default value | |
| 15:21:43 | lbragstad | as far as the logging goes (which doesn't seem to be the root issue) we did just release a new version of oslo.policy that allows for better logging | |
| 15:22:13 | lbragstad | https://review.openstack.org/#/c/619260/ | |
| 15:22:39 | lbragstad | and the default from policy.json isn't changing for what's documented in code? | |
| 15:23:07 | mriedem | no they are using /etc/nova/policy.json | |
| 15:23:22 | mriedem | "adding policy_file = policy.json under it fixed it" | |
| 15:25:44 | mriedem | we don't test policy overrides in tempest/dsvm jobs, but patrole should, i should find one of those jobs and see if they have to explicitly configure this in nova.conf | |
| 15:25:59 | kashyap | If anyone has a few spare minutes, this already has a +2: https://review.openstack.org/#/c/620327/ -- "libvirt: Refactor handling of PCIe root ports" | |
| 15:26:28 | stephenfin | mriedem: Would you mind taking a look at this when you have time? https://review.openstack.org/#/c/554523/ | |
| 15:26:38 | stephenfin | kashyap: on it | |
| 15:27:25 | kashyap | stephenfin: Thanks! The more important bit I need to work out is a clean solution for long "TODO" in the code... | |
| 15:27:35 | stephenfin | just reading that atm | |
| 15:28:30 | dansmith | mriedem: when you get a sec, check my comment on the initial ratio migration patch | |
| 15:28:32 | dansmith | (please) | |
| 15:29:15 | stephenfin | kashyap: I think you've already stated the fix, no? (third paragraph of that TODO) | |
| 15:30:16 | kashyap | stephenfin: Yep, so you actually read it, then :D | |
| 15:30:42 | stephenfin | I'm 100% for detailed code comments ;) | |
| 15:30:49 | stephenfin | ...so long as they're kept up-to-date | |
| 15:31:30 | kashyap | Thanks! I spent unjustifiable time to write that comment :D | |
| 15:31:34 | stephenfin | kashyap: In any case, that's a future problem. +Wd | |
| 15:31:39 | kashyap | stephenfin: The "hidden" bit is to workout XML wrangling to get the machine type from the right XML bit | |