Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-12-03
11:50:19 ShilpaSD is i am missing any other supporting extensions?
11:51:27 gibi ShilpaSD: I don't know. This is the original commit added the notification extension https://github.com/openstack/nova/commit/05adc8d006b482e0aed2fcc9dc4885924aca74d0
11:51:39 gibi ShilpaSD: in that I did not have to add any extra extension
11:52:12 gibi ShilpaSD: btw, what do you want to achive? do you want to reuse ext.versioned_notifications outside of the nova project?
11:55:11 gibi ShilpaSD: if I insert some python error to ext/versioned_notifications.py then doc generation command prints a proper stack trace for me
11:56:09 gibi ShilpaSD: nova uses the following build command in tox: sphinx-build -W -b html -d doc/build/doctrees doc/source doc/build/html
11:57:58 gibi ShilpaSD: this part of the conf.py in nova could be intresting to you as well https://github.com/openstack/nova/blob/master/doc/source/conf.py#L24
12:03:48 ShilpaSD gibi: Hi, i am in the process of introducing notifications in Masakari, i have completed all coding and api doc, not only part remained is this sample notifications table
12:05:36 gibi ShilpaSD: so you copied ext/versioned_notifications.py from nova to masakari and would like to use it in masakari
12:05:49 ShilpaSD gibi: yes
12:06:05 gibi ShilpaSD: do you have a patch up on review that I can download and play with it locally?
12:07:09 ShilpaSD gibi: sorry for that, as of now no patch i have uploaded
12:08:09 ShilpaSD gibi: during tox, its giving error while 'Running Sphinx v1.8.2'
12:09:13 openstackgerrit Balazs Gibizer proposed openstack/nova master: Reject networks with QoS policy https://review.openstack.org/570079
12:09:13 openstackgerrit Balazs Gibizer proposed openstack/nova master: Reject interface attach with QoS aware port https://review.openstack.org/570078
12:10:33 openstackgerrit Balazs Gibizer proposed openstack/nova master: Reject networks with QoS policy https://review.openstack.org/570079
12:11:04 openstackgerrit Chris Dent proposed openstack/nova master: Clean up header encoding handling in compute API https://review.openstack.org/606967
12:11:06 gibi ShilpaSD: let me try to reproduce yor problem locally
12:13:29 ShilpaSD gibi: thanks for this
12:22:57 gibi ShilpaSD: with this change https://review.openstack.org/621558 I can make sphinx load the extension in masakari
12:23:23 gibi ShilpaSD: of course it still fails as the code in versioned_notifications.py tries to import nova
12:26:16 openstackgerrit Merged openstack/nova stable/rocky: Remove unnecessary redirect https://review.openstack.org/607400
12:27:30 openstackgerrit Jan Gutter proposed openstack/os-vif master: Extend port profiles with datapath offload type https://review.openstack.org/572081
12:30:38 ShilpaSD gibi: sorry, its still giving me Extension error:, i have updated my code for 'https://review.openstack.org/#/c/621558/1/doc/source/conf.py@19'
12:30:45 ShilpaSD from your patch
12:30:54 ShilpaSD rest already i ahve taken from Nova
12:31:46 gibi ShilpaSD: I get the following from my patch
12:31:47 gibi Could not import extension ext.versioned_notifications (exception: No module named 'nova')
12:31:47 gibi Extension error:
12:31:50 gibi ERROR: InvocationError for command '/home/ebalgib/upstream/git/masakari/.tox/docs/bin/python setup.py build_sphinx' (exited with code 1)
12:32:05 gibi ShilpaSD: and as I said this is expected as I just blindly copied versioned_notifications.py from nova
12:32:12 gibi and that python code imports nova
12:33:27 ShilpaSD ok, will check further, give me few time, will get back to you
12:33:49 gibi ShilpaSD: so the next step with that patch would be to adapt the code in versioned_notificaton.py to masakri
12:33:51 gibi ShilpaSD: sure
12:34:01 ShilpaSD gibi: sure
12:42:12 ShilpaSD gibi: thanks, after adding 'https://review.openstack.org/#/c/621558/1/doc/source/conf.py@19', its giving me proper stack trace, and now i am on the way to resolve errors listed
12:42:40 ShilpaSD earlier it gives, exception: cannot import name 'json_ref'
12:43:03 gibi ShilpaSD: cool
12:43:05 ShilpaSD after resolving its giving further error with detailed stack trace
12:43:17 gibi ShilpaSD: json_ref is also something that is inside nova
12:43:37 ShilpaSD gibi: yes, that i have got it
12:43:44 gibi OK
12:44:00 ShilpaSD now further issues with my code, will check and get back to you if any further hurdles
12:44:58 gibi ShilpaSD: sure, you can ping me any time (I'm working mostly in EU timezone)
12:45:28 ShilpaSD gibi: sure thnaks
13:11:34 sean-k-mooney sligtly off topic but does anyone know if any of the people from packet are on the nova irc?
14:01:34 stephenfin sean-k-mooney: packet?
14:02:18 sean-k-mooney stephenfin: https://www.packet.com/
14:02:41 stephenfin sean-k-mooney: You learn something new every day
14:05:33 sean-k-mooney i am planning on setting up a 2 node openstack over the christmas + nodepools/zuul but i was debating about using some burst capasity from them or another cloud provider also
14:06:03 sean-k-mooney i have the hardware locally to do ci but as you heard my rackmount server are not exactly quite
14:07:19 sean-k-mooney ahyway i might not but just wanted to ask them a few questions like can i set a montly limit on pricing that kind of thing
14:14:48 adrianc sean-k-mooney: Hi, regarding libvirt-neutron-sriov-livemigration, did you have a chance to look further at the code ? Also did you get a chance to work on the direct port support for POC ?
14:15:28 adrianc sean-k-mooney: i.e the detach/attach flow
14:18:46 sean-k-mooney adrianc: i hope to start working on the direct mode support this/ next week as my primary focus. i have been dealing with downstream bugs for the last week or more so other then deploying your code i have not made much progress
14:19:43 sean-k-mooney adrianc: i see you pushed a new version of the code yesterday
14:19:59 adrianc sean-k-mooney: ack, ill upload an updated PS today, dealing with some unit test issues
14:20:14 sean-k-mooney i should get a change to re review and redeploy with it tomorrow
14:20:33 adrianc sean-k-mooney: yes, addressing some of the issues that we talked abou, plus better clarifying the code
14:20:58 sean-k-mooney i will be respinnign the spec today/tommorow too by the way
14:22:04 adrianc sean-k-mooney: any major changes ? or mainly what was discussed in the review ?
14:22:25 sean-k-mooney ill try and align the spec to the code you have submitted.
14:22:52 sean-k-mooney adrianc: am bauzas had some cleanups/clarifing questions but no major changes
14:22:52 mriedem bauzas: while you're here, it would be good to get another core looking at the initial allocation ratio series, starting here https://review.openstack.org/#/c/620154/
14:23:22 bauzas mriedem: sure, will do
14:23:58 sean-k-mooney adrianc: ill be addressing his nits first but if you want to respond to any of his questions ill incoperate your answers tomorrow after i review the latest version fo the code
14:24:26 adrianc adrianc: great, so seems we are on the right track, ill look at his comments today and comment if needed
14:25:11 sean-k-mooney adrianc: the main question resolves around how the claims will work and how we handel mixed verions of compute nodes
14:28:25 sean-k-mooney adrianc: i am hoping we can converge on the spec and approve it in the next week or so and then have the code ready for a runway not too long after. if we can land this before m2 that would be ideal but we will see how things go
14:28:46 sean-k-mooney there are several higher priority items ahead of it
14:56:30 jangutter jaypipes, sean-k-mooney: regarding the os-vif-generic-datapath-spec-of-doom, how would I go about "freezing the object versions prior to a major version bump"?
14:57:16 sean-k-mooney you wouldnt we jsut would not bump them if that is what we agreed to do
14:57:52 jangutter jaypipes, sean-k-mooney: OK, is there some way of submitting that as a doc patch to os-vif?
14:57:54 jaypipes sean-k-mooney: I've proposed just back-versioning everything to 1.0 on all those objects.
14:58:04 jaypipes sean-k-mooney: since nothing is sent over the wire anyway
14:58:20 sean-k-mooney jaypipes: so kuryr might be
14:58:26 jaypipes ugh
14:58:30 sean-k-mooney they should not be but they might be
14:58:38 sean-k-mooney but we will figure that out
14:58:55 sean-k-mooney im fine with flatneing to 1.0 or 2.0
14:59:08 sean-k-mooney jaypipes: did you see my mail by the way
14:59:25 jaypipes sean-k-mooney: yes but haven't gotten to it yet this morning
15:00:34 sean-k-mooney it kindof long you can skip most of it
15:01:02 jangutter is there a separate mailing list for os-vif (or is it mostly nova + neutron)...
15:01:42 sean-k-mooney i will likely propsoe a patch to our docs later this week to update our usage docs to document some of expections we have more explictly
15:02:05 sean-k-mooney jangutter: i useally add [os-vif] and [nova][neutron]
15:02:12 sean-k-mooney but not really
15:14:19 openstackgerrit Balazs Gibizer proposed openstack/nova master: Send RP uuid in the port binding https://review.openstack.org/569459
15:14:19 openstackgerrit Balazs Gibizer proposed openstack/nova master: Recalculate request group - RP mapping during re-schedule https://review.openstack.org/619529
15:14:20 openstackgerrit Balazs Gibizer proposed openstack/nova master: Reject interface attach with QoS aware port https://review.openstack.org/570078
15:14:20 openstackgerrit Balazs Gibizer proposed openstack/nova master: Test boot with more ports with bandwidth request https://review.openstack.org/573317
15:14:21 openstackgerrit Balazs Gibizer proposed openstack/nova master: Reject networks with QoS policy https://review.openstack.org/570079
15:18:12 jangutter sean-k-mooney, jaypipes: if I don't need to jump through hoops, I hope https://review.openstack.org/#/c/572081 is a good representative of 'Option 1'.
15:21:03 mriedem dansmith: online data migration pattern check here https://review.openstack.org/#/c/613499/12/nova/objects/compute_node.py@211 - it works, but not sure if it's the "right way"
15:21:21 openstackgerrit Balazs Gibizer proposed openstack/nova master: Deprecate the unversioned notifications https://review.openstack.org/603079
15:21:29 dansmith mriedem: queued
15:21:45 adrianc Ah i really need to setup an IRC bouncer, sean-k-mooney: understood, ive dealt with the mixed version in the code. we will see how it goes.
15:22:39 sean-k-mooney adrianc: i just set up znc on kubernets over the weekend. k8s is a pain on the ass but i now have a bouncer
15:23:48 sean-k-mooney it was so much more work then i had planned vs plain docker

Earlier   Later