| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-11-21 | |||
| 19:57:31 | mriedem | http://paste.openstack.org/show/735916/ | |
| 19:58:57 | sean-k-mooney | mriedem: do you want sema.__enter__.assert_called_once() or just assert it is called | |
| 19:59:56 | mriedem | does'nt matter | |
| 20:00:09 | mriedem | point is, i don't really want to add a bunch of mocks all over test code and never assert it's used | |
| 20:00:23 | sean-k-mooney | ah ok | |
| 20:02:40 | sean-k-mooney | im not sure that does what you want | |
| 20:03:27 | sean-k-mooney | you are asserting that the __enter__ metod of the sema context manager is called but will that not always be called by the with statement | |
| 20:03:48 | mriedem | if i remove the code change for that method, the test fails | |
| 20:03:53 | mriedem | which is what i'd expect | |
| 20:04:51 | sean-k-mooney | hum ok this is one of those things in python that i always have to trow in an interpreter to prove to myself it scorrect | |
| 20:06:16 | mriedem | i also don't know why we have nova.privsep.qemu.convert_image but not everything uses it, there are a few places in here that are calling qemu-img convert outside of privsep | |
| 20:06:43 | mriedem | dansmith: do you know anything about that? ^ | |
| 20:06:53 | mriedem | b/c i thought we declared mission accomplished on privsep stuff | |
| 20:07:10 | sean-k-mooney | mriedem: are the fucntion that call it out side of privsep called from function with the prive sep decorator applied | |
| 20:08:00 | mriedem | umm, no | |
| 20:08:12 | mriedem | grep _disk_raw_to_qcow2 in the libvirt driver | |
| 20:08:31 | mriedem | it's using processutils from oslo | |
| 20:09:04 | mriedem | and we're passing through a rootwrap helper | |
| 20:10:09 | dansmith | mriedem: not everything like that needs to run privileged | |
| 20:10:13 | sean-k-mooney | ttp://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/driver.py#n8361 is using oslo but i dont see a rootwarap helper | |
| 20:10:30 | dansmith | mriedem: might be that we need image convert sometimes when reading from an lvm or something like that, I dunno | |
| 20:11:15 | mriedem | ok i'll pretend this never happene | |
| 20:11:20 | dansmith | good plan | |
| 20:11:25 | sean-k-mooney | assuimg the nova user has the correct permisiosn to read and write the vm images it shoudl be able to execute that command with out elevating | |
| 20:11:34 | mriedem | jackding: so on that io concurrency change, | |
| 20:11:45 | mriedem | i would just like to see that for the functional code paths that add the context manager, | |
| 20:11:53 | mriedem | that at least one corresponding unit test asserts the context manager is called | |
| 20:12:01 | mriedem | like i noted for _disk_raw_to_qcow2 | |
| 20:12:06 | mriedem | then i'm +20 on that change | |
| 20:12:21 | mriedem | the privsep one might not be possible | |
| 20:12:27 | sean-k-mooney | based on code search its only ever called once | |
| 20:12:29 | sean-k-mooney | http://codesearch.openstack.org/?q=_disk_raw_to_qcow2&i=nope&files=&repos=nova | |
| 20:12:51 | jackding | mriedem: I have added asserts for all places where sema is used. running tox now, will push after it's done. | |
| 20:12:56 | sean-k-mooney | here in finish migration http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/libvirt/driver.py#n8437 | |
| 20:13:00 | mriedem | jackding: sweet | |
| 20:15:35 | openstackgerrit | Jack Ding proposed openstack/nova master: Add I/O Semaphore to limit concurrent disk ops https://review.openstack.org/609180 | |
| 20:18:34 | openstackgerrit | sean mooney proposed openstack/os-vif master: always create ovs port during plug https://review.openstack.org/602384 | |
| 20:18:49 | openstackgerrit | sean mooney proposed openstack/os-vif master: add isolate_vif config option https://review.openstack.org/612534 | |
| 20:18:59 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Default embedded instance.flavor.is_public attribute https://review.openstack.org/619349 | |
| 20:28:35 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Default embedded instance.flavor.is_public attribute https://review.openstack.org/619351 | |
| 20:36:33 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Default embedded instance.flavor.is_public attribute https://review.openstack.org/619352 | |
| 20:46:52 | openstackgerrit | Merged openstack/nova stable/rocky: Consider root id is None in the database case https://review.openstack.org/619076 | |
| 20:57:24 | openstackgerrit | Jack Ding proposed openstack/nova master: Add I/O Semaphore to limit concurrent disk ops https://review.openstack.org/609180 | |
| 20:58:51 | mriedem | there are some assertions made in this change which i'm not sure i agree with https://review.openstack.org/#/c/617927/ | |
| 20:58:56 | mriedem | hopefully that doesn't set some kind of precedent | |
| 20:59:24 | mriedem | saying nova supports cinder v1 is a stretch, but i wouldn't want someone to think, nova stein can't work with cinder from queens | |
| 20:59:27 | mriedem | because it totally should | |
| 21:20:02 | openstackgerrit | Merged openstack/nova master: Default embedded instance.flavor.is_public attribute https://review.openstack.org/615134 | |
| 21:41:51 | mriedem | stephenfin: artom: i've granted your wish and reviewed the numa aware live migration spec and dumped some questions | |
| 21:42:01 | mriedem | artom: can you tl;dr the diff from the approved spec in rocky to stein? | |
| 21:42:25 | mriedem | because this essentially sounds like, do the RT/claim stuff like cold migration already does (and what nikola's old patch did) | |
| 21:42:54 | mriedem | was the rocky version of the spec much more dependent on actually modeling numa in placement? | |
| 21:44:07 | openstackgerrit | Zane Bitter proposed openstack/nova stable/rocky: Don't use private interface in oslo.service https://review.openstack.org/619360 | |
| 21:44:21 | sean-k-mooney | the stine one has been refined somewhat to not depend on plamcennt at all | |
| 21:44:36 | openstackgerrit | melanie witt proposed openstack/nova-specs master: Propose counting quota usage from placement and API database https://review.openstack.org/509042 | |
| 21:45:54 | sean-k-mooney | mriedem: it will prefrom claims in the RT on the destination node and pass back the topology info as ovo form the dest to the source the same way we did for the multi port bindings spec | |
| 21:47:41 | mriedem | sean-k-mooney: i just read the stein one | |
| 21:47:52 | mriedem | i was looking for the summary on the diff from the rocky spec | |
| 21:48:36 | sean-k-mooney | ah ok stephen just proposed tthe rocky one as is so the delta should just be comparing to v1 of the stein one | |
| 21:50:08 | sean-k-mooney | there was no content change when stepen reproposed it so https://review.openstack.org/#/c/599587/1..6/specs/stein/approved/numa-aware-live-migration.rst will show you the delta | |
| 21:51:05 | sean-k-mooney | basicaly we added detail for the resouce claimes section and how the nume info on the destinaiton woudl be generated | |
| 21:53:20 | artom | mriedem, whoa, thanks dude | |
| 21:53:43 | artom | What sean-k-mooney said. And also how the destination will communicate said NUMA stuff to the source | |
| 21:54:30 | mriedem | right, ok so no placement | |
| 21:54:31 | mriedem | got it | |
| 21:54:32 | artom | And more explicitly spelled out why we can't use just placement (even if it was ready, which it isn't) and still need the resource tracker | |
| 21:54:53 | mriedem | given that, i'm going to f off for thanksgiving now | |
| 21:55:05 | artom | Fair enough, r right off then :) | |
| 21:55:12 | artom | *f | |
| 21:55:13 | sean-k-mooney | mriedem: enjoy the break o/ | |
| 21:55:52 | artom | I haven't fully parsed your feedback then, but I'll have a new version for you when you're back | |
| 21:55:57 | artom | s/then/yet | |
| 21:55:58 | artom | wtf brain | |
| 22:00:04 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Default embedded instance.flavor.is_public attribute https://review.openstack.org/619366 | |
| 22:38:13 | sean-k-mooney | cfriesen: by the way were you aware we approved a spec for vTPM on hyperv back in liberty https://specs.openstack.org/openstack/nova-specs/specs/liberty/approved/hyper-v-vtpm-devices.html | |
| 22:39:34 | openstackgerrit | Merged openstack/nova master: Make supports_direct_io work on 4096b sector size https://review.openstack.org/616580 | |
| 22:42:22 | sean-k-mooney | cfriesen: it also got appoved in mitaka but i dont think they ever implmented it | |
| 22:44:19 | sean-k-mooney | actully they do http://git.openstack.org/cgit/openstack/compute-hyperv/tree/compute_hyperv/nova/vmops.py#n1334 | |
| 22:45:39 | cfriesen | sean-k-mooney: hadn't seen it. now I'm obligated to go check it out. :) | |
| 22:48:32 | cfriesen | what git tree is that? I don't see any use of "vtpm" in nova, so it seems like it was never implemented on the nova side. | |
| 22:48:58 | sean-k-mooney | its in openstack/compute-hyperv | |
| 22:49:52 | sean-k-mooney | https://github.com/openstack/compute-hyperv its still active aparently | |
| 22:50:24 | cfriesen | looks like it was superceded by https://blueprints.launchpad.net/nova/+spec/hyper-v-shielded-vms | |
| 22:52:57 | sean-k-mooney | im going to add thi to the reply i was sending to fungi on the ml | |
| 22:53:55 | cfriesen | was proposed late for ocata, but doesn't seem to have been re-proposed for pike | |
| 22:54:53 | sean-k-mooney | well hyperv had an out of tree driver just like power so i guess they did not need to reporpose to support it | |
| 23:14:10 | fungi | thanks for the details, sean-k-mooney! | |
| 23:18:14 | fungi | and yeah, in the future where hosts which have legit tpms can pass them through the hypervisor to guests, as long as it's apparent to the guest whether it's getting an actual tpm or an emulated one i think that's probably fine | |
| 23:19:08 | fungi | at least running the emulated tpm on the hypervisor is still a step up from running an emulated tpm inside the guest itself | |
| 23:22:16 | fungi | certainly an attacker with access to the host can clone and impersonate the tpm (unlike with a proper hardware one) but that's a higher barrier than compromising the guest | |
| 23:51:16 | openstackgerrit | Merged openstack/nova master: Use long_rpc_timeout in select_destinations RPC call https://review.openstack.org/607735 | |
| 23:55:45 | openstackgerrit | Merged openstack/nova stable/pike: Handle HostMappingNotFound when deleting a compute service https://review.openstack.org/583567 | |
| #openstack-nova - 2018-11-22 | |||
| 02:11:25 | openstackgerrit | Fan Zhang proposed openstack/nova master: Log disk transfer stats in live migration monitor. https://review.openstack.org/619395 | |
| 02:18:23 | openstackgerrit | Jason SUN proposed openstack/nova master: For instances end up in cell0, set its availability_zone to None. https://review.openstack.org/618737 | |
| 03:36:18 | openstackgerrit | Yikun Jiang proposed openstack/nova master: Remove live_migration_progress_timeout config https://review.openstack.org/619142 | |
| 03:36:18 | openstackgerrit | Yikun Jiang proposed openstack/nova master: Add live migration timeout action https://review.openstack.org/619143 | |
| 04:32:45 | openstackgerrit | Fan Zhang proposed openstack/nova master: Log disk transfer stats in live migration monitor. https://review.openstack.org/619395 | |
| 05:13:57 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a bug tag for nova doc https://review.openstack.org/619434 | |
| 05:17:55 | openstackgerrit | Merged openstack/python-novaclient master: Fix a type of block_device_mapping_v2 in a comment https://review.openstack.org/619145 | |
| 06:15:59 | openstackgerrit | Jason SUN proposed openstack/nova master: For instances end up in cell0, set its availability_zone to None. https://review.openstack.org/618737 | |