| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-11-19 | |||
| 21:50:33 | cdent | yeah, you'd think so, but someone decided that the method should behave more like C | |
| 21:50:48 | cdent | the comments on the python bug are amusing | |
| 21:50:49 | sean-k-mooney | c ends with \0 | |
| 21:50:56 | sean-k-mooney | e.g. a 0 byte | |
| 21:50:58 | sean-k-mooney | not a new line | |
| 21:51:20 | cdent | right, but it tokenizes a NEWLINE | |
| 21:51:21 | cdent | apparently | |
| 21:51:25 | sean-k-mooney | so it does not match c either in terms of string termination of const char* s | |
| 21:51:30 | cdent | it's not about string termination | |
| 21:51:34 | cdent | it is about code tokenizing | |
| 21:51:59 | cdent | please, read the bug | |
| 21:52:05 | cdent | it will all become clear | |
| 21:52:30 | sean-k-mooney | yes i was as we were chatting "As was pointed out in https://bugs.python.org/issue33766 there is an edge case in the tokenizer whereby it will implicitly treat the end of input as a newline." | |
| 21:53:45 | efried | cdent: What is [1] in the commit message? | |
| 21:54:02 | cdent | that link that sean-k-mooney just pointed at, did I forget to add it? le sigh | |
| 21:54:23 | efried | not https://bugs.python.org/issue33899 ? | |
| 21:54:39 | openstackgerrit | Chris Dent proposed openstack/nova master: Skip double word hacking test https://review.openstack.org/618843 | |
| 21:54:52 | cdent | argh too many bugs | |
| 21:55:39 | sean-k-mooney | efried: the openstack bug points to the python bug | |
| 21:55:48 | openstackgerrit | Chris Dent proposed openstack/nova master: Skip double word hacking test https://review.openstack.org/618843 | |
| 21:55:51 | sean-k-mooney | but yes the commit does not have a bug link | |
| 21:56:09 | sean-k-mooney | hehe ok now it does | |
| 21:56:12 | efried | so none of those is https://bugs.python.org/issue33766 | |
| 21:56:14 | cdent | there we go, now it links to the two python bugs I wanted to link to, neither of which are the one that sean pointed to (which was an originating bug) | |
| 21:56:16 | cdent | indeed | |
| 21:57:05 | efried | Not having dug any deeper, I'll point out that ``echo 'print("a");print("b")' > test.py`` does indeed end with a newline. | |
| 21:57:16 | sean-k-mooney | yes https://bugs.python.org/issue35107 is tracking the fallout of fixing https://bugs.python.org/issue33899 which ended up breaking backward compatiblity | |
| 21:57:33 | efried | 0000026 | |
| 21:57:33 | efried | 0000020 ( " b " ) \n | |
| 21:57:33 | efried | 0000000 p r i n t ( " a " ) ; p r i n t | |
| 21:57:33 | efried | efried@efried-ThinkPad-W520:~$ od -c /tmp/test.py | |
| 21:57:33 | efried | efried@efried-ThinkPad-W520:~$ echo 'print("a");print("b")' > /tmp/test.py | |
| 21:57:47 | cdent | i don't think that's the point efried | |
| 21:57:52 | efried | I'm sure it's not. | |
| 21:57:59 | efried | hence the 'not having dug any deeper' | |
| 21:59:11 | cdent | it's the same deal: discussion on that bug revealed the different between a newline character and a NEWLINE token and ways in which tokenizer failed to produce NEWLINE in some cirtical areas | |
| 21:59:16 | cdent | the fix, however, was too hasty | |
| 22:00:11 | sean-k-mooney | ya and they should not have backporte it to python 2.7 luckally they reverted it on the 2.7 branch | |
| 22:01:12 | efried | cdent: Did this start appearing because we *just* started testing with py3.6.7? | |
| 22:01:18 | cdent | yes | |
| 22:01:38 | cdent | ubuntu bionic got it within the past few days | |
| 22:01:43 | sean-k-mooney | looking at https://bugs.python.org/issue35107 they are still discusiing what the behavior should be but i agreee with them that you should be able to round trip | |
| 22:01:46 | cdent | and our images updated recently | |
| 22:02:56 | sean-k-mooney | am i missrembereing or did ubunut ship with a beta python version at lauchch or was that just for 3.7 | |
| 22:03:28 | sean-k-mooney | i remembere there was somting about an unreleased python version at one point on ubuntu but dont know if that was 3.6 or 3.7 | |
| 22:03:29 | efried | right, cuz we've been testing with 3.7 for a while now, so if it was >=3.6.7 we should have hit it. | |
| 22:04:26 | sean-k-mooney | efried: well no the original bugfix was merged 2018-07-06 10:23 | |
| 22:05:00 | mriedem | efried: i think the 3.6 jobs switched to bionic in the last 24 hours | |
| 22:05:03 | mriedem | according to logstash | |
| 22:05:23 | sean-k-mooney | so it proably took a while to get in the ubuntu package repos and then for use to update the image with it | |
| 22:05:42 | sean-k-mooney | or what mriedem said | |
| 22:06:06 | mriedem | anyway, it doesn't really matter | |
| 22:06:15 | mriedem | sh*t is f'ed, skip until it's not | |
| 22:07:05 | mriedem | making sure we don't have double words in comments is probably not super high on the cloud infrastructure priority list | |
| 22:07:34 | cdent | my testing box has been bionic for months, but i did an update update and upgrade today (after being gone for the week of berlin) and that's when it started showing up. I reguarly to upgrades on that machine, so I think it is a minor upgrade in bionic | |
| 22:07:55 | cdent | mriedem: no way man, it's the tippy top top | |
| 22:08:36 | mriedem | how are we going to do flake8 checks AT THE EDGE?! | |
| 22:08:37 | sean-k-mooney | you know i have been starting to look into jamspell after the sumit demo | |
| 22:09:07 | sean-k-mooney | im hopign to see if i can figure out how to make it work with a git commit hook to try and fix may patches | |
| 22:09:09 | sean-k-mooney | maybe | |
| 22:09:17 | efried | heh | |
| 22:10:02 | sean-k-mooney | ok i should call it a night o/ | |
| 22:11:00 | cdent | i probably need something like that too | |
| 22:11:14 | cdent | I gave up on grammarly, seemed to be making browser too slow, and only works there | |
| 22:12:42 | sean-k-mooney | i still use it somethime but i have to fix the formating after so it breaks my workflow to copy and past the suff into a broswer | |
| 22:13:26 | sean-k-mooney | anyway email sent really going this time | |
| 22:19:34 | cdent | I think I should go too. night all | |
| 23:05:38 | efried | jroll: Can I get your nod on https://review.openstack.org/#/c/616721/ please before I merge it? | |
| 23:08:21 | openstackgerrit | Eric Fried proposed openstack/nova master: Nix refs to ResourceProvider obj from libvirt UT https://review.openstack.org/618786 | |
| 23:23:02 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix server query examples https://review.openstack.org/616834 | |
| #openstack-nova - 2018-11-20 | |||
| 00:10:18 | prometheanfire | http://logs.openstack.org/34/618834/1/check/cross-nova-py27/c3128e0/testr_results.html.gz new oslo.service causes failures | |
| 00:10:26 | prometheanfire | happy post-summit :D | |
| 00:14:33 | jroll | efried: done | |
| 01:21:06 | openstackgerrit | zhufl proposed openstack/nova master: Add missing ws seperator between words https://review.openstack.org/618491 | |
| 02:18:26 | openstackgerrit | Tetsuro Nakamura proposed openstack/nova master: Consider root id is None in the database case https://review.openstack.org/613305 | |
| 03:46:14 | openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407 | |
| 04:57:05 | openstackgerrit | Merged openstack/nova master: Skip double word hacking test https://review.openstack.org/618843 | |
| 04:57:13 | openstackgerrit | Merged openstack/nova master: Fix server query examples https://review.openstack.org/616834 | |
| 06:04:30 | openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407 | |
| 07:10:12 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova stable/rocky: Imported Translations from Zanata https://review.openstack.org/614757 | |
| 07:18:24 | openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: implement trigger crash dump https://review.openstack.org/618736 | |
| 08:29:44 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add os_compute_api:servers:create:cell_down policy https://review.openstack.org/614783 | |
| 10:30:13 | sean-k-mooney | o/ | |
| 10:33:25 | openstackgerrit | Chris Dent proposed openstack/nova master: Use external placement in functional tests https://review.openstack.org/617941 | |
| 10:33:39 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: Delete the placement code https://review.openstack.org/618215 | |
| 11:29:57 | openstackgerrit | Merged openstack/nova master: Nix refs to ResourceProvider obj from libvirt UT https://review.openstack.org/618786 | |
| 11:32:29 | cdent | huzzah | |
| 11:33:21 | sean-k-mooney | was the the last usage of placement object in the nova unit tests | |
| 11:34:03 | cdent | sean-k-mooney: not quite | |
| 11:34:14 | cdent | well, strictly speaking, yes | |
| 11:34:19 | cdent | it was the last usage of the objcts | |
| 11:34:32 | cdent | but there are some other tests which are testing things that want to use the placement db | |
| 11:34:37 | sean-k-mooney | but not the last useage of placement | |
| 11:34:42 | sean-k-mooney | ah ok | |
| 11:34:48 | cdent | in the my wip to remove the placement code I've had to remove some other tests/code | |
| 11:35:32 | cdent | when I get mat's suggestions on https://review.openstack.org/#/c/600161/ done, I'm going to go back to https://review.openstack.org/#/c/618215/ to fix up the merge conflict and tidy up whatever else is broken | |
| 11:40:00 | prometheanfire | http://logs.openstack.org/34/618834/1/check/cross-nova-py27/c3128e0/testr_results.html.gz new oslo.service causes failures | |
| 11:40:07 | prometheanfire | since people seem here :D | |
| 11:40:40 | openstackgerrit | Martin Midolesov proposed openstack/nova master: Allow driver to specify switch&port for faster lookup https://review.openstack.org/617695 | |
| 11:45:29 | cdent | prometheanfire: oh joy. I seem to recall efried and melwitt being vaguely aware of that | |