| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-11-06 | |||
| 23:51:23 | prometheanfire | just for requirements.txt | |
| 23:54:41 | efried | prometheanfire: Holy s | |
| 23:55:13 | efried | can I get a clickable version of that? | |
| 23:55:16 | efried | :P | |
| 23:56:03 | prometheanfire | need a place to put the svg | |
| 23:56:38 | prometheanfire | I'm using it as intro for https://www.openstack.org/summit/berlin-2018/summit-schedule/events/22145/using-the-openstack-requirements-process-to-manage-dependencies-in-large-projects | |
| #openstack-nova - 2018-11-07 | |||
| 00:28:05 | prometheanfire | well, devspace works | |
| 00:29:01 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Spec for cross-cell resize https://review.openstack.org/616037 | |
| 00:30:00 | mriedem | yay for upper-constraints and integration testing | |
| 00:30:02 | prometheanfire | https://dev.gentoo.org/~prometheanfire/images/nova-reqs.svg | |
| 00:30:12 | prometheanfire | :D | |
| 00:30:36 | mriedem | a lot of that stuff is probably not really required | |
| 00:30:43 | mriedem | depending on what you use | |
| 00:30:46 | mriedem | we just don't use 'extras' | |
| 00:30:53 | prometheanfire | ya | |
| 00:31:00 | prometheanfire | dep tree, so deps of deps mostly | |
| 00:31:03 | mriedem | but yeah if you pip install you're in for some frun | |
| 00:31:05 | mriedem | *fun | |
| 00:31:26 | mriedem | dansmith: i have birthed it https://review.openstack.org/#/c/616037/ | |
| 00:31:34 | mriedem | i shall call it, damien | |
| 00:31:37 | prometheanfire | dep of testtools/subunit it looks like | |
| 00:31:45 | prometheanfire | lol | |
| 00:32:15 | dansmith | mriedem: remind me tomorrow.. if there is a tomorrow. | |
| 00:32:31 | mriedem | i don't think i'm going to do anything with it until summit | |
| 00:32:34 | mriedem | i just wanted to get it out there | |
| 00:32:36 | dansmith | ack | |
| 00:47:29 | openstackgerrit | melanie witt proposed openstack/nova master: Use SleepingFixture instead of mocking _ThreadingEvent.wait https://review.openstack.org/615724 | |
| 01:39:05 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Improve formats of the Compute API guide https://review.openstack.org/615809 | |
| 01:45:20 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add method to allow fetch root_volume BDM by instance_uuid https://review.openstack.org/614672 | |
| 01:45:33 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | |
| 03:11:01 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add API ref guideline for body text https://review.openstack.org/605628 | |
| 03:49:49 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add API ref guideline for body text https://review.openstack.org/605628 | |
| 04:01:49 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Improve formats of the Compute API guide https://review.openstack.org/615809 | |
| 04:21:11 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add a link to the doc contrib guide https://review.openstack.org/616063 | |
| 05:40:47 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Adds view builders for keypairs controller https://review.openstack.org/347289 | |
| 05:41:15 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | |
| 05:57:06 | gmann | alex_xu: you around for API office hour today ? | |
| 05:57:18 | alex_xu | gmann: yea | |
| 05:58:35 | gmann | alex_xu: anything specific you have to discuss otherwise i would like to skip, little busy for summit things | |
| 06:03:40 | alex_xu | gmann: really nothing specific | |
| 06:06:03 | gmann | alex_xu: ok, i will skip then. btw you will come to summit right ? | |
| 06:09:46 | openstackgerrit | Merged openstack/nova master: [Trivial Fix] Correct spelling error of "should" and "resource" https://review.openstack.org/614899 | |
| 06:42:57 | alex_xu | gmann: no, I won't, I didn't get budget this time | |
| 06:43:28 | gmann | alex_xu: oh | |
| 07:51:53 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add method to allow fetch root_volume BDM by instance_uuid https://review.openstack.org/614672 | |
| 08:41:55 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | |
| 09:08:02 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Add method to allow fetch root_volume BDM by instance_uuid https://review.openstack.org/614672 | |
| 09:09:45 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750 | |
| 09:20:09 | openstackgerrit | Adrian Chiris proposed openstack/nova master: Allow per-port modification of vnic_type and profile https://review.openstack.org/607365 | |
| 09:20:09 | openstackgerrit | Adrian Chiris proposed openstack/nova master: add get_pci_requests_from_vifs to request.py https://review.openstack.org/609166 | |
| 09:20:10 | openstackgerrit | Adrian Chiris proposed openstack/nova master: Add free for claimed, allocated devices https://review.openstack.org/616120 | |
| 11:25:57 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transfer port.resource_request to the scheduler https://review.openstack.org/567268 | |
| 12:04:58 | openstackgerrit | lvxianguo proposed openstack/python-novaclient master: Update the documentation bug tag https://review.openstack.org/616174 | |
| 12:37:58 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Make _instances_cores_ram_count() be smart about cells https://review.openstack.org/569055 | |
| 12:37:59 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: WIP: API microversion bump for handling-down-cell https://review.openstack.org/591657 | |
| 12:37:59 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: [WIP] Add os_compute_api:servers:create:cell_down policy https://review.openstack.org/614783 | |
| 12:56:07 | sean-k-mooney | bauzas: cdent gibi for https://review.openstack.org/#/c/610034/10 are we ok with its current form or do we want another revision | |
| 12:57:31 | sean-k-mooney | bauzas: cdent gibi any change i make to the nova version will also need to be appied to the placement version and i dont really want to kick of ci jobs for all the stuff that depnd on this on the placemnt side un less i need too | |
| 12:57:56 | cdent | sean-k-mooney: I'm not sure. gibi seemed to have some reservations and it might make sense to do his simpler version in nova and the run_once version in placement (where we have longer term needs) | |
| 12:57:58 | sean-k-mooney | that said i also plan to back port this so i what this to be right | |
| 12:58:26 | sean-k-mooney | cdent: nova need to have it done for the nova-api too however | |
| 12:58:43 | sean-k-mooney | do we want two ifs one for each both depending on private data | |
| 12:59:30 | cdent | I don't have a strong preference, except that we move it forward quickly in some way that satisfies us and recognize that it is okay to fix it more later. | |
| 13:00:36 | sean-k-mooney | cdent: ya same. this has been blocking downstream ci for almost a month at this point. i will have to consider applying a donwstream only fix if we dont merge something with the next week | |
| 13:01:45 | cdent | Yeah, we seem to have quite the backlog at the moment | |
| 13:05:13 | cdent | sean-k-mooney: I wish I could help to move things a bit more | |
| 13:06:12 | sean-k-mooney | cdent: i need to run to the bank so ill be back in a while. efried spotted a typo so i was going to resping for that and ill add the extra docs that gibi asked for too. unfortunetly that will cause curn on the placement side is that ok with you? | |
| 13:06:18 | sean-k-mooney | cdent: and no worries | |
| 13:06:35 | sean-k-mooney | you have help move it along alot already | |
| 13:07:13 | cdent | no worries on the placement side, I'll watch that and make sure it's properly rebased etc. The test load from placement is currently very light and fast, so no issues there. | |
| 13:07:41 | sean-k-mooney | thanks :) ok got to run brb | |
| 13:13:20 | gibi | sean-k-mooney: my -1 is mostly due to the problem with raised exception from the wrapped function | |
| 13:13:40 | gibi | sean-k-mooney: the rest is mostly thinking out loud different alternatives | |
| 13:14:43 | sean-k-mooney | gibi: well we dont want to catch exceptions when we invoke the wrapped function the first time. but we could catch exceptions when logging i guess | |
| 13:15:05 | gibi | sean-k-mooney: my problem is that if the first call raises then we allow a second call | |
| 13:15:18 | gibi | sean-k-mooney: because called only set _after_ the wrapped function returns | |
| 13:15:38 | sean-k-mooney | gibi: yes because this is a general decorator and we should not assume that means another call to the same fucntion will also raise | |
| 13:16:17 | gibi | sean-k-mooney: for me the contract of that decorator is that the decorated function will be called at most once. But the actual implementation allows any number of calls to the wrapped function if the wrapped function raises | |
| 13:16:38 | sean-k-mooney | gibi: yes the order of setting called after was very deliberate | |
| 13:17:35 | gibi | so if my func() has some code in it that can only be run once, but also my func() can raise then I cannot use the new decorator | |
| 13:17:36 | sean-k-mooney | gibi: for me it will be called at most once if it succeeds and the fuctor object will be in its orignal state if not | |
| 13:17:42 | artom | lyarwood, could you hit https://review.openstack.org/#/c/587249/ ? It's the pike version of a backport you +2'ed for Queens - I'll try and get Matt R as well when he comes onlone | |
| 13:18:01 | artom | (Pike is still a thing, right? I know Ocata is EM now) | |
| 13:18:09 | sean-k-mooney | gibi: you can but if you caugt the excption that by definitoin means its recoverable | |
| 13:18:21 | lyarwood | artom: yeah tis and I'll get to it after this call | |
| 13:18:23 | sean-k-mooney | gibi: if its not recoverable you should end the program | |
| 13:18:34 | artom | lyarwood, much thanks! | |
| 13:18:44 | sean-k-mooney | gibi: so that means you should be able to call the function again. | |
| 13:19:23 | gibi | sean-k-mooney: but allowing to call the function _again_ is something the run_once decorator should not allow at least that is what the name of the decorator suggests | |
| 13:20:13 | sean-k-mooney | gibi: the contract i wanted to give is this fucntion will run once sucessfully | |
| 13:20:14 | gibi | sean-k-mooney: I don't want to block your CI so I'm fine if you can document the behavior of the decorator precisely | |
| 13:20:30 | sean-k-mooney | sure ill add more documentaion | |
| 13:21:54 | sean-k-mooney | i could may be make the setting of the called value explcit but i was concered that people would complain it was over enginerred. my oringinal solution was a try block | |
| 13:22:14 | sean-k-mooney | then an if and then i was asked for a decorator | |
| 13:23:27 | gibi | sean-k-mooney: I'm one of the guy who feels it is overengineered so please do not add more configurability to the decorator, add just more documentation what is the intention of the decorator. Like that a run only counts if it wasn't raised | |
| 13:24:25 | sean-k-mooney | ok will do thanks ill get this back up in about 2 hours | |
| 13:24:39 | gibi | sean-k-mooney: ping me and I will try to +2 it quickly | |
| 13:42:08 | artom | lyarwood, there's the one below it as well ;) https://review.openstack.org/#/c/587248/1 | |
| 13:43:08 | artom | Cheers! | |
| 13:43:21 | lyarwood | artom: np LGTM | |