Posted	Nick	Remark
#openstack-nova - 2018-11-06
00:04:47	openstackgerrit	Eric Fried proposed openstack/nova master: WIP: Remove redundant inventory refresh https://review.openstack.org/615695
00:12:28	efried	Oh, jaypipes, you're gonna like this one...
00:33:10	openstackgerrit	gaobin proposed openstack/nova master: Complete the parameters in the API documentation https://review.openstack.org/615697
01:03:52	openstackgerrit	Joshua Cornutt proposed openstack/nova master: Moving get_hash_str() from md5 to sha-256 https://review.openstack.org/615704
01:27:37	openstackgerrit	Eric Fried proposed openstack/nova master: WIP: Commonize _update code path https://review.openstack.org/615705
01:27:47	efried	jaypipes: Still working out the kinks, but ^^
01:28:00	efried	-1KLOC so far :)
01:34:45	openstackgerrit	Merged openstack/nova-specs master: High Precision Event Timer (HPET) on x86 guests https://review.openstack.org/607989
01:54:51	prometheanfire	not sure if oslo or nova, but the other services are fine
01:54:55	prometheanfire	new oslo.service breaks nova
01:54:57	prometheanfire	http://logs.openstack.org/76/615676/1/check/cross-nova-py27/67e6a5d/testr_results.html.gz
01:56:34	melwitt	prometheanfire: ouch. will take a look later
02:04:53	openstackgerrit	Joshua Cornutt proposed openstack/nova master: Moving get_hash_str() from md5 to sha-256 https://review.openstack.org/615704
05:05:53	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Remove Placement API reference https://review.openstack.org/614437
05:12:53	prometheanfire	melwitt: :D
05:44:19	openstackgerrit	melanie witt proposed openstack/nova master: Patch LoopingCallBase._sleep instead of _ThreadingEvent.wait https://review.openstack.org/615724
07:27:23	openstackgerrit	Yikun Jiang proposed openstack/nova master: Add compute_node ratio online data migration script https://review.openstack.org/609995
07:38:31	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750
08:14:40	openstackgerrit	Merged openstack/nova master: Add request_spec.RequestGroup versioned object https://review.openstack.org/568840
08:51:59	openstackgerrit	Merged openstack/nova master: Add requested_resources field to RequestSpec https://review.openstack.org/567267
09:31:29	openstackgerrit	Maciej Jozefczyk proposed openstack/nova master: Force refresh instance info_cache during heal https://review.openstack.org/591607
09:31:30	openstackgerrit	Maciej Jozefczyk proposed openstack/nova master: Add fill_virtual_interface_list online_data_migration script https://review.openstack.org/614167
10:14:24	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Improve formats of the Compute API guide https://review.openstack.org/615809
10:57:48	s10	Please approve backports for https://review.openstack.org/#/q/If1c901b974bc7295927b3f033a04eaa6ac36f603
11:49:52	openstackgerrit	Brin Zhang proposed openstack/nova-specs master: Support deleting data volume when destroy instance https://review.openstack.org/580336
12:37:30	fanzhang	hi melwitt, sorry to bother, but if you got some free time, would you please take a look at this patch ? https://review.openstack.org/#/c/612272/
13:33:24	openstackgerrit	Radoslav Gerganov proposed openstack/nova master: Fix support matrix for VMware UEFI support https://review.openstack.org/615870
13:56:45	openstackgerrit	sean mooney proposed openstack/nova-specs master: Add spec for sriov live migration https://review.openstack.org/605116
14:11:21	mriedem	efried: "Tell me we have a retry in place for that" yes we should
14:11:49	mriedem	efried: "Is the code path for is_new_compute_node guaranteed to run only on startup?" no it runs during the periodic so you could delete the compute service, forget to stop the nova-compute service on the host, and it will recreate the compute node record
14:16:22	openstackgerrit	John Garbutt proposed openstack/nova-specs master: Enable rebuild for instances in cell0 https://review.openstack.org/554218
14:18:09	openstackgerrit	John Garbutt proposed openstack/nova-specs master: Add PENDING vm state https://review.openstack.org/554212
14:19:10	openstackgerrit	John Garbutt proposed openstack/nova-specs master: Add PENDING vm state https://review.openstack.org/554212
14:25:30	jangutter	to all the US people, good luck with voting... The most important vote in our lifetime is the one that names the T release.
14:26:57	bauzas	R
14:26:57	bauzas	T
14:26:58	bauzas	A
14:26:59	bauzas	I
14:27:00	bauzas	N
14:51:29	openstackgerrit	Merged openstack/nova-specs master: Add support for emulated virtual TPM https://review.openstack.org/571111
14:52:26	openstackgerrit	Merged openstack/nova-specs master: Switch to stestr https://review.openstack.org/581284
14:54:41	openstackgerrit	Jay Pipes proposed openstack/nova master: quota: remove get_quota_classes() driver method https://review.openstack.org/615615
14:54:42	openstackgerrit	Jay Pipes proposed openstack/nova master: quota: remove Context.quota_class https://review.openstack.org/615616
14:54:43	openstackgerrit	Jay Pipes proposed openstack/nova master: quota: clean up DbQuotaDriver unit tests https://review.openstack.org/615619
14:54:43	openstackgerrit	Jay Pipes proposed openstack/nova master: quota: remove _no_class tests https://review.openstack.org/615618
14:54:43	openstackgerrit	Jay Pipes proposed openstack/nova master: quota: remove FakeContext from quota unit tests https://review.openstack.org/615617
14:54:44	openstackgerrit	Jay Pipes proposed openstack/nova master: quota: rename arguments to clarify they are limits https://review.openstack.org/615633
15:08:09	efried	mriedem: okay, I added this part to account for that: https://review.openstack.org/#/c/615677/2/nova/compute/resource_tracker.py
15:15:49	mriedem	meaning if it's a new compute node, clear_provider_cache() so that when we hit the report client later, it will see it's empty and force the POST of the resource provider for the new compute node record?
15:18:57	efried	mriedem: It won't force the POST necessarily. It'll do the GET /rps?in_tree - which we would otherwise skip if it was already in the cache - and iff that comes up empty, it'll do the POST to create.
15:19:32	mriedem	yeah i left comments, i think i understand
15:19:50	mriedem	also, nice coincidental use of iff https://review.openstack.org/#/c/614037/2/nova/scheduler/host_manager.py@679
15:31:20	mriedem	i just came in hot and late and dumped some comments on a few changes in that series
15:36:23	gibi	mriedem: now I managed to read back the diffs in the two bandwidth patch you fixed up and approved. Thank you for making those changes. They look good to me in retrospect
15:36:45	mriedem	cool, yw
15:36:57	gibi	mriedem: I think I this week finally I will have time to pick up that patch series again.
15:44:56	efried	mriedem: https://review.openstack.org/#/c/615646/ see response please. I may be misunderstanding some side effect of making the conf option mutable.
15:47:43	mriedem	hmm yeah i guess in addition to changing the refresh cache interval, we also need to clear the in-memory "cache" in the compute
15:48:30	mriedem	dropped the -1
15:48:37	efried	correct. I agree making the conf option mutable (in the bottom patch) is a good idea.
15:48:41	mriedem	we should make the refresh interval option mutable somewhere in this series shouldn't we?
15:48:45	mriedem	ok
15:48:53	efried	mriedem: unless you think that should be separated.
15:49:21	mriedem	i'm fine with it either going in the bottom change that adds min=0 or the sighup change to clear the cache
15:49:50	mriedem	it might make more logical sense to be in the sighup change itself
15:49:53	mriedem	but idk, not a big deal probably
15:51:25	efried	It was tempting to do both of those things at the same time, since (rats, I forgot to do this...) I'm going to update the conf option help and the reno text in the SIGHUP patch anyway.
16:02:39	openstackgerrit	Jay Pipes proposed openstack/nova master: prevent common kwargs from glance client failure https://review.openstack.org/614351
16:05:09	jaypipes	efried: ^^ took your advice and re-worked that patch. thanks again for the great idea.
16:05:23	efried	jaypipes: cool mon, will look.
16:05:49	efried	jaypipes: Have you seen my -1KLOC rt patch yet?
16:06:09	efried	(that's a minus :)
16:09:23	jaypipes	efried: it's in the queue...
16:09:41	efried	jaypipes: It's not quite finished yet, just thought it would bring a smile to your face.
16:15:20	mriedem	melwitt: is there any reason we don't call _clean_instance_console_tokens when we shelve offload from a host?
16:15:34	mriedem	i guess we don't *have* to because the _cleanup_expired_console_auth_tokens periodic should clean them up?
16:16:07	openstackgerrit	Merged openstack/nova master: Add bandwidth related standard resource classes https://review.openstack.org/570847
16:26:05	melwitt	mriedem: I think the only reason is because when we moved from consoleauth => database backend we didn't introduce any behavior changes (didn't add any additional token removal sites other than the periodic). there were some sites during the review where we said, "there should probably be token removal here"
16:32:59	efried	stephenfin: https://review.openstack.org/#/c/614351/ is back atcha, when you get a chance.
16:41:17	efried	mriedem, jaypipes: If we're gonna make the default "no refreshing", why not just remove the conf option and all unprompted periodic refreshing entirely?
16:43:40	mriedem	because i continue to think there was originally some desire to allow external services to frequently adjust things that might affect what we report, like inventory and traits, i.e. powervm and vcenter things
16:43:55	mriedem	that are trying to sync information back from those "hypervisors" to nova
16:44:51	mriedem	if there aren't, and the refresh was just purely a bridge b/c that's how the RT always worked before placement, then i'm a big meh on keeping the refresh stuff
16:44:57	efried	mriedem: Well, anything that happens in upt will get synced back right away.
16:45:13	efried	and we already allow tailoring the interval that runs upt
16:45:42	mriedem	so external changes from let's say vcenter for inventory/traits would just get synced back via the driver -> RT -> reportclient -> placement
16:46:02	efried	assuming the driver is set up to detect them and push them into the provider tree, yeah.
16:46:31	efried	but actually
16:47:02	cdent	from the vcenter side there some slim chance that what might be considered weird resource providers will be being created within the virt driver during upt. If that's cool and upt is happening regularly, then goorvy
16:47:05	efried	if they're truly oob, then the next time upt thinks something *else* has changed, its update will bounce 409 (due to the oob change) and we'll clear the cache and go again on the next periodic.
16:47:30	efried	but only if upt thinks something else has changed, and that something else happens to be on the same provider that changed oob. So that's not a reliable model.
16:47:50	efried	No, we have to count on the virt driver being the sole source of truth OR the oob changes being followed with SIGHUP. Unless we keep the refresh.
17:30:59	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Destination.cross_cell_move field https://review.openstack.org/614035
17:30:59	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add Migration.cross_cell_move and get_by_uuid https://review.openstack.org/614012
17:31:00	openstackgerrit	Matt Riedemann proposed openstack/nova master: Change HostManager to allow scheduling to other cells https://review.openstack.org/614037
17:31:00	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add InstanceAction/Event create() method https://review.openstack.org/614036
17:31:01	openstackgerrit	Matt Riedemann proposed openstack/nova master: WIP: Cross-cell resize https://review.openstack.org/603930
17:31:01	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add CrossCellWeigher https://review.openstack.org/614353
17:36:28	bauzas	mriedem: mmm, I'm working on a customer issue in Newton, and AFAICS we don't call the late check for anty-affinity in the compute service if it's a live-migration :(
17:36:44	bauzas	mriedem: looks like we don't do this even now

Earlier   Later