Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-11-05
22:18:09 cdent mriedem: I don't have a huge opinion on that actual name, just that the symbol and the string in the canonical location be the same thing
22:18:31 cdent given the canonical location is going to change soonish *shrug*
22:19:47 mriedem gibi mentioned the bits vs bytes thing
22:20:10 mriedem "I needed to include the unit of the resource as it is not trivial and as the name needs to be all upper case the bit and byte difference (the capital B in KB means byte officially) in the unit cannot be expressed if abbreviated."
22:21:58 mriedem i'll just change to NET_BW_EGR_KILOBIT_PER_SEC and NET_BW_IGR_KILOBIT_PER_SEC so we can shit and get off the pot
22:22:34 cdent wfm
22:30:13 efried So effit, we can just go back to the original names and suck up literally half the line width Python allows us.
22:30:13 efried But jaypipes has a point that you can always alias it if you need to.
22:30:13 efried I don't see why the const has to be the same as the string.
22:30:13 efried since I think the discussion is all my fault, I might as well weigh back in.
22:32:24 mriedem no backsies now
22:32:26 mriedem i've already changed it
22:39:37 efried idgas
22:47:47 openstackgerrit Matt Riedemann proposed openstack/nova master: Add request_spec.RequestGroup versioned object https://review.openstack.org/568840
22:47:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Add bandwidth related standard resource classes https://review.openstack.org/570847
22:47:48 openstackgerrit Matt Riedemann proposed openstack/nova master: Add requested_resources field to RequestSpec https://review.openstack.org/567267
22:47:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Reject interface attach with QoS aware port https://review.openstack.org/570078
22:47:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Transfer port.resource_request to the scheduler https://review.openstack.org/567268
22:47:50 openstackgerrit Matt Riedemann proposed openstack/nova master: Reject networks with QoS policy https://review.openstack.org/570079
23:01:53 mriedem UH OH http://logs.openstack.org/47/615347/5/check/tempest-full/bf73d04/controller/logs/screen-n-sch.txt.gz#_Nov_05_20_39_53_554408
23:02:49 mriedem http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22AllocationUpdateFailed%3A%20Failed%20to%20update%20allocations%20for%20consumer%5C%22%20AND%20message%3A%5C%22Error%3A%20another%20process%20changed%20the%20consumer%5C%22%20AND%20message%3A%5C%22after%20the%20report%20client%20read%20the%20consumer%20state%20during%20the%20claim%5C%22%20AND%20tags%3A%5C%22screen-n-sch.txt%5C%22&from=10d
23:08:25 efried mriedem: Tell me we have a retry in place for that
23:13:47 efried mriedem: Is the code path for is_new_compute_node guaranteed to run only on startup?
23:56:51 openstackgerrit Eric Fried proposed openstack/nova master: Remove LazyLoad of Scheduler Clients https://review.openstack.org/615641
23:56:52 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Reduce calls to placement from _ensure https://review.openstack.org/615677
23:56:52 openstackgerrit Eric Fried proposed openstack/nova master: SIGHUP n-cpu to refresh provider tree cache https://review.openstack.org/615646
#openstack-nova - 2018-11-06
00:04:47 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Remove redundant inventory refresh https://review.openstack.org/615695
00:12:28 efried Oh, jaypipes, you're gonna like this one...
00:33:10 openstackgerrit gaobin proposed openstack/nova master: Complete the parameters in the API documentation https://review.openstack.org/615697
01:03:52 openstackgerrit Joshua Cornutt proposed openstack/nova master: Moving get_hash_str() from md5 to sha-256 https://review.openstack.org/615704
01:27:37 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Commonize _update code path https://review.openstack.org/615705
01:27:47 efried jaypipes: Still working out the kinks, but ^^
01:28:00 efried -1KLOC so far :)
01:34:45 openstackgerrit Merged openstack/nova-specs master: High Precision Event Timer (HPET) on x86 guests https://review.openstack.org/607989
01:54:51 prometheanfire not sure if oslo or nova, but the other services are fine
01:54:55 prometheanfire new oslo.service breaks nova
01:54:57 prometheanfire http://logs.openstack.org/76/615676/1/check/cross-nova-py27/67e6a5d/testr_results.html.gz
01:56:34 melwitt prometheanfire: ouch. will take a look later
02:04:53 openstackgerrit Joshua Cornutt proposed openstack/nova master: Moving get_hash_str() from md5 to sha-256 https://review.openstack.org/615704
05:05:53 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove Placement API reference https://review.openstack.org/614437
05:12:53 prometheanfire melwitt: :D
05:44:19 openstackgerrit melanie witt proposed openstack/nova master: Patch LoopingCallBase._sleep instead of _ThreadingEvent.wait https://review.openstack.org/615724
07:27:23 openstackgerrit Yikun Jiang proposed openstack/nova master: Add compute_node ratio online data migration script https://review.openstack.org/609995
07:38:31 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Bump compute service to indicate attach/detach root volume is supported https://review.openstack.org/614750
08:14:40 openstackgerrit Merged openstack/nova master: Add request_spec.RequestGroup versioned object https://review.openstack.org/568840
08:51:59 openstackgerrit Merged openstack/nova master: Add requested_resources field to RequestSpec https://review.openstack.org/567267
09:31:29 openstackgerrit Maciej Jozefczyk proposed openstack/nova master: Force refresh instance info_cache during heal https://review.openstack.org/591607
09:31:30 openstackgerrit Maciej Jozefczyk proposed openstack/nova master: Add fill_virtual_interface_list online_data_migration script https://review.openstack.org/614167
10:14:24 openstackgerrit Takashi NATSUME proposed openstack/nova master: Improve formats of the Compute API guide https://review.openstack.org/615809
10:57:48 s10 Please approve backports for https://review.openstack.org/#/q/If1c901b974bc7295927b3f033a04eaa6ac36f603
11:49:52 openstackgerrit Brin Zhang proposed openstack/nova-specs master: Support deleting data volume when destroy instance https://review.openstack.org/580336
12:37:30 fanzhang hi melwitt, sorry to bother, but if you got some free time, would you please take a look at this patch ? https://review.openstack.org/#/c/612272/
13:33:24 openstackgerrit Radoslav Gerganov proposed openstack/nova master: Fix support matrix for VMware UEFI support https://review.openstack.org/615870
13:56:45 openstackgerrit sean mooney proposed openstack/nova-specs master: Add spec for sriov live migration https://review.openstack.org/605116
14:11:21 mriedem efried: "Tell me we have a retry in place for that" yes we should
14:11:49 mriedem efried: "Is the code path for is_new_compute_node guaranteed to run only on startup?" no it runs during the periodic so you could delete the compute service, forget to stop the nova-compute service on the host, and it will recreate the compute node record
14:16:22 openstackgerrit John Garbutt proposed openstack/nova-specs master: Enable rebuild for instances in cell0 https://review.openstack.org/554218
14:18:09 openstackgerrit John Garbutt proposed openstack/nova-specs master: Add PENDING vm state https://review.openstack.org/554212
14:19:10 openstackgerrit John Garbutt proposed openstack/nova-specs master: Add PENDING vm state https://review.openstack.org/554212
14:25:30 jangutter to all the US people, good luck with voting... The most important vote in our lifetime is the one that names the T release.
14:26:57 bauzas R
14:26:57 bauzas T
14:26:58 bauzas A
14:26:59 bauzas I
14:27:00 bauzas N
14:51:29 openstackgerrit Merged openstack/nova-specs master: Add support for emulated virtual TPM https://review.openstack.org/571111
14:52:26 openstackgerrit Merged openstack/nova-specs master: Switch to stestr https://review.openstack.org/581284
14:54:41 openstackgerrit Jay Pipes proposed openstack/nova master: quota: remove get_quota_classes() driver method https://review.openstack.org/615615
14:54:42 openstackgerrit Jay Pipes proposed openstack/nova master: quota: remove Context.quota_class https://review.openstack.org/615616
14:54:43 openstackgerrit Jay Pipes proposed openstack/nova master: quota: clean up DbQuotaDriver unit tests https://review.openstack.org/615619
14:54:43 openstackgerrit Jay Pipes proposed openstack/nova master: quota: remove _no_class tests https://review.openstack.org/615618
14:54:43 openstackgerrit Jay Pipes proposed openstack/nova master: quota: remove FakeContext from quota unit tests https://review.openstack.org/615617
14:54:44 openstackgerrit Jay Pipes proposed openstack/nova master: quota: rename arguments to clarify they are limits https://review.openstack.org/615633
15:08:09 efried mriedem: okay, I added this part to account for that: https://review.openstack.org/#/c/615677/2/nova/compute/resource_tracker.py
15:15:49 mriedem meaning if it's a new compute node, clear_provider_cache() so that when we hit the report client later, it will see it's empty and force the POST of the resource provider for the new compute node record?
15:18:57 efried mriedem: It won't force the POST necessarily. It'll do the GET /rps?in_tree - which we would otherwise skip if it was already in the cache - and iff that comes up empty, it'll do the POST to create.
15:19:32 mriedem yeah i left comments, i think i understand
15:19:50 mriedem also, nice coincidental use of iff https://review.openstack.org/#/c/614037/2/nova/scheduler/host_manager.py@679
15:31:20 mriedem i just came in hot and late and dumped some comments on a few changes in that series
15:36:23 gibi mriedem: now I managed to read back the diffs in the two bandwidth patch you fixed up and approved. Thank you for making those changes. They look good to me in retrospect
15:36:45 mriedem cool, yw
15:36:57 gibi mriedem: I think I this week finally I will have time to pick up that patch series again.
15:44:56 efried mriedem: https://review.openstack.org/#/c/615646/ see response please. I may be misunderstanding some side effect of making the conf option mutable.
15:47:43 mriedem hmm yeah i guess in addition to changing the refresh cache interval, we also need to clear the in-memory "cache" in the compute
15:48:30 mriedem dropped the -1
15:48:37 efried correct. I agree making the conf option mutable (in the bottom patch) is a good idea.
15:48:41 mriedem we should make the refresh interval option mutable somewhere in this series shouldn't we?
15:48:45 mriedem ok
15:48:53 efried mriedem: unless you think that should be separated.
15:49:21 mriedem i'm fine with it either going in the bottom change that adds min=0 or the sighup change to clear the cache
15:49:50 mriedem it might make more logical sense to be in the sighup change itself
15:49:53 mriedem but idk, not a big deal probably
15:51:25 efried It was tempting to do both of those things at the same time, since (rats, I forgot to do this...) I'm going to update the conf option help and the reno text in the SIGHUP patch anyway.
16:02:39 openstackgerrit Jay Pipes proposed openstack/nova master: prevent common kwargs from glance client failure https://review.openstack.org/614351
16:05:09 jaypipes efried: ^^ took your advice and re-worked that patch. thanks again for the great idea.
16:05:23 efried jaypipes: cool mon, will look.
16:05:49 efried jaypipes: Have you seen my -1KLOC rt patch yet?
16:06:09 efried (that's a minus :)
16:09:23 jaypipes efried: it's in the queue...
16:09:41 efried jaypipes: It's not quite finished yet, just thought it would bring a smile to your face.

Earlier   Later