Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-10-26
15:41:33 SteelyDan which is why we've been talking about removing it entirely since placement became required
15:41:50 cdent SteelyDan: that was _one_ of the reasons, and yes, the very first reason, but very quickly it took on "deal with errors from keystoneclient"
15:42:31 SteelyDan yes, it has evolved
15:42:42 openstackgerrit Eric Fried proposed openstack/nova master: Kill @safe_connect in _get_provider_traits https://review.openstack.org/613613
15:42:46 cdent we had: is it in the service catalog, then can I reach it
15:42:52 fried_rice cdent: added words clarifying intent --^
15:43:32 cdent thanks
15:44:31 openstackgerrit sean mooney proposed openstack/nova master: harden placement init under wsgi https://review.openstack.org/610034
15:44:34 cdent I'm trying really hard to not to think to much about the resource tracker lately but sometimes I get sucked in.
15:45:34 sean-k-mooney cdent: ^ uses the run_once decorator
15:45:38 fried_rice For example, if we decided to make it retry, we would have to restrict the decorator to *only* single primitive API calls. We would have to remove it from all the methods that do more complex things e.g. involving multiple API calls.
15:45:38 fried_rice cdent: Anything we would do to @safe_connect, beyond making it essentially a no-op shell (which isn't better than removing it IMO), would also entail a thorough audit of everywhere it is used, which is a nearly impossible task due to how many different ways and in how many layers things get called.
15:46:02 cdent sean-k-mooney: yeah, thanks, reading
15:46:25 sean-k-mooney cdent: ill propose the placement version shortly if people are fine with it
15:47:07 cdent fried_rice: yes, I know, thus why I'm trying really hard not to think about the resource tracker lately. It was already really complicated before placement, and we somehow managed to make it worse, not better.
15:47:28 fried_rice I have made a couple of attempts, and I think SteelyDan has as well, to do something to @safe_connect itself to improve it. At some point in a review leakypipes said we should just target one usage at a time and get rid of it. Which so far has been the only approach that has gotten us to actually merge code around this.
15:47:45 SteelyDan yup
15:47:54 fried_rice cdent: I still hope that it will be better in the long run, once we've purged all the legacy stuff from this painful transitional period.
15:48:09 fried_rice like @safe_connect :P
15:48:34 fried_rice and stuff gibi has been doing lately has cleaned up some of that legacy gorp too.
15:48:37 fried_rice So we're getting there.
15:48:49 cdent well, just to cover my ass here: If I had my druthers we never would have had safe_connect
15:49:09 cdent but we gots we gots
15:49:12 cdent i'll cope
15:49:28 fried_rice My dad used to say, "If frogs had wings, they wouldn't bump their asses so much."
15:49:45 fried_rice (I made that sound like he's dead or something. He would still say it, given the slightest opportunity.)
15:49:50 cdent heh
15:55:50 cdent sean-k-mooney: have you run the functional tests on that change? I think you're going to run into trouble with the databse fixture
15:55:58 spatel sean-k-mooney: is there a way to find real instance hostname using virsh list command?
15:57:05 spatel currently i am doing "virsh dumpxml instance-00000387 | grep nova:name"
15:57:14 spatel i wish it has build it function
15:58:06 sean-k-mooney cdent: am no but i will and see what it does not like
15:58:15 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix min config value for shutdown_timeout option https://review.openstack.org/613028
15:58:22 cdent sean-k-mooney: i'm doing it now, will leave a comment with the reasults
15:59:33 sean-k-mooney spatel: no grep is your friend in this case
15:59:50 spatel :) thanks
16:01:23 fried_rice cdent: btw, that log server has the ANSI color coding patch (which isn't working 100% properly - some codes don't like to turn off), not the choose-your-theme patch, so you're SOL, sorry.
16:01:51 cdent fair enough, as before, I'll cope
16:02:50 fried_rice if we ever reach a point where you're having to look at PowerVM CI logs more than once a year, I'll take that patch offa there :)
16:03:08 cdent ✔
16:06:56 openstackgerrit Martin Midolesov proposed openstack/nova master: VMware: Expose esx hosts to Openstack https://review.openstack.org/613626
16:06:56 openstackgerrit Martin Midolesov proposed openstack/nova master: vmware:PropertyCollector for caching instance properties https://review.openstack.org/608278
16:14:36 openstackgerrit Martin Midolesov proposed openstack/nova master: VMware: Expose esx hosts to Openstack https://review.openstack.org/613626
16:15:11 openstackgerrit Matt Riedemann proposed openstack/nova master: Migrate "reboot an instance" user guide docs https://review.openstack.org/612730
16:17:28 mriedem fried_rice: gibi: do you see something here that i don't? https://review.openstack.org/#/c/605785/16/nova/tests/functional/test_servers.py@5275
16:17:49 mriedem if i'm wrong, i'll +W
16:18:23 openstackgerrit Merged openstack/python-novaclient master: Fixes Python3 issue in decoding password https://review.openstack.org/604870
16:19:55 fried_rice mriedem: I didn't scrutinize tbh. If it is a redundant test, I figgered it could be removed in a fup.
16:21:54 mriedem btw, on that safe_connect thing, couldn't all of the same arguments be made for all other services nova talks to if we're worried about network drops? so that would be at least: keystone, glance, cinder, neutron, *barbican
16:22:06 mriedem i think the ironic driver already has it's own retry wrapper
16:22:24 cdent yes?
16:23:09 cdent we assume a lot that's can to be less easy to assume in this like edge and other blech like that
16:23:15 cdent s/can/going/
16:23:32 mriedem oh i'm sure
16:23:54 mriedem ksa already has retry stuff in it too right?
16:23:57 mordred yup
16:24:01 melwitt
16:24:16 mordred and in sdk we have a structure for expressing per-service error codes that are safe to do automatic retries on
16:24:39 cdent this whole day has been a slow setup to allow mordred to do an sdk advertisement
16:24:46 mordred cdent: isn't htat what most days are?
16:24:51 mriedem we just need to rip and replace all nova's internal client things with the sdk, done!
16:25:09 mordred coming soon to a gerrit near you!
16:26:03 mordred (honestly, I've got one more patch i need to write sdk-side, then I want to make y'all a couple of sake-of-argument patches so we can look at what it might be like and whether it's worth working on in earnest)
16:27:12 mriedem working on what? sdk in nova?
16:27:31 mriedem back in the first YVR summit i think dean said the service projects shouldn't use the sdk, but that was a long time ago
16:27:50 mriedem i think for perf reasons
16:27:56 mriedem but it seems kinda dumb not to
16:29:06 leakypipes gibi, mriedem: anyone got the link to gibi's patch series that removes the doubled-up allocation cruft for legacy evacuate code paths?
16:29:14 leakypipes can't find it atm
16:30:12 mriedem https://review.openstack.org/#/c/512623/ ?
16:30:42 mriedem otherwise idk what that is
16:30:51 openstackgerrit Merged openstack/nova master: Bump os-brick version to 2.6.1 https://review.openstack.org/611109
16:31:03 openstackgerrit Merged openstack/nova master: Add API ref guideline for examples https://review.openstack.org/604060
16:31:16 melwitt mriedem: s-1 release review is here. sorry I forgot to do it yesterday https://review.openstack.org/613636
16:34:10 mriedem done
16:34:50 melwitt thx
16:41:37 melwitt mnaser: do you ever use beta releases of nova? as of http://lists.openstack.org/pipermail/openstack-dev/2018-September/135088.html beta releases are optional and I wasn't sure if operators use them or not
16:42:56 melwitt I proposed a s-1 release out of habit and release folk asked if anyone needed it and to consider not doing a beta release. so just trying to find out if operators we know use them
16:49:23 mnaser I haven’t ever really played with them. Only RCs
16:49:50 melwitt ok, thanks
17:01:06 openstackgerrit Stephen Finucane proposed openstack/nova master: tox: Stop build *all* docs in 'docs' https://review.openstack.org/613645
17:01:28 finucannot fried_rolls: You'd probably appreciate that ^
17:02:41 openstackgerrit Stephen Finucane proposed openstack/nova master: Fail to live migration if instance has a NUMA topology https://review.openstack.org/611088
17:28:45 bexigastack hello all
17:28:59 bexigastack i have a quick question that someone here could possibly answer quickly
17:29:35 bexigastack i've got cinder handling nfs mounts served from a netapp in c-mode
17:29:45 bexigastack everything is working as expected
17:30:15 bexigastack i am having an issue when launching an instance on a compute node where that nfs share is already mounted
17:30:39 bexigastack nova attempts to mount it before launching a second instance but is hit with:
17:31:13 bexigastack Command: mount -t nfs nfsserver.dns.name:/OPENSTACK_MOUNT/OPENSTACK_CLOUD_1 /var/lib/nova/mnt/787b0fb4b865db5b3b3c9d305128af32
17:31:31 bexigastack Exit code: 32
17:31:35 bexigastack Stdout: u''
17:31:39 bexigastack Stderr: u'mount.nfs: /var/lib/nova/mnt/787b0fb4b865db5b3b3c9d305128af32 is busy or already mounted\n'
17:32:11 bexigastack oh woops - i think i am in the wrong channel - this is used for development
17:32:18 bexigastack appologies - i will use #openstack
18:31:30 openstackgerrit Merged openstack/nova master: Reject forced move with nested source allocation https://review.openstack.org/605785
18:31:38 openstackgerrit Merged openstack/nova master: api-ref: Remove unnecessary minimum microversion https://review.openstack.org/613226
18:31:46 openstackgerrit Merged openstack/nova master: Add a hacking rule for deprecated assertion methods https://review.openstack.org/613184
18:52:43 melwitt SteelyDan, leakypipes: are either of you willing to please review this nova-status upgrade check that warns if the deployment is using consoles to set the [workarounds]enable_consoleauth = True config option if performing a live/rolling upgrade? https://review.openstack.org/611214 we need to backport it to stable/rocky and were hoping to include it in stable/rocky release as soon as we can
18:54:39 melwitt mnaser: would you like to have a look at the reno update for the nova-consoleauth thing? https://review.openstack.org/613174

Earlier   Later