| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-10-24 | |||
| 14:20:44 | openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.openstack.org/552924 | |
| 14:20:57 | mdbooth | Just because it's simple and an obvious improvement | |
| 14:21:13 | sean-k-mooney | mdbooth: ok ill add a flag instead of catching the exception | |
| 14:21:15 | mdbooth | Then we can consider the finer points of wsgi, and whether a refactor is worth it later | |
| 14:21:50 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consider allocations invovling child providers during allocation cleanup https://review.openstack.org/606050 | |
| 14:23:45 | dansmith | jaypipes: could you look at this for me? It's been a while since I wrote it and my context is fading, so I'd like to get it reviewed: https://review.openstack.org/#/c/611665 | |
| 14:25:59 | cdent | sean-k-mooney, mdbooth looks like zzzeek just did : https://review.openstack.org/#/c/613040/ | |
| 14:26:39 | sean-k-mooney | cdent: that is in oslo db. | |
| 14:26:55 | sean-k-mooney | the intent was to add the flag to the callee code not the lib code | |
| 14:27:18 | cdent | this allows the callee to check for already started before configuring | |
| 14:27:19 | sean-k-mooney | that said i can use that but then its not backportable easilly | |
| 14:27:30 | cdent | right, I'm not suggesting you use it _now_ | |
| 14:27:36 | cdent | just that it is available in the future | |
| 14:28:02 | cdent | and the change of exception is handy | |
| 14:31:06 | sean-k-mooney | acttuly i can use hasattter to see if it exits so i can contionally use it. ill submit a patch soon | |
| 14:31:29 | sean-k-mooney | cdent: enjoy your non compute thing :) | |
| 14:38:45 | jaypipes | dansmith: done | |
| 14:39:36 | dansmith | jaypipes: ah thanks, will fix those typos | |
| 14:42:47 | openstackgerrit | Dan Smith proposed openstack/nova master: Make CellDatabases fixture reentrant https://review.openstack.org/611665 | |
| 14:42:48 | openstackgerrit | Dan Smith proposed openstack/nova master: Minimal construct plumbing for nova list when a cell is down https://review.openstack.org/567785 | |
| 14:42:48 | openstackgerrit | Dan Smith proposed openstack/nova master: Modify get_by_cell_and_project() to get_not_deleted_by_cell_and_projects() https://review.openstack.org/607663 | |
| 14:42:49 | openstackgerrit | Dan Smith proposed openstack/nova master: Return a minimal construct for nova show when a cell is down https://review.openstack.org/591658 | |
| 14:42:49 | openstackgerrit | Dan Smith proposed openstack/nova master: Refactor scatter-gather utility to return exception objects https://review.openstack.org/607934 | |
| 14:42:50 | openstackgerrit | Dan Smith proposed openstack/nova master: Return a minimal construct for nova service-list when a cell is down https://review.openstack.org/584829 | |
| 14:42:57 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient stable/rocky: Fix up userdata argument to rebuild. https://review.openstack.org/613057 | |
| 14:46:16 | openstackgerrit | Matthew Booth proposed openstack/nova master: Allow placement_context_manager to be replaced on reconfiguration https://review.openstack.org/613058 | |
| 14:46:22 | mdbooth | sean-k-mooney: ^^^ | |
| 14:46:50 | mdbooth | sean-k-mooney: Not quite as clean as I'd hoped because python syntax doesn't allow @db_api.placement_context_manager().writer | |
| 14:48:31 | efried | mdbooth: Not having looked at the patch at all, why do you need () ? | |
| 14:48:52 | efried | oh, I think I get it. | |
| 14:49:48 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Deprecate the unused instance-name https://review.openstack.org/602520 | |
| 14:50:59 | bauzas | efried: the placement modeling for https://review.openstack.org/#/c/602474/2/specs/stein/approved/vgpu-stein.rst@103 is already made by the reshaper change https://review.openstack.org/#/c/599208/ | |
| 14:51:27 | efried | bauzas: I thought that might be the case. | |
| 14:51:40 | bauzas | melwitt: once you're up, not sure I understand your concern about upgrade on https://review.openstack.org/#/c/602474 since I already commented this in the upgrade section | |
| 14:51:57 | sean-k-mooney | mdbooth: i was assuming you would have made it @db_api.writer but ya ill take a look when my browser stops crashing form the giat log i tried to open | |
| 14:52:01 | efried | bauzas: Is that described in the reshaper spec? | |
| 14:52:01 | bauzas | efried: I just wanted to keep minimalistic changes to the alrady approved spec | |
| 14:52:12 | bauzas | efried: no, that's direct code | |
| 14:52:17 | efried | bauzas: I think I'm trying to say it should be described in *some* spec *somewhere*. | |
| 14:52:36 | bauzas | efried: I could amend https://specs.openstack.org/openstack/nova-specs/specs/queens/implemented/add-support-for-vgpu.html if you wish | |
| 14:52:41 | efried | I don't disagree we should minimize changes to a spec reapproval in theory, but this seems like something worth including. | |
| 14:52:49 | efried | bauzas: That would be okay too. | |
| 14:53:10 | bauzas | what I reallly want is possible quick approval | |
| 14:53:18 | efried | bauzas: swhy I didn't downvote :) | |
| 14:53:24 | sean-k-mooney | mdbooth: that will still not rebind the context on reconfigurtion | |
| 14:53:27 | bauzas | and then, if left comments, a possible follow-up | |
| 14:53:31 | efried | sure | |
| 14:54:10 | bauzas | efried: or I could amend https://review.openstack.org/#/c/602474 in a follow-up if you prefer | |
| 14:56:27 | sean-k-mooney | mdbooth: you will need to do somehtin like this https://stackoverflow.com/a/33507308 | |
| 14:56:55 | efried | bauzas: There was some question (discussion with mriedem) as to whether these vgpu reshaper patches should be associated with the reshaper bp or the vgpu bp. I'm starting to think it's more appropriate to do the latter. The reshaper bp enables the work, but we're not going to go back and tag every future reshape impl against that same bp. | |
| 14:57:27 | bauzas | honestly, it's just a gerrit tag | |
| 14:57:31 | bauzas | so I don't really care | |
| 14:57:34 | efried | That being the case, IMO the text in question ought to go into https://review.openstack.org/#/c/602474 (the vgpu spec). | |
| 14:57:35 | bauzas | provided I have reviews :) | |
| 14:57:41 | mdbooth | sean-k-mooney: Ah, you're right | |
| 14:58:03 | bauzas | efried: fair, I'll write a follow-up | |
| 14:58:08 | efried | It's more than a gerrit tag. It feeds into being able to claim completion of a blueprint, etc. | |
| 14:58:24 | bauzas | I understand this but meh | |
| 14:58:52 | bauzas | either way, looks like it's a priority | |
| 14:59:12 | sean-k-mooney | mdbooth: ill submit the version with the flag for review. ill see if i can create a simple decorator after once the simple fix is up | |
| 14:59:31 | efried | bauzas: I'm not a spec core, so I can't approve it either way. | |
| 14:59:35 | mdbooth | sean-k-mooney: In lighter news, putting an emoji in a gerrit comment causes a 500 :) | |
| 15:00:14 | bauzas | efried: I know, but your comments are still valid | |
| 15:00:21 | jaypipes | melwitt, dansmith: do we actually support quota classes other than "default"? | |
| 15:00:33 | sean-k-mooney | hehe im not sure if that is a feature or a bug | |
| 15:00:39 | dansmith | jaypipes: I think no | |
| 15:08:01 | melwitt | jaypipes: we don't have anything in tree that uses anything other than "default" but if we were to wire it up, it would work. we've thrown around ideas of using them for things like preemptible instances but nothing has materialized yet. and alex_xu's "quota by resource class" proposed to leverage them if you've seen that spec | |
| 15:09:12 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consider allocations invovling child providers during allocation cleanup https://review.openstack.org/606050 | |
| 15:11:01 | jaypipes | melwitt: well, the quota by resource class is different. quota *classes* are more templates of default limit values for the set of re | |
| 15:11:05 | jaypipes | gistered resource types. | |
| 15:11:22 | jaypipes | and highly coupled to RAX's turnstile middleware... | |
| 15:11:31 | mdbooth | sean-k-mooney: Actually I'm just going to abandon that patch. It's dumb and nothing like it can work. | |
| 15:12:15 | melwitt | jaypipes: I know, but if you read the spec, we could use them to set limits for resource classes in nova. but I don't think that's gonna happen because people would rather wait until we move to keystone limits and oslo.limit | |
| 15:12:18 | mdbooth | sean-k-mooney: At least sed's feelings won't be hurt. | |
| 15:12:47 | jaypipes | melwitt: ack | |
| 15:13:35 | bauzas | dansmith: based on the numerous feedback, could you please review https://review.openstack.org/#/c/602474/ ? I'll provide a follow-up on some efried's details | |
| 15:13:44 | bauzas | it's a re-approval | |
| 15:14:38 | sean-k-mooney | mdbooth: well https://stackoverflow.com/a/33507308 will work because i wrote it specically for doing this kind of thing but ya lets just stick with the simple fix until it breaks | |
| 15:16:07 | openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.openstack.org/552924 | |
| 15:16:20 | bauzas | efried: just fixed the typo you mentioned ^ | |
| 15:16:30 | bauzas | thanks for the review | |
| 15:16:40 | efried | bauzas: But just one of them :) | |
| 15:17:09 | dansmith | bauzas: I'll add it to the queue | |
| 15:17:15 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add restrictions on updated_at when getting migrations https://review.openstack.org/607798 | |
| 15:17:16 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Document restrictions on changes-since/before when listing servers https://review.openstack.org/613070 | |
| 15:17:16 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add restrictions on updated_at when getting instance action records https://review.openstack.org/607801 | |
| 15:17:16 | mdbooth | sean-k-mooney: However, I think I didn't demonstrate that mechanically updating all uses of placement_context_manager() is pretty easy. | |
| 15:17:27 | mdbooth | s/didn't/did/ | |
| 15:17:33 | mdbooth | That was a weird typo | |
| 15:20:07 | sean-k-mooney | mdbooth: ya i suspected that woudl be easy to do but getting the new decorator correct is the tricky bit. anyway the more i talk about the less time i spend doing it ill have the patch up in a ffew minutes | |
| 15:25:09 | bauzas | dansmith: heh, np | |
| 15:50:48 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Reject forced move with nested source allocation https://review.openstack.org/605785 | |
| 15:50:48 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consider allocations invovling child providers during allocation cleanup https://review.openstack.org/606050 | |
| 15:50:49 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Handle allocations consuming only from the child RPs https://review.openstack.org/608298 | |
| 15:50:49 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Run negative server moving tests with nested RPs https://review.openstack.org/604125 | |
| 15:51:34 | gibi | mriedem, efried, jaypipes: I have fixed up the use-nested-allocation-candidates series ^^ | |
| 15:53:00 | efried | gibi: Cool, I'm sure it's perfect now. | |
| 15:53:11 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient stable/rocky: Follow up "Fix up userdata argument to rebuild" https://review.openstack.org/613086 | |
| 15:53:33 | gibi | efried: :) | |
| 15:56:13 | jaypipes | gibi: thx gibi | |