Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-10-08
17:11:18 sean-k-mooney im just going to comment out the exception in the else block for now and add a todo/log then once i have migration back and fort working reliable with a singel vm ill add the claim logic and xml update code
17:11:24 moshele we should sub set of this just for pci
17:12:29 sean-k-mooney cool thanks yes what i really just wanted to grab out of that was how it was calling the resouce tracker to do the claim fo the devices as i was going to do it simlarly
17:13:13 sean-k-mooney anyway im going to go grab dinner but just wanted to checkin with you on the migration work.
17:15:01 moshele sean-k-mooney: let do a meeting about this thursday when adrianc will be back to sync on everything
18:06:08 mriedem guh, instance.launched_on, why
18:14:17 mriedem dansmith: true story, resize_claim doesn't handle volume-backed instance disk usage reporting properly yet...
18:20:21 mdbooth mriedem: Do we have an etherpad for BFV gaps?
18:20:33 mriedem not that i know of
18:21:22 openstack Launchpad bug 1796737 in OpenStack Compute (nova) "resize: hypervisor local_gb_used still reports usage even with volume-backed instances after fix for bug 1469179" [Undecided,New]
18:21:22 mriedem https://bugs.launchpad.net/nova/+bug/1796737
18:21:43 mriedem i only hit this b/c of some functional tests in my cross-cell resize bafoonery
18:22:21 mdbooth You going to see how deep the rabbit hole goes?
18:22:25 mdbooth Or move on...
18:22:41 mriedem it's a relatively easy fix,
18:22:57 mriedem but i'll be commenting this out in my cross-cell resize test until fixed
18:24:16 openstack bug 1469179 in OpenStack Compute (nova) "instance.root_gb should be 0 for volume-backed instances" [Medium,Fix released] https://launchpad.net/bugs/1469179 - Assigned to Dan Smith (danms)
18:24:16 melwitt I wonder if the old func test from my NAKed bug 1469179 interim fix would be helpful. it did things like verify local_gb not reported after resize, shelve etc
18:25:09 mriedem it's a very easy recreate
18:25:14 mriedem resize a volume-backed instance and check disk usage
18:25:18 mriedem in the hypervisors API
18:25:28 melwitt I know, I'm saying I wrote a func test back then that does all of that
18:25:59 melwitt it was this one https://review.openstack.org/#/c/428505/19/nova/tests/functional/test_boot_from_volume.py
18:27:37 melwitt it does resize, shelve, unshelve, rebuild
18:30:59 mriedem does it julienne cut?
18:32:54 melwitt well, I thought it might help if you're finding gaps with local_gb not being handled correctly after server actions. those were the other ones I tested
18:33:37 mdbooth_bus The shelve-o-matic
18:33:43 mriedem yeah, i know, thanks. :) i'm just joking about julienne cuts.
18:33:51 melwitt at the time that I was trying to fix the bug with the patch that's now part of starlingX
18:37:34 mriedem yeah i can restore that test locally and see what fails still with context on this resize_claim bug
19:01:48 mdbooth_bus b
19:02:15 mdbooth_bus mriedem: Do you happen to remember where the local ephemeral root bdm is defined?
19:02:42 mdbooth_bus I'm trying to re-grok the bdm code in compute api, and I'm running out of mental cache
19:02:58 mdbooth_bus Also, it's really late and I'm on a bus
19:03:49 mdbooth_bus There's a comment which suggests that the client does it, but I couldn't find it there, either
19:04:45 mriedem yeah the api creates a thing, sec
19:09:31 mriedem nova.block_device.create_image_bdm creates it,
19:09:40 mriedem called from nova.block_device.from_legacy_mapping,
19:09:44 mdbooth_bus mriedem: Thanks
19:09:58 mriedem called from the api
19:09:59 mriedem at some point
19:10:06 mriedem totally not obvious
19:10:51 mdbooth_bus Wow, I'd already found and dismissed the from_legacy_mapping call
19:11:00 mdbooth_bus Yeah, that's not obvious, thanks
19:11:31 mriedem right b/c even if you use bdm_v2 you end up down that legacy path which is confusin
19:11:39 mriedem since legacy should mean bdm v1
19:12:21 mriedem legacy_image_defined = not image_properties.get('bdm_v2', False)
19:12:33 mriedem ^ is the source of the confusion
19:12:39 mriedem in _get_image_defined_bdms
19:12:44 openstackgerrit Merged openstack/nova master: VMware: Live migration of instances https://review.openstack.org/270116
19:13:05 mdbooth_bus 'legacy' there presumably meant you specified --image <imageid> rather than --blockdevice ...image-fu...
19:13:26 mriedem maybe
19:13:54 mdbooth_bus Anyway, that's saved me a bunch of bleary-eyed staring at code, thanks
19:14:21 mriedem mayhap i should throw some comments in that code
19:16:35 mdbooth_bus Oh, I think I'm about to arrive after that. Night...
19:23:09 melwitt I marked that bp as complete ^ after removing it from the runway
19:37:01 mriedem we can remove nova-cyborg-interaction from the runways queue right?
19:37:44 melwitt yeah, I wasn't sure if we should leave the note on it for whoever put it there, so they know why it's not going to be added to a runway
19:37:57 mriedem i'm assuming sundar added it
19:38:14 mriedem i would probably just remove it
19:39:08 melwitt ok
19:40:24 efried I suspect Sundar wanted us to review the spec.
19:40:45 efried we should have separate "spec runways".
19:40:52 efried for specs that would otherwise get ignored
20:09:39 sean-k-mooney efried: should or could. they could just go into the stuck review or open discustion section
20:09:44 sean-k-mooney of the nova meeting
20:09:53 efried I was being (mostly) facetious
20:09:55 sean-k-mooney that said i do need to go review it again
20:36:43 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Cross-cell resize https://review.openstack.org/603930
21:05:59 mriedem melwitt: ^
21:05:59 openstack bug 1796737 in OpenStack Compute (nova) rocky "resize: hypervisor local_gb_used still reports usage even with volume-backed instances after fix for bug 1469179" [Medium,Triaged] https://launchpad.net/bugs/1796737
21:05:59 openstackgerrit Matt Riedemann proposed openstack/nova master: Add regression test for bug 1796737 https://review.openstack.org/608771
21:17:10 melwitt coolness. will take a look
21:37:57 openstackgerrit Matt Riedemann proposed openstack/nova master: Properly track local root disk usage during moves https://review.openstack.org/608777
21:47:03 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove ServersTestBase.setUp() https://review.openstack.org/608780
22:08:46 openstackgerrit Matt Riedemann proposed openstack/nova master: Make ResourceTracker.tracked_instances a set https://review.openstack.org/608781
22:21:56 openstackgerrit Matt Riedemann proposed openstack/nova master: Make ResourceTracker.tracked_instances a set https://review.openstack.org/608781
23:01:08 alex_xu jaypipes: thanks, no futher answer, that is my expect answer, will recheck the spec again today.
23:01:20 alex_xu s/futher answer/futher question/
23:12:53 openstackgerrit sean mooney proposed openstack/nova master: [DNM] stub out sriov live migration https://review.openstack.org/608788
23:42:14 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3) https://review.openstack.org/574104
23:42:37 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4) https://review.openstack.org/574106
23:42:48 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5) https://review.openstack.org/574110
23:43:08 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (6) https://review.openstack.org/574113
23:43:27 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (7) https://review.openstack.org/574974
#openstack-nova - 2018-10-09
00:07:01 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (8) https://review.openstack.org/575311
00:07:14 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (9) https://review.openstack.org/575581
00:07:37 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (10) https://review.openstack.org/576017
00:18:32 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (11) https://review.openstack.org/576018
00:18:43 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (12) https://review.openstack.org/576019
00:32:22 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (13) https://review.openstack.org/576020
00:38:36 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (14) https://review.openstack.org/576027
00:38:50 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (15) https://review.openstack.org/576031
00:41:35 openstackgerrit liuming proposed openstack/nova master: Deletes evacuated instance files when source host is ok https://review.openstack.org/605987
00:44:12 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Remove a description in servers-actions.inc https://review.openstack.org/608796
00:49:11 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (16) https://review.openstack.org/576299
00:49:32 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (17) https://review.openstack.org/576344
00:57:52 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673
01:12:55 openstackgerrit Merged openstack/nova master: Fix nits in choices documentation https://review.openstack.org/608310
01:14:44 naichuans bauzas: Thanks.

Earlier   Later