| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-10-02 | |||
| 13:37:31 | mdbooth | It's a bug in my patch to fix the bug. | |
| 13:37:57 | efried | I think I understand now. I'll stop bugging you and let you fix the bug in the fix. | |
| 13:38:02 | mdbooth | efried: ;) | |
| 13:38:50 | mdbooth | efried: I only highlighted it originally, because I being super-alert to the possibility of having to revert my other patch. | |
| 13:38:55 | efried | but if I remember, I'll try to get several successful rechecks before approving. | |
| 13:39:23 | mdbooth | efried: That will take weeks at the moment ;) | |
| 13:39:34 | mdbooth | But sure | |
| 13:39:45 | efried | okay, "successful" meaning that specific test passes. | |
| 13:40:01 | efried | the runs are only taking a couple of hours. | |
| 13:54:40 | sean-k-mooney | melwitt mriedem so i finally got time to start working on sriov livemigration and i can confirm that we "broke" macvtap based sriov live migration in rocky when we added the multiple port binding. | |
| 13:55:27 | sean-k-mooney | melwitt: mriedem im not sure why yet but i think its due to how we create the dest binding so this might be a neutron error or nova error depending on the intended behavior | |
| 14:00:32 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: support claim_resources https://review.openstack.org/583667 | |
| 14:02:38 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: support claim_resources https://review.openstack.org/583667 | |
| 14:05:58 | mriedem | sean-k-mooney: super | |
| 14:07:13 | sean-k-mooney | mriedem: i think we need to set the vnic-type when creating the binding but i also was under the impression that neutorn was ment to copy that info form the source binding if not set so not sure its our bug. | |
| 14:08:39 | sean-k-mooney | mriedem: ill file a bug but it should hopefully be a trival backport. that said "sriov migration" even when it works is not reallly supprot yet | |
| 14:09:16 | sean-k-mooney | im hoping to work on that this cycle but we will see how thing go. | |
| 14:44:04 | jaypipes | sean-k-mooney: let's get down to brass tacks on https://review.openstack.org/#/c/603805/2/specs/stein/approved/device-discovery-policy-lib.rst. What is the likelihood that this will proceed? I have a number of concerns about the proposed implementation, but I don't really want to spend a bunch of time on reviewing it if you're not going to have time to pursue this and nobody else is either. | |
| 14:45:34 | efried | jaypipes: I will pursue it to whatever extent sean-k-mooney doesn't have time. Depending which approach you (and/or others) prefer, I will pursue as appropriate. | |
| 14:46:01 | jaypipes | efried: I thought you were more into pursuing Konstantinos' spec? | |
| 14:46:22 | efried | jaypipes: They're both shooting at the same target. | |
| 14:46:57 | efried | jaypipes: I like my baby better, possibly mostly because it's my baby (though I do have some logical reasons), but it's not a big gap. | |
| 14:47:42 | efried | jaypipes: So whichever approach (the spirit, not the specifics yet - as I said, neither is perfectly ready for primetime yet) you and/or others prefer, I'm going to run with. | |
| 14:48:00 | efried | But I want to run with one of them asap. | |
| 14:49:16 | efried | fwiw, I already have code written for the schema in kosamara's spec. It's in nova-powervm atm, but trivial to port. | |
| 14:50:32 | jaypipes | efried: I only have time this morning to review one of those specs. I will review kosamara's then. | |
| 14:51:19 | efried | jaypipes: ack, thanks. | |
| 14:51:54 | efried | note that a number of issues have been mentioned and acked, but not yet revised for, in previous patch sets. | |
| 14:53:11 | sean-k-mooney | jaypipes: well that depend i would really like to pursue this but my primary focus this release will be fixing more live migration stuff specificaly for sriov | |
| 14:54:06 | sean-k-mooney | jaypipes: spend time reviewing kosamara's proposal. | |
| 15:04:17 | openstackgerrit | Matthew Booth proposed openstack/nova master: Fix a race evacuating instances in an anti-affinity group https://review.openstack.org/605436 | |
| 15:11:38 | stephenfin | johnthetubaguy: When you're about, fancy taking another look at https://review.openstack.org/#/c/456572 | |
| 15:13:56 | sean-k-mooney | mriedem: so yes i just confirmed we need to pass the vnic type to the binding api but i also found another neutron bug | |
| 15:14:12 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Enable nested allocation candidates in scheduler https://review.openstack.org/585672 | |
| 15:14:31 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Use provider tree in virt FakeDriver https://review.openstack.org/604083 | |
| 15:15:10 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Refactor allocation checking in functional tests https://review.openstack.org/607287 | |
| 15:15:27 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Run ServerMovingTests with nested resources https://review.openstack.org/604084 | |
| 15:15:44 | sean-k-mooney | gibi: so while macvtap sriov livemigration i was able to cause the same neutron db confilct and fush error so it looks liek tehre is definetly a neutron portbining bug at least on master | |
| 15:19:12 | gibi | sean-k-mooney: good info | |
| 15:20:17 | sean-k-mooney | i need to do more diging to see if this is just an issue for sriov or if i get the same behavior with just ovs so ill test that later today. | |
| 15:20:52 | gibi | sean-k-mooney: good info | |
| 15:20:58 | gibi | sean-k-mooney: oops | |
| 15:21:04 | gibi | sean-k-mooney: I mean, thank you | |
| 15:22:02 | sean-k-mooney | no worries this will be a blocker for me to enable sriov livemigration anyway so i need to figure out how to fix it one way or another | |
| 15:22:07 | johnthetubaguy | stephenfin: what about uri being last in the list, leaving the mostly commonly changed ones first? Not sure I am actually that bothered by the order actually, kinda happy with whatever gets the later fixes in quickly, which is probably what you have now. | |
| 15:22:25 | jaypipes | sean-k-mooney: ack, will do. thx. | |
| 15:22:55 | stephenfin | johnthetubaguy: Sure, I can do that. I'm writing an expanded message to better explain the reasoning for why this is necessary | |
| 15:29:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Convert 'live_migration_inbound_addr' to HostAddressOpt https://review.openstack.org/456573 | |
| 15:29:39 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Gather 'live_migration_scheme', 'live_migration_inbound_addr' https://review.openstack.org/456572 | |
| 15:29:40 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Add three new '[libvirt] live_migration_*' options https://review.openstack.org/456571 | |
| 15:29:54 | stephenfin | johnthetubaguy: aaand done. Hopefully that's clearer | |
| 15:30:21 | johnthetubaguy | stephenfin: cool, thanks | |
| 15:30:45 | stephenfin | owalsh: You probably want to look at those (again) too ^ | |
| 15:30:59 | owalsh | stephenfin: ack | |
| 15:31:49 | johnthetubaguy | stephenfin: although now you have scheme first which basically says "please don't touch this config" | |
| 15:32:22 | stephenfin | johnthetubaguy: I was just about to comment on https://review.openstack.org/#/c/456572/8/nova/conf/libvirt.py@278 about that | |
| 15:32:28 | stephenfin | They're in URI order :) | |
| 15:32:54 | stephenfin | I wonder if they should all be advanced? | |
| 15:33:05 | stephenfin | *marked as advanced | |
| 15:33:31 | stephenfin | Seeing as in many (most?) cases the driver can configure this automatically for us | |
| 15:33:54 | johnthetubaguy | stephenfin: it should be marked advanced, yeah | |
| 15:34:13 | johnthetubaguy | stephenfin: I can live with URI order then :) | |
| 15:34:57 | sean-k-mooney | stephenfin: wait you are removing live_migration_uri | |
| 15:35:20 | stephenfin | sean-k-mooney: Nope, I'm closing gaps to allow us to remove it in the future | |
| 15:36:02 | sean-k-mooney | ... i guess i normally only change the user name so i could chagne to live_migration_username instead | |
| 15:36:08 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Consider nested allocations during allocation cleanup https://review.openstack.org/606050 | |
| 15:36:08 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ignore forcing of live migration for nested instance https://review.openstack.org/605785 | |
| 15:36:09 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Run negative server moving tests with nested RPs https://review.openstack.org/604125 | |
| 15:36:09 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Ignore forcing of evacuation for nested instance https://review.openstack.org/606111 | |
| 15:36:37 | stephenfin | sean-k-mooney: yeah, that's the idea | |
| 15:37:29 | sean-k-mooney | live_migration_username=root woudl be the same as live_migration_uri = qemu+ssh://root@%s/system | |
| 15:37:50 | mdbooth | efried: Incidentally, I ran that test 250 times locally without failure. | |
| 15:38:14 | efried | mdbooth: And you had been able to reproduce it some percentage of the time prior to the fix? | |
| 15:38:29 | mdbooth | Yeah, before it failed 50%, as expected. | |
| 15:38:37 | mdbooth | That's with *my* bug | |
| 15:38:41 | owalsh | stephenfin: live_migration_tunnelled isn't related, is it? | |
| 15:38:46 | mdbooth | With the original bug it failed about 1 in 10 locally | |
| 15:39:13 | efried | mdbooth: Okay, then 250 passes is good enough for me. Thanks for your work on this. That bug has been a thorn in our collective sides for a long time. | |
| 15:39:20 | openstackgerrit | Merged openstack/os-vif master: add nested DPDK VIF classes for kuryr-kubernetes https://review.openstack.org/604992 | |
| 15:39:50 | stephenfin | owalsh: If tunneling is enabled, none of that configuration is used, right? | |
| 15:40:00 | owalsh | stephenfin: commit message says the opposite | |
| 15:40:00 | mdbooth | efried: Hasn't passed check queue once yet, though :) | |
| 15:40:07 | stephenfin | whoops | |
| 15:40:11 | mdbooth | Latest revision, that is | |
| 15:40:16 | efried | mdbooth: But it's still on the first run? | |
| 15:40:22 | mdbooth | Yeah | |
| 15:40:25 | efried | :) | |
| 15:40:25 | stephenfin | That should read "disabled" | |
| 15:40:48 | mdbooth | efried: If it fails for any related reason I promise I'll shout about it :) | |
| 15:41:53 | owalsh | stephenfin: ack, makes a lot more sense then :-) | |
| 15:42:48 | sean-k-mooney | stephenfin: why are you defaulting to qemu+tcp and not qemu+ssh if the schema is not set? | |
| 15:44:03 | sean-k-mooney | libvirt is typiclaly not exosed over tcp by default | |
| 15:45:02 | stephenfin | sean-k-mooney: That was the case previously, right? (i.e. I haven't change anything) | |
| 15:45:37 | sean-k-mooney | ya just looking at the old code. it was the case yes however the code comment is inccort in the old code too | |
| 15:46:28 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Gather 'live_migration_scheme', 'live_migration_inbound_addr' https://review.openstack.org/456572 | |
| 15:46:29 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Add three new '[libvirt] live_migration_*' options https://review.openstack.org/456571 | |
| 15:46:29 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Convert 'live_migration_inbound_addr' to HostAddressOpt https://review.openstack.org/456573 | |
| 15:47:00 | stephenfin | johnthetubaguy: Sorry, fancy hitting the first of those again. Typo fix pointed out by owalsh | |
| 15:48:49 | sean-k-mooney | stephenfin: perhapes as a follow up we should have a seperate patch to change the default. or at least advise againts using tcp as that will copy the state unencrypted | |
| 15:51:12 | sean-k-mooney | stephenfin: ssh or libssh/libssh2 would be much better defaults imho | |