| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-10-01 | |||
| 16:39:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Add minimal documentation for RDP consoles https://review.openstack.org/606992 | |
| 16:39:32 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Rewrite the console doc https://review.openstack.org/606148 | |
| 16:39:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Allow 'nova-xvpvncproxy' to be called with CLI args https://review.openstack.org/606929 | |
| 16:39:33 | openstackgerrit | Stephen Finucane proposed openstack/nova master: doc: Add minimal documentation for MKS consoles https://review.openstack.org/606993 | |
| 16:44:13 | tssurya | dansmith: sorry for the wrong timing of the ping, I have to leave office now, but I will update the nova list patch asap and see if I can just catch the InstanceNotFound exception seperately for the above and the then mabe we can disuss a generic solution. | |
| 16:44:30 | tssurya | maybe* | |
| 18:24:53 | cdent | this very minor bug fix is just about ready to pass all its tests, if anyone is looking for something easy to review: https://review.openstack.org/#/c/606967/ | |
| 18:28:23 | efried | cdent: Your comments is garbledes | |
| 18:29:15 | cdent | again? | |
| 18:30:07 | efried | is there be a tests somewhere that demonstrate the bug? | |
| 18:30:07 | cdent | ah, misplaced ) | |
| 18:31:04 | cdent | the tests I changed? | |
| 18:31:27 | efried | no, I mean where were you seeing the concatenation errors you mention in the bug report? | |
| 18:31:48 | efried | the changed tests just prove that you changed the code in the way that you changed the code :) | |
| 18:32:23 | mriedem | cdent: question inlline | |
| 18:32:25 | mriedem | *inline | |
| 18:33:44 | cdent | efried: exactly, it changed from being bytes to being not bytes. the code violated the spec, I referenced the spec | |
| 18:34:49 | efried | yeah, cool, but the bug report says you actually encountered a real problem as a result of the code being wrong. Something about concatenating the str url with the unicode header under wsgi intercept? | |
| 18:36:12 | cdent | efried: in one of the iterations of https://review.openstack.org/#/c/601614/ | |
| 18:36:23 | cdent | http://logs.openstack.org/14/601614/25/check/placement-tempest-gabbi/d9a37a4/controller/logs/screen-n-api.txt.gz#_Sep_29_09_57_29_463012 | |
| 18:37:15 | mriedem | dansmith: want to this the queens version of that add host to aggregate case revert change (and the one after it): https://review.openstack.org/#/c/605266/1 | |
| 18:37:17 | cdent | efried: but mriedem raises a good question. It appears like things may be more broken than I hoped (I guess I never learn) | |
| 18:37:24 | mriedem | s/this/hit/ | |
| 18:37:44 | dansmith | mriedem: omg I so want | |
| 18:41:16 | dansmith | heh | |
| 18:41:39 | dansmith | mriedem: lee was +2 then removed.. I went to +W but then figured I must be missing something? | |
| 18:41:52 | mriedem | i think melwitt asked the same thing last week | |
| 18:42:33 | mriedem | i can only assume b/c the rocky change hadn't merged yet | |
| 18:42:58 | mriedem | you might as well re-apply that +W b/c it's in the gate | |
| 18:43:05 | dansmith | gah okay | |
| 18:43:09 | mriedem | let's use the rule of stable core backport == +2 | |
| 18:43:54 | mriedem | dansmith: in case you haven't seen my email yet, i'm trying to flush the open ocata backports so we can EM https://etherpad.openstack.org/p/nova-ocata-em | |
| 18:44:25 | dansmith | okay | |
| 18:44:33 | mriedem | if you want to do some mindless stable branch reviews on your first day back | |
| 18:44:50 | cdent | efried: sigh. you know what you were saying about "senile" last week? Those gabbits are not using wsgi intercept at all that's a live devstack. I guess I will spin one up | |
| 18:45:49 | efried | glad I could help in not at all a way I intended or even understand. | |
| 18:48:14 | cdent | efried: what it means in this case it is that it is likely the problem is present in "real" situations | |
| 18:48:20 | cdent | so now I'm going to check | |
| 18:48:24 | efried | cool | |
| 18:52:13 | cfriesen | mriedem: once you're done the ocata stuff, any chance you could look at https://review.openstack.org/#/c/605164/ ? since you triaged the bug :) | |
| 18:53:44 | mriedem | that was the old me | |
| 18:54:12 | mriedem | i also tried fixing that and couldn't recreate it in the functional test... | |
| 18:57:58 | cfriesen | so, need to reproduce for real first on master? | |
| 19:04:48 | mriedem | not necessarily | |
| 19:05:06 | mriedem | the fix is the same thing i was doing, | |
| 19:05:13 | mriedem | i just couldn't get a recreate in the functional test, | |
| 19:05:24 | mriedem | but was also doing it while at one of my kids activity things | |
| 19:05:30 | mriedem | like a champion dad | |
| 19:07:37 | cfriesen | mriedem: you were actually doing the delete/purge API calls, right? (as opposed to this patch which is doing a direct DB operation) | |
| 19:09:38 | mriedem | i deleted the marker record from the instances table but probably forgot to archive it | |
| 19:20:51 | mriedem | cfriesen: i just need to wrap up what i'm doing locally first | |
| 19:21:01 | cfriesen | mriedem: no worries | |
| 19:39:41 | openstackgerrit | Jack Ding proposed openstack/nova master: Add HPET timer support for x86 guests https://review.openstack.org/605902 | |
| 19:42:43 | openstack | Launchpad bug 1795425 in OpenStack Compute (nova) "create server api sends location header as bytestring in py3" [Undecided,In progress] - Assigned to Chris Dent (cdent) | |
| 19:42:43 | cdent | mriedem, efried : the location header issue is weirder/worse than I feared: https://bugs.launchpad.net/nova/+bug/1795425 | |
| 19:43:23 | gryf | hm. what is the status of live migration of numa nodes? I saw a really old change set started by Nikola, than a BP which trying to pick of the solution description in one place, but implementation didn't make it to Rocky | |
| 19:43:51 | openstackgerrit | Jack Ding proposed openstack/nova master: Add HPET timer support for x86 guests https://review.openstack.org/605902 | |
| 19:44:08 | mriedem | gryf: ask artom | |
| 19:44:17 | gryf | also I get the reading of etherpad from ptg, and there was an agreement for modeling numa nodes as RPs | |
| 19:44:35 | dansmith | gryf: artom would love to talk to you about it at length over a candle-lit dinner | |
| 19:44:39 | sean-k-mooney | cdent: im a little confused by that bug. what spec are you refering to that is violated pep 3333? | |
| 19:45:13 | gryf | as far as I can tell, bauzas was the one who is dealing with that modeling, right? | |
| 19:45:27 | openstackgerrit | Jack Ding proposed openstack/nova master: Correct instance port binding for rebuilds/reboots https://review.openstack.org/603844 | |
| 19:45:28 | cdent | sean-k-mooney: initially I thought the code is violating pep3333 | |
| 19:45:32 | gryf | dansmith, I'd like to skip romantic dinners ;) | |
| 19:45:51 | cdent | sean-k-mooney: so when I "the spec" I'm referring to pep3333 | |
| 19:45:55 | openstackgerrit | Jack Ding proposed openstack/nova master: Handle missing marker during online data migration https://review.openstack.org/605164 | |
| 19:45:57 | cdent | but the problem is more messy than just that | |
| 19:46:21 | melwitt | mriedem: two patches to un-deprecate nova-consoleauth start here https://review.openstack.org/605250 | |
| 19:46:40 | gryf | so, artom, you around? | |
| 19:46:50 | sean-k-mooney | cdent: so " the content of native strings must still be translatable to bytes via the Latin-1 encoding" woudl seam to be in conflict with the http spec which allow unicode in URL such as the location header | |
| 19:49:00 | mriedem | melwitt: so you plan on undeprecating in stein, and backporting that change to stable/rocky, then re-deprecating in stein? | |
| 19:49:01 | cdent | it's the source of much argument | |
| 19:49:06 | mriedem | or only re-deprecate once cells v1 is gone? | |
| 19:49:08 | melwitt | mriedem: yes | |
| 19:49:51 | cdent | sean-k-mooney: my understanding, however, was that you couldn't put unicode codepoints in headers, but you could have urls that encode unicode, which is not quite the same thing | |
| 19:50:16 | melwitt | mriedem: and I'll stack the patches that remove use of nova-consoleauth by non-cells v1 code on top of the re-deprecation patches | |
| 19:51:01 | sean-k-mooney | cdent: that definetly used to be the case but i was under the impression that restiction was relaxed in the last few years | |
| 19:51:35 | cdent | sean-k-mooney: that may be, but wsgi itself has not caught up/changed and has its own contract | |
| 19:56:13 | mriedem | melwitt: have you cherry picked those changes to stable/rocky and built the release notes to see if they are going to show up weird at all? | |
| 19:56:14 | sean-k-mooney | cdent: ok so https://www.rfc-editor.org/rfc/rfc3986.txt relaxes the constraitn but not entirely. "on-ASCII | |
| 19:56:17 | sean-k-mooney | characters must first be encoded according to UTF-8 [STD63], and then | |
| 19:56:19 | sean-k-mooney | each octet of the corresponding UTF-8 sequence must be percent- | |
| 19:56:21 | sean-k-mooney | encoded to be represented as URI characters | |
| 19:56:23 | sean-k-mooney | " | |
| 19:56:24 | mriedem | rewriting release note history makes me uneasy | |
| 19:58:24 | sean-k-mooney | cdent: so basically if you want to transport utf-8/unicode charaters in a url you must htmlencode the underlying utf-8 byte syequence rather then use the raw utf-8 charater stream | |
| 20:00:48 | cdent | sean-k-mooney: urlencode, not htmlencode, but yes, pretty much | |
| 20:00:50 | melwitt | mriedem: no -- but let me do that and verify it looks ok | |
| 20:01:52 | sean-k-mooney | cdent: sorry yes, i could not remember the normal name for the % encoding | |
| 20:02:34 | melwitt | mriedem: I guess, did you have something else in mind when you were thinking of un-deprecation? i.e. just modifying the code side and not touching the release note side? | |
| 20:04:52 | sean-k-mooney | melwitt: if its going to "remain" deprecated in stein after the modification is there any reason to un deprecate it? | |
| 20:05:47 | melwitt | sean-k-mooney: just a bad signal to folks moving to rocky. it will make them think they can stop running nova-consoleauth in rocky, but I found the code still requires it | |
| 20:08:02 | sean-k-mooney | melwitt: oh ok i was missing that context. the console auth service is technically optional so i dont neccicarly think that is a problem | |
| 20:08:15 | openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Un-deprecate the nova-consoleauth service https://review.openstack.org/607038 | |
| 20:08:15 | openstackgerrit | melanie witt proposed openstack/nova stable/rocky: Revert "Deprecate the nova-consoleauth service" https://review.openstack.org/607037 | |
| 20:09:15 | sean-k-mooney | for example i belive you can configure nova/libvirt dirver to have no console correct? | |
| 20:09:32 | melwitt | sean-k-mooney: a couple of users already tripped over it, caused confusion and wasted time | |
| 20:10:57 | sean-k-mooney | melwitt: right, then other than the possible weirdness with the release notes i guess undeprecating and deprecating in stein is proablly a better user experice. | |
| 20:11:56 | melwitt | yeah. I didn't consider the possibility of un-depcrecating it in the code only, and leaving the release notes alone. I had been thinking I should back out every mention of it | |