Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-09-28
18:23:05 mriedem it's been a latent issue since queens
18:23:28 mriedem note that nothing will be using this in CI until it's released and in upper-constraints
18:23:33 mriedem so i'm not sure how you're going to soak it in
18:23:43 mriedem well, except os-brick CI itself
18:23:48 jungleboyj mriedem: Oh, good point.
18:24:00 imacdonn yeah, I was just pondering that too
18:24:38 imacdonn I just I'd at least want to give Gorka a chance to object before a release is made
18:24:44 imacdonn I guess*
18:25:05 jungleboyj I can propose a release and tag Gorka to review.
18:25:16 imacdonn OK, that works
18:25:50 jungleboyj Lets do that.
18:25:59 openstackgerrit Matt Riedemann proposed openstack/nova stable/pike: Null out instance.availability_zone on shelve offload https://review.openstack.org/606161
19:38:17 melwitt zzzeek: hey, are you around?
19:38:25 zzzeek melwitt: heya
19:39:21 melwitt zzzeek: hey, I'm looking at how we can eliminate the warnings we're getting from our code, "OsloDBDeprecationWarning: EngineFacade is deprecated; please use oslo_db.sqlalchemy.enginefacade'"
19:39:51 melwitt I suspect they're coming from calls like this https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L137
19:40:25 zzzeek melwitt: probably
19:40:27 melwitt and I'm looking for the correct supported way in oslo.db to achieve the same thing
19:41:16 zzzeek melwitt: there might be a direct engine accessor at this point but the original idea was you wouldnt be using an "Engine" directly
19:41:48 zzzeek melwitt: looks like you can just drop the get_legacy_facade() part
19:41:49 melwitt hm, ok
19:41:53 zzzeek melwitt: there's a get_engine() now
19:42:17 melwitt zzzeek: I saw that, but it doesn't have the ability to specify use_slave, correct?
19:42:30 zzzeek melwitt: the "async reader" would be the "slave"
19:43:01 zzzeek so...allow_async.reader.get_engine() ? I guess
19:43:15 melwitt oh, I see. ok
19:43:48 melwitt I think that would do it then, thank you. looking to make an incremental progress
19:44:43 zzzeek melwitt: or maybe async_.reader.get_engine....sorry i havent looked at this in over a year
19:45:05 melwitt zzzeek: np, I can find it. just needed that hint
19:47:13 zzzeek melwitt: Ok i think "reader engine" is the slave, async or not
20:25:51 openstackgerrit Carlos Goncalves proposed openstack/os-vif master: Introduce network namespace aware plugging https://review.openstack.org/546961
20:31:17 melwitt zzzeek: ok, so the old way was context_manager.get_legacy_facade().get_engine() but when I do context_manager.get_engine() it does ValueError("mode should be WRITER or READER")'
20:31:38 zzzeek melwitt: yes, try context_manager.reader.get_engine()
20:32:22 melwitt zzzeek: ok, it's just that these get_engine methods we have were not calling out whether they were reader or writer
20:32:31 zzzeek melwitt: the reader is the "slave"
20:32:37 zzzeek you want the "slave" right
20:32:57 melwitt zzzeek: not always, only if use_slave=True was passed
20:32:59 zzzeek melwitt: if you want the non-slave hten ctx.writer.get_engine()
20:33:52 melwitt zzzeek: ok. what about this one? is this one implying that it is a writer then? https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L140
20:34:16 zzzeek that sohuld be the same as the "writer" yes
20:34:39 melwitt ok, thank you. I didn't realize that's what they were underneath
20:44:33 melwitt ah, yup I see it here now https://github.com/openstack/oslo.db/blob/dff11337f55b7a9a28d7c30658df51b7b0b443eb/oslo_db/sqlalchemy/enginefacade.py#L1290
20:46:24 openstackgerrit Merged openstack/nova stable/ocata: Cleanup the caches when deleting a resource provider https://review.openstack.org/604021
20:46:30 openstackgerrit Merged openstack/nova stable/queens: libvirt: Always escape IPv6 addresses when used in migration URI https://review.openstack.org/603737
21:14:39 openstackgerrit Merged openstack/nova master: nova-manage - fix online_data_migrations counts https://review.openstack.org/605329
21:15:24 openstackgerrit Merged openstack/nova stable/queens: cover migration cases with functional tests https://review.openstack.org/602408
22:10:29 openstackgerrit melanie witt proposed openstack/nova master: Replace usage of get_legacy_facade() with get_engine() https://review.openstack.org/606213
22:38:26 openstackgerrit melanie witt proposed openstack/nova master: Use an alternative class 'MoxStubout' https://review.openstack.org/579482
#openstack-nova - 2018-09-29
00:15:42 openstackgerrit Merged openstack/nova master: Follow up for Iba230201803ef3d33bccaaf83eb10453eea43f20 https://review.openstack.org/605653
01:26:38 openstackgerrit Merged openstack/nova master: Follow up for Ie991d4b53e9bb5e7ec26da99219178ab7695abf6 https://review.openstack.org/605658
01:51:33 openstackgerrit Merged openstack/nova stable/rocky: Revert "Make host_aggregate_map dictionary case-insensitive" https://review.openstack.org/605260
02:13:40 openstackgerrit Merged openstack/nova stable/rocky: Enforce case-sensitive hostnames in aggregate host add https://review.openstack.org/605261
03:20:24 openstackgerrit OpenStack Proposal Bot proposed openstack/nova stable/rocky: Imported Translations from Zanata https://review.openstack.org/604260
06:49:45 openstackgerrit OpenStack Proposal Bot proposed openstack/nova stable/rocky: Imported Translations from Zanata https://review.openstack.org/604260
07:54:22 openstackgerrit Merged openstack/nova stable/queens: Update RequestSpec.flavor on resize_revert https://review.openstack.org/602409
08:47:45 openstackgerrit Brin Zhang proposed openstack/nova master: Add microversion 2.67 to support ``volume_type`` https://review.openstack.org/605573
09:52:02 openstackgerrit Filippo Inzaghi proposed openstack/os-traits master: Removed older version of python added 3.5 https://review.openstack.org/606370
11:43:29 openstackgerrit Brin Zhang proposed openstack/nova master: Add compute API version for when a ``volume_type`` is requested https://review.openstack.org/605573
12:08:20 openstackgerrit Brin Zhang proposed openstack/nova master: Add microversion 2.67 to support volume_type https://review.openstack.org/606398
12:17:38 openstackgerrit Brin Zhang proposed openstack/nova master: Add compute API version for when a ``volume_type`` is requested https://review.openstack.org/605573
12:27:41 openstackgerrit Brin Zhang proposed openstack/nova master: Add microversion 2.67 to support volume_type https://review.openstack.org/606398
20:23:27 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix neutron-tempest-linuxbridge irrelevant-files https://review.openstack.org/606616
#openstack-nova - 2018-09-30
00:12:00 openstackgerrit Merged openstack/nova master: Fix stacktraces with redis caching backend https://review.openstack.org/605748
02:48:13 openstackgerrit Brin Zhang proposed openstack/nova master: Add API samples test for volume_type https://review.openstack.org/606758
02:54:53 openstackgerrit Brin Zhang proposed openstack/nova master: Add API samples test for ``volume_type`` https://review.openstack.org/606758
05:55:13 openstackgerrit Brin Zhang proposed openstack/nova master: Add microversion 2.67 to support volume_type https://review.openstack.org/606398
06:04:32 openstackgerrit Brin Zhang proposed openstack/nova master: Add API samples test for ``volume_type`` https://review.openstack.org/606758
07:54:08 openstackgerrit Brin Zhang proposed openstack/nova master: Add microversion 2.67 to support volume_type https://review.openstack.org/606398
11:48:37 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge used_limits extension response into limit view builder https://review.openstack.org/606031
12:00:59 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge used_limits extension response into limit view builder https://review.openstack.org/606031
13:38:26 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge image_size extension response into image view builder https://review.openstack.org/606845
15:25:49 openstackgerrit Matt Riedemann proposed openstack/nova master: Add hide server address tests in test_serversV21.py https://review.openstack.org/605435
20:50:04 openstackgerrit Merged openstack/nova master: Use INFO for logging no allocation candidates https://review.openstack.org/605765
23:08:06 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Update the CLI reference https://review.openstack.org/606871
#openstack-nova - 2018-10-01
00:43:49 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add API ref guideline for body text https://review.openstack.org/605628
06:24:07 openstackgerrit Brin Zhang proposed openstack/nova master: Add microversion 2.67 to support volume_type https://review.openstack.org/606398
06:45:54 openstackgerrit Sam Morrison proposed openstack/python-novaclient master: Fix up userdata argument to rebuild. https://review.openstack.org/605341
07:01:30 bauzas good morning Nova
07:50:54 openstackgerrit Christoph Manns proposed openstack/nova stable/rocky: Fix stacktraces with redis caching backend https://review.openstack.org/606895
07:52:09 openstackgerrit Christoph Manns proposed openstack/nova stable/queens: Fix stacktraces with redis caching backend https://review.openstack.org/606896
07:53:46 openstackgerrit Brin Zhang proposed openstack/nova master: Add microversion 2.67 to support volume_type https://review.openstack.org/606398
09:07:47 openstackgerrit Matthew Booth proposed openstack/nova master: Raise error on timeout in wait_for_versioned_notifications https://review.openstack.org/604859
09:08:06 openstackgerrit Matthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846
09:08:06 openstack bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9)
09:08:06 openstackgerrit Matthew Booth proposed openstack/nova master: Add regression test for bug 1550919 https://review.openstack.org/591733
09:11:58 kashyap testone nova.tests.unit.virt.libvirt.test_driver.LibvirtConnTestCase.test_next_min_qemu_version_ok
09:12:47 kashyap Err, disregard that
09:13:14 openstackgerrit Theodoros Tsioutsias proposed openstack/nova-specs master: Add PENDING vm state https://review.openstack.org/554212
09:13:47 ttsiouts johnthetubaguy: I tried to refresh the spec ^
10:03:21 sean-k-mooney o/
10:04:17 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Update the contributor guide https://review.openstack.org/606926
10:05:40 sean-k-mooney stephenfin: when you get a chance can you run your eyes over https://review.openstack.org/#/c/604992/3. looks like an easy addtion to me.
10:05:48 stephenfin ack
10:06:23 sean-k-mooney stephenfin: i think we need to port other vif types from kuyr-kubernetes too but they can be in different patches
10:35:08 sean-k-mooney ralonsoh: hi are you around today?
10:35:47 ralonsoh sean-k-mooney: very well, fighting with DVR and FIP (and SRIOV)
10:36:52 stephenfin sean-k-mooney: Also, "i prefer explcit else clauses"
10:37:00 stephenfin sean-k-mooney: Just wanted you to know you're wrong
10:37:04 stephenfin sean-k-mooney: That is all.
10:37:05 stephenfin :)

Earlier   Later