| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-09-27 | |||
| 18:50:02 | mriedem | or, let --live take a value for compat but proxy it to --host if --host isn't used | |
| 18:50:39 | mriedem | i'm not sure how you could specify --live w/o a host though if --live can take a host | |
| 18:50:41 | mriedem | gd CLIs | |
| 18:50:52 | mriedem | empty string? | |
| 18:50:58 | mriedem | pretty janky | |
| 18:51:25 | mriedem | openstack server migrate --live-but-with-no-host-seriously my_server | |
| 18:51:32 | mordred | mriedem: ++ | |
| 18:51:35 | mordred | that's totally the right answer | |
| 18:51:50 | mriedem | do i win something? | |
| 18:52:00 | mordred | you win this bucket of parts I just found | |
| 18:54:33 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add more documentation for online_data_migrations CLI https://review.openstack.org/605836 | |
| 18:54:42 | mriedem | imacdonn: efried: ^ does this make life better? | |
| 18:55:54 | imacdonn | only slightly, IMO | |
| 18:56:27 | mriedem | :( | |
| 18:57:12 | imacdonn | if those two rows don't need migration, then they couldn't be included in something named "Total Needed"......... ? | |
| 18:57:20 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: nova-manage - fix online_data_migrations counts https://review.openstack.org/605839 | |
| 18:57:45 | mriedem | like i said, total needed is a bad title, | |
| 18:57:55 | imacdonn | if "Total Needed" means "Total Rows that exist that may or may not need it", we should see a lot less zeroes | |
| 18:57:56 | mriedem | i'm not sure if renaming that to Total Found breaks any kind of compat, | |
| 18:58:07 | mriedem | Total Candidates | |
| 18:58:09 | mriedem | something like that | |
| 18:58:28 | mriedem | no one should be parsing the output of this command for column headers and such anyway | |
| 18:58:46 | efried | hah | |
| 18:58:48 | imacdonn | I suspect that the existing migration methods may already interpret it inconsistently, but I haven't analysed it to confirm | |
| 18:59:42 | efried | yeah, to me, seeing needed=2/completed=0 feels like it should be an error | |
| 19:00:01 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: nova-manage - fix online_data_migrations counts https://review.openstack.org/605840 | |
| 19:01:17 | efried | I mean, this is better than it was before, because there's at least *some* attempt to explain wtf is going on. | |
| 19:01:41 | efried | Is this dansmith's bailiwick btw? Something he would want to review? | |
| 19:05:45 | mriedem | i assume he would yes | |
| 19:06:22 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: nova-manage - fix online_data_migrations counts https://review.openstack.org/605842 | |
| 19:11:13 | mordred | mriedem, cfriesen: I just left a suggestion on the osc live migration patch about a way to make --live take an optional argument | |
| 19:12:54 | cfriesen | mordred: sweet, I think that's probably the best way to handle backwards compatibility | |
| 19:13:28 | mriedem | there are two, but i found it | |
| 19:14:25 | mriedem | i like that idea yeah | |
| 19:14:34 | mriedem | note you can't also cold migrate and specify a target host now... | |
| 19:14:53 | mriedem | so i'm not sure how that would play with this too | |
| 19:15:00 | mriedem | *can also | |
| 19:15:14 | imacdonn | I always thought that was weird .. that you can't do that (but can for live) | |
| 19:15:44 | imacdonn | (always => since icehouse days, at least) | |
| 19:16:06 | cfriesen | imacdonn: artificial OSC limitation | |
| 19:16:34 | imacdonn | hmm | |
| 19:16:34 | cfriesen | imacdonn: the compute API lets you specify a host since 2.56 | |
| 19:17:20 | cfriesen | (which is admittedly fairly new) | |
| 19:17:37 | imacdonn | right .. I was just checking ;) | |
| 19:18:16 | imacdonn | so "the struggle was real" when I last looked | |
| 19:18:28 | artom | I'm guessing splitting live and cold migration into different subcommands is no longer an option at this point, right? | |
| 19:18:37 | artom | Since they're, you know, fundamentally different operations? | |
| 19:19:20 | cfriesen | artom: to the end user, they're very similar. | |
| 19:19:36 | artom | cfriesen, you mean besides the fact that your workload goes down? | |
| 19:19:37 | artom | ;) | |
| 19:20:06 | artom | And that live migration is admin-only (by default)? | |
| 19:21:12 | cfriesen | artom: cold is too, isn't it? | |
| 19:22:02 | artom | cfriesen, doh, you're right | |
| 19:22:21 | imacdonn | to a typical sysadmin (I'm thinking private cloud), "migrate" means "VM is running on node A, and I want it to be running <somewhere else>" .. if we can do it without shutting the VM OS down, that'll make my life better | |
| 19:22:29 | artom | Wait no, I was looking at the wrong bit of api-ref | |
| 19:22:42 | imacdonn | from that perspective, they're basically the same thing | |
| 19:22:44 | artom | ... aaand no, still admin-only | |
| 19:23:41 | artom | I dunno, there's just a whole bunch of things that cold migration can do that live migration can't | |
| 19:24:20 | artom | And anyways, I was being rhetorical, we're obviously not going to limit osc migrate to cold migration and add a new osc live-migrate at this point. | |
| 19:27:27 | mriedem | cold migrate is admin only, resize is non-admin | |
| 19:27:32 | mriedem | w/ cold migrate under the covers | |
| 19:27:46 | artom | Kinky. | |
| 19:28:02 | mriedem | only on anniversaries dude | |
| 19:28:13 | mriedem | resize and cold migrate have been married awhile | |
| 19:28:59 | artom | Yeah, I'm surprised there's still anything going on under the covers. | |
| 19:29:08 | imacdonn | better than cold feet | |
| 20:07:24 | mriedem | melwitt: i think the vmware live migration change can go into a runway slot | |
| 20:07:34 | mriedem | rgerganov updated it to get ci passing, | |
| 20:07:41 | mriedem | i've done another pass, still -1 but it's closer | |
| 20:08:24 | melwitt | ok, cool. I'll add it then. missed the +1 vote from the vmware CI earlier today after I rechecked it | |
| 20:49:57 | melwitt | nova meeting in 11 minutes | |
| 20:50:06 | melwitt | 10 minutes | |
| 20:52:36 | mriedem | melwitt: want to hit this backport? https://review.openstack.org/#/c/605260/ - would be good to get those reverts in stable merged/released since they regressed blazar | |
| 20:52:50 | mriedem | the fix to replace the original is stacked on top on master but the gate is....not cooperating | |
| 20:53:53 | melwitt | can do. any idea why lee removed his vote? | |
| 20:57:36 | mriedem | no idea | |
| 20:57:38 | mriedem | classic lee | |
| 22:45:56 | cfriesen | is there an equivalent of CONF.reserved_huge_pages but for regular memory? (per numa node though) | |
| 22:46:58 | cfriesen | I can see CONF.reserved_host_memory_mb but that's not specifically 4k pages and is per compute node, not numa node. | |
| 22:47:44 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Update RequestSpec.flavor on resize_revert https://review.openstack.org/605879 | |
| 23:01:11 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Update RequestSpec.flavor on resize_revert https://review.openstack.org/605880 | |
| 23:03:36 | mriedem | stable branch core review please https://review.openstack.org/#/c/600113/ | |
| 23:08:45 | cfriesen | mriedem: what would you think of something like CONF.reserved_huge_pages but for regular memory? (ie, to reserve specific amounts of 4K memory on each host numa node) | |
| 23:10:35 | cfriesen | or can CONF.reserved_huge_pages be used for 4k pages as well even though the name implies otherwise | |
| 23:11:14 | mriedem | cfriesen: i don't think you realize that i don't know anything about that nova/virt/hardware stuff | |
| 23:11:22 | cfriesen | heh | |
| 23:11:34 | cfriesen | I'm off to go dig through code | |
| 23:11:43 | mriedem | so not reserved_host_ram or whatever we have? | |
| 23:11:48 | mriedem | that goes on the compute node? | |
| 23:12:20 | cfriesen | yeah, "reserved_host_memory_mb" is per compute node | |
| 23:12:25 | mriedem | reserved_host_memory_mb | |
| 23:12:35 | mriedem | and you want something to reserve ram per numa node? | |
| 23:13:27 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Fix instance evacuation with PCI devices https://review.openstack.org/605881 | |
| 23:13:37 | mriedem | melwitt: fyi i'm trying to flush through my stable queens and pike changes which also apply to ocata, and then gonna probably send a thing to the ML to wrassle a stable branch review sprint for next week | |
| 23:13:49 | mriedem | to flush all stable branches so we can get ocata released and tagged for EM | |
| 23:14:17 | mriedem | it took an entire week to just get stuff merged for the last round of stable releases | |
| 23:14:19 | mriedem | b/c of the gate | |
| 23:16:19 | cfriesen | mriedem: after looking at the code, I think I could use CONF.reserved_huge_pages to reserve 4K memory per numa node, even though it's not actually huge pages. now to actually try it out | |
| 23:17:28 | melwitt | mriedem: sounds good | |
| 23:20:56 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/ocata: Update nova network info when doing rebuild for evacuate operation https://review.openstack.org/605882 | |