Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-09-26
17:51:56 cfriesen mriedem: okay, new microversion it is. I'm not going to be the one writing this spec, I'm just establishing the parameters for someone else to write it up.
17:52:07 cfriesen (someone else on our side, I mean)
17:52:54 mriedem i'm also only one person
17:52:59 mriedem others might have other opinions
17:53:50 mriedem like alex_xu and gmann
17:54:27 cfriesen we can write it up assuming a new microversion and call it out in the review. easy enough to remove if not needed
17:55:18 mriedem yeah just use the alternatives sectoin
17:55:19 mriedem *section
18:07:57 openstackgerrit iain MacDonnell proposed openstack/nova master: nova-manage - fix online_data_migrations counts https://review.openstack.org/605329
18:46:56 openstackgerrit Jonte Watford proposed openstack/nova master: Add __str__ method to NUMACell related objects https://review.openstack.org/600269
18:49:24 openstackgerrit Jonte Watford proposed openstack/nova master: Add __str__ method to NUMACell related objects https://review.openstack.org/600269
19:18:28 openstackgerrit Jonte Watford proposed openstack/nova master: Add __str__ method to NUMACell related objects https://review.openstack.org/600269
19:37:51 efried imacdonn: The test will hopefully help me understand it - or at least prove to myself that you've fixed something.
19:38:48 imacdonn efried: I pasted example output of the failure case in the bug report
19:39:29 mriedem i could use a hashable ovo right about now
19:40:30 efried imacdonn: Yeah, I saw that and it helped me understand the problem, but looking at the code I couldn't see a) how the problem was happening, or b) how you fixed it. It's been a few hours now, maybe a second look will do the trick.
19:40:37 mriedem i've got a sorted list of things, but some of those things could be duplicates, and i need to filter out the duplicates, but ovos are'nt hashable as far as i can tell
19:40:50 efried mriedem: set()?
19:41:01 efried oh, you have a sorted list of OVOs.
19:41:05 mriedem right
19:41:08 efried got it
19:41:15 efried are the __eq__ able?
19:41:19 mriedem specifically, 2 of the Migration objects in the same list have the same uuid
19:41:19 imacdonn efried: heh. the problem was that each invocation of the inner method was returning a dict with counts from that run, and it was being used to update() a dict in the outer functions .. that replaced the values in the outer one, instead of adding to them
19:41:34 mriedem but their updated_at values are different and i just need to remove the older one
19:41:41 efried mriedem: So you sorted by UUID?
19:41:48 mriedem not necessarily
19:42:16 mriedem default sort keys are: sort_keys=['created_at', 'id']
19:43:16 mriedem http://paste.openstack.org/show/730960/
19:43:25 efried mriedem: You could use filter() to bastardize set() logic
19:45:19 efried but, yeah, one way or another you're not getting out of this without a loop.
19:45:27 mriedem right i've got a loop
19:45:32 mriedem but it's fugly
19:45:47 efried You could monkey-patch a __hash__ function onto the objects...
19:45:49 mriedem plus, i have to maintain the sort order of the list
19:46:43 efried this is nova.objects.Migration?
19:46:48 mriedem yeah
19:46:52 mriedem ovo actually has a ComparableVersionedObject mixin
19:47:01 mriedem we only use it in one place in nova's objects, the Selection object
19:47:41 efried but you only want to use the UUID to compare the lists?
19:54:04 mriedem i think i might have it
19:55:16 mriedem yup got it
19:55:41 mriedem ffs, you know how sometimes you come across a programming problem which seems like something you dealt with on a daily basis when you were a junior in college?
19:56:00 mriedem and now, getting paid high professional tech person salary, you feel dumb as a brick
19:56:38 efried college is way harder than real life
19:57:41 efried imacdonn: Okay, I'm there. The bug is the .update, which is patently wrong.
19:57:51 efried imacdonn: I convinced myself by solving it a different way: http://paste.openstack.org/show/730962/
19:58:00 efried which isn't better than what you've done, just different.
19:59:04 imacdonn efried: I tried to do it your way, but I got a complaint about tuples ... oh, you changed it to a list
19:59:12 efried yeah
19:59:19 efried no reason for it to be a tuple afaics
19:59:41 efried anyway, I'm approving your patch. Good catch, good fix.
19:59:56 imacdonn cool, thanks!
20:51:28 openstackgerrit Merged openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297
20:51:37 openstackgerrit Merged openstack/nova master: cells: Be explicit in docs about service restarts https://review.openstack.org/603588
20:51:47 openstackgerrit Merged openstack/nova master: api-ref: add 'migrations' param to GET /os-migrations https://review.openstack.org/605232
20:51:55 openstackgerrit Merged openstack/nova master: Ignore VirtDriverNotReady in _sync_power_states periodic task https://review.openstack.org/604376
20:58:48 openstackgerrit Matt Riedemann proposed openstack/nova stable/rocky: Ignore VirtDriverNotReady in _sync_power_states periodic task https://review.openstack.org/605533
21:27:35 imacdonn mriedem: something's troubling me about this online migrations stuff
21:27:40 imacdonn https://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L374-L386
21:28:26 imacdonn if there are more than max-count non-migratable rows, wouldn't the method return 50 found and 0 done... even though there could be some that are migratable ?
21:29:16 imacdonn is the migration method supposed to be smart enough to attempt the migratable ones first ?
21:44:10 mriedem i'm not sure what a non-migrateable record is
21:44:29 mriedem dansmith would be the best person to ask about that comment but he's out the rest of this week
21:45:42 imacdonn my interpretation was that there are some migrations that cannot always be applied to all rows .... tho it's not clear what the implications would be
22:05:34 openstackgerrit Chris Friesen proposed openstack/nova-specs master: Add support for emulated virtual TPM https://review.openstack.org/571111
22:08:34 openstackgerrit Chris Friesen proposed openstack/nova-specs master: Add support for emulated virtual TPM https://review.openstack.org/571111
23:08:07 mriedem holy god 609 things in the check queue
23:23:48 openstackgerrit melanie witt proposed openstack/nova master: Un-deprecate the nova-consoleauth service https://review.openstack.org/605255
23:23:48 openstackgerrit melanie witt proposed openstack/nova master: Revert "Deprecate the nova-consoleauth service" https://review.openstack.org/605250
23:25:32 openstackgerrit melanie witt proposed openstack/nova master: Revert "Deprecate the nova-consoleauth service" https://review.openstack.org/605250
23:25:33 openstackgerrit melanie witt proposed openstack/nova master: Un-deprecate the nova-consoleauth service https://review.openstack.org/605255
23:29:50 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Cross-cell resize https://review.openstack.org/603930
#openstack-nova - 2018-09-27
01:25:46 alex_xu gmann: sorry, I didn't back at that time yesterday, I have late meeting at yesterday lunchtime
01:27:04 gmann alex_xu: no prob.
01:28:12 gmann cfriesen: did not get completely about query on microversion need. are you saying to return 400 if image properties and flavor extra-spec if in rebuild/resize/create request ?
01:52:40 openstackgerrit zhaodan7597 proposed openstack/nova master: Unable to delete volume when a vmware instance bfv is failed. https://review.openstack.org/571112
02:03:29 cfriesen gmann: we're planning on adding extra validation for flavor extra-specs and image properties for operations that could change either or both of them. if the combination of flavour extraspecs and image properties doesn't make sense, we will return an error (400 presumably) back to the user.
02:04:19 cfriesen gmann: currently this request would be accepted but would fail later on down on the compute node, but that's an RPC cast and so the user wouldn't get an error message.
02:08:07 gmann cfriesen: ok, what all APIs? i am wondering if that is taken care by additionalProperties or not.
03:07:34 openstackgerrit Brin Zhang proposed openstack/nova master: Add support volume_type in compute api https://review.openstack.org/605573
03:16:42 openstackgerrit Brin Zhang proposed openstack/nova master: Add support volume_type in compute api https://review.openstack.org/605573
03:20:39 openstackgerrit zhaodan7597 proposed openstack/nova master: Unable to delete volume when a vmware instance bfv is failed. https://review.openstack.org/571112
03:21:50 openstackgerrit zhaodan7597 proposed openstack/nova master: Unable to delete volume when a vmware instance bfv is failed. https://review.openstack.org/571112
03:26:08 brinzhang Kevin_zheng: Take a look at this patch https://review.openstack.org/#/c/605573/2/nova/compute/api.py
03:27:40 brinzhang Kevin_zheng: VOLUME_TYPE_MIN_COMPUTE_VERSION = 52 this variable is not need, instead of it with CINDER_V3_VOLUME_TYPE_MIN_COMPUTE_VERSION = 35
03:28:31 brinzhang to check the volume type is supported in cinder min version.
03:29:33 Kevin_Zheng you should re arrange your patchsets, it now seems very hard to follow
03:33:52 Kevin_Zheng replied in your new patch
03:40:20 brinzhang Yeah, updating
04:11:32 openstackgerrit Merged openstack/nova master: Revert "Make host_aggregate_map dictionary case-insensitive" https://review.openstack.org/604898
04:12:07 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (3) https://review.openstack.org/574104
04:12:43 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (4) https://review.openstack.org/574106
04:13:01 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (5) https://review.openstack.org/574110
05:42:50 openstackgerrit fupingxie proposed openstack/nova master: Don't recreate inst_base on source when using rbd backend in resize https://review.openstack.org/605590
06:05:19 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (7) https://review.openstack.org/571992
06:05:52 openstackgerrit Takashi NATSUME proposed openstack/nova master: Remove mox in libvirt/test_driver.py (8) https://review.openstack.org/571993
06:13:18 openstackgerrit Tao Li proposed openstack/nova master: Rollback instance vm_state to original where instance claims failed https://review.openstack.org/592252
06:35:07 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: placement: Always reset conf.CONF when starting the wsgi app https://review.openstack.org/604694
06:45:31 openstackgerrit Bryan Song proposed openstack/nova master: Creation image for volume-backend instance should use volume size in image property 'min_disk' https://review.openstack.org/605596

Earlier   Later