| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-09-20 | |||
| 13:50:05 | bauzas | I'm back | |
| 13:50:12 | bauzas | PapaOurs is here | |
| 13:50:32 | mriedem | dansmith: so you got this one? | |
| 13:50:33 | bauzas | any regression I made, mmm ? | |
| 13:50:55 | tssurya | Q: placement should not even return deleted RPs right ? the list of compute_uuids coming from placement should be legit ? or its okay because the post-scheduler compute filter is supposed to check for these conditions like it doesn for enabled/disabled ? | |
| 13:51:04 | dansmith | mriedem: but the real problem is not in placement but that we keep finding the compute node in our search yeah? | |
| 13:51:11 | bauzas | tssurya: we have a filter for this | |
| 13:51:13 | mriedem | tssurya: mnaser didn't have https://review.openstack.org/#/c/563698/ | |
| 13:51:20 | mriedem | tssurya: so yes this is a side effect that shouldn't otherwise happen | |
| 13:51:33 | bauzas | we have the ComputeFilter | |
| 13:51:44 | tssurya | (I understand that beore this fix, the RPs were not deleted so it they are returned, but in current situation it should be okay right ?) | |
| 13:51:49 | tssurya | bauzas: yea that filter | |
| 13:51:49 | dansmith | mriedem: I got this one what? you want me to fix it up? | |
| 13:52:02 | mriedem | dansmith: i assumed you were asking for the bug in order to push a change | |
| 13:52:21 | mnaser | if we get a fix it'd be nice to get a dot release for nova, last queens release was end of may | |
| 13:52:25 | dansmith | no, I was just curious what the symptom was.. but I can fix it up, sure | |
| 13:52:29 | jroll | TIL papa bear is not a name for comstud | |
| 13:52:35 | dansmith | mnaser: ++ | |
| 13:52:40 | bauzas | so I think we agreed maybe in Portland that the Placement API wouldn't check whether the node is active or not | |
| 13:52:49 | mriedem | mnaser: we know - i've been watching rocky/queens/pike/ocata approved changes sit in the gate for 3 days | |
| 13:52:59 | mnaser | :( | |
| 13:53:03 | cdent | bauzas: correct | |
| 13:53:08 | mriedem | http://lists.openstack.org/pipermail/openstack-dev/2018-September/134867.html | |
| 13:53:14 | mnaser | rough times out here | |
| 13:53:18 | tssurya | ack | |
| 13:53:27 | bauzas | jroll: https://scontent-cdt1-1.xx.fbcdn.net/v/t1.15752-9/41984667_323237498424760_7346301711654322176_n.jpg?_nc_cat=0&oh=a19da45f6d7b7b799d8f831e7f3c4a05&oe=5C1954CF | |
| 13:53:34 | mriedem | bauzas: tssurya: cdent: dansmith: mnaser: in true form, we're all talking past each other | |
| 13:53:40 | mriedem | does someone want me to summarize the issue here? | |
| 13:53:57 | jroll | bauzas: add a guitar and you can come work on ironic :) | |
| 13:54:01 | dansmith | seems clear, | |
| 13:54:08 | cdent | mriedem: I think i was following along okay, was just trying to pause bauzas | |
| 13:54:09 | gibi | nova meeting stars in 6 minutes on #openstack-meeting | |
| 13:54:09 | tssurya | I have understood this to be something needed as a regression fix for the code before this patch | |
| 13:54:13 | tssurya | so its clear to me too | |
| 13:54:18 | bauzas | wait wait | |
| 13:54:22 | mriedem | so bauzas is the odd man out | |
| 13:54:25 | dansmith | we are not filtering the list of placement results against compute nodes that exist | |
| 13:54:38 | mnaser | yes, we're getting *all* including deleted ones | |
| 13:54:40 | bauzas | can someone explains me what's the problem ? | |
| 13:54:45 | tssurya | yep yep | |
| 13:54:49 | mriedem | dansmith: yes, but we were only given those uuids for deleted records because mnaser doesn't have https://review.openstack.org/#/c/563698/ | |
| 13:54:49 | dansmith | bauzas: wait for my bug fix | |
| 13:54:51 | dansmith | it'll be clear then | |
| 13:54:52 | bauzas | see my BBIAB 30 mins before :) | |
| 13:54:56 | bauzas | dansmith: ok cool | |
| 13:54:57 | dansmith | mriedem: right | |
| 13:55:01 | mriedem | which would have deleted the RP in placement when the compute service was deleted | |
| 13:55:04 | mriedem | it's just a simple side effect | |
| 13:55:33 | mnaser | bauzas: if a compute service is deleted (but still somehow in placement and has host_mappings, something which a bug has fixed not long ago), then nova ComputeNodeList.get_all_by_uuids returns that, it shouldn't | |
| 13:55:37 | dansmith | mriedem: yeah, but we could need to delete a compute node when placement is down or something, so definitely should fix this issue | |
| 13:55:39 | bauzas | jroll: meh, I do have a guitar as well at home... | |
| 13:56:02 | jroll | ++ | |
| 13:56:03 | mnaser | bauzas: and the reason was because get_all_by_uuids() doesn't use model_query so it doesn't filter against soft deleted stuff | |
| 13:56:17 | mnaser | that's what i got out of it and it makes sense enough for me :p | |
| 13:56:24 | mriedem | dansmith: sure i agree | |
| 13:56:42 | bauzas | mnaser: we don't have services in placement, just compute nodes, but okay I understand you :) | |
| 13:56:53 | mnaser | haha | |
| 13:56:53 | mnaser | i'm trying here | |
| 13:57:03 | bauzas | 3 mins dude | |
| 13:57:06 | bauzas | too early | |
| 13:57:08 | mnaser | one last thing: is someone pushing up a patch for this or is it on me? | |
| 13:57:13 | mnaser | (i dont mind) | |
| 13:57:13 | mriedem | dan is | |
| 13:57:16 | mnaser | ok cool | |
| 13:57:18 | bauzas | i think dansmith said | |
| 13:57:20 | mnaser | thanks dansmith | |
| 13:57:21 | bauzas | yeah that | |
| 13:57:29 | mriedem | *head explodes* | |
| 13:57:48 | bauzas | just throw me tomatoes now if I regressed :) | |
| 13:57:59 | dansmith | bauzas: you did regress | |
| 13:58:03 | dansmith | but I will fix | |
| 13:58:11 | efried | stephenfin: Can you please see if I used the correct arguments here? https://review.openstack.org/#/c/603993/ | |
| 13:58:28 | bauzas | dansmith: you're the hero and I'm the villain then ;) | |
| 13:58:38 | dansmith | per usual | |
| 13:58:58 | bauzas | I can snip fingers, don't tempt me | |
| 13:59:01 | bauzas | snap* | |
| 14:37:41 | openstackgerrit | Dan Smith proposed openstack/nova master: Filter deleted computes from get_all_by_uuids() https://review.openstack.org/604108 | |
| 14:45:07 | mriedem | mdbooth: did you see the evacuate integration tests are passing? | |
| 14:45:53 | mdbooth | mriedem: I didn't, but I will as soon as poss :) | |
| 14:46:39 | mriedem | not much to see - we evacuate with the down compute so it fails, and then bring libvirtd back up and evacuate and it passes | |
| 14:46:54 | mriedem | only question is if it should be horked into the live migration job which is convenient but sorta confusing | |
| 14:47:23 | mdbooth | mriedem: Ideally we'd have it in a few places: would be good to cover both shared and non-shared. | |
| 14:47:46 | mdbooth | Perfectly we'd cover 'all 4' cases, but I don't think we have all 4 in CI. | |
| 14:48:24 | mriedem | all 4 is what again? volume-backed, local disk not shared, local disk shared | |
| 14:48:26 | mriedem | what's the other? | |
| 14:48:40 | mdbooth | 2 axes are: shared instance, shared disk. | |
| 14:48:41 | mriedem | right now the patch is running on ceph local shared | |
| 14:49:11 | mriedem | the script could be updated to create a volume-backed server and evacuate again | |
| 14:49:42 | mnaser | is there a reason why running debug=True doesn't show the http requests done by placement client? | |
| 14:49:50 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: libvirt: Turn off max_unit https://review.openstack.org/604110 | |
| 14:50:02 | mnaser | rather than reconstructing the http request, it'd be nice to know what nova-scheduler is asking placement | |
| 14:50:27 | mriedem | we call placement over ksa, | |
| 14:50:41 | mriedem | so our debug=True logging is likely not carrying over to ksa | |
| 14:51:19 | mnaser | because before debug=True would show you the filters running through things | |
| 14:51:27 | mnaser | and you'd be able to debug scheduler issues | |
| 14:51:43 | mriedem | you just want to see like the GET /allocation_candidates request right? | |
| 14:51:45 | mnaser | now it just starts filtering a subset and you don't know where that came from so yeah | |
| 14:51:59 | mnaser | stuff like that, yes, so that i know why this live migration is not getting scheduled on one of the hosts | |
| 14:52:07 | mnaser | there's empty capacity but it's not adding it | |
| 14:52:21 | mnaser | probably something along the lines of placement being inconsistent | |