Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-09-14
16:20:27 bauzas hah
16:22:07 kashyap lyarwood: Okay, I can confirm from log examination that this is another racy occurence of the libvirt bug I pointed out
16:22:33 lyarwood kashyap: cool, should we work around this for now?
16:23:21 kashyap lyarwood: There is no "one" simple workaround :-( We need to make Nova consume the 'events' from libvirt / QEMU block layer
16:23:35 kashyap The problem is here. If you see this line:
16:23:36 kashyap 2018-09-13 22:57:16.517+0000: 30124: info : qemuMonitorJSONIOProcessLine:213 : QEMU_MONITOR_RECV_REPLY: mon=0x7f67a0021980 reply={"return": [{"io-status": "ok", "device": "drive-virtio-disk1", "busy": true, "len": 1073741824, "offset": 1073741824, "paused": false, "speed": 0, "ready": false, "type": "mirror"}], "id": "libvirt-143"}
16:23:42 kashyap You see "len" == "offset"
16:23:48 kashyap Which can mean, okay, swap has completed.
16:24:11 kashyap _But_: You don't have the "ready": *true* <-- That is the critical missing bit for the job to complete.
16:26:56 kashyap Anyway.
16:29:32 lyarwood kashyap: kk thanks, about to talk about your libvirt/qemu bump on L774 https://etherpad.openstack.org/p/nova-ptg-stein btw
16:30:29 kashyap lyarwood: Yeah, that's fairly mundane and boring stuff that needs to be done
16:35:05 mriedem sorrison: https://review.openstack.org/#/c/591607/
16:35:12 bauzas tetsuro: I'm confused by your branching on nested-alloc-candidates
16:36:06 bauzas tetsuro: https://review.openstack.org/#/c/585672/ seems to be the top change, but you have https://review.openstack.org/#/c/527728/ that requires a rebase on the last version of the above ?
16:36:07 tetsuro bauzas: Is that about https://review.openstack.org/#/c/585672/4?
16:36:21 bauzas yup
16:36:29 bauzas ok, you know why ?
16:36:57 bauzas I'll put my WIP on top of the last rev of 585672
16:37:07 bauzas and then we'll figure out later
16:39:16 kashyap lyarwood: I'm about to be AFK for the night; responded on the bug. Will read the Etherpad on Mon
16:49:24 tetsuro bauzas: https://review.openstack.org/#/c/527728/ and https://review.openstack.org/#/c/587350/ are tests that confirms the change in https://review.openstack.org/#/c/585672/. So the 3 patches can be squashed into one patch. But I did't do that because one of the test patch had been first written by not me but Lajos Katona before I made the nested enablement 1.30 patch, https://review.openstack.org/#/c/585672/.
16:51:35 giblet tetsuro: I work with Lajos, I don't think he would be mad about such squash
16:52:12 giblet tetsuro: but I feel having smaller, separate patches easier to review
17:03:00 tetsuro_ giblet, bauzas: Sorry for being disconnectd. Yes, separate patches are easier to review. My point was that the 2 follow up patches are tests and have no additional function.
17:03:42 giblet tetsuro_: true
17:04:15 tetsuro_ Does that answer your first question, bauzas?
17:23:14 melwitt evrardjp: are you around? loos like you bumped up your topic on the topic list?
17:23:51 evrardjp melwitt: I am coming :) johnthetubaguy has bumped it up
17:23:57 melwitt ok
17:31:45 melwitt priorities setting etherpad https://etherpad.openstack.org/p/nova-ptg-stein-priorities
17:47:21 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: hyperv: Cleans up live migration Planned VM https://review.openstack.org/602698
17:49:20 openstackgerrit Matthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846
17:49:48 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: hyperv: Cleans up live migration Planned VM https://review.openstack.org/602698
18:10:22 mdbooth mriedem: Do you mind if I hack on your evacuate job, btw?
18:12:53 mriedem mdbooth: i'm still waiting to get a clean run
18:13:29 mdbooth I was volunteering to fix things
18:14:07 mdbooth Looks like the libvirtd pid detection didn't work. Wonder if we can just assume that devstack wrote a pid file to the default location
18:14:22 mdbooth I can stick that in and retry
18:14:28 mdbooth (for eg)
18:28:26 openstackgerrit Matthew Booth proposed openstack/nova master: WIP: Add post-test hook for testing evacuate https://review.openstack.org/602174
19:47:48 bauzas tetsuro: sorry was not reading my IRC
19:48:02 tetsuro np
19:48:05 bauzas tetsuro: yeah, that's what I saw
19:48:31 bauzas tetsuro: like I said, I'll just base my change on top of the main change, not the functional tests and we'll sort that out later
19:48:46 tetsuro sounds good to me
20:19:05 bauzas giblet: tetsuro: wow, that's a big rebase I have to do, but let's do it
20:20:32 bauzas giblet: are you working on rebasing https://review.openstack.org/#/c/591811/3 or can I work on it ?
20:21:37 giblet bauzas:, tetsuro: I'm working on the consumer gen series
20:22:57 giblet bauzas, tetsuro: I have to rework the logic in the consumer gen series (no retries) then I will do the rebase
20:23:53 giblet bauzas, tetsuro: for discussion about the consumer gen support see: http://lists.openstack.org/pipermail/openstack-dev/2018-August/133373.html
20:28:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Allow ability for non admin users to use all filters on server list. https://review.openstack.org/526558
20:29:03 bauzas giblet: tbh, the rebase is trivial and I needed it for testing :)
20:29:22 bauzas giblet: but I'll rebase on your changes once they're uploaded
20:29:52 giblet bauzas: I cannot promise that the rebase will be trivial _after_ all the rework is done
20:30:06 giblet bauzas: but I'm close to finish that so we will see soon
20:31:40 bauzas :)
20:36:22 openstackgerrit Matthew Booth proposed openstack/nova master: WIP: Add post-test hook for testing evacuate https://review.openstack.org/602174
20:37:14 openstackgerrit Balazs Gibizer proposed openstack/nova master: consumer gen: support claim_resources https://review.openstack.org/583667
20:37:27 giblet bauzas: that is the last rework^^
20:37:34 giblet bauzas: now I try the rebase
20:44:57 openstackgerrit Lee Yarwood proposed openstack/nova master: WIP compute: Unreserve volumes attached to offloaded instances before detach https://review.openstack.org/602743
20:46:57 giblet bauzas: rebase introduces new unit tests that I have to adapt...
20:48:08 bauzas giblet: that's right
20:48:12 bauzas giblet: I was on it
20:48:17 bauzas the reshape ones
20:48:34 bauzas you doing that then ?
20:48:43 giblet yes, I try :)
20:51:04 giblet bauzas: I have to go to the airport
20:51:33 giblet bauzas: is it OK for you If I continue today and Monday or you want to progress and therefor would like to do the rebase ?
20:52:13 bauzas giblet: no worries, I'm just quickly testing on my own and I can test what I want meanwhile
20:52:28 giblet bauzas: cool, think I'd like to continue and I will
20:52:34 bauzas giblet: so, relax and safe travels :)
20:52:39 giblet bauzas: thanks
22:58:41 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add post-test hook for testing evacuate https://review.openstack.org/602174
23:01:03 mriedem sorrison: you owe me a coke my friend
23:01:08 mriedem https://review.openstack.org/#/c/526558/
23:01:31 mriedem sorrison: are you ok with the policy name change i made to be allow_all_filters vs use_all_filters?
23:01:34 mriedem if so, i'm +2
23:02:09 mriedem i guess you might have to alias it internally
23:03:31 mriedem maybe just needed to use mock instead of mox
23:05:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Allow ability for non admin users to use all filters on server list. https://review.openstack.org/526558
23:35:54 sorrison mriedem: Great! thanks and name change is fine with me
#openstack-nova - 2018-09-15
00:25:38 openstackgerrit Merged openstack/nova stable/pike: [Stable Only] Remove soft-deleted instances from quota_usages https://review.openstack.org/602459
00:31:53 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: Set default of oslo.privsep.daemon logging to INFO level https://review.openstack.org/602798
02:20:07 openstackgerrit Brin Zhang proposed openstack/nova master: Resource retrieving: add changes-before filter https://review.openstack.org/599276
02:21:10 openstackgerrit Matt Riedemann proposed openstack/nova stable/queens: Set default of oslo.privsep.daemon logging to INFO level https://review.openstack.org/602798
02:39:56 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Add post-test hook for testing evacuate https://review.openstack.org/602174
03:19:21 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Change the default values of XXX_allocation_ratio https://review.openstack.org/602803
03:46:41 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: [WIP] Use new ``initial_xxx_allocation_ratio`` CONF https://review.openstack.org/602804
03:46:42 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: [WIP] Remove the allocation ratios adjusting logic https://review.openstack.org/602805
05:16:18 openstackgerrit Merged openstack/nova stable/queens: Set default of oslo.privsep.daemon logging to INFO level https://review.openstack.org/602798
06:53:45 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Change the default values of XXX_allocation_ratio https://review.openstack.org/602803
07:10:08 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: [WIP] Use new ``initial_xxx_allocation_ratio`` CONF https://review.openstack.org/602804
07:32:04 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: [WIP] Use new ``initial_xxx_allocation_ratio`` CONF https://review.openstack.org/602804
08:17:46 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Use new ``initial_xxx_allocation_ratio`` CONF https://review.openstack.org/602804
09:05:36 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: [WIP] Remove the allocation ratios adjusting logic https://review.openstack.org/602805
09:16:44 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Use new ``initial_xxx_allocation_ratio`` CONF https://review.openstack.org/602804
09:17:30 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: [WIP] Remove the allocation ratios adjusting logic https://review.openstack.org/602805
10:33:18 openstackgerrit Brin Zhang proposed openstack/nova master: Resource retrieving: add changes-before filter https://review.openstack.org/599276

Earlier   Later