Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-09-13
21:08:43 efried mm
21:09:04 bauzas so I just wanted to make sure we were getting'em, including the ones that were against inventories on children
21:09:10 efried mm
21:09:21 bauzas you know, if you have teeth problem, I can help you :p
21:09:21 efried and, for that matter, sharing providers
21:09:41 bauzas in my case, for the nested RPs
21:09:54 gibi bauzas: what you will not get from placement is the mapping between granular request groups in the a_c request and the allocation that fulfills that group
21:09:54 bauzas not for shared
21:10:25 gibi bauzas: this is where the spec https://review.openstack.org/#/c/597601/ comes into picture
21:10:25 efried "not for shared" - yes, for shared too. If you had any. Which you kinda shouldn't.
21:10:26 bauzas nah, kidding
21:10:32 bauzas ok
21:11:11 bauzas gibi: ok, I'll look at the spec later in the day
21:11:39 gibi bauzas: will GPUs use granular requet groups?
21:11:39 bauzas naichuans: FWIW, I'm gonna creating a vgpu-stein BP
21:11:55 bauzas gibi: it will for NUMA affinity
21:12:18 gibi bauzas: then for NUMA you might hit the problem I describe in that spec
21:12:23 bauzas yup
21:12:50 bauzas for the simple case where VGPUs are on a child but other resources are on root RP, we're all good
21:13:05 bauzas provided I'm getting RPs that support both requesrs
21:13:22 efried gibi: Skimming the spec, I don't think it goes far enough, I'm afraid.
21:13:25 bauzas requests, ie. VGPU in one child that's necessarly on the root RP having enough resources
21:13:43 gibi efried: comments are very welcome :)
21:14:41 bauzas oh, awesome, there is already a vgpu-stein BP https://blueprints.launchpad.net/nova/+spec/vgpu-stein
21:14:49 bauzas naichuans: nevermind then my previous point
21:15:19 openstackgerrit Lee Yarwood proposed openstack/nova stable/pike: [Stable Only] Remove soft-deleted instances from quota_usages https://review.openstack.org/602459
21:18:07 efried gibi: If I wind up with more than one value in my 'contributes_to' list, I'm right back where I started not knowing which request group corresponds to which chunk of the response.
21:19:06 gibi efried: if you mean group_policy=None and two request groups end up fulfilled by the same RP then you are correct that still sucks
21:19:15 efried gibi: So
21:19:21 gibi efried: I forget about that case
21:19:30 efried The alternative you suggest at the end, breaking the allocation request up...
21:19:31 bauzas oh shit, I just realize that the next PTG will litterally be 1 week after Brexit, and I'm usually flying BA
21:19:35 bauzas that could become fun
21:19:48 efried if you do that keyed by request group instead, you're golden.
21:19:53 efried gibi: ^
21:20:14 efried Sucks to have to change the allocation request syntax, for sure, but there's no other complete solution.
21:20:52 gibi efried: good point. I will need to work on that spec
21:21:24 efried gibi: Even for a granular request you have the problem.
21:26:34 efried gibi: e.g. resources2=BW:100&resources3=BW:200&group_policy=none
21:26:50 efried today you might get back BW:300 from a single provider, which is :(
21:26:59 openstackgerrit Lee Yarwood proposed openstack/nova stable/ocata: [Stable Only] Remove soft-deleted instances from quota_usages https://review.openstack.org/570653
21:30:14 gibi efried: true
21:31:13 bauzas gibi: efried: that's the exact problem I hit for VGPU affinity, right?
21:31:30 bauzas if I want to have this NUMA node and that VGPU to be on the same tree
21:31:44 efried bauzas: It's less of a problem for VGPU, which is single unit
21:31:51 efried bauzas: Oh, no, that's a separate problem.
21:32:19 bauzas sorry, I learnt German and English at college, not Placement :p
21:53:13 openstackgerrit Sylvain Bauza proposed openstack/nova-specs master: Re-proposes multiple vGPU types in libvirt https://review.openstack.org/602474
21:53:59 bauzas oh, we're not advertising on nova-specs changes ?
21:54:22 bauzas I mean, I don't openstackgerrit telling my spec
21:55:43 openstackgerrit Sylvain Bauza proposed openstack/nova-specs master: Re-proposes multiple vGPU types in libvirt https://review.openstack.org/602474
21:56:54 bauzas mmm, strange but ok
21:58:34 openstackgerrit sean mooney proposed openstack/os-vif master: add support for generic tap device plug https://review.openstack.org/602384
21:59:06 bauzas mriedem: given what we said yesterday, shall we put a procedural -2 on https://review.openstack.org/#/c/599208/ and say we can't do it until https://review.openstack.org/#/q/topic:use-nested-allocation-candidates+(status:open+OR+status:merged) is merged ?
22:01:04 mriedem because once the vgpu is on the child provider, vgpu scheduling would be broken?
22:03:42 bauzas mriedem: yup
22:04:00 bauzas no valid hosts
22:04:15 bauzas since it wouldn't find any RP that fulfills the VGPU resource class
22:04:25 mriedem bauzas: i guess? alternatively, we should have a functional test that does the reshape and then tries to schedule to the vgpu in the child - which we said we wanted as part of the checklist for placement extraction
22:04:44 bauzas mriedem: yeah, I discussed that with gibi
22:04:55 bauzas mriedem: the functional test should see that
22:04:56 mriedem we do have functional tests for reshaper with the fake virt driver,
22:05:02 mriedem we just don't try to schedule to that host after the reshape
22:05:08 openstackgerrit Merged openstack/nova stable/rocky: Add functional test for affinity with multiple cells https://review.openstack.org/599731
22:05:17 bauzas mriedem: cool, I know what to do for next week
22:05:52 mriedem the functional test for reshaper mocks out the reshape code in the test itself; i suggested to efried that we move that to a fake virt driver - and if we did that, then i think we can just bolt the post-reshape scheduler request onto the same test
22:06:18 mriedem maybe we don't need to move that into a fake virt driver, idk
22:06:29 mriedem but would be nice if we can just add a few lines to that existing test to see if this passes or fails
22:07:24 bauzas mriedem: lemme test that
22:07:51 mriedem bauzas: https://github.com/openstack/nova/blob/0ba34a818414823eda5e693dc2127a534410b5df/nova/tests/functional/test_servers.py#L1835
22:08:16 mriedem yeah so at the end, just try to create an instance on that host with vgpu and see if it blows up
22:08:33 mriedem if it fails, we can assert it should fail until https://review.openstack.org/#/q/topic:use-nested-allocation-candidates+(status:open+OR+status:merged) fixes it
22:08:37 mriedem and rebase those on top
22:08:41 mriedem LIKE A CHAMP
22:08:53 efried mriedem: What ought to happen is: the fake libvirt driver should (by default? based on fixture setup?) call the real libvirt driver's impl of update_provider_tree, which should be modified to do reshaping for vgpus in this cycle (and maybe other things) so we can actually test those things in functional tests.
22:09:03 bauzas mriedem: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L1835 ?
22:09:10 bauzas oh shit, sorry
22:09:11 mriedem bauzas: yes just linked that above
22:09:15 mriedem gawd!
22:09:19 efried mriedem: But we should (still) absolutely not move the mocked-up update_provider_tree-of-bizarreness from that mock to the fake libvirt driver. It just doesn't make sense.
22:09:32 mriedem efried: i will cut your damn letter jacket
22:09:32 bauzas I should employ someone to read my IRC
22:09:50 mriedem efried: honestly i don't care how it's done
22:09:51 efried Just try it. Actually, the last guy who said that was also named Matt.
22:09:53 mriedem just that it's tested
22:09:54 openstackgerrit sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432
22:15:04 openstackgerrit Lee Yarwood proposed openstack/nova stable/rocky: Refix disk size during live migration with disk over-commit https://review.openstack.org/602477
22:15:12 openstackgerrit Lee Yarwood proposed openstack/nova stable/queens: Refix disk size during live migration with disk over-commit https://review.openstack.org/602478
22:21:07 jroll melwitt: https://docs.openstack.org/ironic/latest/install/configure-nova-flavors.html
22:23:42 melwitt jroll: yeah, I'm pretty sure that override will _not_ stop quota counting from considering and summing the values in the flavor
22:25:20 sean-k-mooney mriedem: o/ fixed now on irc
22:26:44 melwitt jroll: we count the 'vcpus' and 'memory_mb' columns in the 'instances' table to count as quota usage. and I don't think the extra spec overrides will affect how those columns are populated
22:26:52 melwitt and those values come from the flavor
22:30:47 mriedem sean-k-mooney: https://etherpad.openstack.org/p/nova-network-removal-rocky
22:31:01 mriedem there are still some apis to investigate there
22:31:46 sean-k-mooney mriedem: thanks i have bookmarked it ill take a look
22:34:28 openstackgerrit Jay Pipes proposed openstack/nova master: remove virt driver requires_allocation_refresh https://review.openstack.org/602481
22:39:15 jroll melwitt: awesome, thanks :)
23:17:52 openstackgerrit Chris Dent proposed openstack/nova-specs master: List resource providers having inventory https://review.openstack.org/600016
23:30:12 openstackgerrit Merged openstack/nova stable/rocky: Make scheduler.utils.setup_instance_group query all cells https://review.openstack.org/599732

Earlier   Later