| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-09-13 | |||
| 15:30:07 | bauzas | lyarwood: I made some very technical comments on the functional test | |
| 15:30:20 | bauzas | lyarwood: if you need help for a respin, lemme know | |
| 15:31:01 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Fix 500 error while passing 4-byte unicode data https://review.openstack.org/407514 | |
| 15:31:16 | edleafe | bauzas: that's a different version of shuffling, for the nested case | |
| 15:31:38 | edleafe | IOW, if a single RP has multiple allocation_candidates, just pick the first for now | |
| 15:31:56 | edleafe | The TODO is to evaluate each for "best fit" | |
| 15:35:19 | lyarwood | bauzas: thanks, I'll get to it after this session | |
| 15:35:33 | edleafe | bauzas: I don't see a problem with a random selection, but in the two-node setup described in the bug, it won't help :) | |
| 15:36:03 | bauzas | edleafe: well, it could help or not | |
| 15:36:45 | edleafe | bauzas: in a two-node setup, there is only one possible alternate :) | |
| 15:36:45 | bauzas | edleafe: but at least, we would ensure that if we have more than 1 host as alternate, we don't pick the same for all the instances :) | |
| 15:36:53 | bauzas | edleafe: yeah, sure, no disagreement on it :D | |
| 15:37:48 | edleafe | bauzas: the other thing to remember is that the list of hosts have been weighed at this point | |
| 15:37:48 | bauzas | actually, my guess is that the example we have in the bug report will fail anyway | |
| 15:38:07 | edleafe | So a random choice will ignore all weighting | |
| 15:38:14 | bauzas | ah good point | |
| 15:38:24 | bauzas | mmmm | |
| 15:38:43 | bauzas | ok, let's keep it simple then | |
| 15:39:19 | bauzas | if alternates follow the packing/spreading strategy given by the weighers, they're already shuffled | |
| 15:39:34 | bauzas | so, what lyarwood did is sufficient | |
| 15:43:30 | openstackgerrit | Eric Fried proposed openstack/os-traits master: Add OWNERSHIP_$SERVICE traits https://review.openstack.org/602160 | |
| 15:47:45 | bauzas | edleafe: wait a sec | |
| 15:48:09 | bauzas | edleafe: is https://github.com/openstack/nova/blob/master/nova/scheduler/filter_scheduler.py#L417 a weighed list ? | |
| 15:49:20 | edleafe | ARs are not weighed. The hosts they represent are | |
| 15:49:39 | bauzas | that's old greek to me :) | |
| 15:50:47 | bauzas | oh shit | |
| 15:51:05 | bauzas | I think I misunderstood the logic | |
| 15:51:28 | bauzas | we got selected hosts, we iterate over those and see whether they have an AR against each | |
| 15:51:36 | bauzas | gotcha | |
| 15:52:26 | bauzas | so, yeah, selected hosts is weighed | |
| 15:52:50 | edleafe | bauzas: this is where the alternates are created: https://github.com/openstack/nova/blob/master/nova/scheduler/filter_scheduler.py#L260, and the 'hosts' variable is defined above: https://github.com/openstack/nova/blob/master/nova/scheduler/filter_scheduler.py#L260 | |
| 15:54:24 | bauzas | yeah I got it | |
| 15:54:33 | edleafe | bauzas: oops: the second link should be https://github.com/openstack/nova/blob/master/nova/scheduler/filter_scheduler.py#L201 | |
| 15:54:49 | bauzas | https://github.com/openstack/nova/blob/master/nova/scheduler/filter_scheduler.py#L397 is the loop over hosts that are weighed | |
| 15:55:13 | bauzas | so, yeah, we basically either spread or pack that list | |
| 15:55:17 | bauzas | so, we're fine | |
| 15:55:21 | edleafe | yup | |
| 15:55:22 | bauzas | no need to shuffle any bit | |
| 15:55:41 | bauzas | if the operator chose the packing strategy, that's their decision | |
| 16:01:43 | openstackgerrit | sean mooney proposed openstack/os-vif master: add support for generic tap device plug https://review.openstack.org/602384 | |
| 16:08:58 | bauzas | edleafe: you know what ? I'm horribly confused | |
| 16:11:20 | openstackgerrit | Eric Fried proposed openstack/os-traits master: Add OWNERSHIP_$SERVICE traits https://review.openstack.org/602160 | |
| 16:11:52 | bauzas | edleafe: how many times are we calling _get_alternate_hosts() if we have multiple instances ? one AFAICS | |
| 16:13:34 | mriedem | mdbooth: i'm not sure why but my evacuate script is thinking that we only have 1 hypervisor in this job but we should have 2 https://review.openstack.org/#/c/602174/ - i'm guessing it's a bug in my script doing the word count | |
| 16:14:34 | mriedem | oh i see why | |
| 16:14:43 | mriedem | well i think | |
| 16:15:35 | mriedem | 1 | |
| 16:15:35 | mriedem | $ echo "Missing value auth-url required for auth plugin password" | wc -l | |
| 16:29:31 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: consumer gen: more tests for delete allocation cases https://review.openstack.org/591811 | |
| 16:29:32 | edleafe | bauzas: We call it once for each requested instance | |
| 16:50:43 | openstackgerrit | Merged openstack/nova master: Fix mock.patch usage in unit tests https://review.openstack.org/602198 | |
| 16:55:34 | bauzas | edleafe: I tried to summarize my thoughts in one single comment https://review.openstack.org/#/c/593074/2/nova/scheduler/filter_scheduler.py@397 | |
| 17:17:26 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Update RequestSpec.flavor on resize_revert https://review.openstack.org/602403 | |
| 17:31:03 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Noop CantStartEngineError in targets_cell if API DB not configured https://review.openstack.org/581912 | |
| 17:32:05 | melwitt | efried: can you add some notes about the whitelist plan on the etherpad? I wasn't sure which line we're talking | |
| 17:33:48 | efried | melwitt: roger that. It's here: https://review.openstack.org/#/c/591037/ Where do you want it on which etherpad? :) | |
| 17:34:27 | melwitt | efried: oh, if it's already known, that's cool | |
| 17:34:41 | efried | melwitt: Agree it would be useful to have on one or both etherpads | |
| 17:35:19 | melwitt | efried: yeah, I wanted there to be a reference for cyborg team to see how that part will be handled. I don't see a relevant section in the etherpad https://etherpad.openstack.org/p/stein-ptg.cyborg-nova-new so far | |
| 17:35:37 | efried | oh, yeah, that spec is in a topic of its own later on.... | |
| 17:35:59 | efried | melwitt: L291 of https://etherpad.openstack.org/p/nova-ptg-stein | |
| 17:36:59 | melwitt | ah thanks | |
| 17:38:23 | mriedem | actually 214 | |
| 17:38:39 | mriedem | i see what efried is trying to do | |
| 17:38:59 | mriedem | oh nvm - different topic :) | |
| 17:39:34 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: cover migration cases with functional tests https://review.openstack.org/602408 | |
| 17:39:35 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Update RequestSpec.flavor on resize_revert https://review.openstack.org/602409 | |
| 17:53:12 | lyarwood | edleafe: sorry missed your ping earlier, I'm not sure how that additional conditional would help tbh | |
| 17:55:58 | openstack | Launchpad bug 1784020 in OpenStack Compute (nova) "Shared storage providers are not supported and will break things if used" [Medium,Fix released] | |
| 17:55:58 | bauzas | mriedem: that's the bug right ? https://bugs.launchpad.net/nova/+bug/1784020 | |
| 17:56:01 | bauzas | thanks for the heads-up | |
| 17:56:08 | openstackgerrit | Merged openstack/nova master: hyperv: Cleans up live migration Planned VM https://review.openstack.org/478943 | |
| 17:56:35 | mriedem | yes | |
| 17:57:22 | edleafe | lyarwood: because the bug only is an issue when there aren't enough potential alternate hosts, right? | |
| 17:58:09 | lyarwood | edleafe: right and alternates listed are per instance | |
| 17:58:19 | lyarwood | alternates are listed* | |
| 17:59:40 | edleafe | lyarwood: so in the more common case where there are many more alternates available, we would be better off not adding hosts that may not have enoguh resources | |
| 18:00:16 | edleafe | lyarwood: only in the case where there aren't enough alternates should we include a host that is actively being built on | |
| 18:02:09 | lyarwood | edleafe: ah right, got it | |
| 18:04:41 | openstackgerrit | Eric Fried proposed openstack/os-traits master: Add OWNERSHIP_$SERVICE traits https://review.openstack.org/602160 | |
| 18:18:55 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Add post-test hook for testing evacuate https://review.openstack.org/602174 | |
| 19:56:07 | mriedem | gibi: for your bw provider demo, osc commands take a wrap option, might be good to use - you're doing this at the summit too i think | |
| 20:03:24 | openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.openstack.org/602432 | |
| 20:08:37 | stephenfin | mriedem, gibi: You can also use '-c' to show only the columns you care out and filter out the noise | |
| 20:13:52 | gibi | stephenfin, mriedem: thanks, it was a projector - laptop incompatibilty issue today about screen size. We will do better in Berlin :) | |
| 20:14:23 | mriedem | stephenfin: oh i know all about -c | |
| 20:14:31 | mriedem | and -f | |
| 20:20:57 | melwitt | our cycle highlights say live migration between neutron backends works https://github.com/openstack/releases/blob/master/deliverables/rocky/nova.yaml#L44-L46 | |
| 20:21:55 | melwitt | given that, I think filling in the gaps would be good ^ | |
| 20:38:50 | gibi | bauzas: if you want to try nested scheduling then this is the commit you need https://review.openstack.org/#/c/585672/ (our today's demo was based on it too) | |
| 20:38:58 | bauzas | gibi: awesome, ta | |
| 20:39:10 | bauzas | gibi: I first need to put my hands on some hardware | |
| 20:39:19 | openstackgerrit | Merged openstack/python-novaclient master: Follow the new PTI for document build https://review.openstack.org/602153 | |
| 20:39:21 | gibi | bauzas: please be aware that it is on an old base. I'm working on to rebase the whoel series | |
| 20:39:29 | bauzas | but that's something I'd like to do sooner than later clearly | |
| 20:39:42 | bauzas | gibi: no worries, you said it's a substantial amount of work | |
| 20:39:56 | bauzas | gibi: I guess it's worth it for me to help you if I can | |
| 20:40:15 | bauzas | gibi: the only problem is that I was a bit on and off last cycle, so I need to ramp up a little bit | |
| 20:42:39 | gibi | bauzas: as soon as I catch up with the rebase you can help a lot by reviewing the series and finding gaps we missed | |
| 20:43:02 | gibi | bauzas: until that if you have any questions about the current solution then I'm happy to help | |