Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-08-30
17:19:41 cfriesen in nova/compute/flavors.py we call "from nova.api.validation import parameter_types". This appears to be really expensive (~6 seconds in a recent test) due to the regex stuff. One possibility would be to do the import right before the flavor creation so that it doesn't impact all nova processes. Thoughts?
17:21:14 openstackgerrit Merged openstack/nova master: reshaper gabbit: Nix comments re doubled max_unit https://review.openstack.org/597220
17:35:10 openstackgerrit Merged openstack/nova master: Fix race condition in reshaper handler https://review.openstack.org/596497
17:37:31 sean-k-mooney melwitt: im just back, am would you like me to squash those two disk bus patches together?
17:38:23 sean-k-mooney melwitt: i used the functional regression style partly to prove to my self that the test case was corret since you pointed out my orginial test case worked without the patch applied
17:38:32 melwitt sean-k-mooney: not right now, maybe only if you need to respin. I don't have a strong opinion about it, just pointing it out
17:38:53 melwitt yeah, understood
17:42:52 sean-k-mooney cdent: just got back and ya MOT and NCT are basically the same.
17:43:23 sean-k-mooney cdent: happily in my case it passed the second time.
17:44:13 sean-k-mooney cdent: that said i dont drive my car enough i have only done 8000KM/5000 miles in the last two years...
17:44:17 cdent sean-k-mooney: my car is 21 years old. the emissions check is going to be an issue, I fear. Apparently the trick is to take it in to the test good and hot after racing around like a crazy person
17:45:02 sean-k-mooney cdent: if its 21 years old it shoudl qualify as a vintage car now right?
17:45:26 cdent hmm, that's a good point.
17:46:06 sean-k-mooney i cant remeber what the cut off is in ireland but there is an emaitions cut off at some point in ireland where provided you have converted from lead based fule to unleeded the co2 emmsions are basically ignored
17:46:14 openstackgerrit Merged openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648
17:47:46 cdent sean-k-mooney: it looks like it may be 40 years here :(
17:50:33 sean-k-mooney cdent: well hopfully it will keep running that long :)
17:53:00 cdent i can only try
17:53:30 cdent sean-k-mooney: in other vaguely related to sean-k-mooney news: I'm sending in my applicaiton for an irish passport today
17:54:11 sean-k-mooney oh. cutting it a little close with brexit no?
17:54:35 cdent i had to get a hold of my mother's birth certificate
17:56:09 sean-k-mooney ya i love that to get a pass port which is ment to be the most secure id you can get in the contry you need a copy of your birth cert which is the only id i have that cant even be used to by alcohol
17:56:44 cdent \o/
17:56:54 sean-k-mooney i know they use it in thery to prove that you our your parent are entiled to citezenship in this case but still
18:00:17 sean-k-mooney ok time for food. laters o/
18:19:29 melwitt dansmith or jaypipes: could one of you hit this to move rocky implemented specs? https://review.openstack.org/592622
18:36:22 openstackgerrit Merged openstack/nova-specs master: Move rocky implemented specs https://review.openstack.org/592622
18:38:16 cfriesen sean-k-mooney: stephenfin: either of you care to take a look at review.openstack.org/588657 ? not my patch, I just think it's useful and it's stalled
19:00:35 tzumainn hi! I'm working with ironic, and running into an issue where, after enrolling baremetal nodes, I can see them in the compute_nodes database table but they never get processed or whatever and show up when I run 'openstack hypervisor list'
19:00:44 tzumainn the nova-compute.log does have this error, which is suspicious:
19:00:45 tzumainn 2018-08-30 17:00:51.142 7 ERROR nova.compute.manager File "/usr/lib/python2.7/site-packages/nova/compute/manager.py", line 7729, in _update_av\
19:00:45 tzumainn 2018-08-30 17:00:51.142 7 ERROR nova.compute.manager Traceback (most recent call last):
19:00:45 tzumainn 05cc-e872-49aa-aff4-1a91278b5cb3.: NotImplementedError: Cannot load 'id' in the base class
19:00:45 tzumainn 018-08-30 17:00:51.142 7 ERROR nova.compute.manager [req-73ba9d4b-b51d-4ab7-88c8-5fc3f27fd89e - - - - -] Error updating resources for node 0e57\
19:00:47 tzumainn ailable_resource_for_node
19:00:57 tzumainn anyone have experience with this? sorry if the questions are vague, I'm a bit new to this
19:17:26 mriedem melwitt: jungleboyj: is there a specific nova/cinder etherpad for the ptg? i just see a topic section for cinder on thursday in the nova ptg
19:18:13 melwitt mriedem: not that I know of. I suggested people add topics on the nova ptg etherpad in the section in my email to the ML
19:18:32 melwitt we can have a separate etherpad to link to if you want
19:21:37 mriedem ack
19:21:47 openstackgerrit Eric Fried proposed openstack/nova master: Fix reshaper report client functonal test nits https://review.openstack.org/598330
19:22:22 melwitt tzumainn: can you pastebin the full traceback?
19:23:34 tzumainn melwitt, it's at http://pastebin.test.redhat.com/639596
19:25:34 melwitt thanks
19:27:46 mriedem how about a public paste?
19:28:03 mriedem paste.openstack.org or gist.github.com
19:28:21 tzumainn whoops, sorry!
19:29:43 tzumainn melwitt, http://paste.openstack.org/show/729177/
19:29:51 melwitt the error is saying there's the 'id' field missing from the ComputeNode object, which means it wasn't created/obtained from the database (where the 'id' field comes from). but in the code, I see a cn.create() before _setup_pci_tracker is called, so 'id' should be populated
19:29:59 mriedem cdent: vmware ci might be hitting the same scheduling issues? http://207.189.188.190/logs/16/270116/12/check-vote/ext-nova-zuul/7a47690/
19:30:04 mriedem lots of novalidhost in there
19:30:11 mriedem that's on the live migration for vmware change
19:30:12 melwitt tzumainn: what release is this?
19:30:17 tzumainn melwitt, this is rocky
19:30:25 melwitt ok
19:31:40 mriedem i was going to say https://review.openstack.org/#/c/520024/ but that's not in rocky
19:33:36 melwitt heh, that patch again
19:34:10 mriedem it's in the same code path
19:36:31 mriedem by the time we call _setup_pci_tracker there in that block on L563 we should have an existing instance, either created from the RT or pulled from the DB
19:36:41 mriedem *existing compute node record
19:36:54 melwitt yeah, according to the trace, the ComputeNode object in self.compute_nodes has no 'id' field populated
19:37:26 melwitt so there must be a way we're adding things to self.compute_nodes that are object shells, not gotten from the DB or newly created
19:41:31 openstackgerrit Matt Riedemann proposed openstack/nova master: Default AZ for instance if cross_az_attach=False and checking from API https://review.openstack.org/469675
19:49:07 cdent thanks mriedem will do some poking and prodding
19:49:50 openstackgerrit Chris Dent proposed openstack/nova master: VMware: Live migration of instances https://review.openstack.org/270116
19:52:12 mriedem tzumainn: which virt driver? libvirt? ironic?
19:52:21 mriedem and are you doing anything when this happens?
19:52:35 melwitt it's ironic
19:52:39 mriedem like, is this on start of nova-compute or during a periodic task?
19:52:48 mriedem hmmm, is a rebalance happening?
19:53:10 tzumainn mriedem, ah, this is ironic - I've just enrolled four nodes, and am trying to figure out why they don't show up in 'openstack hypervisor list'
19:53:56 mriedem they won't show up in openstack hypervisor list until you've "discovered" them
19:54:02 mriedem see the nova-manage cell_v2 discover_hosts command
19:54:07 mriedem you'll need to discover by service
19:55:12 tzumainn ah, okay! I wasn't aware - I'm following the instructions in http://tripleo.org/install/advanced_deployment/baremetal_overcloud.html which I guess are out of date
19:56:26 melwitt the traceback was unrelated then. still don't see how the condition of no 'id' on a ComputeNode in self.compute_nodes can happen (thought it obviously can happen somehow)
19:56:43 mriedem yeah i don't really know how that's being hit
19:57:13 mriedem tzumainn: no idea re tripleo deployment, they have their own irc channel for that
19:57:16 melwitt remove_node removes things from the dict if orphaned, all of the setting of self.compute_nodes seem to be covered by actual DB gets or creates. weird
19:57:17 mriedem plus like 50 red hat cores
19:58:39 tzumainn mriedem, haha, yep - I started out talking with some ironic folks, and confusion all around has led me here : )
19:58:55 tzumainn thanks for the information, I really appreciate it!
19:59:30 mriedem maybe related to https://review.openstack.org/#/c/587922/ ?
20:00:19 jungleboyj mriedem: I don't have a separate one. Asked people to mark the topics and then I was going to collect them up.
20:00:22 mriedem remove_node should likely be in the same semaphore as _update_available_resource_for_node
20:00:52 mriedem i guess i already said that https://review.openstack.org/#/c/587922/2/nova/compute/resource_tracker.py
20:01:21 mriedem so self.old_resources will default a ComputeNode object if an entry isn't in the dict...
20:02:25 zigo mriedem: Should I try your patch at https://review.openstack.org/#/c/598176/ and report the result?
20:02:45 melwitt does self.compute_nodes refer to self.old_resources at all?
20:03:01 mriedem they are compared in _resource_change
20:03:11 mriedem to determine if we should call ComputeNode.save()
20:03:28 mriedem zigo: we aren't going to ship that revert i don't think so probably would be a waste of your time
20:04:13 zigo mriedem: If it's only a temporary fix that I can use to validate all of Rocky, that's nice already, then I can still remove the patch...
20:04:34 zigo Hum...
20:04:39 zigo It doesn't apply at all anyway.
20:05:12 zigo mriedem: This wasn't in rocky.
20:05:16 mriedem cdent: melwitt: was also wondering if this somehow is contributing to the allocation ratio bug https://review.openstack.org/#/c/518294/
20:05:19 mriedem but that was in queens
20:05:27 mriedem zigo: right
20:05:56 melwitt ack

Earlier   Later