| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-08-29 | |||
| 19:00:11 | sean-k-mooney | disk_allocation_ratio = 2.0 | |
| 19:00:13 | sean-k-mooney | ram_allocation_ratio = 1.5 | |
| 19:00:15 | sean-k-mooney | cpu_allocation_ratio = 16.0 | |
| 19:00:38 | melwitt | yeah. I was trying to think if that would appear to reportclient as "no change" and therefore not update placement | |
| 19:00:41 | sean-k-mooney | all vaild that said i would never advise setting the disk_allocation_ration over 1 | |
| 19:01:20 | melwitt | but, reportclient should be comparing what placement has with those new values, so it should see a change. but from what we know so far, it looks like it isn't seeing a change. mriedem's debug logs will confirm | |
| 19:01:30 | sean-k-mooney | melwitt: if you could some how get the value to the report clinet as 0.0 then yes | |
| 19:02:34 | melwitt | right, yeah | |
| 19:03:31 | mriedem | sean-k-mooney: they are *now* | |
| 19:03:35 | mriedem | they weren't when they reported the issue | |
| 19:03:42 | mriedem | they are hard-coding them in config as a workaround for the CI failure | |
| 19:03:54 | mriedem | which is why i've reverted that change to try and actually get a recreate with logging | |
| 19:04:03 | sean-k-mooney | right so before they were not set | |
| 19:04:24 | cdent | mriedem: have you added logs which watch the value of the cn.*_allocation_ratio in some way? | |
| 19:05:02 | cdent | i'm looking at https://review.openstack.org/#/c/597560/2/nova/compute/resource_tracker.py,unified and wonder if we want more info about the state of the compute node along the way | |
| 19:06:04 | cdent | when cn.save() is called if those values are weird for some reason the ratio adjustment stuff in _from_db_object _might_ no be behaving as expected | |
| 19:06:15 | mriedem | i could add that | |
| 19:06:17 | cdent | (of course you have probably already analyzed this while I was getting elderberries) | |
| 19:06:25 | melwitt | sean-k-mooney: yeah, so focusing on the values somehow being 0.0 _after_ the normalize from compute node object, that's what got mentioned earlier, how that could possibly happen | |
| 19:07:11 | melwitt | the normalize function is supposed to be filling in with the defaults 16.0 etc | |
| 19:08:36 | sean-k-mooney | ... so my raise NotImplemented to force the alt path with the libvirt driver sill resulted in the correct vaules | |
| 19:09:17 | melwitt | ? so how is xen failing? I thought it was taking the alt path | |
| 19:09:47 | sean-k-mooney | melwitt: it is but taking the alt path is apparently not enough | |
| 19:09:57 | melwitt | oh | |
| 19:11:40 | sean-k-mooney | i have matt's debug patch applied also but im not sure that is going to show where the default values got applied | |
| 19:12:58 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add debug logs for when provider inventory changes https://review.openstack.org/597560 | |
| 19:13:05 | mriedem | cdent: like this? ^ | |
| 19:18:52 | cdent | mriedem: yeah, nice. that combined with the other stuff ought to help see the flow | |
| 19:19:18 | cdent | s/see/better see/ | |
| 19:19:37 | cdent | The difficulty with creating an MTC for this makes me anxious | |
| 19:26:31 | sean-k-mooney | im restacking in offline mode (with libvirt) we are expecting to see the defaulting to ... message if the compute node object is setting the defaults right | |
| 19:28:34 | sean-k-mooney | i can deploy a xen node tommorow if needed to see if i can reporduce | |
| 19:41:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Revert "libvirt: add method to configure migration speed" https://review.openstack.org/590814 | |
| 19:43:53 | cfriesen | jaypipes: re the cold migration with PCI devices. were you talking about the difference between it being theoretically supported and actually doing it? StarlingX integration tests do cold migration with PCI/SRIOV regularly, but I realize that doesn't answer the question for upstream. | |
| 19:45:34 | sean-k-mooney | cfriesen: i think i have done it in the past also i had tought it was ment to be supported. that said not sure it updated teh resouce tracker correctly | |
| 19:45:49 | jaypipes | cfriesen: yes, I'm referring to real-world deployments who do migrations where the instances hold on to their IP addresses, GPUs, and everything else and are migrated to a different rack/region whatever | |
| 19:46:19 | jaypipes | cfriesen: but whatever, I'm running from that conversation screaming. | |
| 19:46:25 | cfriesen | jaypipes: :) | |
| 19:55:35 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional test for live migrate with anti-affinity group https://review.openstack.org/588935 | |
| 19:56:22 | mriedem | cfriesen: upstream supports cold migration with pci devices | |
| 19:56:31 | mriedem | remember moshe and ludovic got that working | |
| 19:57:03 | mriedem | there was also 3rd party ci from mellanox for it at one time i think | |
| 19:57:06 | mriedem | but that might be dead now | |
| 20:16:11 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete instance_group_member records from API DB during archive https://review.openstack.org/588943 | |
| 20:16:12 | mriedem | melwitt: just noticed you had commented on this ^ test should cover the case you noted now | |
| 20:17:08 | melwitt | ok, will look | |
| 20:20:18 | mriedem | crap forgot to update the bug reference in the commit message | |
| 20:21:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Delete instance_group_member records from API DB during archive https://review.openstack.org/588943 | |
| 20:28:26 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old check_attach version check in API https://review.openstack.org/588348 | |
| 20:39:26 | dansmith | melwitt: mriedem: this is going to pass tests in a few minutes: https://review.openstack.org/#/c/597206 | |
| 20:39:49 | dansmith | if you could ack it with a +1 (or tell me what you want changed), I will go about trying to figure out how I'm going to get that merged :) | |
| 20:40:06 | melwitt | will do | |
| 20:43:05 | dansmith | also i was going to verify resource providers before/after and then realized we can't really do that since other projects might create providers, and we have no "service type" field | |
| 20:43:37 | mriedem | one hack way to determine a compute node provider is via the VCPU inventory | |
| 20:44:25 | dansmith | for the moment, yeah, but meh | |
| 20:44:31 | dansmith | I'd rather get this in and work on the other stuff | |
| 20:44:40 | dansmith | because this was a PITA to get working | |
| 20:44:56 | mriedem | dansmith: need to recheck https://review.openstack.org/#/c/597566/ ? | |
| 20:44:57 | dansmith | just because I don't want to run it locally | |
| 20:45:08 | dansmith | mriedem: no, it's about to pass soon too | |
| 20:45:12 | mriedem | ok | |
| 20:45:53 | zigo | mriedem: As I told you, if you wish, I can push your patches into the packages... | |
| 20:45:54 | zigo | Package is building with the patch... | |
| 20:46:19 | mriedem | zigo: sure, but that's not something you'll release is it? with the debug log patch? | |
| 20:46:38 | mriedem | i'm just hoping to debug a recreate with ci logs | |
| 20:47:00 | zigo | mriedem: It just lives in my Stretch backport, until I remove the patch. | |
| 20:47:12 | zigo | I don't have the intention to push that to Debian Sid / Experimental, no. | |
| 20:48:18 | zigo | mriedem: once the package is built by my jenkins (you can see the build process there: https://stretch-queens.infomaniak.ch/job/nova/) then we just need to re-trigger the puppet-openstack CI. | |
| 20:50:18 | zigo | mriedem: Otherwise, I can teach you how to re-produce it on a local Stretch VM. It's very easy . | |
| 20:53:44 | mriedem | that's ok, looks like we have a recreate again in the xen ci https://review.openstack.org/#/c/597613/ | |
| 20:56:29 | mriedem | that doesn't have the logging i need though, so rechecking the xenserver ci job | |
| 20:57:57 | zigo | Silly me, wrong jenkins ... | |
| 20:59:23 | melwitt | dansmith: are you intentionally not checking for DISK_GB in the verify inventory step? | |
| 20:59:49 | dansmith | melwitt: um, duh, of course I'm not | |
| 20:59:50 | dansmith | I mean | |
| 20:59:55 | dansmith | who would verify DISK_GB | |
| 21:00:00 | dansmith | that'd be kinda, like, really stupid right? | |
| 21:00:38 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add encrypted volume support to feature matrix docs https://review.openstack.org/570255 | |
| 21:00:45 | melwitt | lol | |
| 21:02:19 | dansmith | melwitt: like six of those patchsets were me getting resource classes wrong | |
| 21:02:24 | dansmith | melwitt: just pushed to use a central list | |
| 21:02:45 | melwitt | heh. central list = good | |
| 21:03:20 | dansmith | since it takes about 90 minutes to test each one, I've been trying to make minimal change | |
| 21:03:40 | dansmith | you better hope this one works and I don't have to spend another couple days throwing things at the wall :) | |
| 21:04:08 | melwitt | it's gotta work | |
| 21:18:03 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Default AZ for instance if cross_az_attach=False and checking from API https://review.openstack.org/469675 | |
| 21:23:10 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Time how long select_destinations() takes in conductor https://review.openstack.org/517108 | |
| 21:24:42 | zigo | mriedem: Package built, waiting for recheck now. | |
| 21:25:03 | zigo | It probably will end when I'll be sleeping ... | |
| 21:31:29 | mriedem | yeah i'm t-15 minutes from parenting duties | |
| 21:40:21 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Combine error handling blocks in _do_build_and_run_instance https://review.openstack.org/545960 | |
| 21:50:50 | Sundar | efried: Please ping me | |
| 22:07:10 | openstackgerrit | Merged openstack/nova master: doc: add info how to troubleshoot vmware specific problems https://review.openstack.org/597446 | |
| 23:09:50 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Document differences and similaries between extra specs and hints https://review.openstack.org/581410 | |
| 23:51:23 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add TODO note for mox removal https://review.openstack.org/576758 | |
| #openstack-nova - 2018-08-30 | |||
| 00:52:29 | openstackgerrit | Merged openstack/nova master: [placement] Make _ensure_aggregate context not independent https://review.openstack.org/597486 | |
| 01:05:06 | openstackgerrit | Merged openstack/nova master: Add explanatory prefix to post_test_perf output https://review.openstack.org/591850 | |
| 01:12:36 | openstackgerrit | Merged openstack/nova master: Add trait query to placement perf check https://review.openstack.org/592624 | |
| 01:12:42 | openstackgerrit | Merged openstack/nova master: Restart scheduler in TestNovaManagePlacementHealAllocations https://review.openstack.org/597571 | |
| 01:12:52 | openstackgerrit | Merged openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033 | |