| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-08-23 | |||
| 13:55:37 | mriedem | like that flavor.disabled thing we had to fix | |
| 13:55:59 | gibi | mriedem: yeah. Then I will file a bug and propose the removal. | |
| 13:56:04 | mriedem | i can report a "logs are noisy" bug if you want for tracking | |
| 13:56:07 | mriedem | ah ok | |
| 13:56:08 | mriedem | :) | |
| 13:56:18 | melwitt | nova meeting in 4 minutes | |
| 13:56:33 | gibi | mriedem: I'm not fully happy with ovos with unset fields but we use the ovos that way a lot in nova | |
| 13:56:43 | mdbooth | melwitt: We may have to continue that discussion another time, then ;) | |
| 13:57:30 | mdbooth | melwitt dansmith: Incidentally, were you trying to grok https://review.openstack.org/#/c/578846/7/nova/virt/libvirt/driver.py 1002-> ? | |
| 13:57:56 | mdbooth | melwitt dansmith: Because if so I don't grok that either, but it's not new code. | |
| 13:58:42 | mdbooth | It came from old code line 1066-> | |
| 13:59:11 | mdbooth | As I put in the comment, I'm pretty sure it's wrong, though, but I wasn't going to change it in this patch | |
| 13:59:14 | dansmith | mdbooth: I'm not saying I don't grok it, I'm saying it's a lot of change | |
| 13:59:18 | dansmith | "code motion" or not :) | |
| 13:59:31 | dansmith | we have a meeting in 30 seconds and then I can look in more detail, | |
| 13:59:42 | melwitt | yeah, it was just me who said I couldn't follow the change so far | |
| 13:59:46 | mdbooth | dansmith: It updates _create_image() to return whether or not it created anything | |
| 13:59:57 | dansmith | but I was saying that mriedem and melwitt and cfriesen at least have context on this and probably can get back up to speed quicker than I can even start | |
| 14:00:04 | mriedem | this is about the time i muse about an evacuate test in the gate | |
| 14:00:14 | jroll | ykarel: what I meant was e.g. openstack flavor set --memory-mb 0 $flavor | |
| 14:00:17 | dansmith | mdbooth: see? ^ | |
| 14:00:17 | jroll | or the equivalent | |
| 14:00:35 | mdbooth | mriedem: I wrote one :) | |
| 14:00:35 | mriedem | run a nova tempest plugin test in serial, | |
| 14:00:37 | mriedem | 2 node CI | |
| 14:00:41 | mriedem | force down one host, | |
| 14:00:44 | mriedem | evacuate to the other | |
| 14:00:47 | ykarel | jroll, okk my bad, will try that | |
| 14:00:48 | mriedem | run in both ceph and non-ceph jobs | |
| 14:00:55 | mdbooth | mriedem: Ah, that would be better of course. Mine's in functional. | |
| 14:00:58 | mriedem | mdbooth: you wrote a functional test with stubs yes? | |
| 14:01:09 | mdbooth | mriedem: right. | |
| 14:01:28 | mdbooth | mriedem: It runs quite a lot of code, though. It runs the libvirt driver. | |
| 14:02:20 | mdbooth | mriedem: And it tests all 4 combinations of shared/nonshared instance storage and block. | |
| 14:02:32 | mriedem | johnthetubaguy: since you're around, you've been summoned several times on https://review.openstack.org/#/c/536351/ | |
| 14:03:05 | johnthetubaguy | oh sorry, looking | |
| 14:04:05 | melwitt | sahid: are you still around? would you be able to advise us on how to document the issue in https://review.openstack.org/#/c/595592/ for the config option help and release notes? | |
| 14:06:24 | sahid | melwitt: yes sure i will try to reply to Matt with the most information that i have | |
| 14:06:30 | openstackgerrit | Merged openstack/nova master: Merge extended server attributes extension response https://review.openstack.org/584590 | |
| 14:06:48 | melwitt | great, thank you sahid | |
| 14:07:59 | melwitt | we're trying to get the information straight to document the situation for RC3 whose deadline is today | |
| 14:09:36 | mdbooth | mriedem: We were discussing https://review.openstack.org/#/c/578846/ btw, which is a completely new approach. Described in the commit message: "This change modifies spawn in the libvirt driver such that it only cleans up resources it created." | |
| 14:10:28 | mriedem | nova meeting, and rc3 fires | |
| 14:10:32 | mriedem | so i'm not looking into that today | |
| 14:10:33 | mriedem | or soon | |
| 14:10:50 | mdbooth | mriedem: ack | |
| 14:12:05 | ykarel | jroll, i tried creating a new flavor as i can't find update command for ram and it says:- Invalid input for field/attribute ram. Value: 0. 0 is less than the minimum of 1 (HTTP 400) (Request-ID: req-1545b718-80c2-4c08-bcba-356a21535b47) | |
| 14:12:13 | mriedem | johnthetubaguy: thanks | |
| 14:13:05 | mriedem | ykarel: ram must be at least 1 per the api schema | |
| 14:13:15 | mriedem | same for vcpus | |
| 14:13:18 | mriedem | root_gb can be 0 | |
| 14:13:25 | mriedem | http://eavesdrop.openstack.org/meetings/nova/2018/nova.2018-08-16-21.00.html | |
| 14:13:27 | mriedem | oops | |
| 14:13:32 | mriedem | 'required': ['name', 'ram', 'vcpus', 'disk'], | |
| 14:13:36 | jroll | ugh | |
| 14:13:42 | ykarel | mriedem, but to avoid that nova bug, jroll suggested to use 0 | |
| 14:13:53 | mriedem | the api says otherwise | |
| 14:14:07 | mriedem | for ironic, the flavor values will likely just be informational, | |
| 14:14:14 | mriedem | and then the extra spec resources: are meant to override i thought | |
| 14:14:30 | jroll | right | |
| 14:14:39 | jroll | which isn't working in these tripleo jobs | |
| 14:14:54 | jroll | https://github.com/openstack/ironic/blob/master/devstack/lib/ironic#L2083 | |
| 14:15:35 | jroll | ah, we don't enable cpu/ram/disk filters | |
| 14:17:43 | ykarel | hmm in tripleo we have those enabled | |
| 14:18:13 | ykarel | enabled_filters=RetryFilter,TripleOCapabilitiesFilter,ComputeCapabilitiesFilter,AvailabilityZoneFilter,RamFilter,DiskFilter,ComputeFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter | |
| 14:18:13 | ykarel | enabled_filters=RetryFilter,AvailabilityZoneFilter,ComputeFilter,ComputeCapabilitiesFilter,ImagePropertiesFilter,ServerGroupAntiAffinityFilter,ServerGroupAffinityFilter | |
| 14:18:21 | jroll | right | |
| 14:18:30 | jroll | are you also using VMs here? | |
| 14:18:47 | ykarel | no, just ironic | |
| 14:18:51 | ykarel | bms | |
| 14:19:05 | jroll | ah, I'd kill those filters then, they aren't necessary | |
| 14:19:13 | jaypipes | enabled_filters should not include RamFilter, DiskFilter or ComputeFilter. | |
| 14:19:16 | jroll | and please do file a bug about the override thing, if you would | |
| 14:19:39 | jaypipes | perhaps this is the thing I was referring to when I mentioned triple-o was still relying on non-resource-class world. | |
| 14:19:41 | jroll | jaypipes: oh, we don't need those filters anywhere now, right? | |
| 14:19:50 | jaypipes | jroll: correct. | |
| 14:19:51 | jroll | even for VMs? | |
| 14:19:53 | jroll | nice | |
| 14:19:57 | jaypipes | yes, even for VMs. | |
| 14:20:10 | jaypipes | actually, lemme verify... | |
| 14:20:37 | jaypipes | there was a CoreFilter too I think, and I can't remember whether it was that or ComputeFilter which filters out "disabled" nodes. | |
| 14:21:25 | jaypipes | jroll, ykarel: you don't need CoreFilter, DiskFilter and RamFilter. ComputeFilter is still needed | |
| 14:21:28 | sean-k-mooney | ComuteFilter does the disabled host i think | |
| 14:21:32 | jaypipes | it filters out "disabled" nodes | |
| 14:21:32 | mriedem | correction! | |
| 14:21:37 | mriedem | you need those filters for caching scheduler | |
| 14:21:41 | mriedem | which doesn't use placement | |
| 14:21:43 | jaypipes | oh ffs, yes. | |
| 14:21:45 | mriedem | otherwise what jay said | |
| 14:22:03 | jroll | gdi mriedem | |
| 14:23:07 | mriedem | hey, if mgagne_ gives the ok at the ptg that we can drop the caching scheduler, then we can | |
| 14:23:14 | sean-k-mooney | mriedem: we are deleting the cachingschduler this cycle right? | |
| 14:23:26 | mriedem | sean-k-mooney: idk, we were going to drop nova-net in rocky ... | |
| 14:23:26 | sean-k-mooney | ah ptg topic | |
| 14:23:52 | sean-k-mooney | ya... stein for that? | |
| 14:24:41 | sean-k-mooney | the caching schduiler could be kicked out of tree like the ec2 api if people really wanted it for some reason. that is still a plug point right? | |
| 14:24:57 | sean-k-mooney | e.g. you can provide your own schduler driver | |
| 14:25:08 | mriedem | yes i think so | |
| 14:25:11 | mriedem | via stevedore extensions | |
| 14:25:14 | melwitt | johnthetubaguy: I pinged you a long time ago about https://review.openstack.org/533168 that you reviewed in the past, if you can get a chance to look at it | |