| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-08-23 | |||
| 13:30:29 | edmondsw | I wonder if this was added with the intention of having a followup that used it and maybe that just never happened | |
| 13:31:09 | sean-k-mooney | perhaps that or there is patch in review that has not landed yet | |
| 13:37:31 | stephenfin | mriedem: Does we need to wait for blueprint approval for [1] or can I start flushing them through? [1] https://review.openstack.org/#/q/topic:bp/api-extensions-merge-stein+status:open | |
| 13:38:37 | stephenfin | mriedem: Wait, it's specless and approved. Ignore me | |
| 13:39:09 | zigo | mriedem: cdent: I now know why I missed the webob version, it's because I forgot the EPOCH ... | |
| 13:39:20 | zigo | 1:1.8.2 is what's needed, not 1.8.2 ... | |
| 13:39:22 | zigo | :/ | |
| 13:39:27 | mriedem | stephenfin: right some are already approved/merged | |
| 13:39:34 | stephenfin | ack | |
| 13:41:48 | mriedem | edmondsw: a notification is trying to build a payload from the MonitorMetric object which has unset fields which don't have default values | |
| 13:41:57 | mriedem | but if it's nullable we can just set it to None | |
| 13:42:10 | mriedem | since 'numa_membw_values': fields.DictOfIntegersField(nullable=True), that's what we do | |
| 13:43:08 | edmondsw | mriedem yep, my point is that I think it's always going to be unset and thus DEBUG logs will always have a bunch of these messages filling them because nowhere is it ever set that I can find | |
| 13:43:23 | mriedem | we also get that a ton for flavor stuff i think | |
| 13:43:24 | mriedem | or used to | |
| 13:43:35 | edmondsw | and if that's the case, why does the schema have it in the first place? | |
| 13:44:02 | mriedem | i would be ok with dropping the 'defaulting to None' debug log | |
| 13:44:04 | mriedem | but it's up to gibi | |
| 13:44:30 | mriedem | or change to TRACE if we ever get a TRACE log level | |
| 13:44:42 | edmondsw | I can ignore it, it's not a big deal to me... just thought I'd ask | |
| 13:44:49 | mriedem | it bothers me too | |
| 13:45:51 | openstackgerrit | Eric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033 | |
| 13:45:52 | openstackgerrit | Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider raise https://review.openstack.org/584598 | |
| 13:45:53 | openstackgerrit | Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599 | |
| 13:45:54 | openstackgerrit | Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648 | |
| 13:45:55 | openstackgerrit | Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034 | |
| 13:45:56 | openstackgerrit | Eric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049 | |
| 13:45:57 | openstackgerrit | Eric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | |
| 13:47:09 | ykarel | jroll, mriedem openstack flavor unset --property resources:VCPU --property resources:DISK_GB --property resources:MEMORY_MB <flavor> didn't help, or i tried something wrong | |
| 13:49:19 | gibi | mriedem: as the MonitorMetric.numa_membw_values is also nullable I think when nova creates the MonitorMetric object it fails to set the default value of that field | |
| 13:49:36 | mriedem | there is no default value | |
| 13:49:39 | mriedem | but it is nullable | |
| 13:49:48 | mriedem | i guess you mean fails to initialize the field to None? | |
| 13:49:50 | gibi | mriedem: ohh, my bad | |
| 13:50:03 | gibi | mriedem: I mixed nullable and default value | |
| 13:54:00 | gibi | mriedem: if an ovo is valid with unset fields then I cannot do anything else than remove the debug log | |
| 13:55:06 | mriedem | yeah i don' think the debug log adds much besides noise - if the field is unset and can't be lazy-loaded and is nullable and set it to None, great | |
| 13:55:08 | mriedem | that's what should happen | |
| 13:55:19 | mriedem | if we can't do that - i.e. it's not nullable, then we fail and log an error | |
| 13:55:37 | mriedem | like that flavor.disabled thing we had to fix | |
| 13:55:59 | gibi | mriedem: yeah. Then I will file a bug and propose the removal. | |
| 13:56:04 | mriedem | i can report a "logs are noisy" bug if you want for tracking | |
| 13:56:07 | mriedem | ah ok | |
| 13:56:08 | mriedem | :) | |
| 13:56:18 | melwitt | nova meeting in 4 minutes | |
| 13:56:33 | gibi | mriedem: I'm not fully happy with ovos with unset fields but we use the ovos that way a lot in nova | |
| 13:56:43 | mdbooth | melwitt: We may have to continue that discussion another time, then ;) | |
| 13:57:30 | mdbooth | melwitt dansmith: Incidentally, were you trying to grok https://review.openstack.org/#/c/578846/7/nova/virt/libvirt/driver.py 1002-> ? | |
| 13:57:56 | mdbooth | melwitt dansmith: Because if so I don't grok that either, but it's not new code. | |
| 13:58:42 | mdbooth | It came from old code line 1066-> | |
| 13:59:11 | mdbooth | As I put in the comment, I'm pretty sure it's wrong, though, but I wasn't going to change it in this patch | |
| 13:59:14 | dansmith | mdbooth: I'm not saying I don't grok it, I'm saying it's a lot of change | |
| 13:59:18 | dansmith | "code motion" or not :) | |
| 13:59:31 | dansmith | we have a meeting in 30 seconds and then I can look in more detail, | |
| 13:59:42 | melwitt | yeah, it was just me who said I couldn't follow the change so far | |
| 13:59:46 | mdbooth | dansmith: It updates _create_image() to return whether or not it created anything | |
| 13:59:57 | dansmith | but I was saying that mriedem and melwitt and cfriesen at least have context on this and probably can get back up to speed quicker than I can even start | |
| 14:00:04 | mriedem | this is about the time i muse about an evacuate test in the gate | |
| 14:00:14 | jroll | ykarel: what I meant was e.g. openstack flavor set --memory-mb 0 $flavor | |
| 14:00:17 | dansmith | mdbooth: see? ^ | |
| 14:00:17 | jroll | or the equivalent | |
| 14:00:35 | mdbooth | mriedem: I wrote one :) | |
| 14:00:35 | mriedem | run a nova tempest plugin test in serial, | |
| 14:00:37 | mriedem | 2 node CI | |
| 14:00:41 | mriedem | force down one host, | |
| 14:00:44 | mriedem | evacuate to the other | |
| 14:00:47 | ykarel | jroll, okk my bad, will try that | |
| 14:00:48 | mriedem | run in both ceph and non-ceph jobs | |
| 14:00:55 | mdbooth | mriedem: Ah, that would be better of course. Mine's in functional. | |
| 14:00:58 | mriedem | mdbooth: you wrote a functional test with stubs yes? | |
| 14:01:09 | mdbooth | mriedem: right. | |
| 14:01:28 | mdbooth | mriedem: It runs quite a lot of code, though. It runs the libvirt driver. | |
| 14:02:20 | mdbooth | mriedem: And it tests all 4 combinations of shared/nonshared instance storage and block. | |
| 14:02:32 | mriedem | johnthetubaguy: since you're around, you've been summoned several times on https://review.openstack.org/#/c/536351/ | |
| 14:03:05 | johnthetubaguy | oh sorry, looking | |
| 14:04:05 | melwitt | sahid: are you still around? would you be able to advise us on how to document the issue in https://review.openstack.org/#/c/595592/ for the config option help and release notes? | |
| 14:06:24 | sahid | melwitt: yes sure i will try to reply to Matt with the most information that i have | |
| 14:06:30 | openstackgerrit | Merged openstack/nova master: Merge extended server attributes extension response https://review.openstack.org/584590 | |
| 14:06:48 | melwitt | great, thank you sahid | |
| 14:07:59 | melwitt | we're trying to get the information straight to document the situation for RC3 whose deadline is today | |
| 14:09:36 | mdbooth | mriedem: We were discussing https://review.openstack.org/#/c/578846/ btw, which is a completely new approach. Described in the commit message: "This change modifies spawn in the libvirt driver such that it only cleans up resources it created." | |
| 14:10:28 | mriedem | nova meeting, and rc3 fires | |
| 14:10:32 | mriedem | so i'm not looking into that today | |
| 14:10:33 | mriedem | or soon | |
| 14:10:50 | mdbooth | mriedem: ack | |
| 14:12:05 | ykarel | jroll, i tried creating a new flavor as i can't find update command for ram and it says:- Invalid input for field/attribute ram. Value: 0. 0 is less than the minimum of 1 (HTTP 400) (Request-ID: req-1545b718-80c2-4c08-bcba-356a21535b47) | |
| 14:12:13 | mriedem | johnthetubaguy: thanks | |
| 14:13:05 | mriedem | ykarel: ram must be at least 1 per the api schema | |
| 14:13:15 | mriedem | same for vcpus | |
| 14:13:18 | mriedem | root_gb can be 0 | |
| 14:13:25 | mriedem | http://eavesdrop.openstack.org/meetings/nova/2018/nova.2018-08-16-21.00.html | |
| 14:13:27 | mriedem | oops | |
| 14:13:32 | mriedem | 'required': ['name', 'ram', 'vcpus', 'disk'], | |
| 14:13:36 | jroll | ugh | |
| 14:13:42 | ykarel | mriedem, but to avoid that nova bug, jroll suggested to use 0 | |
| 14:13:53 | mriedem | the api says otherwise | |
| 14:14:07 | mriedem | for ironic, the flavor values will likely just be informational, | |
| 14:14:14 | mriedem | and then the extra spec resources: are meant to override i thought | |
| 14:14:30 | jroll | right | |
| 14:14:39 | jroll | which isn't working in these tripleo jobs | |