| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-08-22 | |||
| 16:09:26 | openstackgerrit | Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648 | |
| 16:09:27 | openstackgerrit | Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034 | |
| 16:09:28 | openstackgerrit | Eric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049 | |
| 16:09:29 | openstackgerrit | Eric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | |
| 16:10:31 | efried | Does anyone have the power to remove a bogus review? viz https://review.openstack.org/#/c/584598/ | |
| 16:10:48 | efried | Not that we would necessarily let that stop us from merging the thing, but it's potentially distracting. | |
| 16:11:55 | openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Network bandwidth resource provider https://review.openstack.org/595243 | |
| 16:14:28 | melwitt | efried: not that I know of. I think if anyone could, it might be infra people | |
| 16:15:08 | efried_rollin | ight | |
| 16:17:33 | dansmith | trivial change'll fix it :) | |
| 16:17:55 | dansmith | that person has been -1ing with no comment on a lot of patches | |
| 16:18:06 | melwitt | yeah. I'm wondering if they're scripting it | |
| 16:22:10 | mriedem | they are -1ing changes that have other -1s on them | |
| 16:22:48 | mriedem | a few +1s i guess https://review.openstack.org/#/q/reviewer:wangying%2540gohighsec.com | |
| 16:22:50 | mriedem | so probably not scripted | |
| 16:22:55 | mriedem | given the small sample size | |
| 16:23:01 | mriedem | Kevin_Zheng: ^ shame them on wechat :) | |
| 16:25:11 | openstackgerrit | Merged openstack/nova master: Handle binding_failed vif plug errors on compute restart https://review.openstack.org/587498 | |
| 16:25:40 | mriedem | lyarwood: weren't you just working on fixing something like this? http://logs.openstack.org/50/594050/6/check/nova-next/af897cc/logs/screen-n-cpu.txt.gz?level=TRACE#_Aug_22_13_55_27_694243 | |
| 16:25:53 | mriedem | seems this volume detach from live/persistent domain thing needs to be fixed every other week | |
| 16:27:44 | mriedem | ah yes https://github.com/openstack/nova/commit/636c7461dee4002571da6e99986eb17e9a28b0f4#diff-ec64afccc111bbe81f5c85b27d73b41b | |
| 16:27:51 | Sundar | efried: Please ping me when you have the time | |
| 16:29:04 | Sundar | sean-k-mooney: Hope you have seen the updated os-acc spec (#link https://review.openstack.org/#/c/577438/). It should reflect the feedback you gave. | |
| 16:31:40 | mriedem | tssurya needs to re-propose the handling a down cell spec for stein | |
| 16:32:24 | openstackgerrit | Matthew Booth proposed openstack/nova-specs master: Add serial numbers for local disks https://review.openstack.org/595247 | |
| 16:35:52 | sean-k-mooney | Sundar: i have not had time to fully review this sorry. ill try to get back to it by the end of the week | |
| 16:37:27 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Wait for network-vif-plugged before starting live migration https://review.openstack.org/591735 | |
| 16:37:28 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: DNM: Debug patch to test live migration waiting https://review.openstack.org/591775 | |
| 16:38:24 | mriedem | dansmith: are you also going to do ^ for pike? | |
| 16:38:33 | mriedem | because https://review.openstack.org/#/c/591762/ | |
| 16:38:51 | dansmith | I had assumed we would yeah | |
| 16:43:49 | openstackgerrit | Dan Smith proposed openstack/nova master: Batch results per cell when doing cross-cell listing https://review.openstack.org/592698 | |
| 16:43:50 | openstackgerrit | Dan Smith proposed openstack/nova master: List instances from all cells explicitly https://review.openstack.org/593717 | |
| 16:43:51 | openstackgerrit | Dan Smith proposed openstack/nova master: Make instance_list perform per-cell batching https://review.openstack.org/593131 | |
| 16:43:52 | openstackgerrit | Dan Smith proposed openstack/nova master: Record cell success/failure/timeout in CrossCellLister https://review.openstack.org/594265 | |
| 16:43:53 | openstackgerrit | Dan Smith proposed openstack/nova master: Optimize global marker re-lookup in multi_cell_list https://review.openstack.org/594577 | |
| 16:43:54 | openstackgerrit | Dan Smith proposed openstack/nova master: Clarify which context is used by do_query() https://review.openstack.org/595250 | |
| 16:45:30 | dansmith | mriedem: FYI the last patch removes an extra db hit we do in the listing process which was a fixme from the original work | |
| 16:45:59 | dansmith | probably small and not super impactful, but..fewer is better | |
| 17:16:36 | openstackgerrit | Merged openstack/nova master: libvirt: Always escape IPv6 addresses when used in migration URI https://review.openstack.org/589548 | |
| 17:33:22 | imacdonn | Could someone help me understand (or point me to a good description of) the deprecation of nova-consoleauth? From the way it's described, it sounds like you can just not run the service, but when I do that 'nova get-vnc-console ... novnc' gets an "unknown error" (HTTP 504) | |
| 17:50:29 | melwitt | imacdonn: sec, looking for docs link | |
| 17:55:00 | melwitt | imacdonn: https://docs.openstack.org/nova/latest/user/cellsv2-layout.html#consoleauth-service-and-console-proxies and the release notes https://docs.openstack.org/releasenotes/nova/rocky.html#relnotes-18-0-0-0b2-stable-rocky-upgrade-notes | |
| 17:55:29 | imacdonn | melwitt: OK... will review - I just found https://review.openstack.org/#/c/557489/ too | |
| 17:56:55 | imacdonn | Somehow I missed that upgrade release notes.... maybe was looking at the wrong version of release notes .. thans | |
| 17:56:58 | imacdonn | thanks* | |
| 17:58:30 | imacdonn | melwitt: Actually, though, this still seems to suggest that I can "just not run the service" ... and that's not working for me | |
| 17:59:19 | melwitt | yeah, sorry. indeed you are supposed to be able to not run the service | |
| 18:00:08 | melwitt | imacdonn: do you have a single cell deployment or multiple cells? | |
| 18:00:30 | imacdonn | melwitt: single cell, not counting cell0 | |
| 18:02:10 | melwitt | do you have a trace you can pastebin of the nova-api log and nova-novnc | |
| 18:03:22 | imacdonn | melwitt: I guess I'll enable debug logging and see what I can get ... wanted to make sure I wasn't missing a required config change or something first | |
| 18:05:39 | melwitt | here's examples from the gate of what the configs should look like for the cell and compute host http://logs.openstack.org/58/540258/13/check/tempest-full-py3/f59f34a/controller/logs/etc/nova/nova_cell1_conf.txt.gz http://logs.openstack.org/58/540258/13/check/tempest-full-py3/f59f34a/controller/logs/etc/nova/nova-cpu_conf.txt.gz | |
| 18:19:03 | melwitt | imacdonn: I made a mistake, sorry. you do have to run the consoleauth service in Rocky still. being able to discontinue running it will be in Stein | |
| 18:19:30 | imacdonn | melwitt: Oooh okay .... so ... uhm ... it's not really deprecated yet, then ....... ? | |
| 18:20:10 | melwitt | imacdonn: it's deprecated but not yet removed. in rocky it's doing things side-by-side, then in stein we can remove it | |
| 18:20:16 | imacdonn | melwitt: where my definition of "deprecated" is something like "you can still do this, but you really shouldn't, and you should do it the new way instead" | |
| 18:21:20 | melwitt | yeah, I see what you mean. and the docs are wrong saying you can stop running it in rocky, so I need to fix that | |
| 18:21:44 | imacdonn | melwitt: yes, that was going to be my next point ;) | |
| 18:22:37 | melwitt | yeah, apologies for that. I'll work on some updates to the docs right now | |
| 18:23:01 | melwitt | mriedem_lunch ^ think this will be another thing for rc3 | |
| 18:23:46 | imacdonn | no problem! Thanks for working through it with me | |
| 18:24:40 | imacdonn | part of my practice for each new release is to review logs for deprecation warnings, and eliminate as many as I can | |
| 18:25:33 | melwitt | that's a good practice. sorry that doc threw a wrench in it | |
| 18:26:11 | imacdonn | Glad to catch it before the release! | |
| 18:26:34 | melwitt | yes, definitely. thank you for that | |
| 18:27:27 | imacdonn | np | |
| 19:00:18 | mriedem | imacdonn: can you report a bug that the docs are wrong? | |
| 19:00:41 | imacdonn | mriedem: ok | |
| 19:01:04 | melwitt | I'm in the middle of writing up a bug | |
| 19:02:15 | melwitt | heh | |
| 19:02:34 | mriedem | https://www.youtube.com/watch?v=Vvwq1FZ6gxE | |
| 19:03:30 | imacdonn | :) | |
| 19:05:10 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/rocky: Handle binding_failed vif plug errors on compute restart https://review.openstack.org/595317 | |
| 19:06:59 | openstack | Launchpad bug 1788470 in OpenStack Compute (nova) "release notes and docs erroneously say that nova-consoleauth doesn't have to run in Rocky " [Medium,New] - Assigned to melanie witt (melwitt) | |
| 19:06:59 | melwitt | https://bugs.launchpad.net/nova/+bug/1788470 | |
| 19:54:39 | mriedem | so uh, i could use some reviews on this rc3 potential fix https://review.openstack.org/#/c/594508/ | |
| 19:54:41 | mriedem | "fix" | |
| 19:55:42 | melwitt | I'll review the rc3 things today. it's been a distracting day | |
| 19:56:59 | mriedem | i'll review yours if you review mine | |
| 19:57:24 | mriedem | the other one, approved yesterday morning, is still humping its way through the gate | |
| 20:01:04 | melwitt | ok, cool. I saw on the todos etherpad | |
| 20:28:36 | mriedem | dansmith: i'm slowly climbing multi-cell list batch mountain | |
| 20:28:41 | mriedem | nearly at the summit | |
| 20:28:49 | mriedem | oxygen....depleting... | |
| 20:41:21 | melwitt | I found that the console code in compute is storing token auths in both the database and nova-consoleauth for rocky, and I'm struggling to understand why. it was like that before I took on the patch series. I assume it was just so operators could keep using nova-consoleauth as the storage backend for a cycle, if they for some reason wanted to | |
| 20:41:48 | melwitt | initially, I thought maybe it was to support rolling upgrades, but I don't think storing new tokens in nova-consoleauth helps with that | |
| 20:46:11 | eandersson | Is compute_driver used by any other service then nova-compute? | |
| 20:46:51 | eandersson | Can you have nova-compute-ironic on the same box as nova-conductor, api etc? | |
| 20:56:38 | tssurya | mriedem: ack, I'll repropose.. | |
| 20:57:25 | openstackgerrit | Dan Smith proposed openstack/nova master: Make CELL_TIMEOUT a constant https://review.openstack.org/594570 | |
| 20:57:26 | openstackgerrit | Dan Smith proposed openstack/nova master: Stash the cell uuid on the context when targeting https://review.openstack.org/594571 | |
| 20:57:27 | openstackgerrit | Dan Smith proposed openstack/nova master: Make RecordWrapper record RequestContext and expose cell_uuid https://review.openstack.org/594572 | |
| 20:57:28 | openstackgerrit | Dan Smith proposed openstack/nova master: Clarify which context is used by do_query() https://review.openstack.org/595250 | |
| 20:57:29 | openstackgerrit | Dan Smith proposed openstack/nova master: Batch results per cell when doing cross-cell listing https://review.openstack.org/592698 | |
| 20:57:30 | openstackgerrit | Dan Smith proposed openstack/nova master: List instances from all cells explicitly https://review.openstack.org/593717 | |
| 20:57:31 | openstackgerrit | Dan Smith proposed openstack/nova master: Make instance_list perform per-cell batching https://review.openstack.org/593131 | |
| 20:57:32 | openstackgerrit | Dan Smith proposed openstack/nova master: Record cell success/failure/timeout in CrossCellLister https://review.openstack.org/594265 | |
| 20:57:33 | openstackgerrit | Dan Smith proposed openstack/nova master: Optimize global marker re-lookup in multi_cell_list https://review.openstack.org/594577 | |
| 21:00:03 | melwitt | eandersson: no, compute_driver shouldn't be used for any other service (though I see one check for it in the novnc proxy since the xen driver doesn't support a new enough novnc version, IIRC). and AFAIK, you could run nova-compute-ironic on the same box as nova-conductor, etc, but I'm not sure it's recommended. maybe TheJulia can advise | |