| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-08-21 | |||
| 10:46:50 | mriedem | https://github.com/openstack/nova/blob/722d5b477219f0a2435a9f4ad4d54c61b83219f1/nova/conductor/manager.py#L815 | |
| 10:47:48 | mriedem | which reminds me https://review.openstack.org/#/c/559828/ | |
| 10:48:55 | mriedem | as noted in ^ we also don't clear the port binding | |
| 10:49:28 | tssurya | mriedem: back from lunch, oh okay yea would be better to all together filter out the ones where host is NOne | |
| 10:49:59 | mriedem | tssurya: i think that still works for your original bug too | |
| 10:50:01 | mriedem | comments inline on why | |
| 10:59:21 | tssurya | mriedem: I agree, | |
| 11:44:46 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Resource retrieving: add change-before filter https://review.openstack.org/591976 | |
| 11:47:03 | openstackgerrit | Jiri Suchomel proposed openstack/nova master: Filter out instances without a host when populating AZ https://review.openstack.org/594050 | |
| 11:53:26 | mriedem | sean-k-mooney: see how ^ floats your boat | |
| 11:53:27 | mriedem | oops | |
| 11:53:34 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Re-activate source host port bindings on live migration rollback https://review.openstack.org/594139 | |
| 11:53:37 | mriedem | sean-k-mooney: ^ | |
| 11:53:45 | mriedem | i want to see what miguel thinks about that too | |
| 11:55:48 | sean-k-mooney | mriedem: ill test that and see. the other thing is im not sure what the state of qemu when this partaclar bug happens due to the fact th monitor closed. | |
| 11:56:02 | sean-k-mooney | that is kind of a seperate bug however | |
| 11:56:27 | sean-k-mooney | at least with this patch if i do a hard reboot i think everything shold work properly again. | |
| 11:56:33 | mriedem | i am a bit surprised that qemu would bomb out after we went into post-copy mode | |
| 11:56:48 | mriedem | we only activate the dest host port bindings during post-copy or post-live migration | |
| 11:57:10 | mriedem | so your qemu failure must have happened after post-copy for us to activate the dest host bindings | |
| 11:57:27 | mriedem | you'd know if you saw "Binding ports to destination host" in the source host compute logs | |
| 11:58:15 | sean-k-mooney | ill reporduce and check that then apply your patch and see what happens | |
| 12:05:30 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: [placement] Use oslotest uuidsentinel https://review.openstack.org/594144 | |
| 12:05:37 | mriedem | cdent: ^ | |
| 12:05:59 | cdent | nice | |
| 12:07:22 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Resource retrieving: add change-before filter https://review.openstack.org/591976 | |
| 12:07:54 | cdent | mriedem: wait | |
| 12:08:10 | cdent | nm | |
| 12:08:27 | cdent | efried: did you see https://review.openstack.org/#/c/594068/ | |
| 12:08:41 | efried | looking... | |
| 12:09:01 | efried | cdent: Thanks, I was just starting to poke on that. | |
| 12:09:57 | cdent | efried: cool, wasn't sure if you had started your own | |
| 12:11:51 | mriedem | clearly that will have to go through the release dance | |
| 12:23:46 | openstackgerrit | Brin Zhang proposed openstack/nova-specs master: Resource retrieving: add change-before filter https://review.openstack.org/591976 | |
| 12:23:55 | openstackgerrit | Slawek Kaplonski proposed openstack/os-vif master: Avoid os-vif to add untagged ports to ovs ports by default https://review.openstack.org/594118 | |
| 12:26:02 | openstackgerrit | Jiri Suchomel proposed openstack/nova master: Filter out instances without a host when populating AZ https://review.openstack.org/594050 | |
| 12:28:39 | openstackgerrit | Slawek Kaplonski proposed openstack/os-vif master: DNM Testing different CDN projects with DEAD_VLAN_TAG https://review.openstack.org/594153 | |
| 12:58:13 | tssurya | alex_xu, gmann or other api-experts: nova list seems to have this filter "--instance-name" which doesn't seem to be processed anywhere, was wondering where/why it was used ? | |
| 13:00:44 | alex_xu | tssurya: I even don't know we have '--instance-name' filter in the API | |
| 13:01:10 | alex_xu | I don't think we have that in the API | |
| 13:01:30 | tssurya | alex_xu: I didn't find it either; but its listed in the options | |
| 13:01:45 | mriedem | what is it translated to in novaclient? | |
| 13:03:19 | mriedem | added in 2011 by rackspace so it was probably something in rax | |
| 13:03:21 | mriedem | not upstream | |
| 13:04:24 | mriedem | looks like it's meant to filter on OS-EXT-SRV-ATTR:instance_name | |
| 13:04:28 | alex_xu | we have attribute 'OS-EXT-SRV-ATTR:instance_name', try to find out if there is any translate | |
| 13:04:40 | alex_xu | mriedem: yea | |
| 13:04:43 | mriedem | right which would be instance.name | |
| 13:04:51 | mriedem | filtering on --name would be instance.display_name | |
| 13:04:53 | tssurya | but we also have the "--name" | |
| 13:04:57 | tssurya | ah okay | |
| 13:06:05 | mriedem | https://github.com/openstack/python-novaclient/commit/dcd5544133f1cc1171f8078b2ed54143b52fb064 | |
| 13:07:41 | alex_xu | but it doesn't work in server side | |
| 13:07:57 | tssurya | alex_xu: yea, was just trying it | |
| 13:08:40 | tssurya | because we don't have it on the server side right ? | |
| 13:09:25 | alex_xu | yes, I think so | |
| 13:09:56 | alex_xu | gmann: enjoy your vacation! | |
| 13:10:19 | tssurya | cool, should I open a bug on the client to remove it from the option for the users ? or do we have plans on putting it on the server side | |
| 13:11:08 | mriedem | that initial novaclient change wasn't even correct, | |
| 13:11:11 | mriedem | it was later updated in https://github.com/openstack/python-novaclient/commit/fc8e5e3fe3a1164eb2e923ed599e63a2af1a4f3c | |
| 13:11:35 | alex_xu | tssurya: we have a filter called 'name', it is should be the '--instance-name' | |
| 13:11:38 | tssurya | either ways, I was trying to skip the minimal constructs for down cells for "all" filters and came across this one not abiding the rules and doing nothing except priting everything | |
| 13:12:29 | alex_xu | tssurya: sorry, that 'name' is mapping to 'display_name' also | |
| 13:12:32 | tssurya | alex_xu: yea, the documentation for those options need to be more clear to explain what means what if we are going to have both | |
| 13:12:56 | alex_xu | tssurya: yea | |
| 13:13:28 | tssurya | mriedem: oh, so you want to keep both ? | |
| 13:13:40 | mriedem | not necessarily, | |
| 13:13:46 | mriedem | clearly there is a bug in novaclient which needs to be reported | |
| 13:14:57 | tssurya | mriedem: right, I can open a bug now and we can see if this option is really useful to implement on the server side, else we can punt it. At least the documentation should be clearer for those options | |
| 13:15:23 | mriedem | so the --name filter in nova list is being mapped to filter on instance.name rather than display_name? | |
| 13:16:05 | mriedem | https://github.com/openstack/python-novaclient/commit/fc8e5e3fe3a1164eb2e923ed599e63a2af1a4f3c | |
| 13:16:06 | mriedem | oops | |
| 13:16:11 | mriedem | 'name': 'display_name', | |
| 13:16:11 | mriedem | 'image': 'image_ref', | |
| 13:16:11 | mriedem | filter_mapping = { | |
| 13:16:20 | mriedem | so we map name to display_name in the compute API code | |
| 13:16:26 | mriedem | and instance_name should map to 'name' | |
| 13:16:31 | mriedem | is what i think alex_xu was saying | |
| 13:16:42 | mriedem | if we want to support that in the server | |
| 13:16:51 | mriedem | but the client side --instance-name filter doesn't do anything today, right? | |
| 13:17:00 | alex_xu | mriedem: we have instance_name filter long time before https://github.com/openstack/nova/commit/1c90eb34085dbb69f37e2f63dea7496afabb06b3#diff-516904cc81cade24a9122ecf96707bf0R702 | |
| 13:17:20 | mriedem | (8:16:28 AM) mriedem: and instance_name should map to 'name' | |
| 13:17:20 | mriedem | right | |
| 13:17:32 | mriedem | so when was that removed? | |
| 13:20:52 | alex_xu | mriedem: probably folsom release, I see that filter in that relese, but disappear after grizzle | |
| 13:26:25 | alex_xu | mriedem: tssurya here https://review.openstack.org/#/c/10917/3 | |
| 13:27:55 | mriedem | ah ok, and forgot to remove the novaclient side of that | |
| 13:28:01 | tssurya | ah thanks | |
| 13:28:03 | mriedem | and apparently no one has noticed since folsom | |
| 13:28:51 | openstackgerrit | Chris Dent proposed openstack/nova master: Set policy_opt defaults in placement gabbi fixture https://review.openstack.org/594172 | |
| 13:29:05 | openstack | Launchpad bug 1295126 in python-novaclient "Admin only shown for args that can be used by non-admin" [Wishlist,Fix released] - Assigned to Verónica Musso (veronica-a-musso) | |
| 13:29:05 | mriedem | https://bugs.launchpad.net/python-novaclient/+bug/1295126/comments/3 | |
| 13:29:10 | mriedem | "and --instance-name has no effect for both" | |
| 13:30:13 | mriedem | tssurya: alex_xu: i'd probably just deprecate the --instance-name option in nova list, it's not done anything since essex | |
| 13:30:23 | mriedem | adding the support server-side at this point is likely a microversion | |
| 13:30:45 | alex_xu | mriedem: yea, and it is admin-only filter so we can deprecate it | |
| 13:30:48 | tssurya | mriedem: ack, I don't think its that essential a filter | |
| 13:31:14 | tssurya | its not an admin-only.. | |
| 13:33:08 | alex_xu | tssurya: instance_name field only can be see by the admin? | |
| 13:35:24 | mriedem | no, | |