Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-08-15
13:52:17 openstackgerrit Matthew Booth proposed openstack/nova master: Add regression test for bug 1550919 https://review.openstack.org/591733
13:53:21 lyarwood dansmith: https://review.openstack.org/#/c/591761/ is good to go right?
13:53:34 lyarwood dansmith: you didn't want to wait until your other backport was ready or anything?
13:54:01 openstackgerrit Matthew Booth proposed openstack/nova master: Py3 fix in fake image service https://review.openstack.org/592056
13:54:03 dansmith lyarwood: no, I don't think we should wait and yes I think it's good to go
13:54:08 lyarwood dansmith: ack thanks
13:58:18 mriedem dansmith: just replied in the other
13:58:31 mriedem will check it over in the morning
13:59:13 dansmith mriedem: coolt hanks
13:59:22 gmann mriedem: melwitt can either of you approve this BP. i have rebased the patches and added stein BP link - https://blueprints.launchpad.net/nova/+spec/api-extensions-merge-stein
13:59:23 openstackgerrit xhzhf proposed openstack/nova master: VMware: add missing os types in vSphere sdk 6.5 https://review.openstack.org/591771
14:00:53 gmann tssurya: done, 3 more view builder left which i am working and push soon - https://review.openstack.org/#/q/topic:bp/api-extensions-merge-stein+(status:open+OR+status:merged)
14:00:59 mriedem gmann: done
14:01:04 gmann mriedem: thanks
14:07:44 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Remove the deprecated API extensions policies https://review.openstack.org/586872
14:08:48 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge extended availability zone response into server controller https://review.openstack.org/502859
14:09:06 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge config drive extension response into server controller https://review.openstack.org/584223
14:09:25 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge extended server attributes extension response https://review.openstack.org/584590
14:09:43 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge keypair extension response into server view builder https://review.openstack.org/584748
14:10:03 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge server usage extension response into server view builder https://review.openstack.org/585262
14:18:09 mriedem dansmith: anything i should fast approve before going to bed?
14:18:28 dansmith mriedem: sounds like a recipe for disaster
14:18:42 dansmith but nothing that I know of this morning.. you got the revert backports I think
14:18:53 mriedem yup
14:18:57 dansmith I'll have this real backport up in a little while, but if you can look tomorrow I think that's fine
14:19:08 mriedem yeah i will
14:19:42 dansmith 祝你晚安
14:19:43 mriedem o/ then
14:20:03 mriedem ha
14:20:05 mriedem tai gui
14:20:11 dansmith g'nite
14:21:08 dansmith too expensive?
14:21:09 dansmith hmm
14:21:25 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge security groups extension response into server view builder https://review.openstack.org/585475
14:27:17 openstackgerrit Dan Smith proposed openstack/nova stable/queens: Wait for network-vif-plugged before starting live migration https://review.openstack.org/591735
14:27:18 openstackgerrit Dan Smith proposed openstack/nova stable/queens: DNM: Debug patch to test live migration waiting https://review.openstack.org/591775
14:28:27 mdbooth Eurgh
14:30:06 openstack bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9)
14:30:06 openstackgerrit Matthew Booth proposed openstack/nova master: Add regression test for bug 1550919 https://review.openstack.org/591733
14:30:07 openstackgerrit Matthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846
14:30:07 openstackgerrit Matthew Booth proposed openstack/nova master: Py3 fix in fake image service https://review.openstack.org/592056
14:31:05 mdbooth melwitt: ^^^ No refactor, change is confined to libvirt driver, no need to look at task state :)
14:32:59 mdbooth Grr, I forgot to re-run pep8 after fixing tests :/
14:34:08 openstackgerrit Matthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846
14:39:15 efried jaypipes: Would you please cast your eye upon https://review.openstack.org/#/c/468560/ when you get a chance? update_provider_tree for PowerVM driver.
14:47:46 openstackgerrit Eric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927
14:47:47 openstackgerrit Eric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033
14:47:48 openstackgerrit Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane https://review.openstack.org/584598
14:47:49 openstackgerrit Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599
14:47:50 openstackgerrit Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648
14:47:51 openstackgerrit Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034
14:47:52 openstackgerrit Eric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049
14:47:53 openstackgerrit Eric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees https://review.openstack.org/576236
14:47:54 openstackgerrit Eric Fried proposed openstack/nova master: [placement] Regex consts for placement schema https://review.openstack.org/591863
14:54:53 sapd1 melwitt: I would like to develop this feature (https://review.openstack.org/#/c/139910/) How can I start? Because I would like to use SR-IOV with Octavia.
14:55:44 sean-k-mooney sapd1: specifcally you wish to enale sriov atach/detach
14:56:00 sapd1 In Octavia flow, Port in VIP Network was created after instance launched, If I use SR-IOV Network for VIP Network, I can't attach VIP Port.
14:56:28 sapd1 sean-k-mooney: Yep. I wish
14:56:34 sean-k-mooney sapd1: by sriov network you mean sriov port
14:57:07 sean-k-mooney our rather vnic_type=dircet,macvtap or drict-phyical
14:57:40 sean-k-mooney sapd1: the first thing you would need to do is repropose the spec for stien
14:58:01 sapd1 sean-k-mooney: yes. Because in this flow (https://github.com/openstack/octavia/blob/master/octavia/network/drivers/neutron/allowed_address_pairs.py#L87)
14:58:19 openstack bug 1550919 in OpenStack Compute (nova) "[Libvirt]Evacuate fail may cause disk image be deleted" [Medium,In progress] https://launchpad.net/bugs/1550919 - Assigned to Matthew Booth (mbooth-9)
14:58:19 openstackgerrit Matthew Booth proposed openstack/nova master: Add regression test for bug 1550919 https://review.openstack.org/591733
14:58:20 openstackgerrit Matthew Booth proposed openstack/nova master: Don't delete disks on shared storage during evacuate https://review.openstack.org/578846
14:58:20 openstackgerrit Matthew Booth proposed openstack/nova master: Py3 fix in fake image service https://review.openstack.org/592056
14:59:01 sapd1 octavia-lb-vrrp port is created and attached to amphora instance after instance is created.
15:00:23 sean-k-mooney sapd1: right. so im personally ok with adding attach/detach for sriov interfaces but are you aware that the process is more complicated now then it was in newton
15:01:34 sean-k-mooney one of the hopes for stien is that we would start tracking VFs in placement, so you would have to update the instance allocation in placement
15:02:16 sean-k-mooney addtionaly assuming the vm is on a host that has an available VF attached to the correct physnet
15:02:46 sapd1 sean-k-mooney: yep. It's more complicated with me
15:03:20 sean-k-mooney the vm may or may not have enough pci slots available for the VF to be attached. this also changes depending on if the vm is using the qemu Q35 chipset in the libvirt driver case
15:04:15 efried sapd1: keep an eye on https://review.openstack.org/#/c/591898/ -- I'm hoping this evolves to make SRIOV hot (un)plug based on a driver capability, but either way you'll need to work with it to do your support.
15:05:41 sean-k-mooney efried: we used to hard fail in old releases for sriov attach
15:05:56 sean-k-mooney efried: do you know if the current attach api call is blocking
15:06:10 efried sean-k-mooney: According to that patch, which *adds* a hard fail...
15:07:24 sean-k-mooney efried: we used to have an api check at some point before this
15:07:46 sapd1 sean-k-mooney: yep. I think we have to check number of pci slots available when attach.
15:08:35 sean-k-mooney sapd1: yes my concern with that is is attach blocking or async
15:09:39 sean-k-mooney sapd1: if its a blocking call that means the api must wait for the hyperviror to try to attach the interface to the guest before returning assuming a device is available to attach
15:09:59 tssurya gmann: thanks a ton!
15:10:37 sean-k-mooney sapd1: well that is it would have to wait if we wanted to comunicate a good error message as to why the attach failed
15:11:05 sapd1 sean-k-mooney: So we have to save number of pci slots available in database like CPU and ram. as you said, in placement database
15:11:43 sapd1 then when attach port, we have to check in database.
15:11:46 sean-k-mooney sapd1: that is virtdriver specific. we cannot track that in placement
15:12:22 sean-k-mooney sapd1: we may be able to recored that in the nova db but im not sure it would apply to all drivers
15:13:03 sapd1 sean-k-mooney: But I don't know how to push profile of sriov port from nova-api to nova-compute
15:13:19 jaypipes efried: done
15:13:36 sean-k-mooney sapd1: profile?
15:13:59 sean-k-mooney sapd1: as in vif:binding_profile?
15:14:11 sapd1 sean-k-mooney: http://paste.openstack.org/show/726723/
15:14:41 sapd1 I saw the profile of the port is not updated
15:15:39 sean-k-mooney ya that is because we dont generate it in the api on attach.
15:16:07 sean-k-mooney sapd1: you wil not be able to set that value form neutron or nova apis
15:16:53 sapd1 sean-k-mooney: how can I generate it?
15:17:03 sean-k-mooney sapd1: normally that is set by the virt_driver on the compute node during instace spawn when it does a port bind
15:17:20 sean-k-mooney sapd1: the virt driver is the only thing that can generate it
15:18:36 sapd1 sean-k-mooney: I think so, But in this (https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py#L70)
15:19:13 sapd1 nova notify port update to neutron, but port has not profile (pci_slot) so It can't update port
15:19:17 sean-k-mooney you cannot set this in neutron. neuton does not know what hypervior th vm is booting on

Earlier   Later