Earlier  
Posted Nick Remark
#openstack-nova - 2018-08-13
19:14:34 openstackgerrit Eric Fried proposed openstack/nova master: DNM: Remove blacklisted py3 xen tests https://review.openstack.org/591419
19:45:26 openstackgerrit Chris Dent proposed openstack/nova master: DNM: Add placement perf info gathering to end of nova-next https://review.openstack.org/591367
20:14:42 openstackgerrit melanie witt proposed openstack/nova master: Add functional test for affinity with multiple cells https://review.openstack.org/585073
20:14:43 openstackgerrit melanie witt proposed openstack/nova master: Make scheduler.utils.setup_instance_group query all cells https://review.openstack.org/540258
20:25:57 openstackgerrit Eric Fried proposed openstack/nova master: Improve debug logs for GET /allocation_candidates https://review.openstack.org/591510
#openstack-nova - 2018-08-14
00:33:51 mriedem o/
00:40:39 Kevin_Zheng too early
00:45:30 Kevin_Zheng mriedem, got something interesting, as we can provide metadata with this API, https://developer.openstack.org/api-ref/compute/#create-image-createimage-action it might override the system generated metadata: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2877
00:45:58 Kevin_Zheng and we did it again in https://github.com/openstack/nova/blob/master/nova/compute/api.py#L2911
00:46:19 Kevin_Zheng seems redundant, and should we limit the key?
00:46:45 Kevin_Zheng like don't allow set user_id
00:46:58 Kevin_Zheng image_type
00:47:00 mriedem my network needs to catch up...
00:47:28 Kevin_Zheng OK
00:55:22 mriedem Kevin_Zheng: hmm, yeah, not sure
00:55:42 mriedem looks like this could be used to change the owner of the snapshot to another user
00:56:51 Kevin_Zheng yeah
00:57:18 Kevin_Zheng Yeah
00:57:33 Kevin_Zheng And the uuid might not be important
00:57:45 Kevin_Zheng Instance uuid
01:01:13 mriedem i would think if this were a major issue, someone would have reported/fixed it by now after 10 years
01:04:58 Kevin_Zheng mriedem, got it
01:47:58 mriedem1 blarg!
02:05:11 mriedem1 are we waiting for anything on this? https://review.openstack.org/#/c/590445/ it's marked for RC2
02:05:17 mriedem1 but hasn't yet been merged on master
02:09:09 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Fix service list for disabled compute using MC driver https://review.openstack.org/583936
02:43:39 takashin
03:03:04 naichuans mriedem: Hi, Matt, because Rocky feather has been freezed while bp: vgpu_rocky hasn't finished, I reprose a new bp here: https://blueprints.launchpad.net/nova/+spec/vgpu-stein. Please check if it is OK. Thank you very much.
03:05:50 openstackgerrit liuyamin proposed openstack/python-novaclient master: Replace os-client-config to openstacksdk https://review.openstack.org/590141
03:40:05 mriedem naichuans: ok, i guess we'll just obsolete the rocky bp since none of the changes merged
04:04:55 naichuans mriedem: Got it, thanks
05:45:08 openstackgerrit Matt Riedemann proposed openstack/nova master: Delete instance_id_mappings record in instance_destroy https://review.openstack.org/591558
05:46:06 mriedem Kevin_Zheng: yikun: bingo ^
05:57:55 mriedem do you guys use pypi mirrors in china? otherwise tox times out
06:00:25 Kevin_Zheng Hmm, it should automatically connect to the fastest one, no?
06:04:49 fanzhang mriedem Kevin_Zheng I am using index-url = https://pypi.tuna.tsinghua.edu.cn/simple ;-)
06:15:42 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Fix service list for disabled compute using MC driver https://review.openstack.org/583936
06:21:49 Kevin_Zheng fanzhang Are you doing it in Linux or windows
06:22:37 fanzhang Kevin_Zheng Linux and MacOS
06:24:11 Kevin_Zheng Thanks, we will try latter
06:24:45 fanzhang np
07:20:55 gibi mriedem: hi! I'm not planning to have a notification meeting also I assume your timezone is not friendly for that meeting
07:39:56 sean-k-mooney mriedem: o/ i have been doing some livemigration testing between different backends and different OSs and have been finding issues. im going to keep refining my testing but while it is posible to move the vms i dont think its working correctly
07:41:10 sean-k-mooney mriedem: live migration from cetos to ubuntu is broken. that used to work but the emltor path is nolonger the same and we use the emulator path of the src for the dest when checnking compatablity
07:41:50 sean-k-mooney live migration from lb to ovs appears to work but ovs to lb times out waiting for the plug event
07:41:55 sean-k-mooney from neutron
07:42:52 sean-k-mooney im going to add a few more nodes to my testing to confirm all the behavior. ill send an email to the list with a summary when done
08:01:02 gryf sean-k-mooney, I've answered your review.
08:01:10 gryf erm. comments.
08:02:19 ygk_12345 hi all
08:02:47 gryf johnthetubaguy, could you please also look at https://review.openstack.org/#/c/536351 ?
08:03:05 ygk_12345 what does negative number indicate for RAM in hypervisor stats ?
08:03:34 ygk_12345 does it mean no more memory available for vms on the computes ?
08:15:20 sean-k-mooney gryf: thanks, you are correct that the disk filter is deprcated rather than removed.
08:17:32 sean-k-mooney the disk fileter is calulating the avialble space its self form the host_state.free_diks_mb and host_state.total_usable_disk_gb
08:18:56 sean-k-mooney i am not sure how host_state.total_usable_disk_gb is related to the migrtion_data disk available_gb
08:19:16 sean-k-mooney they apepar to be independent
08:21:18 mriedem gibi: yeah i won't be around for the notification meeting
08:21:31 sean-k-mooney ygk_12345: it means that the total memory used is grater than total ram - reserved ram
08:21:33 gibi mriedem: no problem
08:22:05 mriedem sean-k-mooney: ok i think lb plug events is a known issue isn't it?
08:22:14 ygk_12345 sean-k-mooney: also I am getting warnings in the nova logs that enough memory cant be allocated . what does this mean ?
08:24:27 sean-k-mooney mriedem: well live migration between 2 lb nodes seams to work. i thikn libvirt is using the souce xml without the updated network interfaces in the ovs case and that is breaking things. i have not really had time to dig into it yet
08:24:50 sean-k-mooney ygk_12345: can you post the error message to paste.openstack.org
08:26:03 sean-k-mooney ygk_12345: also on the node with the error can you tell me how much ram do you have, what is the reseved memory set in the config and how much is used by instance on that node?
08:39:49 mriedem dims: http://docs.sqlalchemy.org/en/latest/core/metadata.html?highlight=class%20column#sqlalchemy.schema.Column.params.onupdate
08:41:12 mriedem e.g. Column('last_modified', DateTime, onupdate=func.utc_timestamp())
08:58:54 sean-k-mooney mdbooth: regarding https://review.openstack.org/#/c/536351 can you confirm that this is never used in the disk filter. looking at https://github.com/openstack/nova/blob/master/nova/scheduler/filters/disk_filter.py#L38-L59 we appear to purely calulate the availe disk from the host_state
09:01:34 mdbooth sean-k-mooney: Don't they have the same source?
09:02:02 sean-k-mooney mdbooth: i can not find any use of the migrate_data.disk_available_mb in the condoctor before the downcall to the compute
09:03:01 sean-k-mooney mdbooth: which the host_state object and where we are constuction the migration data
09:03:52 mdbooth sean-k-mooney: Can you restate your original question. Can I confirm that *what*? is never used...
09:04:45 sean-k-mooney mdbooth: so looking at https://review.openstack.org/#/c/536351/3/nova/virt/libvirt/driver.py the migrate_data object constructed in this fuction is not used before the downcall to the compute node.
09:05:38 sean-k-mooney but there is also a comment about this change relating to the disk filter however the disk filter appears to calulate the availabel disk space independly via the info in the host state object
09:06:44 sean-k-mooney so im trying to figure out at what point is the value store in the migarte_data.disk_available_mb actully used
09:12:27 mdbooth sean-k-mooney: It's used in check_can_live_migrate_source
09:12:48 mdbooth But only if disk_over_commit is set
09:13:18 gryf its verified in _assert_dest_node_has_enough_disk method and only for block_migration
09:15:51 sean-k-mooney mdbooth: where is mdbooth gryf i am not seeing either of those methods in the condoctor live_migrate.py are they performed on the compute node via rpc
09:16:25 mdbooth iirc check_can_live_migrate_source is called from check_can_live_migrate_dest
09:16:26 gryf sean-k-mooney, they are performed in driver
09:16:39 mdbooth Nah, they're called from compute manager
09:16:46 gryf and called from compute manager
09:16:48 mdbooth The code's in the driver
09:16:49 gryf yeah
09:17:54 mdbooth Oh, _dest is called from conductor
09:18:04 gryf compute.manager.check_can_live_migrate_destination
09:18:16 mdbooth Which then calls _source
09:19:15 openstackgerrit Merged openstack/nova master: placement: ignore policy scope check failures if not enforcing scope https://review.openstack.org/590445
09:20:33 openstackgerrit Chris Dent proposed openstack/nova master: DNM: Add placement perf info gathering to end of nova-next https://review.openstack.org/591367
09:21:10 mriedem mdbooth: https://docs.openstack.org/nova/latest/reference/live-migration.html :)
09:21:53 mdbooth mriedem: It's so simple they even drew a picture about it.
09:22:52 sean-k-mooney mdbooth: gryf so yes looking at https://github.com/openstack/nova/blob/0502b0ffaf20ef3735e633715ba0f9dda976cb7a/nova/virt/libvirt/driver.py#L6774
09:23:17 sean-k-mooney i do not see the disk allocation ratio being used in that check
09:24:36 sean-k-mooney so would that not imply we have to take account of it when we first calulate disk_avaiable_mb
09:25:03 mdbooth sean-k-mooney: So this code isn't related to DiskFilter
09:25:07 gryf sean-k-mooney, possibly, but that's another thing, isn't it?
09:25:19 sean-k-mooney mdbooth: yes i know
09:26:02 sean-k-mooney gryf: well the bug is fixing how we calulate the available diskspace. if it does so by not allowing over allocation of disk when its turned on that jsut creates another bug
09:26:33 gryf hm.

Earlier   Later