| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-08-02 | |||
| 16:59:18 | mriedem | ooo server group metadata | |
| 16:59:22 | mriedem | good thing we just nuked that from the api in rocky | |
| 17:00:04 | mriedem | anyone know of a way to make github just load all diffs? because it simply gave up here | |
| 17:00:38 | cfriesen | mriedem: heh. the only thing we use it for is "max number of servers in group", and a "best effort" flag that pre-existed the "soft" affinity policies. | |
| 17:01:18 | mriedem | i guess rather than crawl through github it's probably easiest to just clone this repo and look for "WRS" ? | |
| 17:03:15 | cfriesen | looking for WRS will get you a lot of stuff. also look for files with wrs in the name | |
| 17:04:06 | sean-k-mooney | mriedem: all the changes are squashed into one big commit on top of what was master when it was created | |
| 17:04:37 | mriedem | sean-k-mooney: yes, i'm intimately familiar | |
| 17:05:22 | sean-k-mooney | i made a list of randome stuff to look at later in that repo but left it at intel when i left | |
| 17:07:58 | cfriesen | mriedem: technically speaking one of the things I liked was the ability to dynamically shift host CPUs between being used for "pinned" instances and "shared" instances on the same node. That was also the rationale for the floating-point representation of "used cpus" on the host. | |
| 17:20:41 | sean-k-mooney | cfriesen: yes... that is interesting | |
| 17:21:16 | sean-k-mooney | cfriesen: yes re pinned all the floating instances on the host to make that work if i recall | |
| 17:22:16 | mriedem | today ops just use host aggregates to separate hosts/flavors that do cpu pinning and hosts with cpu overcommit yeah? | |
| 17:22:19 | sean-k-mooney | cfriesen: im not sure liked is the workd i would have chosen but the capablit is certenly interesting. | |
| 17:22:46 | sean-k-mooney | mriedem: mostly yes | |
| 17:23:16 | sean-k-mooney | that is more of a cludge to workaround the fact nova does not do it magically for them rather then they like it | |
| 17:24:43 | cfriesen | mriedem: the issue was that we have demand for small installs (down to one or two nodes in some cases) and so it's not practical to have to devote entire nodes to either shared or dedicated instances | |
| 17:24:55 | sean-k-mooney | there were some specs covering having pininned and shared cores on the same host this cycle. tesro and jay were talking about them in dublin. | |
| 17:25:23 | cfriesen | sean-k-mooney: with the new specs you still have to specify up-front which cpus are for which purpose | |
| 17:25:51 | sean-k-mooney | cfriesen: right so you level them float but repin the floating vms wheever you spawn a new pinned vm | |
| 17:26:04 | sean-k-mooney | *let them float | |
| 17:27:16 | cfriesen | sean-k-mooney: sort of. the floating tasks are in a cpuset on the host, and we re-pin the cpuset (to avoid looping over all floating instances) | |
| 17:27:24 | cfriesen | but logically it's equivalent | |
| 17:27:25 | sean-k-mooney | any yes i realise you have to specify up front. with the approch ye took ye still set a minium amount of cores that could be used for the non pinned host right? or did you calulate it based on the oversubsction ratio | |
| 17:27:44 | cfriesen | sean-k-mooney: allocation ratio | |
| 17:28:14 | jaypipes | sean-k-mooney: what's pininned cores? :P | |
| 17:28:29 | mriedem | cfriesen: yeah i figured that was the reason | |
| 17:28:34 | mriedem | 2 node edge site | |
| 17:28:37 | sean-k-mooney | jaypipes: its my getting used to my keyboard :) | |
| 17:28:37 | mriedem | or whatever 'grouse' is | |
| 17:28:41 | jaypipes | :) | |
| 17:28:49 | jaypipes | switched to dvorak? | |
| 17:28:52 | mriedem | cfriesen: grouse install is what, single node? | |
| 17:29:43 | sean-k-mooney | ha no i have a corsair mechanical keyboard that i bought like a year ago but i used to the crappy membrane keyboard i used to use at work | |
| 17:30:24 | sean-k-mooney | i can type way faster now but also im makeing some mistakes i didnt before so hopefully in a week or so i will be used to it | |
| 17:31:30 | cfriesen | mriedem: those names are all newly-invented, have to go look | |
| 17:31:55 | cfriesen | but we support single-node, duplex single-node, and multi-node with two controller nodes | |
| 17:32:22 | mriedem | it goes grouse, something something, and then something with an R in the name | |
| 17:32:25 | mriedem | canadian mountain ranges | |
| 17:32:51 | cfriesen | robson, I think. Pretty much invented right before the summit. :) | |
| 17:33:40 | mriedem | https://youtu.be/Z1DN41WnRkc?t=560 | |
| 17:33:45 | mriedem | grouse, whistler, robson | |
| 17:34:31 | cfriesen | there we go. the two-controller case uses replicated storage for improved availability | |
| 17:36:51 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Remove old check_attach version check in API https://review.openstack.org/588348 | |
| 17:38:48 | openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Debug log per granular request group https://review.openstack.org/588350 | |
| 17:43:58 | sean-k-mooney | cfriesen: ya 3 dedicated contoler nodes is major overkill in many cases but alot of people still default to it | |
| 17:44:49 | openstackgerrit | Merged openstack/nova master: Remove unused stubbing function from test https://review.openstack.org/586968 | |
| 17:44:59 | openstackgerrit | Merged openstack/nova master: Improve NeutronFixture and remove unncessary stubbing https://review.openstack.org/587412 | |
| 17:57:57 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP/PoC: safe_connect shouldn't hide failures https://review.openstack.org/584593 | |
| 18:20:48 | mnaser | so i noticed that | |
| 18:20:49 | mnaser | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/volume/volume.py#L62-L79 | |
| 18:20:52 | mnaser | and | |
| 18:20:54 | mnaser | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/imagebackend.py#L168-L176 | |
| 18:21:02 | mnaser | is pretty much the same thing repeated | |
| 18:21:28 | mnaser | one does it for volumes, the other does it for 'imagebackend' aka nova "images" | |
| 18:22:10 | mnaser | would moving the method to nova.virt.libvirt.utils make sense? | |
| 18:23:24 | mnaser | or maybe moving it into a function inside LibvirtConfigGuestDisk ? | |
| 18:27:00 | melwitt | maybe. if you think there's a common utility method both could use | |
| 18:27:31 | melwitt | they look similar but not sure if they're doing the exact same thing | |
| 18:28:34 | mnaser | melwitt: they're pretty much both setting quotas, one handles the quotas that are extra_specs in flavor, the other one handles setting quotas that are from nova volumes | |
| 18:39:12 | melwitt | mnaser: I see. yeah, I dunno where the common method should go. utils seems like the place, as for LibvirtConfigGuestDisk I'd ask lyarwood or mdbooth (they are EU time zone) | |
| 18:45:16 | mriedem | cfriesen: there wasn't any upstream equivalent for this per-instance live migration max downtime feature was there? i know about https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/live-migration-per-instance-timeout.html but that's for per-instance live migration timeout which is different. | |
| 18:53:51 | openstackgerrit | Eric Fried proposed openstack/nova master: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | |
| 18:53:52 | openstackgerrit | Eric Fried proposed openstack/nova master: reshaper: Look up provider if not in inventories https://review.openstack.org/585033 | |
| 18:53:53 | openstackgerrit | Eric Fried proposed openstack/nova master: Make get_allocations_for_resource_provider sane https://review.openstack.org/584598 | |
| 18:53:54 | openstackgerrit | Eric Fried proposed openstack/nova master: Report client: Real get_allocs_for_consumer https://review.openstack.org/584599 | |
| 18:53:55 | openstackgerrit | Eric Fried proposed openstack/nova master: Report client: get_allocations_for_provider_tree https://review.openstack.org/584648 | |
| 18:53:56 | openstackgerrit | Eric Fried proposed openstack/nova master: Report client: _reshape helper, placement min bump https://review.openstack.org/585034 | |
| 18:53:57 | openstackgerrit | Eric Fried proposed openstack/nova master: Report client: update_from_provider_tree w/reshape https://review.openstack.org/585049 | |
| 18:53:58 | openstackgerrit | Eric Fried proposed openstack/nova master: Compute: Handle reshaped provider trees https://review.openstack.org/576236 | |
| 18:53:59 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: only _init_compute_node on startup https://review.openstack.org/588094 | |
| 18:54:33 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP: Remove redundant _update()s https://review.openstack.org/588091 | |
| 19:03:39 | openstackgerrit | Merged openstack/nova master: Wait for vif plugging during live migration job https://review.openstack.org/578551 | |
| 19:03:48 | openstackgerrit | Merged openstack/nova master: Stop setting glance_api_version in cinder.conf in nova-live-migration https://review.openstack.org/579871 | |
| 19:03:55 | openstackgerrit | Merged openstack/nova master: doc: fix resize user guide link https://review.openstack.org/588097 | |
| 19:06:34 | openstackgerrit | Merged openstack/nova master: Hyper-V + OVS: plug vifs before starting VMs https://review.openstack.org/585661 | |
| 19:06:43 | openstackgerrit | Merged openstack/nova master: Complete the api-ref of security group rule https://review.openstack.org/580109 | |
| 19:31:36 | openstackgerrit | Eric Fried proposed openstack/nova master: Grease test_try_deallocate_network_retry_direct https://review.openstack.org/588364 | |
| 19:51:43 | cfriesen | mriedem: was having lunch. I don't think there's any upstream equivalent. I think that was added for existing pets that were created using flavor with too small of a max-downtime. I seem to recall discussing it upstream, but the concensus was that it would make more sense to add it as a parameter to the live-migration call. | |
| 19:52:31 | mriedem | cfriesen: that was exactly my question - why put it on the flavor/image rather than just directly in the live migration api | |
| 19:52:55 | mriedem | i guess because bigger flavors/images could need more downtime? | |
| 19:53:42 | cfriesen | mriedem: it was less code to do it this way, and no on-the-wire API change | |
| 19:54:01 | cfriesen | mriedem: it'd be cleaner as part of the migration request | |
| 19:54:10 | mriedem | well, there are plenty of "if wrs-header: do extra stuff" | |
| 19:54:30 | mriedem | but yeah, input validation on the api schema i guess | |
| 19:54:31 | mriedem | nixes that | |
| 19:54:44 | mriedem | also, all of this cpu cache stuff... | |
| 19:54:48 | mriedem | i can't wrap my head around this | |
| 19:55:21 | openstackgerrit | Merged openstack/nova master: Fix all invalid obj_make_compatible test case https://review.openstack.org/574240 | |
| 19:55:58 | cfriesen | mriedem: the live migration stuff came out of a live customer issue, as I recall they wanted a quick fix that was backportable to an earlier release. | |
| 19:56:17 | cfriesen | The CPU cache stuff...I think that's the Intel CAT stuff. | |
| 19:56:58 | cfriesen | equivalent to this: https://blueprints.launchpad.net/nova/+spec/cat-support | |
| 19:59:32 | mriedem | ok, not much in there - no spec proposed it looks like | |
| 20:02:30 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Scrub hw:cpu_model from API samples https://review.openstack.org/588371 | |
| 20:03:39 | mriedem | sw:wrs:srv_grp_messaging huh | |
| 20:06:45 | cfriesen | you can probably ignore the server group messaging stuff...it's probably getting removed | |
| 20:06:52 | mriedem | jesus, ok, so servers within the same group can send messages to each other through a channel on the host? | |
| 20:07:14 | cfriesen | yeah, the idea was to have a low-bandwidth really easy way to message other serves in the group | |
| 20:07:26 | openstackgerrit | Eric Fried proposed openstack/nova master: WIP/PoC: safe_connect shouldn't hide failures https://review.openstack.org/584593 | |
| 20:07:29 | cfriesen | ended up being more hassle than it was worth | |