| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-08-02 | |||
| 10:43:30 | stephenfin | 9-5, baby | |
| 10:44:04 | cdent | stephenfin: we should all be a bit more like you | |
| 10:44:28 | sean-k-mooney | stephenfin: 9 pm to 5 am i could do that :) | |
| 10:46:29 | sean-k-mooney | cdent: yours is much more like mine http://stackalytics.com/report/users/cdent | |
| 10:46:55 | cdent | it's a job, not an adventure | |
| 10:48:23 | openstackgerrit | Chen proposed openstack/nova master: Make nova-manage db archive_delete_rows take --all-cells https://review.openstack.org/587858 | |
| 10:49:21 | sean-k-mooney | the problem is when tech is also a hobby. at least you seam to front load most of you work between 11-5 and trail off when you should be home relaxing | |
| 10:49:31 | stephenfin | cdent, sean-k-mooney: I've no idea how people work any differently. It's only way I can make sure I consistently go to the gym, eat decent food, socialize etc. | |
| 10:49:50 | stephenfin | It's doubly impressive when those people have families that surely take a good chunk of their time/attention | |
| 10:50:27 | sean-k-mooney | stephenfin: hehe you assume i go to a gym and socialize. silly person :P | |
| 10:50:29 | cdent | stephenfin: well there ya go: I don't go to the gym, eat decent food, or socialize | |
| 10:50:42 | cdent | which is why I need to do better, I really need to do all those things | |
| 10:51:15 | stephenfin | sean-k-mooney: Heh, fair enough | |
| 10:51:25 | cdent | luckily my kids are all old, so they don't suffer my failings (at least not these) | |
| 10:51:47 | stephenfin | cdent: I think efried does it best. Not only does he go to a gym (of sorts) but he manages to run one | |
| 10:52:31 | stephenfin | cdent: Aye, I should have clarified with young families | |
| 10:52:35 | openstackgerrit | huanhongda proposed openstack/nova master: Destroy evacuated instance while unset nova-compute forced_down https://review.openstack.org/587807 | |
| 10:53:04 | stephenfin | cdent: Totally unrelated but maybe of note for you: it looks like Paste might be entering unmaintained territory https://bitbucket.org/ianb/paste/ Wonder if that's a concern? | |
| 10:54:07 | stephenfin | In particular, https://bitbucket.org/ianb/paste/pull-requests/41/ | |
| 10:54:24 | cdent | hmmm. yeah. | |
| 10:54:53 | cdent | Ideally we'd stop using paste and manage middleware differently, but that's not a change we could make overnight | |
| 10:55:13 | sean-k-mooney | i was going to ask what do we use it for? | |
| 10:56:00 | stephenfin | Indeed. I imagine we'll need to support Python 3.7 long before we could even think about dropping that. | |
| 10:56:24 | sean-k-mooney | is this what the api-past.ini files are for? | |
| 10:57:29 | cdent | sean-k-mooney: that's what paste (the lib) reads | |
| 10:57:39 | sean-k-mooney | oh we use it in the wsgi scripts. | |
| 10:57:41 | cdent | it configured the middlware stack in noav-api | |
| 10:58:35 | cdent | other projects use it too. placement intentionally chose not to use it because it intentionally doesn't have configurable middleware: you get what you're given | |
| 10:59:43 | sean-k-mooney | cdent: do we test reconfiguring the middelware in nova? | |
| 10:59:53 | cdent | I don't know | |
| 11:00:31 | stephenfin | cdent: I wonder if that risk should be mentioned to anyone, given that Python 3.7 is going to be a thing soon enough? | |
| 11:01:05 | stephenfin | I'm pretty sure someone could reach out to the author and offer to help maintain it (bugfixes and future Python support vs. actual new features), but I'm likely spread too thin to actually do it myself right now | |
| 11:02:02 | sean-k-mooney | stephenfin: well will it. i have not heard anyone seriously suggesting more the 3.6 support | |
| 11:02:18 | cdent | I'll bring it up with the TC crowd this afternoon. I also vaguely know Ian from way way back, so might be able to find something out from him | |
| 11:02:24 | sean-k-mooney | ubuntu 18.04 will be sticking with 3.6 as far as i know | |
| 11:02:31 | stephenfin | cdent: ack | |
| 11:02:33 | cdent | (when I say TC crowd I mostly mean doug) | |
| 11:02:42 | stephenfin | ack ack :) | |
| 11:11:47 | rabel | sean-k-mooney: thanks! | |
| 11:16:40 | gibi | stephenfin: +2 on the tox.ini fix | |
| 12:19:14 | openstack | Launchpad bug 1779845 in OpenStack Compute (nova) "hide_hypervisor_id doesn't hide hyperv signature for Windows VMs" [Undecided,In progress] - Assigned to Konstantinos Samaras-Tsakiris (kosamara) | |
| 12:19:14 | maciejjozefczyk | kosamara: hey, I can confirm that bug: https://bugs.launchpad.net/nova/+bug/1779845 | |
| 12:19:33 | maciejjozefczyk | kosamara: and in fact I just started to working on that point, but you were first ;) | |
| 12:34:34 | openstackgerrit | Merged openstack/nova master: Hook resource_tracker to remove stale node information https://review.openstack.org/587922 | |
| 12:37:34 | bauzas | network issues at home, folks | |
| 12:37:43 | bauzas | just in case you need me | |
| 12:37:46 | sean-k-mooney | maciejjozefczyk: glad to hear. that said strictly speaking it not a bug as you are using hardwar in a way the hardwar vendor explictly does not support and has taken measures to prevent | |
| 12:37:54 | sean-k-mooney | maciejjozefczyk: but i do think we should allow it | |
| 12:38:20 | bauzas | given we're in August and in France, can I hope my network issues to be fixed around Aug 29th ? | |
| 12:38:37 | sean-k-mooney | maciejjozefczyk: so really this is an RFE(request for enhancement) | |
| 12:45:43 | sean-k-mooney | why dos our suspend fucntion in the libvirt diriver not suspend the instance ... | |
| 12:50:37 | maciejjozefczyk | sean-k-mooney: yes, thats not a bug, but RFE. Anyway if we have support for spoofing hypervisor identification inside VM, we should be consistent in that point | |
| 12:50:40 | stephenfin | bauzas: Fancy sending this on its way? https://review.openstack.org/588207 | |
| 12:52:10 | stephenfin | gibi: ta! | |
| 12:52:12 | sean-k-mooney | maciejjozefczyk: we add that capablity sole to work for the usecase of running nvidia gpus in a guest via pci passthrough. it is not support on any other virt driver, but sure | |
| 12:52:43 | openstackgerrit | Eric Fried proposed openstack/nova master: doc: fix resize user guide link https://review.openstack.org/588097 | |
| 12:52:51 | gibi | stephenfin: there are two relatively small refactor that https://review.openstack.org/#/c/586968/ and https://review.openstack.org/#/c/587412/ if you have some time | |
| 12:53:05 | sean-k-mooney | maciejjozefczyk: that said if we were being consitent we would hide every feature observable withing the guest that implies you are in a vm not just the hypervior id. | |
| 12:53:05 | stephenfin | gibi: I'll hit those right now | |
| 12:53:40 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Remove unused stubbing function from test https://review.openstack.org/586968 | |
| 12:58:15 | stephenfin | gibi: Could you expand on your comment here? https://review.openstack.org/#/c/587412/3/nova/tests/functional/libvirt/test_numa_servers.py | |
| 12:58:26 | gibi | stephenfin: looking... | |
| 12:58:40 | stephenfin | i.e. why do we need to re-stub? | |
| 12:59:04 | maciejjozefczyk | sean-k-mooney: yes, anyway if we have usecase we should do this :) nvidia is good example | |
| 12:59:38 | gibi | stephenfin: _IntegratedTestBase base class already set up the generic NeutronFixture which means that nova.network.neutronv2.api.get_client is already stubbed by the NeutronFixture | |
| 12:59:40 | sean-k-mooney | maciejjozefczyk: not nessicarialy. but in this case it is not that invasive a cchange | |
| 13:00:02 | gibi | stephenfin: then L350 sets up another fixture NUMAAffinityNeutronFixture that will also stub nova.network.neutronv2.api.get_client | |
| 13:00:20 | gibi | stephenfin: this is OK as the second stub overrides what the first stub did | |
| 13:00:23 | stephenfin | gibi: ahhh, of course. I missed that we were using the other fixture | |
| 13:00:33 | stephenfin | Not like I wrote that code or anything :) | |
| 13:00:53 | gibi | stephenfin: I guess you had a good vacation at properly reset your brain :) | |
| 13:01:01 | gibi | s/at/that/ | |
| 13:01:06 | sean-k-mooney | maciejjozefczyk: for there binary direver it may or may not be complient with there EULA. for the linux opensource Nouveau driver its probaly fine | |
| 13:01:12 | stephenfin | gibi: Currently trying to remember what "Python" is | |
| 13:01:22 | stephenfin | :) | |
| 13:01:24 | gibi | :) | |
| 13:03:46 | stephenfin | gibi: One other comment (the second one here) https://review.openstack.org/#/c/587412/3/nova/tests/functional/libvirt/test_numa_servers.py | |
| 13:04:12 | stephenfin | sean-k-mooney: Off the top of your head, would calling os_vif.initialize() twice have any bad side effects? | |
| 13:04:33 | sean-k-mooney | stephenfin: no we specificaly check for that | |
| 13:04:57 | gibi | stephenfin: I can remove that os_vif.initialize() as that is already in the fake libivirt now | |
| 13:04:58 | sean-k-mooney | call it a 1000 times in a loop if you like it will only initalise once | |
| 13:05:25 | stephenfin | gibi: Meh, unless you want to, I'm happy to just +W as is. It's a nit | |
| 13:05:26 | sean-k-mooney | stephenfin: unless you pass reset=true | |
| 13:05:43 | stephenfin | sean-k-mooney: Excellent. It's just a clean up so | |
| 13:05:47 | gibi | stephenfin: I will respin it quickly | |
| 13:05:54 | stephenfin | gibi: ack | |
| 13:06:39 | sean-k-mooney | stephenfin: by the way if your remove os_vif.initialize from setup and dont call it at all your test will fail | |
| 13:08:21 | sean-k-mooney | stephenfin: i added it becuse your tests were failing because nova assumes (correctly) that os-vif is initalised when its using it and the code is written in such a way that it fails if its not | |
| 13:09:17 | sean-k-mooney | stephenfin: i put it in setup beacuse i dont know what order the test will be run in | |
| 13:09:37 | stephenfin | sean-k-mooney: Yup, I think is was you that pointed that out to me. It should be good now though because of https://review.openstack.org/#/c/587412/3/nova/tests/unit/virt/libvirt/fakelibvirt.py | |
| 13:09:50 | stephenfin | So it'll get initialized the same time the fake nova-compute service starts | |
| 13:10:11 | sean-k-mooney | oh sweet then ya you can remove it from setup | |
| 13:11:20 | openstack | Launchpad bug 1784353 in OpenStack Compute (nova) "Rescheduled boot from volume instances fail due to the premature removal of their attachments" [Medium,In progress] - Assigned to Lee Yarwood (lyarwood) | |
| 13:11:20 | mriedem | lyarwood: before i get too far into https://bugs.launchpad.net/nova/+bug/1784353 - we don't reschedule on a boot from volume failure | |
| 13:11:21 | sean-k-mooney | or not its a nit as you said. its not needed anymore but not enough for a respin on its own | |
| 13:11:59 | mriedem | lyarwood: or is this non-volume backed, so not really boot from volume, | |
| 13:12:06 | mriedem | just boot with volumes attached, but the root disk is on local storage | |
| 13:15:19 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Improve NeutronFixture and remove unncessary stubbing https://review.openstack.org/587412 | |
| 13:15:23 | gibi | stephenfin: ^^ | |
| 13:17:32 | stephenfin | gibi: and done | |