Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-08-01
22:00:25 openstack Launchpad bug 1784782 in OpenStack Compute (nova) "API: flavors - Cannot list all public and private flavors by default" [Undecided,New]
22:00:25 mriedem https://bugs.launchpad.net/nova/+bug/1784782 is news to me that you can pass GET /flavors?is_public=None as admin to list all flavors
22:02:11 sean-k-mooney mriedem: am ya that seams unintentional that is_public=None would have that effect
22:02:23 mriedem it was very intentional when it was added
22:02:52 sean-k-mooney mriedem: im confused is that ment to work or not?
22:03:08 mriedem https://review.openstack.org/#/c/32713/
22:03:32 mriedem https://review.openstack.org/#/c/27403/
22:03:58 mriedem our api-ref doesn't mention anything about this, just says is_public must be a boolean
22:04:04 sean-k-mooney huh ok i did not know that
22:04:09 mriedem me neither
22:04:31 sean-k-mooney im guessing there are no tests for this and we changed something recently
22:05:16 mriedem test_list_detail_flavors_with_is_public_filter_as_string_none
22:05:21 mriedem test_list_flavors_with_is_public_filter_as_string_none
22:05:30 mriedem i don't see any functional tests, but there are unit tests
22:06:22 sean-k-mooney also accourding to git blame nothing has changed in that fuction for 5 years
22:06:38 sean-k-mooney https://github.com/openstack/nova/blame/master/nova/api/openstack/compute/flavors.py#L89
22:07:54 sean-k-mooney i have a devstack deployment i did like 2 hours ago ill see if i can figure out how to test this with curl
22:08:28 mriedem create a private flavor,
22:08:32 mriedem get an admin token
22:08:41 mriedem curl /flavors?is_public='None'
22:12:19 sean-k-mooney that seams to work
22:12:33 sean-k-mooney ill post that to pastbin
22:12:38 openstackgerrit Eric Fried proposed openstack/nova master: WIP: Remove redundant _update()s https://review.openstack.org/588091
22:15:07 sean-k-mooney http://paste.openstack.org/show/727100/
22:15:32 sean-k-mooney i guss i should create some private flavor to see if they are missing one sec
22:16:43 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: fix GET /flavors?is_public description https://review.openstack.org/588092
22:19:56 sean-k-mooney mriedem: ya it still works http://paste.openstack.org/show/727101/
22:20:09 openstackgerrit Eric Fried proposed openstack/nova master: WIP: only _init_compute_node on startup https://review.openstack.org/588094
22:20:20 sean-k-mooney ill add that as a comment on the bug
22:20:39 mriedem sean-k-mooney: thanks
22:21:46 sean-k-mooney also if you can figure out how to get onto my network in the next hour there a free admin token for my devstack cloud lol
22:26:56 mriedem i'm already there,
22:27:07 mriedem checking out your kenny loggins fan directory
22:28:14 sean-k-mooney whey would i need a fan dir when youtube has danger zone on a 4 hour loop https://www.youtube.com/watch?v=K7dXpZCEKls&index=5&list=PLG2eb1MxWbfEQRhkJpzq0YeKOTyfpY3Db&t=0s
22:28:50 mriedem ha
22:29:00 mriedem don't forget about caddyshack
22:30:46 mriedem https://www.youtube.com/watch?v=U8SSdyflGN4 has that guy from the doobie brothers in it
22:30:53 mriedem twice the smoothness
22:30:58 sean-k-mooney mriedem: ah yes i have not seen that movie in like 2 decades
22:31:13 mriedem ^ is what i used to get pumped before all summit talks
22:32:26 sean-k-mooney :)
22:53:10 openstackgerrit Matt Riedemann proposed openstack/nova master: doc: fix resize user guide link https://review.openstack.org/588097
#openstack-nova - 2018-08-02
01:39:30 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Use common functions in granular fixture https://review.openstack.org/588113
02:01:03 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Use common functions in NonSharedStorageFixture https://review.openstack.org/588114
02:30:54 openstackgerrit Merged openstack/nova master: Make ResourceTracker.stats node-specific https://review.openstack.org/587636
03:13:00 openstackgerrit Vishakha Agarwal proposed openstack/nova master: 'Updated_at' is NULL when show aggregate info https://review.openstack.org/580271
06:26:11 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Fix a typo in comment in resource_provider.py https://review.openstack.org/588145
06:58:19 openstackgerrit huanhongda proposed openstack/nova master: Destroy evacuated instance while unset nova-compute forced_down https://review.openstack.org/587807
07:14:37 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Increase max_unit in placement test fixture https://review.openstack.org/588158
07:14:38 openstackgerrit Tetsuro Nakamura proposed openstack/nova master: Refactor AllocationFixture in placement test https://review.openstack.org/588159
07:58:39 jaosorior gibi: do unversioned notifications still work to date? or are they already being deprecated?
08:20:04 jaosorior or anybody that knows about notifications ^^
08:36:55 gibi jaosorior: hi! unversioned still works, not even deprecated yet
08:37:32 gibi jaosorior: we still have couple of unversioned notificatons that does not have versioned pair https://review.openstack.org/588097
08:37:42 gibi jaosorior: I mean http://burndown.peermore.com/nova-notification/
08:38:24 rabel hi there. i have a question regarding https://docs.openstack.org/nova/latest/_images/architecture.svg : is the api really communicating to neutron, glance and cinder? or is this done directly by the conductor?
10:32:42 sean-k-mooney rabel: nova used to have proxy apis for the other serveice. im not sure how many are still left but i think the proxy apis went direct to the other sevices
10:33:42 sean-k-mooney rabel: the conductor and compute agents also talk direct to neutron,glance cinder... as far as i know
10:36:02 stephenfin sean-k-mooney: You work the weirdest hours
10:36:04 stephenfin :)
10:36:33 openstackgerrit Merged openstack/nova master: Add note about reschedules and num_attempts in filter_properties https://review.openstack.org/582412
10:37:04 openstackgerrit Stephen Finucane proposed openstack/nova master: tox: Ensure reused envdirs share the same deps https://review.openstack.org/588207
10:37:17 stephenfin gibi: Fancy taking a look at that ^ I made a silly mistake :(
10:39:15 sean-k-mooney stephenfin: yes i do
10:40:22 sean-k-mooney stephenfin: anything in particalar more weird then usual
10:40:39 stephenfin sean-k-mooney: Nope. Just a general observation :)
10:41:42 sean-k-mooney stephenfin: what time zone am i in lol http://stackalytics.com/report/users/sean-k-mooney
10:42:53 sean-k-mooney stephenfin: our activity reporst are totally different http://stackalytics.com/report/users/stephenfinucane
10:43:25 stephenfin Hahaha
10:43:30 stephenfin 9-5, baby
10:44:04 cdent stephenfin: we should all be a bit more like you
10:44:28 sean-k-mooney stephenfin: 9 pm to 5 am i could do that :)
10:46:29 sean-k-mooney cdent: yours is much more like mine http://stackalytics.com/report/users/cdent
10:46:55 cdent it's a job, not an adventure
10:48:23 openstackgerrit Chen proposed openstack/nova master: Make nova-manage db archive_delete_rows take --all-cells https://review.openstack.org/587858
10:49:21 sean-k-mooney the problem is when tech is also a hobby. at least you seam to front load most of you work between 11-5 and trail off when you should be home relaxing
10:49:31 stephenfin cdent, sean-k-mooney: I've no idea how people work any differently. It's only way I can make sure I consistently go to the gym, eat decent food, socialize etc.
10:49:50 stephenfin It's doubly impressive when those people have families that surely take a good chunk of their time/attention
10:50:27 sean-k-mooney stephenfin: hehe you assume i go to a gym and socialize. silly person :P
10:50:29 cdent stephenfin: well there ya go: I don't go to the gym, eat decent food, or socialize
10:50:42 cdent which is why I need to do better, I really need to do all those things
10:51:15 stephenfin sean-k-mooney: Heh, fair enough
10:51:25 cdent luckily my kids are all old, so they don't suffer my failings (at least not these)
10:51:47 stephenfin cdent: I think efried does it best. Not only does he go to a gym (of sorts) but he manages to run one
10:52:31 stephenfin cdent: Aye, I should have clarified with young families
10:52:35 openstackgerrit huanhongda proposed openstack/nova master: Destroy evacuated instance while unset nova-compute forced_down https://review.openstack.org/587807
10:53:04 stephenfin cdent: Totally unrelated but maybe of note for you: it looks like Paste might be entering unmaintained territory https://bitbucket.org/ianb/paste/ Wonder if that's a concern?
10:54:07 stephenfin In particular, https://bitbucket.org/ianb/paste/pull-requests/41/
10:54:24 cdent hmmm. yeah.
10:54:53 cdent Ideally we'd stop using paste and manage middleware differently, but that's not a change we could make overnight
10:55:13 sean-k-mooney i was going to ask what do we use it for?
10:56:00 stephenfin Indeed. I imagine we'll need to support Python 3.7 long before we could even think about dropping that.
10:56:24 sean-k-mooney is this what the api-past.ini files are for?
10:57:29 cdent sean-k-mooney: that's what paste (the lib) reads
10:57:39 sean-k-mooney oh we use it in the wsgi scripts.
10:57:41 cdent it configured the middlware stack in noav-api
10:58:35 cdent other projects use it too. placement intentionally chose not to use it because it intentionally doesn't have configurable middleware: you get what you're given
10:59:43 sean-k-mooney cdent: do we test reconfiguring the middelware in nova?
10:59:53 cdent I don't know
11:00:31 stephenfin cdent: I wonder if that risk should be mentioned to anyone, given that Python 3.7 is going to be a thing soon enough?

Earlier   Later