| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-08-01 | |||
| 17:08:01 | mnaser | lol ^ | |
| 17:08:15 | mnaser | but yeah i have to solve the image thing first.. | |
| 17:08:45 | mnaser | i was thinking it would be nice if the drivers that are all in cinder got extracted to a seperate library | |
| 17:08:48 | mnaser | say moved to os-brick | |
| 17:08:55 | mnaser | and then nova and cinder could use the same drivers to interact with stuff | |
| 17:09:08 | openstackgerrit | Merged openstack/nova master: Cache is_bfv check in ResourceTracker https://review.openstack.org/584962 | |
| 17:15:38 | melwitt | mnaser: has that been proposed before? I would think it would be more complex than just loading a driver and calling the same methods no matter the driver on the nova side | |
| 17:16:15 | mnaser | melwitt: i dunno, it was just an idea. i'm sure there are a lot of complexities involved but it would greatly reduce the duplicate code across cinder and nova | |
| 17:18:25 | openstack | bug 1784705 in OpenStack Compute (nova) "ResourceTracker.stats can leak across multiple ironic nodes" [High,In progress] https://launchpad.net/bugs/1784705 - Assigned to Matt Riedemann (mriedem) | |
| 17:18:25 | openstackgerrit | Merged openstack/nova master: Add recreate test for RT.stats bug 1784705 https://review.openstack.org/587614 | |
| 17:19:15 | dansmith | mriedem: I'm going to rebase your fix with my thing on top since it's in merge conflict now | |
| 17:19:34 | mriedem | gdi | |
| 17:19:35 | mriedem | ok | |
| 17:19:38 | mriedem | was just working on backports | |
| 17:19:54 | mriedem | oh i suppose my other RT changes caused the merge conflict | |
| 17:20:53 | dansmith | from what? | |
| 17:20:58 | mriedem | https://review.openstack.org/584962 ? | |
| 17:21:12 | dansmith | oh yeah, that one for yours, | |
| 17:21:23 | dansmith | but something else removed the _for_node() bit | |
| 17:23:51 | openstack | bug 1784705 in OpenStack Compute (nova) "ResourceTracker.stats can leak across multiple ironic nodes" [High,In progress] https://launchpad.net/bugs/1784705 - Assigned to Matt Riedemann (mriedem) | |
| 17:23:51 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Add recreate test for RT.stats bug 1784705 https://review.openstack.org/587921 | |
| 17:38:17 | openstackgerrit | Dan Smith proposed openstack/nova master: Make ResourceTracker.stats node-specific https://review.openstack.org/587636 | |
| 17:38:18 | openstackgerrit | Dan Smith proposed openstack/nova master: Hook resource_tracker to remove stale node information https://review.openstack.org/587922 | |
| 18:45:02 | mriedem | dansmith: oopsydoodle https://review.openstack.org/#/c/587636/5 | |
| 18:45:28 | dansmith | did I do that? | |
| 18:45:32 | mriedem | yes urkle | |
| 18:45:40 | dansmith | I did? | |
| 18:45:57 | mriedem | https://review.openstack.org/#/c/587636/4..5/nova/compute/resource_tracker.py@1157 | |
| 18:45:59 | dansmith | hmm, I must have | |
| 18:46:19 | mriedem | you want to fix or me? | |
| 18:46:21 | dansmith | tha's mah bad | |
| 18:46:29 | dansmith | I have to fix unit tests on my top patch anyway | |
| 18:46:46 | dansmith | or, hmm, maybe that's the fail | |
| 18:46:54 | mriedem | i'm sure it is | |
| 18:47:28 | dansmith | I really don't think I resolved a conflict here, | |
| 18:47:33 | dansmith | but it looks like it would have so maybe I did | |
| 18:48:55 | dansmith | hey look'a the'r | |
| 18:49:07 | openstackgerrit | Dan Smith proposed openstack/nova master: Make ResourceTracker.stats node-specific https://review.openstack.org/587636 | |
| 18:49:08 | openstackgerrit | Dan Smith proposed openstack/nova master: Hook resource_tracker to remove stale node information https://review.openstack.org/587922 | |
| 18:49:54 | mriedem | lgtm | |
| 18:56:44 | mriedem | dansmith: one question in https://review.openstack.org/#/c/587922/ | |
| 18:59:02 | mriedem | i also wonder if it's worth backporting https://review.openstack.org/#/c/584204/ | |
| 18:59:23 | mriedem | it's a super latent issue and allocations in placement would still show root_gb usage for bfv instances in queens | |
| 18:59:25 | mriedem | so maybe not worth it | |
| 18:59:51 | dansmith | mriedem: answwered | |
| 19:00:02 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/queens: Make ResourceTracker.stats node-specific https://review.openstack.org/587976 | |
| 19:05:42 | sean-k-mooney | dansmith: remove_node is called within the update_available_resource perodic task. if we delete the hypervior form the compute then read it after the periodic task. are they running in seperate threads? | |
| 19:06:01 | sean-k-mooney | sorry that got messed up | |
| 19:06:30 | sean-k-mooney | do the periodic tasks run in a seperate full os thread form teh rest of the compute agent or a green thread | |
| 19:07:24 | dansmith | everything is a green thread | |
| 19:07:31 | dansmith | with the exception of the libvirt event feeder thread | |
| 19:08:18 | sean-k-mooney | oh ok then ya we are not doing any io in remvoe_node so we wont yield so we should not race | |
| 19:38:34 | melwitt | how do we specify a microversion to openstackclient? trying to use osc-placement and most of the abilities are in later microversions | |
| 19:40:30 | melwitt | I guess it wouldn't be documented by openstackclient because it doesn't officially support it, just passes through to novaclient | |
| 19:41:06 | openstack | bug 1784705 in OpenStack Compute (nova) queens "ResourceTracker.stats can leak across multiple ironic nodes" [High,In progress] https://launchpad.net/bugs/1784705 - Assigned to Matt Riedemann (mriedem) | |
| 19:41:06 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Add recreate test for RT.stats bug 1784705 https://review.openstack.org/588036 | |
| 19:41:07 | openstackgerrit | Matt Riedemann proposed openstack/nova stable/pike: Make ResourceTracker.stats node-specific https://review.openstack.org/588037 | |
| 19:41:15 | mriedem | melwitt: totally different | |
| 19:41:30 | mriedem | novaclient does version negotiation with the server on the cli to see which version to use, | |
| 19:41:37 | mriedem | and uses the max supported between the client and server for the CLI | |
| 19:41:48 | mriedem | osc requires that the user opt into the microversion per request | |
| 19:41:53 | mriedem | so, | |
| 19:42:02 | mriedem | openstack --os-compute-api-version 2.37 server create .... | |
| 19:42:11 | melwitt | right... but as far as what option to pass, I thought osc passes through any CLI option and one of those will tell novaclient | |
| 19:42:28 | mriedem | osc will create novaclient with the version specified yes, | |
| 19:42:37 | melwitt | just found that but it doesn't work for requesting a later placement API microversion? | |
| 19:42:39 | mriedem | because novaclient's python API bindings default to no microversion, so 2.1 | |
| 19:42:50 | mriedem | novaclient != placement... | |
| 19:42:58 | mriedem | there is no 2.1 in placement | |
| 19:43:00 | mriedem | there is 1.0 | |
| 19:43:08 | mriedem | osc-placement doesn't have anything to do with novaclient | |
| 19:43:26 | dansmith | the passthrough is of the version, | |
| 19:43:29 | dansmith | not the CLI opt | |
| 19:43:34 | dansmith | since osc is its own client | |
| 19:43:39 | melwitt | oh, right. so how do we do microversions with it? it's saying I can't 'resource class list' because 1.0 doesn't support it. but it's in the command list | |
| 19:43:53 | dansmith | there's an option to specify the version | |
| 19:44:18 | dansmith | --os-compute-api-version I think | |
| 19:44:26 | mriedem | openstack --os-placement-api-version 1.7 resource class list | |
| 19:44:30 | mriedem | something like that, | |
| 19:44:37 | mriedem | it's not 'compute' because it's not nova | |
| 19:44:39 | mriedem | in the service catalog | |
| 19:44:49 | mriedem | the --os-<service-type>-api-version is based on the service catalog | |
| 19:45:06 | mriedem | https://docs.openstack.org/osc-placement/latest/cli/index.html#resource-class-list | |
| 19:45:09 | mriedem | This command requires at least –os-placement-api-version 1.2. | |
| 19:45:19 | mriedem | so, openstack --os-placement-api-version 1.2 resource class list | |
| 19:45:37 | mriedem | if you know you're at some max version of placement, you could just set an env var | |
| 19:45:43 | mriedem | export OS_PLACEMENT_API_VERSION=1.7 | |
| 19:45:45 | dansmith | yeah, she said novaclient so I assumed she was hitting nova | |
| 19:45:49 | dansmith | but placement for placement obviously | |
| 19:45:49 | melwitt | thanks, I just couldn't find that option --os-placement-api-version anywhere | |
| 19:45:54 | melwitt | yeah, sorry | |
| 19:45:54 | mriedem | and then don't have to worry about per-call mv | |
| 19:46:08 | mriedem | melwitt: should be in the help output for the command | |
| 19:46:17 | mriedem | and https://docs.openstack.org/osc-placement/latest/user/index.html#microversion-usage | |
| 19:46:28 | melwitt | I got confused when I started thinking about passthrough of microversions when using osc | |
| 19:46:41 | melwitt | and it made me think of novaclient and the --os-compute-api-version thing | |
| 19:47:00 | mriedem | yeah, it would be the same if there was a python-placementclient thing | |
| 19:47:11 | mriedem | but we've intentionally always avoided that | |
| 19:47:15 | melwitt | ok yeah, I see now 'openstack resource class list -h' | |
| 19:47:29 | mriedem | b/c we have osc for cli and openstacksdk for sdk | |