| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-07-30 | |||
| 12:07:08 | kashyap | sean-k-mooney: Hmm, Zul was so quick? | |
| 12:07:50 | kashyap | Guess it's still running, isn't it? | |
| 12:07:56 | sean-k-mooney | kashyap: no but you can get the live logs from zuul.openstack.org | |
| 12:08:22 | sean-k-mooney | put 567258 into the filter | |
| 12:08:56 | sean-k-mooney | you can see the nova-live-migration sub job has completed so you can get to the logs | |
| 12:09:27 | sean-k-mooney | if the job is still running you can connect to a telnet stream of the console but that is less useful | |
| 12:12:24 | kashyap | sean-k-mooney: Got a URL of the live log? | |
| 12:12:32 | kashyap | Sorry for the sluggish responses, /me is shuffling b/n kitchen & IRC | |
| 12:12:55 | kashyap | sean-k-mooney: /me goes to put that ID in the filter | |
| 12:13:04 | kashyap | TIL | |
| 12:13:54 | sean-k-mooney | most people dont know you can do this with the gate but its been like this for years. module some minor refinement with zuul v3 | |
| 12:14:18 | sean-k-mooney | amy well here is a live log of your neutron-multinode subjob http://zuul.openstack.org/stream.html?uuid=6bc29a9c0ffb44339b36ee4b42b2b1b2&logfile=console.log | |
| 12:14:21 | kashyap | Yeah, I see the URL here: http://logs.openstack.org/58/567258/11/check/nova-live-migration/93ce085/ | |
| 12:14:55 | sean-k-mooney | kashyap: ya the migration subjob has finished so it has published everything to the normal log server | |
| 12:18:09 | openstackgerrit | Vieri proposed openstack/osc-placement master: Add image link in README.rst https://review.openstack.org/586839 | |
| 12:18:57 | kashyap | sean-k-mooney: Nod; thanks for the education | |
| 12:19:39 | kashyap | http://logs.openstack.org/58/567258/11/check/nova-live-migration/93ce085/logs/screen-n-cpu.txt.gz#_Jul_30_11_39_24_000563 | |
| 12:19:39 | kashyap | sean-k-mooney: Hmm, indeed, still the same TypeError | |
| 12:20:18 | sean-k-mooney | im currently trying to get a 2 node dev env up and running | |
| 12:21:04 | kashyap | Oh, you mean, you might be able to run the Tempest test locally? | |
| 12:21:05 | sean-k-mooney | when i get it stacked i can try and pull this down and see whats going on. i want to do some testing of the numa aware vswich code locally so i have to do a multinode deploy anyway | |
| 12:21:16 | sean-k-mooney | kashyap: ya i have the hardware to do that | |
| 12:21:30 | sean-k-mooney | just not the devstack cloud deployed | |
| 12:22:10 | kashyap | Most excellent, would be curious | |
| 12:24:07 | kashyap | Hmm, maybe something else is None | |
| 12:25:39 | kashyap | sean-k-mooney: Oh: 'migrate_disks' and 'migrate_uri' are None by default! | |
| 12:25:45 | sean-k-mooney | kashyap: there used to be an if check on mirate_uri also. | |
| 12:25:49 | sean-k-mooney | yes | |
| 12:26:31 | sean-k-mooney | i would be surprised if it was migrate_disk however as it is normally a list | |
| 12:27:08 | sean-k-mooney | the none type failure was expecting a sting so im guessing migrate_uri is more likely | |
| 12:28:41 | sean-k-mooney | we might want to add a debug line to print each of the values. | |
| 12:29:05 | kashyap | sean-k-mooney: I think that's pretty much it, actually. | |
| 12:29:18 | kashyap | To be consistent, I'll do this: | |
| 12:29:21 | kashyap | params = {} | |
| 12:29:22 | kashyap | if migrate_disks: | |
| 12:29:22 | kashyap | params['destination_xml'] = destination_xml | |
| 12:29:22 | kashyap | if destination_xml: | |
| 12:29:22 | kashyap | params['bandwidth'] = bandwidth | |
| 12:29:24 | kashyap | params['migrate_disks'] = migrate_disks | |
| 12:29:26 | kashyap | if migrate_uri: | |
| 12:29:29 | kashyap | params['migrate_uri'] = migrate_uri | |
| 12:29:46 | sean-k-mooney | ya that should work or at least help | |
| 12:30:13 | sean-k-mooney | im going to need to do an os reinstall on one of the nodes so it will be a while before i have a working env. | |
| 12:30:48 | sean-k-mooney | devstack is not the happist running on a node that had a failed tripple quickstart previously | |
| 12:31:26 | kashyap | No worries | |
| 12:33:09 | sean-k-mooney | if i do a virtual multi node i just do it on a kolla-ansible deployed openstack cloud. | |
| 12:38:02 | sean-k-mooney | kashyap: ya i use nested virt too i just prefer using an opensck cloud to create my openstack dev enviornments | |
| 12:50:11 | openstackgerrit | Chris Dent proposed openstack/nova master: DNM: Explore limiting resource tracker update https://review.openstack.org/587050 | |
| 12:53:47 | openstackgerrit | Merged openstack/nova master: Use vif.vif_name in _set_config_VIFGeneric https://review.openstack.org/571461 | |
| 12:53:56 | openstackgerrit | Merged openstack/nova master: tox: Silence psycopg2 warnings https://review.openstack.org/585352 | |
| 12:54:05 | openstackgerrit | Merged openstack/nova master: doc: link to CERN summit video about upgrading from cells v1 to v2 https://review.openstack.org/585044 | |
| 12:54:12 | openstackgerrit | Merged openstack/nova master: doc: link to AZ talk from the Rocky summit https://review.openstack.org/585045 | |
| 13:11:04 | openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: libvirt: Remove usage of migrateToURI{2} APIs https://review.openstack.org/567258 | |
| 13:42:30 | dansmith | stephenfin: are you back? | |
| 13:50:04 | openstackgerrit | Merged openstack/nova master: Add documentation for emulator threads policy https://review.openstack.org/579956 | |
| 13:51:50 | kashyap | dansmith: IIRC, he's still off til 01-Aug. | |
| 13:51:59 | dansmith | ugh okay | |
| 13:52:17 | dansmith | gibi: I replied here: https://review.openstack.org/#/c/585385/14 | |
| 13:52:51 | dansmith | gibi: if you're happy with that I'd sure like to get that landed since the previous patches were predicated on those tests, which we're currently lacking in tree | |
| 13:56:28 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add description for placement 1.26 https://review.openstack.org/587067 | |
| 13:59:26 | efried | Scheduler meeting in #openstack-meeting-alt | |
| 14:02:08 | kashyap | sean-k-mooney: Yay! Now the 'nova-live-migration' job succeeds! | |
| 14:02:13 | kashyap | sean-k-mooney: http://zuul.openstack.org/stream.html?uuid=0707146f416940f68506d5d994038158&logfile=console.log | |
| 14:02:49 | kashyap | sean-k-mooney: Hmm, actually I jumped the gun toon soon :P It's "almost" success, because it's still in blue. | |
| 14:04:01 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP compute: Recreate attachments during a reschedule https://review.openstack.org/587071 | |
| 14:04:37 | sean-k-mooney | kashyap: nice | |
| 14:05:04 | kashyap | Not quite, I want to see the green label there :-) | |
| 14:05:35 | sean-k-mooney | has well it will go green when it uploads the logs | |
| 14:05:49 | sean-k-mooney | that said it is still running some of the tests | |
| 14:06:05 | sean-k-mooney | they are passing now however so thats good | |
| 14:06:06 | kashyap | But the failing test succeeded, though: tempest.api.compute.admin.test_live_migration.LiveMigrationTest.test_live_block_migration | |
| 14:06:09 | kashyap | Yep | |
| 14:07:32 | gibi | dansmith: looking... | |
| 14:10:21 | gibi | dansmith: I've removed the L96 fake_network.set_stub_network_methods(self) and removed L506 fake_network.unset_stub_network_methods(self) and the test started failing. Based on the code the two removed calls are reverse of each other so I expected that if I remove both then the test result is the same | |
| 14:11:25 | dansmith | gibi: okay I thought you meant the unstubbing part specifically | |
| 14:11:36 | gibi | dansmith: I can push that change in a separate commit top of stephenfin's if that helps | |
| 14:12:42 | dansmith | well, I just don't want to end up without functional tests for this stuff, but I understand why you think this isn't working | |
| 14:12:48 | dansmith | so let me dig in a bit I guess | |
| 14:14:46 | gibi | dansmith: I'm affraid we are missing something as this functional test is pretty complex. | |
| 14:15:05 | dansmith | I understand | |
| 14:16:04 | gibi | dansmith: If we find nothing then I can accept to merge this as there are new tests that seems OK | |
| 14:17:17 | dansmith | gibi: your comment about L96.. is that new test using that? I don't think it calls _run_build_test() | |
| 14:17:35 | dansmith | because I thought these were stubbed way lower, which is why mriedem suggested just unstubbing in these couple new tests | |
| 14:18:03 | dansmith | I also thought that this was stubbing neutronapi methods, | |
| 14:18:17 | dansmith | but the fake_stub_network_methods() on L96 is stubbing out compute stuff | |
| 14:18:28 | dansmith | unset will unset any that have been stubbed | |
| 14:19:03 | gibi | dansmith: that could explain what I see. Let me dig in after the scheduler meeting | |
| 14:19:38 | gibi | dansmith: in general I think these tests should work with non stubbed neutronv2/api | |
| 14:19:58 | dansmith | gibi: I'm not sure how, we still have to return fake responses from neutron | |
| 14:20:25 | gibi | dansmith: yeah, that is the only thing that need to be faked | |
| 14:22:17 | dansmith | well, it's using the neutronfixture, which seems like the right thing to do... | |
| 14:23:52 | dansmith | ah | |
| 14:23:55 | dansmith | gibi: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py#L79-L79 | |
| 14:24:02 | dansmith | that is the test this inherits from, which stubs things out | |
| 14:24:25 | dansmith | I think if we don't unstub them we don't call into our neutron fixture to return the augmented nw_info, which is why we don't see the new stuff unless we unstub | |
| 14:24:48 | dansmith | so NUMAServersTestWithNetworks->NUMAServersTestBase->ServersTestBase->the stubbing | |
| 14:25:40 | gibi | dansmith: OK, then my expectation is that if I move the unstub to the NUMAServersTestBase.setup() then everything should pass | |
| 14:26:18 | dansmith | do you mean NUMAServersWithNetworksTest? | |
| 14:26:29 | dansmith | I don't think this patch needs to change the other tests that are here | |
| 14:27:36 | gibi | dansmith: I theory both NUMAServersTestBase but I agree that in _this_ patch we should not change the other tests, so the NUMAServersTestBase change would be a followup | |