Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-07-25
18:51:02 mriedem stephen added a NUMAAffinityNeutronFixture or whatever that had fake networks with those values
18:51:14 mriedem oh i didn't know you were doing attach stuff in these tests...
18:51:16 dansmith not in fixtures that I see
18:51:20 mriedem why are we trying to test attach in this basic test?
18:51:29 dansmith mriedem: that's what I said,
18:51:38 dansmith mriedem: but we're talking about the migration test below the rebuilds
18:51:39 mriedem heh, let's get the dumb simple flows working first
18:51:43 dansmith right
18:51:48 dansmith but.. scroll down :)
18:51:52 mriedem before we try to land on the moon
18:51:59 sean-k-mooney the attahced interface is connected to a network which is mapped to a different numa node then the first network
18:52:21 sean-k-mooney the instance has 1 numa node requested so its invalid and should fail
18:53:14 dansmith mriedem: so, that fixture he added has neutron responses with those values,
18:53:36 dansmith but something has to copy them into the info cache's network_model, which is the neutronv2/api code, unless that's implemented somewhere else for this test
18:55:12 dansmith ah, I might know
18:56:27 openstackgerrit Merged openstack/nova master: Add nova-manage placement sync_aggregates https://review.openstack.org/575912
18:58:41 dansmith hmm,
18:58:48 dansmith well the neutron fixture has a canned nw_info structure
18:58:54 dansmith which doesn't have the physnet stuff in it
18:59:23 mriedem but that's only used for add_fixed_ip_to_instance and remove
18:59:25 dansmith and it mocks out networkinfo.hydrate (!) to return that
18:59:28 mriedem which isn't the same as attach/detach
18:59:37 dansmith mriedem: there's no attach/detach in this test
19:00:02 mriedem still, we don't call add_fixed_ip_to_instance at all so that canned one shouldn't matter
19:00:17 dansmith it mocks out hydrate in that fixture
19:00:55 mriedem where?
19:01:08 dansmith oh sorry
19:01:20 dansmith I was reading it wrong, it mocks the thing you said and calls hydrate from the lambda
19:01:23 dansmith sorry
19:03:38 dansmith well, in that case, like I said, I'm not sure how we'll ever get those new things into the network model if we're not running the neutronv2/api code
19:06:58 mriedem i think we are but with the stubbed list_ports, list_networks, show_network stuff
19:07:15 sean-k-mooney dansmith: this is whats in instance.info_cache.network_info if it helps http://paste.openstack.org/show/726641/
19:08:02 mriedem so that does have the physical_network and tunneled network meta
19:08:40 mriedem melwitt: https://review.openstack.org/#/c/517921/ and below need a final +@
19:08:41 mriedem +2
19:08:48 dansmith mriedem: we're not running the _nw_info_build_network code
19:09:08 melwitt mriedem: thanks, will look
19:09:17 mriedem dansmith: hmm
19:09:23 mriedem i'm not sure why we wouldn't, i don't see anything stubbing that out
19:09:27 dansmith mriedem: that was my point above
19:09:30 dansmith and you shat upon it
19:09:31 mriedem oh wait,
19:09:42 mriedem we do have other things that stub some shit out in the nw api
19:09:51 mriedem and i bet that is getting stubbed in the parent test base class
19:10:23 mriedem in the air like you just don't care!?
19:10:52 dansmith like jan brady when marcia suggests the same thing she just did and now everyone thinks it's cool
19:11:58 mriedem ServersTestBase
19:12:03 mriedem fake_network.set_stub_network_methods(self)
19:12:17 mriedem thar she blar
19:13:13 mriedem so if stephenfin's test calls unset_stub_network_methods we should hit the cache rebuilder
19:14:00 sean-k-mooney so _nw_info_build_network is being called when weer are booting
19:14:00 mriedem i'm not sure why someone didn't figure this all out hours ago :P
19:14:19 mriedem sean-k-mooney: yes, at the end of allocate_for_instance,
19:14:26 mriedem but we don't get that far b/c of set_stub_network_methods
19:14:27 sean-k-mooney yes
19:14:37 sean-k-mooney its not called in the rebuild
19:15:01 mriedem it doesn't need to be,
19:15:14 mriedem b/c after the server is created, the nw info cache is persisted in the db with the instance
19:15:21 mriedem assuming we had something in the db, but we don't b/c of set_stub_network_methods
19:15:22 dansmith yep, that fixes it, I'll push this up
19:15:26 mriedem WOOT
19:15:49 sean-k-mooney dansmith: awsome :)
19:16:22 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Add additional functional tests for NUMA networks https://review.openstack.org/585385
19:23:10 dansmith melwitt: mriedem: I'm assuming no cells meeting with the crunch and all
19:23:20 melwitt +1
19:23:35 mriedem agree
19:31:49 mriedem oh sweet irony as soon as we approve artom's test_tagged_attachment debug patch, it fails on that test
19:31:53 mriedem http://logs.openstack.org/32/584032/5/check/nova-next/caee4e1/logs/testr_results.html.gz
19:39:06 mriedem doesn't show any of artom's new debug messages for the instance or volume
19:41:47 sean-k-mooney ok my server says i loged into it 12 hour and 21 minutes ago. my brain is fried so im going to call it a day. i have the functional test for dansmith updated version running local. if test_rebuild_server_network_changes still fails perhaps we should remove it given cold migrate and test_rebuild_server_no_network_changes pass
19:42:31 dansmith yeah the rebuild tests don't work,
19:42:35 mriedem dansmith: what do you want me to do re ^? otherwise i'm just watching zuul and need to book a flight to china. do we have more tests that need to be written and/or cleaned up in the patch?
19:43:15 dansmith I think we need the negative test
19:43:41 mriedem i'm not sure i know how to do that
19:43:50 mriedem that's where the nodes on the host are all claimed?
19:44:01 dansmith no, there's an easier way
19:44:12 dansmith jan will take a crack at it while marcia brushes her hair
19:44:33 mriedem alright, wfm
19:44:39 mriedem works. for. marcia.
19:44:58 mriedem oh btw i'm in full summer feather hair mode atm
19:45:09 mriedem but it will be shorn before denver
19:49:07 sean-k-mooney so ya that just finished running all the nova fuctional tests. nova.tests.functional.libvirt.test_numa_servers.NUMAServersWithNetworksTest.test_rebuild_server_network_changes is the only one that failed in dans version so its just the attch suff thats failing.
20:03:17 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Add additional functional tests for NUMA networks https://review.openstack.org/585385
20:16:58 artom mriedem, wait, it failed and logged nothing at all o_O
20:19:49 dansmith mriedem: so you'll convert your +1 to +2 on the functional move patch?
20:21:50 efried Does he have to deny you three times, or something?
20:22:07 efried not that kind of conversion, maybe.
20:58:39 openstackgerrit Mathieu Gagné proposed openstack/nova master: Add support for multiple fixed-ips in metadata https://review.openstack.org/580742
21:00:12 mriedem dansmith: yeah
21:00:27 mriedem artom: right
21:02:09 melwitt does anyone know anything about metadata API versions and what's valid? for the addition of 'ip_addresses' to network_data.json, it means we have a second version update this cycle and we apparently already used a date in the future 2018-08-27 https://review.openstack.org/#/c/580742/2/nova/api/metadata/base.py@77
21:03:32 mriedem apparently we already did that once with NEWTON_TWO even though NEWTON_ONE was using the wrong date
21:03:44 melwitt what's proposed is 2018-08-27-2 which is a format we haven't done before
21:03:52 mriedem # correlate with OpenStack release dates, with all the changes for a given
21:03:52 mriedem # NOTE(mikal): think of these strings as version numbers. They traditionally
21:03:53 mriedem # from EC2, which this needs to be compatible with.
21:03:53 mriedem # required for testing purposes. We know this isn't great, but its inherited
21:03:53 mriedem # hidden from the listing, but can still be requested explicitly, which is
21:03:53 mriedem # release bundled into a single version. Note that versions in the future are
21:04:03 mriedem i would -1 on the fomrat

Earlier   Later