| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-07-25 | |||
| 09:04:59 | gibi | cdent: what I wanted to say that I think these bugs will be scary even for me after 4 years of nova | |
| 09:05:10 | cdent | :) | |
| 09:05:37 | cdent | It's easier to fix them after they happen then it is easy to guess when they might happen? | |
| 09:07:33 | gibi | cdent: yeah I agree about cost of guessing is bigger. But I also don't know the seriosuness of the effect of these unknown bugs on a live deployment | |
| 09:09:18 | gibi | cdent: anyhow I think I hear you and understand you to move forward with the happy path | |
| 09:09:24 | gibi | cdent: and I think that is reasonable | |
| 09:40:44 | openstackgerrit | sean mooney proposed openstack/os-vif master: add fuctional test for os-vif init https://review.openstack.org/585693 | |
| 09:41:20 | openstackgerrit | Rajesh Tailor proposed openstack/nova stable/queens: Make host_aggregate_map dictionary case-insensitive https://review.openstack.org/585334 | |
| 09:43:41 | openstackgerrit | Rajesh Tailor proposed openstack/nova stable/pike: Make host_aggregate_map dictionary case-insensitive https://review.openstack.org/585335 | |
| 09:45:55 | sean-k-mooney | mriedem: melwitt i have added a fuctionl test https://review.openstack.org/#/c/585693/ to try and reproduce the error in https://bit.ly/2v0ueZp but at least locally it looks like it should work as is. | |
| 09:46:00 | openstackgerrit | Rajesh Tailor proposed openstack/nova master: Fix case-sensitivity for metadata keys https://review.openstack.org/504885 | |
| 10:30:25 | openstackgerrit | Lenny Verkhovsky proposed openstack/nova master: WIP workaround for RHEL7.5 qemu 2.0 https://review.openstack.org/577280 | |
| 10:37:36 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Functional test for booting with nested resources https://review.openstack.org/527728 | |
| 10:38:46 | mdbooth | kashyap: My +1 to sahid's suggestions was before the subsequent discussion. I'll defer to that discussion. | |
| 10:38:58 | kashyap | mdbooth: Hi | |
| 10:40:13 | kashyap | mdbooth: So, you mean: you are OK with moving to guest.migrate() can be done as a separate patch? | |
| 10:40:48 | mdbooth | kashyap: I think moving to guest.migrate() is better, but if you discussed that already and decided to put it in a later change I'm ok with that. | |
| 10:41:01 | kashyap | mdbooth: Yeah, we discussed it, and will do it later | |
| 10:41:11 | kashyap | As I am dealing with too much churn in this change | |
| 10:41:15 | mdbooth | kashyap: That is, I don't mind what colour you paint the bike shed :) | |
| 10:41:29 | kashyap | I'd like to get it done before I head out for 2 weeks starting 01-Aug | |
| 10:41:35 | kashyap | mdbooth: Hehe, nod | |
| 10:41:41 | kashyap | Thanks for looking, BTW! | |
| 10:42:24 | kashyap | mdbooth: About the "parallels" question: it seems alright to me, but I'll go over carefully again | |
| 10:43:00 | mdbooth | kashyap: Ack. Specifically, is it ok to call migrateToURI3() without that parameter? | |
| 10:43:11 | mdbooth | I don't know the answer, btw, just worth checking. | |
| 10:43:24 | kashyap | mdbooth: Without 'destination_xml', you mean? | |
| 10:43:32 | kashyap | Yeah, I'll see | |
| 10:45:14 | kashyap | mdbooth: Right now debugging the test failure from hell: nova.tests.unit.virt.test_virt_drivers.LibvirtConnTestCase.test_live_migration | |
| 10:45:39 | kashyap | Once I'm done w/ it, will look | |
| 10:50:23 | kashyap | stephenfin: LOL | |
| 10:50:41 | kashyap | I'm dealing with a bloody obtuse stubbing failure for 2 hours! | |
| 10:50:55 | stephenfin | kashyap: Try 3 days :( | |
| 10:50:59 | kashyap | The here is incredibly dense; sheesh | |
| 10:51:05 | kashyap | stephenfin: I lied to you | |
| 10:51:14 | kashyap | 2 hours only today | |
| 10:51:21 | kashyap | I spent yesterday & day before too | |
| 10:51:34 | kashyap | After all this debugging, realized the fix is "simple" :-( | |
| 10:51:59 | mdbooth | stephenfin: stub -> simulator. simulators are also really useful, just not as simple. | |
| 10:57:06 | stephenfin | mdbooth: I think that's what I'm writing. God damn neutron | |
| 11:01:14 | kashyap | mdbooth: Got a minute? Does this stub look OK to you: | |
| 11:01:15 | kashyap | 137 migrate_disks=None, destination_xml=None, flags=0, | |
| 11:01:15 | kashyap | 136 lambda self, destination, migrate_uri=None, | |
| 11:01:15 | kashyap | 135 self.stub_out('nova.virt.libvirt.guest.Guest.migrate', | |
| 11:01:18 | kashyap | 138 bandwidth: None) | |
| 11:01:24 | kashyap | (That's from nova/tests/unit/virt/test_virt_drivers.py) | |
| 11:02:45 | mdbooth | kashyap: No, because bandwidth doesn't have a default, and comes after args with defaults. | |
| 11:02:58 | kashyap | mdbooth: Ah | |
| 11:03:01 | mdbooth | Is there any other reason it might not be ok? | |
| 11:03:45 | mdbooth | kashyap: Also, you could probably just mock it. | |
| 11:03:51 | kashyap | mdbooth: What do I give 'bandwidth' then? | |
| 11:03:53 | kashyap | Hmm | |
| 11:04:07 | mdbooth | kashyap: Doesn't matter, because you're not going to use it anyway. | |
| 11:04:32 | kashyap | mdbooth: Ah, this works! | |
| 11:04:33 | kashyap | bandwith=0: None | |
| 11:04:42 | mdbooth | self.useFixture(fixtures.MockPatch('nova.virt.libvirt.guest.Guest', 'migrate')) | |
| 11:04:48 | kashyap | In summary: | |
| 11:04:49 | kashyap | self.stub_out('nova.virt.libvirt.guest.Guest.migrate', | |
| 11:04:51 | kashyap | mdbooth: How about the above? | |
| 11:04:51 | kashyap | bandwidth=0: None) | |
| 11:04:51 | kashyap | migrate_disks=None, destination_xml=None, flags=0, | |
| 11:04:51 | kashyap | lambda self, destination, migrate_uri=None, | |
| 11:04:52 | mdbooth | foo=^^^ | |
| 11:04:57 | mdbooth | foo.return_value=None | |
| 11:05:16 | mdbooth | kashyap: Looks syntactically correct, at least. | |
| 11:05:40 | kashyap | Yeah, it is! | |
| 11:05:43 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Assorted cleanups from numa-aware-vswitches series https://review.openstack.org/582651 | |
| 11:05:44 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Add functional tests for rebuild with NUMA networks https://review.openstack.org/585385 | |
| 11:05:44 | kashyap | And the test from hell passes!~ | |
| 11:06:20 | mdbooth | \o/ | |
| 11:06:37 | stephenfin | mdbooth: If you have time, fancy taking a look at ^ to see if I'm missing anything really obvious? | |
| 11:06:51 | stephenfin | I'm seeing "AttributeError: 'module' object has no attribute 'vif'" but I've no idea why | |
| 11:06:54 | sean-k-mooney | stephenfin: i was just going to ask you about the functional tests | |
| 11:07:17 | sean-k-mooney | do you want me to pull them down and step through them more or did you get them to work? | |
| 11:07:25 | stephenfin | Thought it was a namespace conflict (mocking "objects" or something) but I renamed the import to no effect. Can't find any global mocks or anything | |
| 11:07:30 | stephenfin | sean-k-mooney: That'd be great | |
| 11:07:38 | stephenfin | I've got it to the point where it's attempting to plug | |
| 11:07:47 | sean-k-mooney | stephenfin: cool will do | |
| 11:07:54 | stephenfin | But the plug is failing with the above | |
| 11:08:03 | stephenfin | sean-k-mooney: Awesome. Thank you :) | |
| 12:10:52 | openstackgerrit | Neha Alhat proposed openstack/python-novaclient master: Enable split logging for cinder-novaclient interaction https://review.openstack.org/581218 | |
| 12:22:58 | openstackgerrit | Jan Gutter proposed openstack/nova master: Use vif.vif_name in _set_config_VIFGeneric https://review.openstack.org/571461 | |
| 12:29:34 | mdbooth | lyarwood: https://review.openstack.org/#/c/571410/7 Are we missing a simpler solution here? | |
| 12:29:59 | mdbooth | lyarwood: And another big race condition in a periodic, of course. | |
| 12:42:05 | lyarwood | mdbooth: erm I don't follow, the entire point of that conditional is to not fail, to not raise DiskNotFound? | |
| 12:42:39 | mdbooth | lyarwood: And my point is we're decided whether to fail or not based on data which is really out of date, and why would it ever be better to fail there anyway? | |
| 12:42:57 | mdbooth | lyarwood: i.e. just don't fail. | |
| 12:42:59 | mdbooth | ever. | |
| 12:43:54 | stephenfin | mriedem: FYI, I've got further with that functional test but I'm still seeing some issues (this time "AttributeError: 'module' object has no attribute 'vif'", where module is os_vif). Will keep working on it | |
| 12:44:34 | lyarwood | mdbooth: yeah I guess that's valid sorry, warning when it isn't found would be cleaner I guess | |
| 12:44:55 | mriedem | stephenfin: hmm, i think the FakeLibvirtFixture has a flag for stubbing out os-vif somehow | |
| 12:44:57 | mriedem | might want to check that out | |
| 12:45:19 | stephenfin | mriedem: It does and I think it's enabled by default | |
| 12:45:22 | mriedem | stephenfin: is that just the rebuild functional test on a single host? or are you working on a test that actuall moves the instance from one host to another, like cold migrate? | |
| 12:46:02 | mriedem | i think the latter would be most interesting if you have 3 computes where 2 satisfy the numa affinity network request and we cold migrate and make sure the scheduler picked the other host that supported the network request | |
| 12:46:20 | stephenfin | mriedem: Just rebuild. I'm still stuck attaching an interface to running VM, so until I figure that out I can't do anything else | |
| 12:47:04 | stephenfin | so my test isn't getting past here https://review.openstack.org/#/c/585385/5/nova/tests/functional/libvirt/test_numa_servers.py@449 | |
| 12:47:37 | mriedem | why do you need the attach? to see that the info cache is updated? | |
| 12:48:12 | mriedem | stephenfin: why can't your test just be (1) create server with numa affinity network requested on host A, (2) cold migrate it to host B where host B has the numa affinity you need but we also have another host C which should get filtered out | |
| 12:50:12 | stephenfin | Yup. When I rebuild after attaching an interface, it should take that new interface into account when (re)calculating NUMA topology | |