| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-07-23 | |||
| 13:04:03 | gibi | stephenfin: could be some rebase artifact | |
| 13:12:07 | gibi | stephenfin: tests pass without it so I'm going to respin the patch | |
| 13:13:38 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | |
| 13:14:13 | gibi | stephenfin: ^^ removed the extra line | |
| 13:14:47 | stephenfin | gibi: Cool. +2 now | |
| 13:15:54 | gibi | cdent: stephenfin thanks | |
| 13:16:08 | gibi | bahh | |
| 13:16:11 | gibi | stephenfin: thanks | |
| 13:22:23 | kashyap | mdbooth_: Hi, when you get a moment, I'm blind and can't figure out why 'migrate_uri' is still "None" in the actual call here: http://paste.openstack.org/show/726442/ | |
| 13:22:39 | kashyap | Please enlighten, throw rotten tomatoes, etc. | |
| 13:24:25 | alex_xu | mriedem: re: http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2018-07-20.log.html#t2018-07-20T13:20:30 | |
| 13:24:37 | alex_xu | mriedem: agree with just merge 'server create' part in Rocky | |
| 13:25:23 | tssurya | alex_xu: so the merge into view builder would only be in Stein? | |
| 13:26:23 | alex_xu | tssurya: yea, is there anything you need about view builder, I see there are something you need, but I didn't follow it yet | |
| 13:26:55 | tssurya | alex_xu: yea, its mainly for this patch: https://review.openstack.org/#/c/567785/ | |
| 13:27:18 | tssurya | related to the handling a down cell, I need to basically return a minimal response for nova show and list servers | |
| 13:27:42 | alex_xu | tssurya: got it, let me check, thanks | |
| 13:27:46 | tssurya | for which I would have to handle it seperately for each of the deprecated extensions since they are being merged into the response individually | |
| 13:27:51 | tssurya | alex_xu: thanks | |
| 13:29:21 | mriedem | alex_xu: yeah gmann has some patches up in the same series for moving things from extensions to server view builder, | |
| 13:29:36 | mriedem | but with the state of the gate the last couple of weeks, i doubt all of this will get merged before feature freeze | |
| 13:31:41 | tssurya | mriedem: meanwhile I have a patch for nova service-list here : https://review.openstack.org/#/c/584829/ | |
| 13:31:49 | tssurya | which doesn't depend on those changes | |
| 13:32:22 | mriedem | tssurya: i assumed that the service list and server list changes for partial results would all be in the same microversion | |
| 13:32:30 | mriedem | it's kind of weird if they aren't | |
| 13:32:31 | tssurya | and then I will also do the poliy change for nova boot | |
| 13:32:37 | tssurya | mriedem: true that, | |
| 13:32:54 | tssurya | so we stall the API changes for now ? | |
| 13:33:11 | tssurya | or nvm, I will keep working on them and we can see, | |
| 13:33:17 | openstackgerrit | Takashi NATSUME proposed openstack/python-novaclient master: Fix the help text for server-group-create https://review.openstack.org/584709 | |
| 13:33:23 | mriedem | i don't think the server list/show partial results stuff will get in rocky at this rate, if i'm being honest | |
| 13:33:42 | tssurya | mriedem: got it | |
| 13:33:46 | mriedem | i think we're way too close to feature freeze for a change like that, and even if we approved it all today, it would take 4 days to merge | |
| 13:34:10 | mriedem | but we can see what dansmith and melwitt think about doing the service list partial results in a separate microversion for rocky since that's much smaller scope and admin-only so impacts are smaller | |
| 13:34:24 | gmann | mriedem: yeah, 5-6 are on zuul -2 let’s see how much gets in | |
| 13:34:27 | tssurya | mriedem: hmm ack | |
| 13:35:08 | mriedem | tssurya: my personal goal for the bp is getting the queued_for_delete data migration in for rocky, which means choosing between yours and dan's | |
| 13:35:33 | tssurya | mriedem: right, okay let's wait for dansmith then | |
| 13:35:46 | dansmith | mriedem: I guess I would think returning shell results for missing services would be super low priority to me | |
| 13:36:09 | dansmith | mriedem: if a cell is down and we just return the services we can find, I would think the admins would be fine with that given they know the cell is down | |
| 13:36:11 | mriedem | dansmith: as in might as well make them a single microversion | |
| 13:36:33 | mriedem | them = nova list & service list | |
| 13:36:47 | dansmith | mriedem: we are already returning partial results for service list if a cell is down right? | |
| 13:36:54 | mriedem | yes | |
| 13:37:06 | mriedem | tssurya did the fix for that as a bug | |
| 13:37:16 | tssurya | not partial results, | |
| 13:37:20 | tssurya | like skips that cell | |
| 13:37:21 | dansmith | I'm saying, focus on instance list returning shell instances to patch up the instance list, but not care about service list | |
| 13:37:28 | dansmith | tssurya: that's what I mean by partial results | |
| 13:37:34 | dansmith | just omitting the downed cell | |
| 13:37:37 | tssurya | ah yes sorry, | |
| 13:37:57 | dansmith | I'm not sure why we really need to try to patch up the service list tbh | |
| 13:38:04 | dansmith | and I imagine it's going to be hard | |
| 13:38:15 | mriedem | you can patch up the compute services, but that's about it | |
| 13:38:38 | tssurya | yea just the host and binary fields | |
| 13:38:43 | mriedem | i don't think it's all that hard. the value question is the question | |
| 13:38:59 | dansmith | I always get this confused, but aren't the host mappings done by compute node and not service? | |
| 13:39:18 | mriedem | should be the service | |
| 13:39:47 | dansmith | it's by compute node by default, | |
| 13:39:48 | tssurya | I guess its compute-node for normal cases and service for ironic ? | |
| 13:39:56 | dansmith | I added by-service recently | |
| 13:40:14 | mriedem | sure, but https://github.com/openstack/nova/commit/64e76de43dc55e584c100005fa60da50dd06d352 | |
| 13:40:15 | mriedem | oops | |
| 13:40:20 | mriedem | HostMapping.get_by_host(ctxt, compute.host) | |
| 13:40:33 | mriedem | the host mappings are still 1:1 with the nova-compute service host | |
| 13:40:35 | dansmith | ah, compute.host is service host yeah? | |
| 13:40:37 | dansmith | okay | |
| 13:40:41 | mriedem | there isn't a host mapping per compute.hypervisor_hostname | |
| 13:40:44 | mriedem | which is the 1:M thing | |
| 13:40:46 | dansmith | right right okay | |
| 13:41:13 | dansmith | I was thinking it would be hard if it was one mapping per node, but fair enough | |
| 13:41:23 | dansmith | anyway, it just seems like really low prio to me | |
| 13:41:27 | dansmith | brb | |
| 13:41:32 | mriedem | given ^ why did we need the discover by service again? | |
| 13:42:10 | mriedem | oh b/c ironic doesn't have the nodes yet | |
| 13:42:15 | mriedem | by the time we need to discover the hosts | |
| 13:42:58 | mriedem | anyway, i agree doing shell results for service list is also low(er) priority so that's why i figured it would be part of the single microversion for doing nova list/show shell results | |
| 13:43:22 | tssurya | okay, so we do all of that in the same microversion then | |
| 13:43:45 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | |
| 13:44:35 | tssurya | and for now, we just decide to go with dansmith's migration ? thb, I don't have any particular preference between the two patches | |
| 13:44:47 | tssurya | so both works for us | |
| 13:45:50 | dansmith | mriedem: well my point about being lower priority meant I wouldn't want to hold up the instance side for the service side | |
| 13:46:36 | mriedem | dansmith: sure, she has the service one done* | |
| 13:46:53 | mriedem | and i'm saying i figured just leave it until the instance one is done and make them a single microversion | |
| 13:47:03 | mriedem | then that is the "down cell" microversion | |
| 13:47:10 | mriedem | but that's just how i've always been thinking this would happen | |
| 13:47:27 | dansmith | oh I see, | |
| 13:47:33 | dansmith | I had assumed the opposite | |
| 13:47:44 | dansmith | (that the instance one was done already) | |
| 13:47:56 | dansmith | my fault for not being up to date | |
| 13:48:14 | tssurya | nova list is held up for now because it would be neater if this goes in: https://review.openstack.org/#/q/topic:bp/api-extensions-merge-rocky+(status:open+OR+status:merged) | |
| 13:48:28 | mriedem | and we'll be lucky to just get ^ in to rocky | |
| 13:48:36 | mriedem | given our current merge rates | |
| 13:48:38 | dansmith | oye | |
| 13:48:53 | mriedem | it's taken a week to land code right now | |
| 13:49:07 | dansmith | yarp | |
| 13:49:16 | mriedem | so i'm really only mostly interested in pushing things across the line this week that is already ready to go and has had a lot of review already | |
| 13:49:18 | mriedem | personally, | |
| 13:49:33 | mriedem | plus i'm going to have a shitty week with some personal stuff going on so won't be fully available | |
| 13:50:15 | pooja_jadhav | dansmith: hello | |