Earlier  
Posted Nick Remark
#openstack-nova - 2018-07-17
14:12:44 sean-k-mooney hehe well i was writting a compile fontend at the time so i may have been in an optimisation mindset when i looked at it.
14:25:34 openstackgerrit Merged openstack/nova master: Replace support matrix ext with common library https://review.openstack.org/481304
14:25:41 mriedem gibi: a couple of questions in here https://review.openstack.org/#/c/580567/ - maybe you already went over those with takashi
14:27:58 openstackgerrit Jay Pipes proposed openstack/nova master: perform reshaper operations in single transaction https://review.openstack.org/582383
14:30:17 openstackgerrit Chris Dent proposed openstack/nova master: WIP: [placement] Add /reshaper handler for POST https://review.openstack.org/576927
14:32:42 mriedem seeing something weird on that driver support matrix generated doc change
14:32:49 mriedem XLibvirt KVM (ppc64)
14:32:52 mriedem what is that X?
14:33:01 mriedem before: https://docs.openstack.org/nova/latest/user/support-matrix.html#operation_trusted_certs
14:33:05 mriedem after: http://logs.openstack.org/04/481304/7/gate/build-openstack-sphinx-docs/480faa5/html/user/support-matrix.html#operation_trusted_certs
14:33:20 kashyap That just looks spurious
14:34:29 mriedem nope it was injected in the patch
14:34:35 mriedem https://review.openstack.org/#/c/481304/7/doc/source/user/support-matrix.ini@84
14:35:05 kashyap Oh, then is it X = "Experimental"?
14:35:35 kashyap So that was a typo in the patch itself
14:36:37 stephenfin mriedem: Damn, sorry. I'll draft a follow-up shortly to fix that
14:37:14 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix "XLibvirt KVM (ppc64)" typo in feature support matrix docs https://review.openstack.org/583267
14:37:15 mriedem or just fast approve this ^
14:44:28 gibi mriedem: replied in https://review.openstack.org/#/c/580567 honestly I frigthened by the mess of MonitorMetric and defaulted to provide in the versioned what was in the legacy
14:51:36 mriedem gibi: yeah i'm fine with that
14:51:43 mriedem i didn't even know we sent notifications for metrics
14:51:51 mriedem but i guess it makes sense for a project like watcher
14:52:42 mriedem gibi: if you agree to change that name StringField to MonitorMetricTypeField then I can just make that change and we can approve
14:53:13 gibi mriedem: OK, let's do that.
14:53:32 gibi mriedem: thanks for your time
15:08:43 openstackgerrit Eric Fried proposed openstack/nova master: Fix "XLibvirt KVM (ppc64)" typo in feature support matrix docs https://review.openstack.org/583267
15:24:05 openstackgerrit Matt Riedemann proposed openstack/nova master: Transform metrics.update notification https://review.openstack.org/580567
15:26:15 gibi mriedem: thanks ^^
15:26:40 mriedem np
15:28:04 mriedem i guess we can close this bp out and remove it from the runway then yeah? https://review.openstack.org/#/q/topic:bp/add-zvm-driver-rocky+(status:open+OR+status:merged)
15:28:06 mriedem efried: ^?
15:28:19 mriedem only thing open is a wip doc
15:28:22 openstackgerrit Stephen Finucane proposed openstack/nova master: WIP: Add functional tests for numa-aware-vswitches https://review.openstack.org/583288
15:28:34 efried mriedem: agree
15:29:00 stephenfin gibi, mriedem: I'm using NeutronFixture in the above functional test but I'm seeing calls to functions in 'nova.network.api.API' instead of 'nova.network.neutron_v2.api.API'. Any idea why that might be? (see the comments in nova/compute/api.py)
15:30:04 gibi stephenfin: looking
15:31:48 mriedem stephenfin: because you're using _IntegratedTestBase at the top of the hierarchy but not setting USE_NEUTRON=True
15:34:19 stephenfin mriedem: Ugh. I'd tried self.flags(use_neutron=True) but that did nothing because it's obviously overridden later. Thanks for the tip :)
15:34:46 mriedem looks like the zvm ci isn't testing reboot because this is excluded
15:34:47 mriedem ^tempest\.api\.compute\.servers\.test_server_actions\.ServerActionsTestJSON\.test_reboot_server_hard
15:34:57 mriedem i'll email jichen
15:35:04 gibi stephenfin: mriedem was faster
15:39:11 mriedem efried: looks like none of the zvm changes added the driver to the feature support matrix?
15:39:18 mriedem https://docs.openstack.org/nova/latest/user/support-matrix.html
15:39:43 mriedem unless i missed something, i'll report a docs bug
15:40:04 efried hum, coulda sworn...
15:41:12 efried mriedem: Nope, you're right, just looked through all of 'em again and see no support matrix updates.
15:41:22 mriedem np, i'll report a bug
15:41:32 efried man, I'm really confused.
15:45:02 mriedem https://bugs.launchpad.net/nova/+bug/1782191
15:45:04 openstack Launchpad bug 1782191 in OpenStack Compute (nova) "Newly added z/VM driver is not in feature support matrix" [Medium,Triaged]
16:06:00 mriedem stephenfin: https://review.openstack.org/#/c/575486/ failed on some weird errors
16:06:23 stephenfin Looking
16:07:05 mriedem the py3 one looks like a 500 in neutron api http://logs.openstack.org/86/575486/10/check/tempest-full-py3/bc761dd/controller/logs/screen-q-svc.txt.gz?level=TRACE
16:08:45 stephenfin mriedem: That patchset passed the gate checks on Jul 9 13:54. I'm guessing this is an intermittent gate issue?
16:09:19 stephenfin The other rechecks were necessary because the patch below wasn't merging, I think
16:12:45 mriedem stephenfin: ok all failures are in cleaning up network resources
16:12:50 mriedem so looks like some new regression on the neutron side
16:13:18 mriedem http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22pymysql.err.InternalError%3A%20(1305%2C%20'SAVEPOINT%20sa_savepoint_6%20does%20not%20exist')%5C%22%20AND%20tags%3A%5C%22screen-q-svc.txt%5C%22&from=7d
16:17:55 mriedem actually that's showing up a ton in successful jobs too, so that's not it,
16:17:58 mriedem sqlalchemy.exc.InvalidRequestError: Could not refresh instance '<Router at
16:17:58 mriedem it's likely this:
16:18:45 mriedem only 2 hits in logstash on that though, so maybe just totally random
16:19:05 stephenfin That's purely a neutron thing though, I'm assuming, given that I'm only consuming things in any of those patches
16:19:08 mriedem efried: gibi: the neutron change under this is approved now https://review.openstack.org/#/c/523604/
16:19:16 mriedem stephenfin: agree
16:19:26 stephenfin phew
16:19:33 mriedem did you fart?
16:19:56 stephenfin not this time
16:20:44 mriedem melwitt: i'm going to throw https://blueprints.launchpad.net/nova/+spec/neutron-new-port-binding-api back into a runway slot since the dependent neutron change at the bottom is approved now and the bottom half of the series has +2s on it
16:21:11 efried mriedem: Is it legit to merge the bottom five patches at this point?
16:21:17 mriedem yeah
16:21:22 mriedem it's all neutron api plumbing
16:21:22 efried mriedem: Or will that make dansmith hate us for merging partial function?
16:21:30 mriedem none of this series is 'on' until the very end
16:21:40 mriedem we're mergin partial function on stephenfin's series too
16:21:45 efried Hate us *more*, that is.
16:22:40 efried mriedem: Okay, +W'd the bottom five.
16:22:44 mriedem thanks
16:25:22 efried mriedem: "random dict of terrible boat"?
16:26:08 mriedem correct
16:26:38 mriedem vif_details and profile in a neutron port are like the connection_info in a volume,
16:26:44 mriedem totally backend dependent and unversioned
16:31:06 sean-k-mooney mriedem: well not quite. the standard keys are defiend in the port_bindings api extention. addtion backend keys can be added as vendor extentions and it is unversioned
16:31:35 efried I just don't know what "boat" is doing in that description.
16:31:57 sean-k-mooney mriedem: the binding profile can be set by the end user so it can have anything in it that fits in the db filed.
16:32:12 mriedem efried: they are in the same "random dict of terrible" boat
16:32:17 mriedem it's a boat called "random dict of terrible"
16:32:26 mriedem and profile is a passenger alongside vif_details
16:32:32 efried ahhh, I see now.
16:32:36 mriedem heh
16:33:08 mriedem sean-k-mooney: gross
16:33:09 efried would be clearer as "...in the same random-dict-of-terrible boat..."
16:33:57 sean-k-mooney efried: part of creating os-vif was to sink that boat and have neutron return serialised vif object in the future.
16:34:15 sean-k-mooney may next release. or the one after
16:35:33 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove support for /os-floating-ip-dns REST API https://review.openstack.org/582943
16:35:34 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove "DEPRECATED" tag from Obsolete APIs https://review.openstack.org/583092
16:36:53 mriedem once that dns one is approved ^ we can probably close out that bp for rocky
16:37:06 mriedem stephenfin: thanks for hitting those when the call for help was raised
16:37:37 stephenfin mriedem: np

Earlier   Later