| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-07-17 | |||
| 12:31:22 | openstackgerrit | Neha Alhat proposed openstack/python-novaclient master: Remove initialization of logger if logger is None https://review.openstack.org/581218 | |
| 13:00:49 | efried | stephenfin, gibi: What am I looking at? | |
| 13:01:04 | stephenfin | efried: https://review.openstack.org/#/c/481304/ | |
| 13:02:09 | gibi | efried: and after that, this is also fixed: https://review.openstack.org/#/c/583205 :) | |
| 13:02:39 | efried | stephenfin: +A | |
| 13:02:42 | efried | gibi: looking... | |
| 13:02:47 | stephenfin | efried++ | |
| 13:04:01 | efried | gibi: +A on both; if zuul is happy with them, I'm happy :) | |
| 13:04:13 | gibi | efried: I'm happy :) thanks | |
| 13:09:31 | jaypipes | stephenfin: I have absolutely zero clue what is best practice on https://review.openstack.org/#/c/574539/. whatever is your best practice/best knowledge, go with that. | |
| 13:11:39 | stephenfin | jaypipes: Cool. It seems to have been removed from os-vif so we should kill it there too | |
| 13:11:57 | stephenfin | I'll tackle that today so we do so before non-client library freeze | |
| 13:16:45 | jaypipes | stephenfin: thx mate | |
| 13:18:48 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | |
| 13:18:49 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Send soft_delete from context manager https://review.openstack.org/476459 | |
| 13:23:54 | sean-k-mooney | jaypipes: oh hi jay how are things | |
| 13:28:53 | openstackgerrit | Vladyslav Drok proposed openstack/nova master: ironic: Report resources as reserved when needed https://review.openstack.org/517921 | |
| 13:30:16 | openstackgerrit | Merged openstack/nova master: objects: Add NUMACell.network_metadata https://review.openstack.org/564439 | |
| 13:31:50 | jaypipes | sean-k-mooney: had a sinus infection for >1 week. sucks. :( | |
| 13:32:50 | jangutter | jaypipes: I do not recommend amputation. | |
| 13:33:31 | jaypipes | jangutter: yes, that is always a dead end. | |
| 13:34:26 | sean-k-mooney | jaypipes: ya thats no fun at all. felling better? | |
| 13:36:42 | jaypipes | sean-k-mooney: slightly, though getting no more than 2 hours of sleep at a time has been taxing. | |
| 13:45:52 | stephenfin | efried: Oh, yeah. https://github.com/tox-dev/tox/pull/910 and https://github.com/pypa/setuptools/pull/1427 | |
| 13:47:00 | cdent | you are a hero stephenfin | |
| 13:47:25 | efried | ++ | |
| 13:48:14 | efried | stephenfin: Meanwhile, here's something in oslo.config that might interest you: https://review.openstack.org/#/c/583064/ | |
| 13:49:38 | jaypipes | oh, stephenfin you are my hero (https://github.com/tox-dev/tox/pull/910) | |
| 13:51:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add unshelve instance error info to fault table https://review.openstack.org/579747 | |
| 13:56:12 | sean-k-mooney | stephenfin: oh that reminds me, do you have a link to your fix for the python version in tox | |
| 13:56:26 | stephenfin | sean-k-mooney: Umm...which one? | |
| 13:57:03 | sean-k-mooney | the one where you conditionally ignore base_python for the p35 etc factors | |
| 13:57:30 | stephenfin | sean-k-mooney: https://github.com/tox-dev/tox/pull/841 | |
| 13:59:14 | openstackgerrit | sahid proposed openstack/nova master: libvirt: remove unused attribute driver for LibvirtConfigNodeDevice https://review.openstack.org/583246 | |
| 13:59:15 | openstackgerrit | sahid proposed openstack/nova master: libvirt: add format_dom for ConfigNodeDevicePciSubFunctionCap https://review.openstack.org/583247 | |
| 13:59:16 | openstackgerrit | sahid proposed openstack/nova master: libvirt: add missing type for LibvirtConfigNodeDevicePciCap https://review.openstack.org/583248 | |
| 13:59:17 | openstackgerrit | sahid proposed openstack/nova master: libvirt: add format_dom() for config LibvirtConfigNodeDevicePciCap https://review.openstack.org/583249 | |
| 13:59:17 | sean-k-mooney | yep thats the one. i wanted to optimize something i spotted that bugged me when i reviewd it... | |
| 13:59:18 | openstackgerrit | sahid proposed openstack/nova master: libvirt: add format_dom() method for LibvirtConfigNodeDevice https://review.openstack.org/583250 | |
| 13:59:19 | openstackgerrit | sahid proposed openstack/nova master: libvirt: add generater of fake pci devices capabilities https://review.openstack.org/583251 | |
| 13:59:39 | edleafe | So... is Walmart dumping OpenStack? https://www.theverge.com/2018/7/17/17580744/microsoft-walmart-azure-partnership-amazon-rival | |
| 14:01:19 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Call generate_image_url only for legacy notification https://review.openstack.org/564528 | |
| 14:01:29 | efried | sean-k-mooney: FYI, I've proposed patches to a couple of repos including nova to pull in that fix: https://review.openstack.org/#/q/topic:tox-3.1.1 | |
| 14:06:32 | sean-k-mooney | efried: should we add tox==3.1.1 to lower-constraits also? | |
| 14:07:10 | efried | sean-k-mooney: I don't think it works that way. Chicken/egg. | |
| 14:09:12 | sean-k-mooney | hehe actully yes good point | |
| 14:11:58 | stephenfin | sean-k-mooney: Optimize _my_ code? The cheek of some people... | |
| 14:12:00 | stephenfin | :) | |
| 14:12:44 | sean-k-mooney | hehe well i was writting a compile fontend at the time so i may have been in an optimisation mindset when i looked at it. | |
| 14:25:34 | openstackgerrit | Merged openstack/nova master: Replace support matrix ext with common library https://review.openstack.org/481304 | |
| 14:25:41 | mriedem | gibi: a couple of questions in here https://review.openstack.org/#/c/580567/ - maybe you already went over those with takashi | |
| 14:27:58 | openstackgerrit | Jay Pipes proposed openstack/nova master: perform reshaper operations in single transaction https://review.openstack.org/582383 | |
| 14:30:17 | openstackgerrit | Chris Dent proposed openstack/nova master: WIP: [placement] Add /reshaper handler for POST https://review.openstack.org/576927 | |
| 14:32:42 | mriedem | seeing something weird on that driver support matrix generated doc change | |
| 14:32:49 | mriedem | XLibvirt KVM (ppc64) | |
| 14:32:52 | mriedem | what is that X? | |
| 14:33:01 | mriedem | before: https://docs.openstack.org/nova/latest/user/support-matrix.html#operation_trusted_certs | |
| 14:33:05 | mriedem | after: http://logs.openstack.org/04/481304/7/gate/build-openstack-sphinx-docs/480faa5/html/user/support-matrix.html#operation_trusted_certs | |
| 14:33:20 | kashyap | That just looks spurious | |
| 14:34:29 | mriedem | nope it was injected in the patch | |
| 14:34:35 | mriedem | https://review.openstack.org/#/c/481304/7/doc/source/user/support-matrix.ini@84 | |
| 14:35:05 | kashyap | Oh, then is it X = "Experimental"? | |
| 14:35:35 | kashyap | So that was a typo in the patch itself | |
| 14:36:37 | stephenfin | mriedem: Damn, sorry. I'll draft a follow-up shortly to fix that | |
| 14:37:14 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix "XLibvirt KVM (ppc64)" typo in feature support matrix docs https://review.openstack.org/583267 | |
| 14:37:15 | mriedem | or just fast approve this ^ | |
| 14:44:28 | gibi | mriedem: replied in https://review.openstack.org/#/c/580567 honestly I frigthened by the mess of MonitorMetric and defaulted to provide in the versioned what was in the legacy | |
| 14:51:36 | mriedem | gibi: yeah i'm fine with that | |
| 14:51:43 | mriedem | i didn't even know we sent notifications for metrics | |
| 14:51:51 | mriedem | but i guess it makes sense for a project like watcher | |
| 14:52:42 | mriedem | gibi: if you agree to change that name StringField to MonitorMetricTypeField then I can just make that change and we can approve | |
| 14:53:13 | gibi | mriedem: OK, let's do that. | |
| 14:53:32 | gibi | mriedem: thanks for your time | |
| 15:08:43 | openstackgerrit | Eric Fried proposed openstack/nova master: Fix "XLibvirt KVM (ppc64)" typo in feature support matrix docs https://review.openstack.org/583267 | |
| 15:24:05 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Transform metrics.update notification https://review.openstack.org/580567 | |
| 15:26:15 | gibi | mriedem: thanks ^^ | |
| 15:26:40 | mriedem | np | |
| 15:28:04 | mriedem | i guess we can close this bp out and remove it from the runway then yeah? https://review.openstack.org/#/q/topic:bp/add-zvm-driver-rocky+(status:open+OR+status:merged) | |
| 15:28:06 | mriedem | efried: ^? | |
| 15:28:19 | mriedem | only thing open is a wip doc | |
| 15:28:22 | openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Add functional tests for numa-aware-vswitches https://review.openstack.org/583288 | |
| 15:28:34 | efried | mriedem: agree | |
| 15:29:00 | stephenfin | gibi, mriedem: I'm using NeutronFixture in the above functional test but I'm seeing calls to functions in 'nova.network.api.API' instead of 'nova.network.neutron_v2.api.API'. Any idea why that might be? (see the comments in nova/compute/api.py) | |
| 15:30:04 | gibi | stephenfin: looking | |
| 15:31:48 | mriedem | stephenfin: because you're using _IntegratedTestBase at the top of the hierarchy but not setting USE_NEUTRON=True | |
| 15:34:19 | stephenfin | mriedem: Ugh. I'd tried self.flags(use_neutron=True) but that did nothing because it's obviously overridden later. Thanks for the tip :) | |
| 15:34:46 | mriedem | looks like the zvm ci isn't testing reboot because this is excluded | |
| 15:34:47 | mriedem | ^tempest\.api\.compute\.servers\.test_server_actions\.ServerActionsTestJSON\.test_reboot_server_hard | |
| 15:34:57 | mriedem | i'll email jichen | |
| 15:35:04 | gibi | stephenfin: mriedem was faster | |
| 15:39:11 | mriedem | efried: looks like none of the zvm changes added the driver to the feature support matrix? | |
| 15:39:18 | mriedem | https://docs.openstack.org/nova/latest/user/support-matrix.html | |
| 15:39:43 | mriedem | unless i missed something, i'll report a docs bug | |
| 15:40:04 | efried | hum, coulda sworn... | |
| 15:41:12 | efried | mriedem: Nope, you're right, just looked through all of 'em again and see no support matrix updates. | |
| 15:41:22 | mriedem | np, i'll report a bug | |
| 15:41:32 | efried | man, I'm really confused. | |
| 15:45:02 | mriedem | https://bugs.launchpad.net/nova/+bug/1782191 | |
| 15:45:04 | openstack | Launchpad bug 1782191 in OpenStack Compute (nova) "Newly added z/VM driver is not in feature support matrix" [Medium,Triaged] | |
| 16:06:00 | mriedem | stephenfin: https://review.openstack.org/#/c/575486/ failed on some weird errors | |