Posted	Nick	Remark
#openstack-nova - 2018-07-13
01:39:59	Kevin_Zheng	I mean Alex and Gmann
01:40:03	mriedem	dan is saying doing it all in rpcapi
01:40:10	mriedem	b/c that's what has the can_send_version check
01:40:13	mriedem	and knows the upgrade_levels pin
01:40:26	mriedem	https://docs.openstack.org/nova/latest/configuration/config.html#upgrade-levels
01:40:41	mriedem	the API could tell us that the compute is running version 33 but the rpc api might be pinned to rocky,
01:40:49	mriedem	at which point can_send_version would still fail the 5.1 check
01:41:08	Kevin_Zheng	hmmm this doc helps
01:41:08	mriedem	also good lord that's a wall of text ^
01:41:40	gmann	mriedem: what is case where node has compute 33 and RPC API not pinned ?
01:42:37	gmann	mriedem: Kevin_Zheng the only reason of checking in api we thought is early revert back the request. check in rpc is needed as you and dansmith mentioned
01:43:11	mriedem	you can fail fast and return an error to the user in either place
01:43:17	mriedem	since the check happens before the cast to compute
01:43:41	mriedem	i'm trying to sort out if we can *move* the !running check from api to rpcapi
01:43:45	mriedem	otherwise it's redundant
01:44:00	mriedem	this https://review.openstack.org/#/c/568542/17/nova/compute/api.py@4427
01:44:11	gmann	mriedem: you mean from rpc to api ?
01:44:38	gmann	agree to have check of !running in single place, either one
01:44:38	mriedem	api to rpc
01:44:50	gmann	humm
01:44:51	Kevin_Zheng	Hmm, that is for microversion
01:44:52	mriedem	nova.compute.api.API can't do the rpc version check
01:44:58	mriedem	it doesn't have the can_send_version logic
01:45:05	mriedem	that's in nova.compute.rpcapi
01:45:11	Kevin_Zheng	I mean, we should check for microversion first
01:45:22	mriedem	right that's what is confusing me
01:45:29	mriedem	because we need to build in the microversion logic as well
01:45:35	Kevin_Zheng	yeah
01:46:12	mriedem	but couldn't we just pass support_abort_in_queue to rpcapi?
01:46:14	mriedem	and do the logic there?
01:46:35	mriedem	then your acceptable status values are based on (1) the microversion and (2) the rpcapi version
01:46:57	mriedem	allowed_statuses = ['running']
01:46:59	mriedem	if support_abort_in_queue:
01:47:16	Kevin_Zheng	and can_send_version?
01:47:20	mriedem	yeah,
01:47:29	mriedem	if support_abort_in_queue and can_send_version(5.1):
01:47:41	mriedem	allowed_statuses.extend(['queued', 'preparing'])
01:47:51	gmann	microversion check is on APOI controller side not enough ?
01:47:52	Kevin_Zheng	Then should I merge patch 2 and 4?
01:47:53	mriedem	if migration.status not in allowed_statuses:
01:47:54	gmann	API
01:47:58	mriedem	raise exception.InvalidMigrationState(
01:48:12	mriedem	gmann: no because if the compute is queens,
01:48:20	mriedem	it doesn't know how to cancel a migration in queued or preparing status
01:49:11	gmann	that what compute version or rpc version check will handle right
01:49:19	mriedem	Kevin_Zheng: i don't think you merge them
01:49:56	mriedem	Kevin_Zheng: i think patch 2 has the rpcapi version bump b/c of the signature change
01:50:12	mriedem	and then in the same change that adds the microversion, you can move the status checking from api into rpcapi
01:50:26	mriedem	based and pass in the support_abort_in_queue flag
01:50:35	Kevin_Zheng	move it in patch 4?
01:50:36	mriedem	*pass in the support_abort_in_queue
01:51:21	gmann	this one will be passed all way till rpc right? - https://review.openstack.org/#/c/573136/6/nova/api/openstack/compute/server_migrations.py@149
01:51:45	openstackgerrit	Chen proposed openstack/nova master: fix cellv2 delete_host https://review.openstack.org/582171
01:52:06	mriedem	gmann: that's what i'm suggesting,
01:52:13	gmann	ohk. i got confuse when you mentioned microversion checks on compute.apy.py
01:52:13	mriedem	i'll leave a comment on patch 2 and then i need to call it a day
01:52:19	mriedem	and i'll talk to dansmith about my idea in the morning
01:52:47	Kevin_Zheng	Ok, good night
01:53:55	openstackgerrit	Julia Kreger proposed openstack/nova master: ironic: provide facilities to gracefully navigate versions https://review.openstack.org/582416
01:54:45	TheJulia	mriedem: looks like I'll need to tune some job timeouts with that rescue test :\ Something for tomorrow since we seem to have a job that now wants to time out independently as well :\
01:56:13	openstackgerrit	Julia Kreger proposed openstack/nova master: virt/ironic: Implement rescue and unrescue https://review.openstack.org/416487
01:56:23	TheJulia	mriedem: parent update rebase ^
01:57:24	mriedem	Kevin_Zheng: gmann: dansmith: left my idea in https://review.openstack.org/#/c/568542/
01:58:03	Kevin_Zheng	Thanks I think it will work, lets collect more ideas.
01:58:59	mriedem	TheJulia: thanks, lgtm
01:59:56	TheJulia	mriedem: no, thank you! :)
02:02:31	gmann	mriedem: thanks. ll check
02:19:32	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Transform instance.live_migration_force_complete notification https://review.openstack.org/480561
02:32:47	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534
02:44:17	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534
02:45:25	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Use ThreadPoolExecutor for max_concurrent_live_migrations https://review.openstack.org/563505
02:45:45	openstackgerrit	Merged openstack/nova master: Follow up for Ie49d605c66062d2548241d7e04f5a2a6b98c011e https://review.openstack.org/582292
02:45:57	openstackgerrit	Merged openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401
02:59:45	openstackgerrit	Merged openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy https://review.openstack.org/571166
03:32:18	openstackgerrit	Eric Fried proposed openstack/nova master: WIP: Compute: Handle reshaped provider trees https://review.openstack.org/576236
03:44:40	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Fix all invalid obj_make_compatible test case https://review.openstack.org/574240
04:03:14	openstackgerrit	Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/578261
04:35:09	openstackgerrit	Hironori Shiina proposed openstack/nova master: ironic: Log an error when API version is not available https://review.openstack.org/582447
06:26:15	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Fix all invalid obj_make_compatible test case https://review.openstack.org/574240
06:33:06	tssurya	/set weechat.look.prefix_join "▬▬▶"
06:40:29	tssurya	oops, sorry ^^
06:40:44	openstackgerrit	zhaolihui proposed openstack/python-novaclient master: Fix flavor keyerror when nova boot vm https://review.openstack.org/582147
06:43:47	openstackgerrit	Yikun Jiang (Kero) proposed openstack/nova master: Address nits in server group policy series https://review.openstack.org/581616
06:45:10	openstackgerrit	Hironori Shiina proposed openstack/nova master: ironic: Log an error when API version is not available https://review.openstack.org/582447
06:45:12	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Compute: add support to abort queued live migration https://review.openstack.org/568542
06:58:28	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/578019
06:59:00	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Fix ServerMigrationSampleJsonTestsV2_24 to use its own sample file https://review.openstack.org/581562
07:41:10	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Compute: add support to abort queued live migration https://review.openstack.org/568542
07:53:41	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Fix ServerMigrationSampleJsonTestsV2_24 to use its own sample file https://review.openstack.org/581562
08:26:51	Miouge	As an admin, can I add a VM to a server group after it’s creation?
08:27:16	Miouge	I don’t find it in the API, so is the only option to go an edit the DB and re-schedule the instances?
08:35:24	giblet_off	I'm taking the day off
08:50:47	gmann	giblet_off: take rest do not be always too hard working :)
09:03:36	openstackgerrit	tianhui proposed openstack/nova master: Change default video model from cirrus to vga https://review.openstack.org/582471
09:14:46	eumel8	Hello Nova Cores! Maybe it's possible to import Zanata translations: https://review.openstack.org/#/c/578019/
09:43:53	openstackgerrit	Chen proposed openstack/nova master: Clean up group members in db when delete https://review.openstack.org/581403
09:57:06	openstackgerrit	huanhongda proposed openstack/nova-specs master: Return "deleted" and "estimated_reclaim" time of instance for admin https://review.openstack.org/581638
10:07:19	openstackgerrit	Chen proposed openstack/nova master: fix cellv2 delete_host https://review.openstack.org/582171
10:47:31	stephenfin	eumel8: Sure, done
11:16:36	openstackgerrit	Merged openstack/nova master: Imported Translations from Zanata https://review.openstack.org/578019

Earlier   Later