| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-07-12 | |||
| 08:35:21 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (18) https://review.openstack.org/576673 | |
| 08:35:34 | openstackgerrit | huanhongda proposed openstack/nova-specs master: Add ram/cpu/disk allocation ratio to Hypervisor show https://review.openstack.org/582089 | |
| 08:40:57 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/python-novaclient master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/578261 | |
| 08:41:23 | openstackgerrit | huanhongda proposed openstack/nova-specs master: Return "deleted" time of instance when vm_state is SOFT-DELETED https://review.openstack.org/581638 | |
| 08:55:40 | vabada | Ctrl-B $ | |
| 08:55:41 | vabada | 10:55 AM | |
| 08:55:41 | vabada | Arne Wiebalck | |
| 08:55:41 | vabada |  | |
| 08:55:50 | vabada | sorry | |
| 09:16:53 | openstackgerrit | Vu Cong Tuan proposed openstack/python-novaclient master: Switch to stestr https://review.openstack.org/582090 | |
| 09:33:07 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | |
| 09:36:35 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (19) https://review.openstack.org/576676 | |
| 09:36:56 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (20) https://review.openstack.org/576689 | |
| 09:43:48 | BrinZhang | dansmith: Hi, can you review this patch? | |
| 09:44:28 | BrinZhang | dansmith: https://review.openstack.org/#/c/579747/ | |
| 09:46:50 | BrinZhang | melwitt: Do you have time ? | |
| 09:46:59 | BrinZhang | Thank you :) | |
| 10:19:22 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (21) https://review.openstack.org/576709 | |
| 10:19:33 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in unit/network/test_neutronv2.py (22) https://review.openstack.org/576712 | |
| 10:20:36 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Remove mox in virt/test_block_device.py https://review.openstack.org/566153 | |
| 10:21:05 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add the guideline to write API reference https://review.openstack.org/569058 | |
| 10:21:28 | kashyap | BrinZhang: Hi, it is middle of the night for both of them. They'll take notice when they come online. | |
| 10:22:34 | BrinZhang | kashyap: That's it, thank you :) | |
| 11:14:26 | openstackgerrit | zhaolihui proposed openstack/python-novaclient master: Fix flavor keyerror when nova boot https://review.openstack.org/582147 | |
| 11:17:32 | gmann | melwitt: i have updated nova meeting agenda to include the API subteam status. I might not be able to attend today but ll be there from next week(on 14.00 UTC slot). for this week, you can refer the mail i shared for API highlights and next week i can start summarize in meeting. - http://lists.openstack.org/pipermail/openstack-dev/2018-July/132148.html | |
| 11:19:12 | openstackgerrit | karim proposed openstack/nova master: Handle rebuild of instances with image traits https://review.openstack.org/569498 | |
| 11:46:30 | openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: Live migration of instances https://review.openstack.org/270116 | |
| 12:01:22 | openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: ensure that live migration attaches to correct interface https://review.openstack.org/478797 | |
| 12:32:45 | mriedem | arvindn05: done https://review.openstack.org/#/c/581920/ | |
| 12:47:22 | openstackgerrit | Chen proposed openstack/nova master: fix cellv2 delete_host https://review.openstack.org/582171 | |
| 12:54:47 | neha_alhat | jaypipes: Hi, Regarding this patch: https://review.openstack.org/#/c/581218/ | |
| 12:56:17 | neha_alhat | jaypipes: Actually no need to remove logger, we can keep it as for future use(if any other client passed logger object while creating novaclient object) if not pass it will be None | |
| 12:56:43 | neha_alhat | jaypipes: and there is no bug reported for this | |
| 12:56:51 | jaypipes | neha_alhat: but aren't you removing all use of self.logger in the client? | |
| 12:57:45 | jaypipes | neha_alhat: please see Kevin Mitchell's comment on the patch. It seems like there should be a bug for this and at a minimum a test case that demonstrates how you are seeing what you are seeing. | |
| 12:57:54 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Mention osc-placement for managing traits in docs https://review.openstack.org/582173 | |
| 12:58:33 | neha_alhat | jaypipes: can you please this patch: https://review.openstack.org/#/c/578045/ | |
| 12:58:53 | neha_alhat | jaypipes: please refer* | |
| 12:59:53 | neha_alhat | jaypipes: Ya I am removing use of self.logger | |
| 13:17:11 | jaypipes | neha_alhat: I'll chat with sean mcginnis about your patch. | |
| 13:18:26 | neha_alhat | jaypipes: ok, sure | |
| 13:31:13 | efried | alex_xu: Are you putting eyes on the rest of the zvm series too? https://review.openstack.org/#/c/523387/ I'm +2 all the way up. When we have a second +2 on all the patches, we can ask dansmith to remove his -2 and merge. | |
| 13:31:43 | dansmith | I'm going to have to drop my -2 as I'm out next week | |
| 13:31:52 | dansmith | please don't let me come back to half that series merged :) | |
| 13:38:21 | mriedem | sob http://paste.openstack.org/show/725704/ | |
| 13:38:41 | mriedem | bfv with cross_az_attach=False, but i guess that's known | |
| 13:38:45 | mriedem | was hoping it was fixed by somethign else | |
| 13:39:38 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | |
| 13:40:15 | alex_xu | efried: yea, I'm working ont he review ont hat series | |
| 13:40:23 | efried | cool | |
| 13:46:32 | efried | mriedem: https://review.openstack.org/#/c/569498/ looks like karimull nailed it. I'm +2 again. | |
| 13:47:09 | stephenfin | dansmith: In brief, could you tell me what's the different between setting an o.vo attribute via the initializer and manually setting it after? | |
| 13:47:52 | stephenfin | e.g. NUMACell(network_metadata=xyz) vs. numa_cell = NUMACell(); numa_cell.network_metadata = xyz | |
| 13:47:56 | dansmith | stephenfin: meaning the difference between Obj(foo=bar) and obj = pbj(); obj.foo = bar? | |
| 13:48:01 | stephenfin | yup | |
| 13:48:02 | dansmith | should be nothing | |
| 13:48:14 | stephenfin | That's what I'd thought | |
| 13:49:07 | dansmith | ...but...? | |
| 13:49:11 | stephenfin | but I've spent the last two days on a case where doing that resulted in the attribute apparently not being set | |
| 13:49:55 | stephenfin | Lemme finish making sure this works and I'll push it up with a comment on the offending line, in case you're curious | |
| 13:50:00 | dansmith | okay | |
| 13:50:20 | stephenfin | Probably PEBKAC but we'll see :) | |
| 13:50:51 | dansmith | hopefully PEBKAC :) | |
| 13:51:31 | stephenfin | mriedem: After that fun, I totally agree on getting functional tests for numa-aware-vswitches. I'm going to need a little guidance/existing examples on how to actually approach it, if you have anything | |
| 13:52:03 | stephenfin | I have half-written Tempest tests but they won't be able to run upstream | |
| 13:55:03 | gibi | stephenfin: which part of the functional test you feel problematic? I might be able to help | |
| 13:55:11 | stephenfin | Also, forget about PCI, how we track all things NUMA is weird and I dislike it | |
| 13:55:25 | melwitt | nova meeting in 5 min | |
| 13:55:35 | alex_xu | efried: yea, +2 also, leave the +w to mriedem | |
| 13:56:01 | efried | Thanks alex_xu | |
| 13:56:17 | stephenfin | gibi: tbh, most of it. I guess I need to model the whole flow from API call to instance creation. I'm not sure how much of that functional tests case do for us | |
| 13:56:25 | stephenfin | Also, simple things like faking nova.conf | |
| 13:56:29 | melwitt | gmann: ack, thanks | |
| 13:58:06 | mriedem | efried: alex_xu: thanks will check after the meeting | |
| 13:58:22 | gibi | stephenfin: functional test is fairly easy if the code under test is not in (or triggered by) the virt driver | |
| 13:59:08 | gibi | stephenfin: there is a lot of server create and move operation tests in https://github.com/openstack/nova/blob/master/nova/tests/functional/test_servers.py | |
| 13:59:23 | mriedem | stephenfin: you'll need a fixture for the host inventory stuff for numa | |
| 13:59:51 | mriedem | probably some kind of simple fixture data struct that you can insert inventory into and then run scenarios against | |
| 14:00:35 | stephenfin | mriedem, gibi: OK, cool. The only functional tests I'd worked | |
| 14:01:00 | stephenfin | *I've worked on before are the PCI ones but they don't seem to be E2E tests. This will be fun, heh https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_pci_sriov_servers.py | |
| 14:02:57 | mriedem | so start simple with writing a fixture that can model some numa cell hardware on a host with no physnets or tunneled set, | |
| 14:03:05 | mriedem | run a server create with numa requirements against that and make sure it's ok, | |
| 14:03:19 | mriedem | then start folding in wrinkles like phsynet inventory and requirements, tunneled, etc | |
| 14:03:27 | gibi | stephenfin: I don't know about functional tests that are end2end in a sense that it trigger something on the API and uses real libvirt driver code (by mocking the libvirt interface) | |
| 14:03:47 | mriedem | you can create the numa topology for the host in the db | |
| 14:03:52 | mriedem | for a single compute node created in the test | |
| 14:05:52 | gibi | mriedem, stephenfin: I wouldn't touch db form a functional test, maybe a FakeVirtDriver that reports numa topology | |
| 14:06:45 | mriedem | depends on how complicated you want to start with, | |
| 14:06:56 | mriedem | creating stuff in the db to start might be easiest and then later convert to a fake virt driver | |
| 14:07:04 | mriedem | once you know all the scenarios | |
| 14:08:28 | openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: Live migration of instances https://review.openstack.org/270116 | |
| 14:08:29 | openstackgerrit | Radoslav Gerganov proposed openstack/nova master: VMware: ensure that live migration attaches to correct interface https://review.openstack.org/478797 | |
| 14:08:47 | gibi | mriedem: sure that could work | |
| 14:10:02 | stephenfin | mriedem: Sounds good. Lemme give that a shot | |
| 14:34:05 | openstackgerrit | Merged openstack/nova master: Add policy to InstanceGroup object https://review.openstack.org/563375 | |
| 14:45:55 | stephenfin | mriedem: RE: [1], NUMACell.network_metadata is not nullable. However, that means I need to update everything that uses NUMACell to set something for that field, right? [1] https://review.openstack.org/#/c/564439/13/nova/objects/numa.py@58 | |
| 14:46:15 | stephenfin | That's a _lot_ of changes, if so | |
| 14:47:32 | dansmith | stephenfin: it can be unset regardless of the nullability | |
| 14:47:47 | dansmith | I think his point was that you should just not set it instead of always forcing it to None | |
| 14:49:11 | stephenfin | dansmith: That makes sense, but I found a piece I'd missed here https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L1692-L1695 | |