| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-07-11 | |||
| 01:36:32 | Kevin_Zheng | mriedem, yeah, I'm trying to remember it but forgot some of the details. | |
| 01:37:08 | mriedem | i see that we don't have any api samples for ServerMigrationsSampleJsonTestV2_24 | |
| 01:37:58 | Kevin_Zheng | yeah, because it dont have microversion | |
| 01:38:03 | mriedem | i think it's the _read_template method | |
| 01:38:23 | mriedem | Kevin_Zheng: can you fix that separately? | |
| 01:38:38 | Kevin_Zheng | it has api.microversion and read_template uses self.microversion | |
| 01:38:49 | mriedem | fix the 2.24 api samples tests in a separate change before your new microversion | |
| 01:39:03 | mriedem | hell push that up outside of the series now and i'll approve it | |
| 01:39:06 | Kevin_Zheng | I don't know, because it was correct before my adding | |
| 01:39:14 | Kevin_Zheng | OK | |
| 01:39:40 | Kevin_Zheng | I still want to tell you the root cause though :) | |
| 01:39:49 | mriedem | i see the root issue, | |
| 01:39:52 | Kevin_Zheng | it is something in the setup | |
| 01:39:57 | mriedem | yeah i see that | |
| 01:40:01 | mriedem | ServerMigrationsSamplesJsonTestV2_23 is doing it correctly | |
| 01:40:37 | Kevin_Zheng | OK then I will make it a seperate patch | |
| 01:40:44 | Kevin_Zheng | I have to rebase anyway | |
| 01:41:05 | mriedem | the 2.24 api sample test is posting the live migration and deleting it with 2.24 but using the 2.1 sample | |
| 01:41:22 | mriedem | because the actual request didn't change between then it works | |
| 01:42:45 | Kevin_Zheng | Ah, I got it | |
| 01:42:59 | Kevin_Zheng | if we inherent 2.24 | |
| 01:43:09 | Kevin_Zheng | it was setup first | |
| 01:43:26 | Kevin_Zheng | and then again self.api.microversion was assigned to be 2.25 | |
| 01:43:28 | Kevin_Zheng | 2.24 | |
| 01:44:12 | Kevin_Zheng | because self.api.microversion=2.24 is after super.setup() | |
| 01:45:36 | Kevin_Zheng | and since it is wrpped in setUp, I can do nothing | |
| 01:46:25 | mriedem | yup | |
| 01:47:45 | Kevin_Zheng | yeah, I'm still young, I can remember things | |
| 01:48:18 | mriedem | what were we talking about again? | |
| 01:48:47 | Kevin_Zheng | I cant remember | |
| 02:07:22 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object https://review.openstack.org/563375 | |
| 02:13:27 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix TypeError in prep_resize allocation cleanup https://review.openstack.org/581548 | |
| 02:15:09 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add unshelve instance error info to fault table https://review.openstack.org/579747 | |
| 02:17:28 | jichen | alex_xu: API meeting 2pm today ? | |
| 02:18:53 | yikun | mriedem: hi, a question on policy notification, should we also do type convert in notification? | |
| 02:18:54 | openstackgerrit | Merged openstack/os-vif master: Fix docstrings to work with Sphinx 1.7.4 https://review.openstack.org/577028 | |
| 02:18:56 | yikun | ^ https://review.openstack.org/#/c/563401/28/nova/tests/unit/compute/test_compute_utils.py@1181 | |
| 02:19:39 | yikun | I mean should we change {"max_server_per_host": "3"} to {"max_server_per_host": 3} in notification | |
| 02:19:42 | mriedem | yikun: i don't think it's necessary to duplicate that type conversion for the notifications | |
| 02:22:46 | yikun | ok, got it, I just thought should keep same format in obj and notification-obj. | |
| 02:23:17 | yikun | and also if user create a group with {"max_server_per_host": 3}, but notification is {"max_server_per_host": "3"} | |
| 02:23:38 | yikun | just not sure it's okay for user or not. | |
| 02:23:55 | mriedem | it doesn't matter too much to me either way, i just don't really like the duplicate code | |
| 02:24:06 | mriedem | you could ask gibi for his opinion when he's up | |
| 02:25:24 | yikun | gibi: fortunately, gibi is online, could you give me some suggestion on it? | |
| 02:25:44 | openstackgerrit | Lei Zhang proposed openstack/nova master: Add method to get cpu traits https://review.openstack.org/560317 | |
| 02:26:44 | mriedem | it's about 4:30am for gibi | |
| 02:26:47 | mriedem | so he's online but not relaly | |
| 02:26:49 | mriedem | *really | |
| 02:26:55 | mriedem | he's in budapest | |
| 02:28:46 | mriedem | o/ | |
| 02:28:46 | mriedem | i on the other hand need to go to bed | |
| 02:29:20 | yikun | ha, have a good night. | |
| 02:33:59 | openstackgerrit | Brin Zhang proposed openstack/nova master: Add unshelve instance error info to fault table https://review.openstack.org/579747 | |
| 02:43:06 | gmann | jichen: yes, 2 PM for you. | |
| 02:43:36 | jichen | gmann: got it , thank you, I will arrange my time to join, in this channel, right? | |
| 02:43:37 | gmann | jichen: if you are in china :) its 6 UTC though | |
| 02:43:48 | gmann | jichen: yes, on nova channel only | |
| 02:44:04 | jichen | gmann: yes, I am in china :) | |
| 02:56:45 | openstackgerrit | Merged openstack/nova master: Remove unused variable in migration https://review.openstack.org/581464 | |
| 02:58:58 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Use ThreadPoolExecutor for max_concurrent_live_migrations https://review.openstack.org/563505 | |
| 03:00:22 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | |
| 03:06:13 | dansmith | yikun: if you get the .rules from the object, it will be type converted, so you don't need to convert again right? | |
| 03:07:24 | yikun | I think no, because 'rules': fields.DictOfStringsField(nullable=True), it will convert back to orignal by default. | |
| 03:07:34 | yikun | https://review.openstack.org/#/c/563401/29/nova/notifications/objects/server_group.py@46 | |
| 03:10:59 | gmann | dansmith: yikun should we rename 'rules' to 'policy_rules' in REST API - https://review.openstack.org/#/c/563401/28/nova/notifications/objects/server_group.py@41 | |
| 03:11:09 | gmann | otherwise it is confusing for users | |
| 03:11:34 | dansmith | yikun: ah you're right I forgot the notification field was typed | |
| 03:11:50 | gmann | in object and notification object 'rules' as it is ok. | |
| 03:12:01 | dansmith | gmann: is it confusing? I guess we should do policy_name and policy_rules? | |
| 03:12:20 | dansmith | personally, I'm okay with policy and rules but if you think it needs scoping, then okay | |
| 03:13:07 | gmann | dansmith: yeah, it was ok under policy dict but if we make out of it then scoping with policy_* is much clear | |
| 03:13:13 | dansmith | gmann: okay | |
| 03:13:21 | dansmith | I've got to go now too, before I turn into a pumpkin | |
| 03:13:32 | gmann | :) gn | |
| 03:16:08 | gmann | yikun: REST API change need spec update also (as it is nested dict in current version). i can quickly update that after my lunch if you busy with code things? and we can discuss in today API office hour also with alex_xu and feedback from matt and dansmith on gerrit . | |
| 03:19:57 | yikun | gmann: sure, thanks for your help, and I will change api from nest to flat fist. and if we decided change policy_* I will append the change. :) | |
| 04:05:23 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Compute: add support to abort queued live migration https://review.openstack.org/568542 | |
| 04:18:11 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Fix ServerMigrationSampleJsonTestsV2_24 to use its own sample file https://review.openstack.org/581562 | |
| 04:22:49 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | |
| 04:22:50 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy https://review.openstack.org/571166 | |
| 04:22:51 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | |
| 04:22:52 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | |
| 04:29:13 | gmann | yikun: sounds good. we can get the consensus on patch first and then update spec for process. | |
| 05:11:35 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy field to ServerGroup notification object https://review.openstack.org/563401 | |
| 05:11:36 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Change the ServerGroupAntiAffinityFilter to adapt to new policy https://review.openstack.org/571166 | |
| 05:11:37 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Adapt _validate_instance_group_policy to new policy model https://review.openstack.org/571465 | |
| 05:11:38 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Microversion 2.64 - Use new format policy in server group https://review.openstack.org/567534 | |
| 05:28:03 | openstackgerrit | Merged openstack/nova master: Update some placement docs to reflect modern times https://review.openstack.org/581151 | |
| 05:52:22 | stelucz | Hi, I just found in our cluster one nova aggregate with one host. It was probably created by temptest/benchmark in the past. Is it safe to delete this aggregate? or it will have some impact on running VMs at host? | |
| 05:59:58 | gmann | API office hour time | |
| 06:00:01 | gmann | #startmeeting nova api | |
| 06:00:02 | openstack | Meeting started Wed Jul 11 06:00:01 2018 UTC and is due to finish in 60 minutes. The chair is gmann. Information about MeetBot at http://wiki.debian.org/MeetBot. | |
| 06:00:03 | openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | |
| 06:00:05 | openstack | The meeting name has been set to 'nova_api' | |
| 06:00:11 | gmann | PING List: gmann, alex_xu | |
| 06:00:14 | gmann | who all here today | |
| 06:00:15 | alex_xu | o/ | |
| 06:00:19 | gmann | alex_xu: hi | |
| 06:00:29 | alex_xu | gmann: good afternoon | |