Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-07-02
14:39:50 openstackgerrit Stephen Finucane proposed openstack/nova master: scheduler: Start utilizing RequestSpec.network_metadata https://review.openstack.org/564452
14:39:51 openstackgerrit Stephen Finucane proposed openstack/nova master: conf: Add '[neutron] physnets' and related options https://review.openstack.org/564440
14:39:52 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Start populating NUMACell.network_metadata field https://review.openstack.org/564441
14:57:15 mriedem sahid: btw, i updated https://review.openstack.org/#/c/551370/ so re-review on that would be appreciated
14:57:33 mriedem that's the thing where we can change vif type during live migration,
14:57:45 mriedem so i'm overwriting the source <interface> elements with the dest vif config
15:01:21 sahid mriedem: sure i will do, i'm curently investigating that issue with MTU, there is that host_mtu parameter added for virtio-net interface which i'm supprised to see libvirt returning an error when not supported by QEMU we (libvirt) should probably just pass
15:05:37 mriedem nova will have to workaround that
15:05:49 mriedem i.e. nova can't wait for libvirt to change
15:07:07 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Add nested resource providers (v1.14) https://review.openstack.org/546675
15:07:08 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16) https://review.openstack.org/548043
15:07:09 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326
15:09:44 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Add nested resource providers (v1.14) https://review.openstack.org/546675
15:09:45 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16) https://review.openstack.org/548043
15:09:46 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326
15:10:14 gibi an easy doc generation bug needs a second core https://review.openstack.org/#/c/579436
15:13:46 mriedem gibi: what's missing? i don't see a difference between http://logs.openstack.org/36/579436/1/check/build-openstack-sphinx-docs/7558c85/html/reference/notifications.html#versioned-notification-samples and https://docs.openstack.org/nova/latest/reference/notifications.html#versioned-notification-samples
15:13:54 mriedem unless the latter is still built using py3
15:13:56 mriedem *py2
15:15:52 gibi mriedem: let me try to reproduce it locally
15:20:26 mriedem gibi: locally i see the aggregate ones are missing at least
15:20:45 gibi mriedem: confirm
15:20:54 gibi mriedem: I mean I can confirm
15:21:19 mriedem +W
15:21:30 gibi mriedem: thanks
15:21:33 mriedem efried: does anyone have a patch up for those busted tests?
15:21:39 mriedem and/or bug
15:21:40 dansmith stephenfin: sounds like "the chat" never happened.. I have another call at the top of the hour and then I assume you'll be gone before I'm done
15:21:58 dansmith stephenfin: shall we plan for tomorrow morning? maybe get something on calendars so we don't let it go?
15:22:31 stephenfin Yeah, that sounds good to me. I don't think I've any conflicts tomorrow
15:22:37 stephenfin I'll just stick something in my calendar now
15:23:32 dansmith stephenfin: can you send invites to make sure we're all good?
15:24:51 stephenfin dansmith: Done
15:24:57 dansmith thanks
15:27:47 efried mriedem: Not that I am aware of, swhy I asked you.
15:27:55 mriedem efried: ok, you can do that also right?
15:28:23 efried mriedem: I took a look at it last week, and I'm not sure how to fix it without sorting it on both sides (test and prod).
15:28:41 efried mriedem: Otherwise I would have to, like, dissect the payload and deserialize the json.
15:28:52 mriedem if it's a json compare we have a jsonEquals helper or something
15:29:05 mriedem yeah we likely have to do that
15:29:37 mriedem nova.test.TestCase.assertJsonEqual
15:29:50 mriedem if no one else is going to, i'll start on the bug and patch now
15:29:53 efried mriedem: IIRC (I've slept since then) it's serialized JSON embedded in another object.
15:30:14 mriedem i'll take a look
15:30:18 efried mriedem: If you've got the time for it, cool. If not, I can take it.
15:32:36 mriedem it saves me from having to look at my mid-year pbc results
15:32:37 mriedem so sure
15:32:46 mriedem s/look/work on/
15:34:19 efried Did you miss the transition from pbc to "checkpoint"?
15:38:28 mriedem i explained that every time i got the "you worked at ibm so you know about pbcs" joke
15:38:37 mriedem "actually...."
15:40:50 openstackgerrit Surya Seetharaman proposed openstack/nova master: Add queued for delete to instance_mappings table. https://review.openstack.org/566788
15:40:51 openstackgerrit Surya Seetharaman proposed openstack/nova master: [WIP] Add queued_for_delete field to InstanceMapping object https://review.openstack.org/566795
15:40:52 openstackgerrit Surya Seetharaman proposed openstack/nova master: [POC] Graceful handling of nova-list when a cell is down https://review.openstack.org/567785
15:40:56 openstack Launchpad bug 1779711 in OpenStack Compute (nova) "test_pre_live_migration_volume_backed* intermittently fails serialized json compare" [Critical,Confirmed]
15:40:56 mriedem https://bugs.launchpad.net/nova/+bug/1779711
15:45:44 efried Thanks, was about to ask so I could start tagging rechecks with it :)
15:48:12 openstackgerrit sahid proposed openstack/nova master: libvirt: add qemu version check when configuring mtu for network https://review.openstack.org/579611
15:51:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Use assertJsonEqual in test_pre_live_migration_volume_backed* tests https://review.openstack.org/579615
15:51:41 mriedem efried: ^
15:53:47 efried mriedem: Does assertJsonEqual tolerate the fact that the outermost thing isn't a JSON string yet?
15:56:00 mriedem doesn't have to be json strings
15:56:05 mriedem it handles them if they are
15:56:15 mriedem assertDictEqual might have also worked for this
15:56:31 mriedem i think we use assertJsonEqual for the versioned notification payload comparisons
15:56:36 mriedem because of the nesting in those
15:56:52 mriedem assertDictEqual kind of gives a shitty error message when it fails though
15:57:32 efried mriedem: Looking at the source for assertJsonEqual, I don't think it's going to work in this case.
15:58:07 mriedem it passes for me locally
15:58:16 efried sure
15:58:19 mriedem bauzas: i'm seeing rescue tests failing since your vgpu race fix patch merged http://logs.openstack.org/47/555947/17/check/nova-multiattach/c6f458a/logs/screen-n-cpu.txt.gz#_Jun_26_15_29_18_875732
15:58:30 mriedem bauzas: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22libvirtError%3A%20failed%20to%20connect%20to%20monitor%20socket%3A%20No%20such%20process%5C%22%20AND%20tags%3A%5C%22screen-n-cpu.txt%5C%22&from=7d
15:58:32 efried the failure is intermittent
15:58:51 efried I would think the things usually serialize the same
15:59:07 efried which is how this got through in the first place
15:59:13 mriedem yeah let me run a few times
16:01:28 openstackgerrit Balazs Gibizer proposed openstack/nova master: Prevent updating an RP's parent to form a loop https://review.openstack.org/579618
16:01:40 lyarwood mriedem / efried ; FWIW this is also here - https://github.com/openstack/nova/blob/0ef62de88862795cf66d13f6640b68ab9b155efb/nova/tests/unit/network/test_os_vif_util.py#L32-L38
16:03:12 mriedem yeah i saw the comment about test_os_vif_util in the new tests
16:03:14 efried mriedem: I'm just copying the reference/actual from a failing test run.
16:03:30 openstackgerrit Balazs Gibizer proposed openstack/nova master: Prevent updating an RP's parent to form a loop https://review.openstack.org/579618
16:03:53 efried mriedem: and it fails assertJsonEqual
16:05:18 openstackgerrit Corey Bryant proposed openstack/nova master: Enable connection_info refresh for new-style attachments https://review.openstack.org/579004
16:05:51 mriedem oh is it connection_info_json ?
16:06:04 mriedem yeah must be
16:06:08 mriedem ok
16:06:27 efried mriedem: Yeah.
16:08:38 mriedem lyarwood: that's why test_os_vif_util doesn't fail then - no embedded serialized json
16:09:42 efried mriedem: This sucks a little, but it works: http://paste.openstack.org/show/724766/
16:11:13 mriedem i was just going to deserialize in the test and pass those on to assertEqual as it's doing now
16:11:14 mriedem with a note
16:11:45 efried ight
16:16:35 mriedem i might also be able to handle this generically in assertJsonEqual
16:16:39 mriedem i'll try both
16:28:56 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle nested serialized json entries in assertJsonEqual https://review.openstack.org/579615
16:28:57 mriedem efried: ok the generic one wins ^
16:29:56 efried mriedem: I still don't see how that's going to help. The outermost object is not a string type.
16:30:25 efried nor is the first level in, which is I guess what you're targeting now.
16:32:43 mriedem i'm doing it in the recursion
16:33:14 mriedem bauzas: nvm i guess that's just something that shows up a lot in the gate

Earlier   Later