| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-07-02 | |||
| 14:07:15 | stephenfin | efried: That's what I was referring to, yup. Now to see if it is the same thing. Cheers! | |
| 14:13:07 | stephenfin | Hmm, so if sets in Python are unordered, how do I make sure a test that relies on particular ordering doesn't fail intermittently? https://review.openstack.org/#/c/575486/6/nova/tests/unit/objects/test_selection.py | |
| 14:14:13 | efried | sort | |
| 14:14:36 | stephenfin | that's going to change the object type though | |
| 14:14:46 | stephenfin | I guess that doesn't matter so long as we can convert back | |
| 14:14:48 | efried | If you're comparing sets, it should just work | |
| 14:16:22 | gibi | stephenfin: if you break up the big assert to a list of smaller asserts then you can eventually compare sets as efried suggests | |
| 14:16:49 | stephenfin | Ooh, much better than what I was about to do | |
| 14:18:35 | gibi | gibi catches | |
| 14:18:41 | gibi | I mean | |
| 14:18:44 | gibi | s | |
| 14:30:16 | efried | mriedem: O bugmeister supreme, do we have a bug open for this: http://logs.openstack.org/62/576462/3/check/openstack-tox-lower-constraints/77e13fb/testr_results.html.gz | |
| 14:30:48 | efried | We're comparing json serialization of a dict, which is happening in unpredictable order (predictably). | |
| 14:31:00 | efried | This is popping up all over the place intermittently. | |
| 14:31:23 | mriedem | i personally haven't opened a bug nor seen that yet no | |
| 14:31:33 | efried | ight. | |
| 14:32:15 | openstack | Launchpad bug 1779626 in OpenStack Compute (nova) "MTU setting feature conflicts with minimum Qemu version " [Undecided,New] | |
| 14:32:15 | mriedem | sahid: you should triage this probably https://bugs.launchpad.net/nova/+bug/1779626 | |
| 14:36:25 | sahid | mriedem: we should probably mark it as duplicate of 1747496 | |
| 14:36:28 | sahid | sounds good for you? | |
| 14:36:54 | sahid | oh wait... i think i missunderstood | |
| 14:37:41 | mriedem | the new bug is saying the change is a regression | |
| 14:38:29 | sahid | yes sorry | |
| 14:39:38 | sahid | i'm supprised to see QEMU in relation to this, since it's libvirt who is creating the tap and configuring the mtu | |
| 14:39:38 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: fix min_version for parent_provider_uuid in responses https://review.openstack.org/579577 | |
| 14:39:44 | openstackgerrit | Stephen Finucane proposed openstack/nova master: network: Always retrieve network information if available https://review.openstack.org/564444 | |
| 14:39:45 | openstackgerrit | Stephen Finucane proposed openstack/nova master: network: Retrieve tunneled status in '_get_physnet_info' https://review.openstack.org/564445 | |
| 14:39:46 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add NUMACell.network_metadata https://review.openstack.org/564439 | |
| 14:39:47 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add NUMATopologyLimits.networks https://review.openstack.org/575486 | |
| 14:39:48 | openstackgerrit | Stephen Finucane proposed openstack/nova master: hardware: Start accounting for networks in NUMA placement https://review.openstack.org/564448 | |
| 14:39:49 | openstackgerrit | Stephen Finucane proposed openstack/nova master: objects: Add RequestSpec.network_metadata https://review.openstack.org/564442 | |
| 14:39:50 | openstackgerrit | Stephen Finucane proposed openstack/nova master: scheduler: Start utilizing RequestSpec.network_metadata https://review.openstack.org/564452 | |
| 14:39:51 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Add '[neutron] physnets' and related options https://review.openstack.org/564440 | |
| 14:39:52 | openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Start populating NUMACell.network_metadata field https://review.openstack.org/564441 | |
| 14:57:15 | mriedem | sahid: btw, i updated https://review.openstack.org/#/c/551370/ so re-review on that would be appreciated | |
| 14:57:33 | mriedem | that's the thing where we can change vif type during live migration, | |
| 14:57:45 | mriedem | so i'm overwriting the source <interface> elements with the dest vif config | |
| 15:01:21 | sahid | mriedem: sure i will do, i'm curently investigating that issue with MTU, there is that host_mtu parameter added for virtio-net interface which i'm supprised to see libvirt returning an error when not supported by QEMU we (libvirt) should probably just pass | |
| 15:05:37 | mriedem | nova will have to workaround that | |
| 15:05:49 | mriedem | i.e. nova can't wait for libvirt to change | |
| 15:07:07 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Add nested resource providers (v1.14) https://review.openstack.org/546675 | |
| 15:07:08 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16) https://review.openstack.org/548043 | |
| 15:07:09 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326 | |
| 15:09:44 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Add nested resource providers (v1.14) https://review.openstack.org/546675 | |
| 15:09:45 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16) https://review.openstack.org/548043 | |
| 15:09:46 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326 | |
| 15:10:14 | gibi | an easy doc generation bug needs a second core https://review.openstack.org/#/c/579436 | |
| 15:13:46 | mriedem | gibi: what's missing? i don't see a difference between http://logs.openstack.org/36/579436/1/check/build-openstack-sphinx-docs/7558c85/html/reference/notifications.html#versioned-notification-samples and https://docs.openstack.org/nova/latest/reference/notifications.html#versioned-notification-samples | |
| 15:13:54 | mriedem | unless the latter is still built using py3 | |
| 15:13:56 | mriedem | *py2 | |
| 15:15:52 | gibi | mriedem: let me try to reproduce it locally | |
| 15:20:26 | mriedem | gibi: locally i see the aggregate ones are missing at least | |
| 15:20:45 | gibi | mriedem: confirm | |
| 15:20:54 | gibi | mriedem: I mean I can confirm | |
| 15:21:19 | mriedem | +W | |
| 15:21:30 | gibi | mriedem: thanks | |
| 15:21:33 | mriedem | efried: does anyone have a patch up for those busted tests? | |
| 15:21:39 | mriedem | and/or bug | |
| 15:21:40 | dansmith | stephenfin: sounds like "the chat" never happened.. I have another call at the top of the hour and then I assume you'll be gone before I'm done | |
| 15:21:58 | dansmith | stephenfin: shall we plan for tomorrow morning? maybe get something on calendars so we don't let it go? | |
| 15:22:31 | stephenfin | Yeah, that sounds good to me. I don't think I've any conflicts tomorrow | |
| 15:22:37 | stephenfin | I'll just stick something in my calendar now | |
| 15:23:32 | dansmith | stephenfin: can you send invites to make sure we're all good? | |
| 15:24:51 | stephenfin | dansmith: Done | |
| 15:24:57 | dansmith | thanks | |
| 15:27:47 | efried | mriedem: Not that I am aware of, swhy I asked you. | |
| 15:27:55 | mriedem | efried: ok, you can do that also right? | |
| 15:28:23 | efried | mriedem: I took a look at it last week, and I'm not sure how to fix it without sorting it on both sides (test and prod). | |
| 15:28:41 | efried | mriedem: Otherwise I would have to, like, dissect the payload and deserialize the json. | |
| 15:28:52 | mriedem | if it's a json compare we have a jsonEquals helper or something | |
| 15:29:05 | mriedem | yeah we likely have to do that | |
| 15:29:37 | mriedem | nova.test.TestCase.assertJsonEqual | |
| 15:29:50 | mriedem | if no one else is going to, i'll start on the bug and patch now | |
| 15:29:53 | efried | mriedem: IIRC (I've slept since then) it's serialized JSON embedded in another object. | |
| 15:30:14 | mriedem | i'll take a look | |
| 15:30:18 | efried | mriedem: If you've got the time for it, cool. If not, I can take it. | |
| 15:32:36 | mriedem | it saves me from having to look at my mid-year pbc results | |
| 15:32:37 | mriedem | so sure | |
| 15:32:46 | mriedem | s/look/work on/ | |
| 15:34:19 | efried | Did you miss the transition from pbc to "checkpoint"? | |
| 15:38:28 | mriedem | i explained that every time i got the "you worked at ibm so you know about pbcs" joke | |
| 15:38:37 | mriedem | "actually...." | |
| 15:40:50 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: Add queued for delete to instance_mappings table. https://review.openstack.org/566788 | |
| 15:40:51 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: [WIP] Add queued_for_delete field to InstanceMapping object https://review.openstack.org/566795 | |
| 15:40:52 | openstackgerrit | Surya Seetharaman proposed openstack/nova master: [POC] Graceful handling of nova-list when a cell is down https://review.openstack.org/567785 | |
| 15:40:56 | openstack | Launchpad bug 1779711 in OpenStack Compute (nova) "test_pre_live_migration_volume_backed* intermittently fails serialized json compare" [Critical,Confirmed] | |
| 15:40:56 | mriedem | https://bugs.launchpad.net/nova/+bug/1779711 | |
| 15:45:44 | efried | Thanks, was about to ask so I could start tagging rechecks with it :) | |
| 15:48:12 | openstackgerrit | sahid proposed openstack/nova master: libvirt: add qemu version check when configuring mtu for network https://review.openstack.org/579611 | |
| 15:51:39 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use assertJsonEqual in test_pre_live_migration_volume_backed* tests https://review.openstack.org/579615 | |
| 15:51:41 | mriedem | efried: ^ | |
| 15:53:47 | efried | mriedem: Does assertJsonEqual tolerate the fact that the outermost thing isn't a JSON string yet? | |
| 15:56:00 | mriedem | doesn't have to be json strings | |
| 15:56:05 | mriedem | it handles them if they are | |
| 15:56:15 | mriedem | assertDictEqual might have also worked for this | |
| 15:56:31 | mriedem | i think we use assertJsonEqual for the versioned notification payload comparisons | |
| 15:56:36 | mriedem | because of the nesting in those | |
| 15:56:52 | mriedem | assertDictEqual kind of gives a shitty error message when it fails though | |
| 15:57:32 | efried | mriedem: Looking at the source for assertJsonEqual, I don't think it's going to work in this case. | |
| 15:58:07 | mriedem | it passes for me locally | |