Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2018-06-29
13:23:57 giblet fried_rice: either the same mock is needed here or we should globally mock the get_fs_info in a fixture
13:24:20 giblet giblet: I would suggest the later as we hit this issue twice in a short time
13:24:42 fried_rice giblet: I agree, but maybe not in this patch?
13:24:57 giblet fried_rice: doing the fixture work in a followup is fine by me
13:25:18 giblet fried_rice: just add a the mock to make the test stable now
13:26:28 fried_rice ++ Thanks for the help, giblet
13:27:06 giblet fried_rice: I'm happy that I could help
13:30:02 PapaOurs cdent: which webob version should be lower for nova ? 1.8.2 ?
13:30:09 PapaOurs lowest*
13:32:09 cdent PapaOurs: I can't guess. The new functionality came in with 1.8.0 but appears it was somewhat broken and fixed in 1.8.1. So I'd say either 1.8.1. or 1.8.2. May as well 1.8.2 unless there's some reason not to?
13:35:38 fried_rice ^ wfm
13:40:19 mriedem tssurya: oh that's right
13:43:47 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326
13:47:55 PapaOurs cdent: yup, I think 1.8.2 is good
13:48:02 cdent ✔
13:49:40 openstackgerrit Sylvain Bauza proposed openstack/nova master: Fix placement incompatible with webob 1.7 https://review.openstack.org/579110
13:49:50 openstackgerrit Jay Pipes proposed openstack/nova master: return 404 when no consumer found in allocs https://review.openstack.org/579163
14:05:20 openstackgerrit Merged openstack/nova stable/queens: Use instance project/user when creating RequestSpec during resize reschedule https://review.openstack.org/577918
14:08:53 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Refactor the policies to policy https://review.openstack.org/579113
14:08:54 openstackgerrit Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models. https://review.openstack.org/563375
14:30:59 openstackgerrit Merged openstack/nova stable/pike: mock utils.execute() in qemu-img unit test https://review.openstack.org/578058
14:39:57 openstackgerrit Merged openstack/os-traits master: normalize_name helper https://review.openstack.org/560107
14:54:21 openstackgerrit huanhongda proposed openstack/nova stable/queens: [Stable Only] Remove soft-deleted instances from quota_usages https://review.openstack.org/579093
14:55:46 openstackgerrit Sylvain Bauza proposed openstack/nova master: Fix placement incompatible with webob 1.7 https://review.openstack.org/579110
15:03:03 openstackgerrit Merged openstack/nova master: Add microversion for nested allocation candidate https://review.openstack.org/565487
15:05:43 finucannot fried_rice: I was most of the way through rebasing this before I realized...it's all in the nova tree now, right? https://review.openstack.org/#/c/475972
15:05:57 finucannot fried_rice: if so, wanna abandon that altogether?
15:06:20 finucannot fried_rice: Whoops, wrong link https://review.openstack.org/#/c/527813/
15:07:31 fried_rice finucannot: We're still maintaining the OOT driver, so we still want to do that thing.
15:07:59 leakypipes melwitt: pug love. https://twitter.com/jaypipes/status/1012713615097335809
15:08:08 finucannot Good thing I didn't just blow that away so
15:08:08 fried_rice finucannot: In fact until we get everything in nova (we're still lagging) the OOT driver is what we have to lead with, product-wise.
15:08:35 fried_rice finucannot: Good thing Abandon has Restore :)
15:08:38 melwitt leakypipes: that's adorbz
15:09:08 fried_rice finucannot: Thanks for doing that!
15:09:12 finucannot fried_rice: Yup, loads of patches under https://review.openstack.org/527813 now for your perusal
15:09:19 fried_rice ack
15:10:11 finucannot Only one thing - is that an official OpenStack project? I switched it to openstackdocstheme but I think there are restrictions on that
15:17:29 fried_rice finucannot: I don't know wtf official means anymore.
15:17:51 fried_rice finucannot: Couple of teeny fixes in a couple of those patches. I can do 'em if you don't wanna.
15:18:18 finucannot fried_rice: Eh, I can take em
15:18:22 fried_rice thanks
15:22:28 fried_rice finucannot: also git rm doc/ext/support_matrix.py if you please.
15:29:03 leakypipes mriedem, giblet: sorry, can we pull https://review.openstack.org/#/c/514646/ from the gate?
15:29:24 leakypipes left review in there explaining why...
15:33:39 openstackgerrit Chris Dent proposed openstack/nova master: [placement] fix allocation handler docstring typo https://review.openstack.org/579198
15:36:27 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: WIP Usages per project and user (v1.8, v1.9) https://review.openstack.org/514646
15:36:32 mriedem leakypipes: replied
15:36:35 mriedem -2 doesn't pull it out of the gate
15:37:16 mriedem it's out so you can drop the -2
15:37:59 leakypipes mriedem: k, done, tha
15:38:01 leakypipes thx
15:40:17 openstackgerrit Chris Dent proposed openstack/nova master: Use 'version2' when syncing placement db https://review.openstack.org/579200
15:43:23 openstackgerrit Eric Fried proposed openstack/nova master: Add method to get cpu traits https://review.openstack.org/560317
15:43:24 openstackgerrit Eric Fried proposed openstack/nova master: FakeLibvirtFixture: mock get_fs_info https://review.openstack.org/579201
15:43:59 kashyap lyaaaaaaaarwood: So, I looked at your change here: https://review.openstack.org/#/c/579125/1
15:44:22 kashyap lyaaaaaaaarwood: The idea is fine, but might want to consider rephrasing the note in the code.
15:44:32 kashyap (Not '-1' on it, of course.)
15:44:49 openstackgerrit Merged openstack/nova master: Fix nits in placement-return-all-resources series https://review.openstack.org/573604
15:44:59 openstackgerrit Merged openstack/nova master: trivial: Remove 'tools/releasenotes_tox.sh' https://review.openstack.org/534383
15:45:01 kashyap (But certainly will be clearer for "outsiders" who normally don't dwell on the libvirt driver.)
15:45:08 openstackgerrit Merged openstack/nova master: tox: Document and dedupe mostly everything https://review.openstack.org/578825
15:45:15 openstackgerrit Merged openstack/nova master: Remove file injection from config drive sample docs https://review.openstack.org/578888
15:45:24 openstackgerrit Merged openstack/nova master: Fix CLI docs for nova-manage api_db commands https://review.openstack.org/578116
15:45:25 fried_rice giblet: updated https://review.openstack.org/#/c/560317/ and added https://review.openstack.org/#/c/579201/ for that get_fs_info race as discussed earlier.
15:45:52 openstackgerrit Merged openstack/nova master: Remove unused DB API instance_group_delete method https://review.openstack.org/578223
15:46:00 openstackgerrit Merged openstack/nova master: Mention nova-status upgrade check CLI in upgrade doc https://review.openstack.org/576719
15:46:46 lyaaaaaaaarwood kashyap: thanks
15:51:12 openstack Launchpad bug 1778498 in OpenStack Compute (nova) "cannot launch instance" [Undecided,New]
15:51:12 fried_rice melwitt: Just getting back around to https://bugs.launchpad.net/nova/+bug/1778498 -- Sorry, that looks to be a bit out of my wheelhouse. I would think keystone ought to take the first look there.
15:52:27 fried_rice melwitt: I'm asking in -keystone
15:53:20 fried_rice giblet: BTW, I only ran that through the two functional tests locally - didn't try to see if there was going to be other impact on the unit tests using that fixture. Figured I would let zuul do that for me :)
15:56:15 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: use dest host vif migrate details for live migration https://review.openstack.org/551370
15:56:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Annotate flows and handle PortBindingDeletionFailed in ComputeManager https://review.openstack.org/551371
15:56:17 openstackgerrit Matt Riedemann proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870
15:56:18 openstackgerrit Matt Riedemann proposed openstack/nova master: conductor: use port binding extended API in during live migrate https://review.openstack.org/522537
15:58:08 fried_rice melwitt: It's a typo in the scheme (htpp://). I invalidated the bug.
16:02:50 openstackgerrit Lee Yarwood proposed openstack/nova master: libvirt: Handle LM rollback error when detaching volumes from transient domain https://review.openstack.org/579125
16:13:31 openstackgerrit Chris Dent proposed openstack/nova master: WIP: [placement] Add /reshaper handler for POST https://review.openstack.org/576927
18:10:01 openstackgerrit Merged openstack/nova master: Match ComputeNode.uuid to ironic node uuid in RT https://review.openstack.org/571535
18:10:12 openstackgerrit Merged openstack/nova master: Mention PowerVM support of config drive https://review.openstack.org/578840
18:10:23 openstackgerrit Merged openstack/nova master: Merge server create schema for BDM v2 extension https://review.openstack.org/577185
18:10:36 openstackgerrit Merged openstack/nova master: Merge server create schema for config drive extension https://review.openstack.org/578329
18:17:42 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Usages per project and user (v1.8, v1.9) https://review.openstack.org/514646
18:17:43 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: CLI allocation candidates (v1.10) https://review.openstack.org/514647
18:17:44 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: New dict format of allocations (v1.11, v1.12) https://review.openstack.org/542819
18:17:45 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Transactionally update allocations (v1.13) https://review.openstack.org/546674
18:17:46 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Add nested resource providers (v1.14) https://review.openstack.org/546675
18:17:47 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Limit allocation candidates (v1.15, v1.16) https://review.openstack.org/548043
18:17:48 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326
20:40:34 fried_rice http://logs.openstack.org/18/579118/1/check/openstack-tox-lower-constraints/ecb1568/testr_results.html.gz
20:40:34 fried_rice Before I go adding sort_keys, did something change in a lib between lower-constraints and upper-constraints that would make jsonutils.dumps deterministic for dicts where it wasn't before?
20:44:44 jroll fried_rice: if that runs in python 3, dict order is guaranteed in 3.7 as part of the spec (and 3.7 was just released), but cpython 3.6 also preserves order AIUI
20:45:13 jroll I'd guess that job just switched to py3
20:47:07 fried_rice I am suddenly unable to run lower-constraints locally. What gives?
20:47:45 jroll maybe you don't have py3 installed :P
20:51:16 fried_rice I needed to upgrade tox, it would seem.
20:52:49 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: Usages per project and user (v1.8, v1.9) https://review.openstack.org/514646
20:52:50 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: CLI allocation candidates (v1.10) https://review.openstack.org/514647
20:52:51 openstackgerrit Matt Riedemann proposed openstack/osc-placement master: New dict format of allocations (v1.11, v1.12) https://review.openstack.org/542819

Earlier   Later