| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2018-06-29 | |||
| 12:58:59 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326 | |
| 13:01:06 | fried_rice | PapaOurs: I agree with finucannot; is there some reason we can't just bump requirements and l-c? | |
| 13:01:21 | giblet | finucannot: quick question in https://review.openstack.org/#/c/578825/1/tox.ini@3 before I approve | |
| 13:01:39 | PapaOurs | fried_rice: wait, lower-constraints is for all the projects | |
| 13:01:51 | finucannot | PapaOurs: It's per-project now | |
| 13:02:19 | finucannot | See the lower-constraints.txt file in root (and lower-constraints tox target) | |
| 13:03:06 | finucannot | giblet: Nope. That's a hangover from a previous rebase, I imagine. It's harmless but I can edit and switch it back if you'd like? | |
| 13:03:32 | giblet | finucannot: no need to change it back, I was just curious | |
| 13:03:35 | giblet | finucannot: approving | |
| 13:03:37 | PapaOurs | finucannot: so, we should bump it for nova ? | |
| 13:03:56 | fried_rice | giblet: I answered at least why it was reversed to begin with. | |
| 13:04:00 | fried_rice | PapaOurs: Yes | |
| 13:04:21 | finucannot | fried_rice: Ah, correct | |
| 13:04:24 | fried_rice | PapaOurs: You'll need to do it in both requirements.txt and lower-constraints.txt | |
| 13:04:31 | giblet | fried_rice: thanks | |
| 13:05:40 | finucannot | PapaOurs: Yeah, that was the idea behind moving those things in-tree, I thought | |
| 13:06:34 | giblet | fried_rice: I opened https://review.openstack.org/#/c/560317/17/nova/tests/functional/libvirt/test_report_cpu_traits.py but at a first glance I don't know the answer of the failure. | |
| 13:06:50 | giblet | fried_rice: I can try to dig on Monday | |
| 13:07:11 | fried_rice | giblet: What was the patch you got into recently where it was something to do with creating or deleting a file on the file system, and that raced among several tests? | |
| 13:08:14 | fried_rice | If you can just point me at that, I can look into it. Cause I suspect the failure is the same or similar. Or at least worth eliminating as a suspect. | |
| 13:08:33 | giblet | fried_rice: that wasn't my patch but I try to find it as now I remember what you are referring to | |
| 13:08:51 | fried_rice | giblet: Right, I remember you swooped in and saved the day | |
| 13:09:40 | cdent | he has a habit of doing that | |
| 13:10:05 | fried_rice | Heh, I misread, at first I thought you were saying *you* have a habit of doing that. | |
| 13:10:26 | fried_rice | i.e. a habit of picturing giblet in a cape. | |
| 13:10:44 | giblet | :) | |
| 13:10:47 | cdent | don't share my secrets in public, please | |
| 13:16:00 | giblet | fried_rice: is the one? https://review.openstack.org/#/c/560459/16 | |
| 13:16:12 | openstackgerrit | Merged openstack/nova master: [placement] Extract create_allocation_list https://review.openstack.org/577200 | |
| 13:16:21 | openstackgerrit | Merged openstack/nova master: [placement] Fix capacity tracking in POST /allocations https://review.openstack.org/578133 | |
| 13:16:22 | giblet | fried_rice: here the CONF.instance_path was the root cause | |
| 13:17:06 | openstackgerrit | Merged openstack/nova master: libvirt: Add missing encryption_secret_uuid tests for pre_live_migration https://review.openstack.org/540679 | |
| 13:17:24 | giblet | http://logs.openstack.org/59/560459/16/gate/nova-tox-functional/c04cbeb/testr_results.html.gz | |
| 13:19:40 | fried_rice | giblet: Yeah, yeah, doesn't that look pretty much identical? | |
| 13:19:50 | giblet | fried_rice: yeah it does | |
| 13:20:19 | giblet | fried_rice: so something is missing from the filesystem the test depends on | |
| 13:22:02 | mriedem | tssurya: replied inline on the spec, i think we're on the same page | |
| 13:22:16 | fried_rice | fixtures.MockPatch('nova.virt.libvirt.utils.get_fs_info')) | |
| 13:22:16 | fried_rice | self.useFixture( | |
| 13:22:16 | fried_rice | giblet: In the other patch, the solution was | |
| 13:23:08 | tssurya | mriedem: FYI regarding backporting https://review.openstack.org/#/c/578152/ to Pike, just realized that Pike is way behind in listing , it doesn't have https://github.com/openstack/nova/commit/bac8f5b046283fbc641d418443e5b899f2989fdf#diff-41e6d0ef0ef79d44593ee0f1b241f9f4 | |
| 13:23:31 | giblet | fried_rice: yeah, the current patch hits that function as well | |
| 13:23:35 | tssurya | so will stop at queens which is already merged. | |
| 13:23:57 | giblet | fried_rice: either the same mock is needed here or we should globally mock the get_fs_info in a fixture | |
| 13:24:20 | giblet | giblet: I would suggest the later as we hit this issue twice in a short time | |
| 13:24:42 | fried_rice | giblet: I agree, but maybe not in this patch? | |
| 13:24:57 | giblet | fried_rice: doing the fixture work in a followup is fine by me | |
| 13:25:18 | giblet | fried_rice: just add a the mock to make the test stable now | |
| 13:26:28 | fried_rice | ++ Thanks for the help, giblet | |
| 13:27:06 | giblet | fried_rice: I'm happy that I could help | |
| 13:30:02 | PapaOurs | cdent: which webob version should be lower for nova ? 1.8.2 ? | |
| 13:30:09 | PapaOurs | lowest* | |
| 13:32:09 | cdent | PapaOurs: I can't guess. The new functionality came in with 1.8.0 but appears it was somewhat broken and fixed in 1.8.1. So I'd say either 1.8.1. or 1.8.2. May as well 1.8.2 unless there's some reason not to? | |
| 13:35:38 | fried_rice | ^ wfm | |
| 13:40:19 | mriedem | tssurya: oh that's right | |
| 13:43:47 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: Allocation candidates parameter: required (v1.17) https://review.openstack.org/548326 | |
| 13:47:55 | PapaOurs | cdent: yup, I think 1.8.2 is good | |
| 13:48:02 | cdent | ✔ | |
| 13:49:40 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Fix placement incompatible with webob 1.7 https://review.openstack.org/579110 | |
| 13:49:50 | openstackgerrit | Jay Pipes proposed openstack/nova master: return 404 when no consumer found in allocs https://review.openstack.org/579163 | |
| 14:05:20 | openstackgerrit | Merged openstack/nova stable/queens: Use instance project/user when creating RequestSpec during resize reschedule https://review.openstack.org/577918 | |
| 14:08:53 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Refactor the policies to policy https://review.openstack.org/579113 | |
| 14:08:54 | openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova master: Add policy to InstanceGroup object and api models. https://review.openstack.org/563375 | |
| 14:30:59 | openstackgerrit | Merged openstack/nova stable/pike: mock utils.execute() in qemu-img unit test https://review.openstack.org/578058 | |
| 14:39:57 | openstackgerrit | Merged openstack/os-traits master: normalize_name helper https://review.openstack.org/560107 | |
| 14:54:21 | openstackgerrit | huanhongda proposed openstack/nova stable/queens: [Stable Only] Remove soft-deleted instances from quota_usages https://review.openstack.org/579093 | |
| 14:55:46 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Fix placement incompatible with webob 1.7 https://review.openstack.org/579110 | |
| 15:03:03 | openstackgerrit | Merged openstack/nova master: Add microversion for nested allocation candidate https://review.openstack.org/565487 | |
| 15:05:43 | finucannot | fried_rice: I was most of the way through rebasing this before I realized...it's all in the nova tree now, right? https://review.openstack.org/#/c/475972 | |
| 15:05:57 | finucannot | fried_rice: if so, wanna abandon that altogether? | |
| 15:06:20 | finucannot | fried_rice: Whoops, wrong link https://review.openstack.org/#/c/527813/ | |
| 15:07:31 | fried_rice | finucannot: We're still maintaining the OOT driver, so we still want to do that thing. | |
| 15:07:59 | leakypipes | melwitt: pug love. https://twitter.com/jaypipes/status/1012713615097335809 | |
| 15:08:08 | finucannot | Good thing I didn't just blow that away so | |
| 15:08:08 | fried_rice | finucannot: In fact until we get everything in nova (we're still lagging) the OOT driver is what we have to lead with, product-wise. | |
| 15:08:35 | fried_rice | finucannot: Good thing Abandon has Restore :) | |
| 15:08:38 | melwitt | leakypipes: that's adorbz | |
| 15:09:08 | fried_rice | finucannot: Thanks for doing that! | |
| 15:09:12 | finucannot | fried_rice: Yup, loads of patches under https://review.openstack.org/527813 now for your perusal | |
| 15:09:19 | fried_rice | ack | |
| 15:10:11 | finucannot | Only one thing - is that an official OpenStack project? I switched it to openstackdocstheme but I think there are restrictions on that | |
| 15:17:29 | fried_rice | finucannot: I don't know wtf official means anymore. | |
| 15:17:51 | fried_rice | finucannot: Couple of teeny fixes in a couple of those patches. I can do 'em if you don't wanna. | |
| 15:18:18 | finucannot | fried_rice: Eh, I can take em | |
| 15:18:22 | fried_rice | thanks | |
| 15:22:28 | fried_rice | finucannot: also git rm doc/ext/support_matrix.py if you please. | |
| 15:29:03 | leakypipes | mriedem, giblet: sorry, can we pull https://review.openstack.org/#/c/514646/ from the gate? | |
| 15:29:24 | leakypipes | left review in there explaining why... | |
| 15:33:39 | openstackgerrit | Chris Dent proposed openstack/nova master: [placement] fix allocation handler docstring typo https://review.openstack.org/579198 | |
| 15:36:27 | openstackgerrit | Matt Riedemann proposed openstack/osc-placement master: WIP Usages per project and user (v1.8, v1.9) https://review.openstack.org/514646 | |
| 15:36:32 | mriedem | leakypipes: replied | |
| 15:36:35 | mriedem | -2 doesn't pull it out of the gate | |
| 15:37:16 | mriedem | it's out so you can drop the -2 | |
| 15:37:59 | leakypipes | mriedem: k, done, tha | |
| 15:38:01 | leakypipes | thx | |
| 15:40:17 | openstackgerrit | Chris Dent proposed openstack/nova master: Use 'version2' when syncing placement db https://review.openstack.org/579200 | |
| 15:43:23 | openstackgerrit | Eric Fried proposed openstack/nova master: Add method to get cpu traits https://review.openstack.org/560317 | |
| 15:43:24 | openstackgerrit | Eric Fried proposed openstack/nova master: FakeLibvirtFixture: mock get_fs_info https://review.openstack.org/579201 | |
| 15:43:59 | kashyap | lyaaaaaaaarwood: So, I looked at your change here: https://review.openstack.org/#/c/579125/1 | |
| 15:44:22 | kashyap | lyaaaaaaaarwood: The idea is fine, but might want to consider rephrasing the note in the code. | |